/srv/irclogs.ubuntu.com/2016/09/05/#juju-dev.txt

menn0thumper: I figured out the blobstore thing. Although Juju doesn't use github.com/juju/blobstore any more, charmstore.v5 still does. I've emailed rog about it.00:13
wallyworldthumper: can you take another look at my PR?01:02
anastasiamacthumper: u r an OCR \o/ my monday might get better after all :D could u PTAL http://reviews.vapour.ws/r/5590/?01:42
thumperyep01:44
anastasiamactyvm!01:55
anastasiamacthumper: one line dependencies update - http://reviews.vapour.ws/r/5591/02:21
thumperanastasiamac: timestamp is a lie02:22
thumperanastasiamac: do this:02:22
thumpergodeps ./... | grep "juju/util"02:22
thumperyou can then just copy that line02:22
thumperveebers: now good?02:23
anastasiamacthumper: done \o/02:24
thumperanastasiamac: I used to hand craft those lines until I worked out that trick02:24
anastasiamacthumper: u r awesome \o/ we should have this in our wiki, I think :D02:25
anastasiamacthumper: i need to update these licecne on 1.25 branch of juju/utils but no amount of fetching/pull is giving me this branch to creat my own on...02:26
anastasiamaci suspect my upstrem/origin pair r not correct but can't figure out where m going wrong02:26
anastasiamaccould anyone point me in the right direction?02:26
thumperanastasiamac: probably not worth fixing IMO02:27
thumperthere are hoops we could jump through if someone thinks it is important enough02:28
thumperbit kinda icky due to godeps02:28
thumperI know we were looking at updating godeps to allow it to look at different branches02:28
thumperbut AFAIK, this isn't done yet02:28
anastasiamacthumper: the thing is i don't think it's too hard.. i think the problem is my setup.. juju/utils does have 1.25 branch which juju 1.25 uses.. my thinking i branch from utils/1.25 to change licence and then do update deps for juju/1.25...02:29
thumperanastasiamac: well, it kinda is hard because godeps expects the revision to be in the master history02:30
thumperwhat you have to do is make a branch from the 1.25 hash02:30
thumpermake the change02:30
thumperthe merge in master02:30
thumperresolve conflicts02:30
thumperthen propose that to merge into master02:30
thumpereven though it may not change any files02:31
anastasiamacthumper: is this not  utils for 1.25? https://github.com/juju/utils/tree/1.2502:31
thumperthen you need to update the hash that 1.25 uses to be the non-mainline hash02:31
thumperthat is the tag on master from which 1.25 was released02:31
thumperwell branch02:32
thumperbut you can't specify non-master branch in godeps02:32
thumperyet02:32
anastasiamacah ... k.. i'll mark as won't fix on 1.25 and if it makes someone cry, we'll fix then :D02:32
thumperit is not impossible02:32
thumperjust difficult at the moment02:33
anastasiamacof course \o/ but since 1.25 is in critical only, i can downgrade it to High and if there is a burning desire to have it in, then we'll go the painful way...02:34
anastasiamacm sure there are other licencning inconsistencies in 1.25 deps :D02:34
thumperanastasiamac: menn0 thinks I'm wrong02:36
thumperwhich may well be trye02:36
thumpertrue02:36
anastasiamacthumper: menn0: which part wrong? tracking only master branches in dependencies.tsv?02:37
thumperto create a branch off the 1.25 branch do this02:37
thumpergit branch update-1.25-foo upstream/1.2502:37
thumperthen checkout02:37
thumperwe were arguing about how git works when fetching revisions02:38
anastasiamacthumper: menn0: fatal: Not a valid object name: 'upstream/1.25'02:43
anastasiamaci think my remotes r funny02:44
thumperanastasiamac: do you have upstream set as the remote?02:44
menn0anastasiamac: what does "git remote -v" show?02:44
anastasiamac$ git remote -v02:44
anastasiamacorigin  https://github.com/anastasiamac/utils.git (fetch)02:44
anastasiamacorigin  https://github.com/anastasiamac/utils.git (push)02:44
anastasiamacupstream        https://github.com/juju/utils (fetch)02:44
anastasiamacupstream        https://github.com/juju/utils (push)02:44
anastasiamacmenn0: ^^02:45
menn0anastasiamac: that looks ok02:50
menn0anastasiamac: what about "git branch -r | grep 1.25" ?02:50
anastasiamacmenn0: and yet it does not work :( must b monday... 'git branch' yields nothing, just returns02:51
menn0anastasiamac: ok, do a "git fetch" and then try again02:52
anastasiamacmenn0: did and it just returns too02:52
anastasiamacsomehow m not "seeing" 1.25 in my git02:52
anastasiamacbut I can see it against juju/utils on github in browser02:52
anastasiamacthumper: wallyworld: veebers: is it normal that landing jenkins says "(pending—juju-core-slave is offline)"02:53
wallyworldnope02:54
thumperanastasiamac: do you find that git asks for your github password everytime you push?02:55
anastasiamacyes02:55
thumperanastasiamac: considered using ssh rather than https?02:55
veebersanastasiamac: I'll see if I can find out whats happening02:56
thumperanastasiamac: make sure github has your public key02:56
anastasiamaci'd consider anything at this stage especially if it'll solve my current trip02:56
wallyworldeithet that or use a keyring02:56
thumperthen set the remote url02:56
thumpergit remote origin set-url git@github.com:anastasiamac/utils.git02:56
thumperthen no more password requests02:56
thumperanastasiamac: do `git branch -r`02:57
menn0anastasiamac: also worth trying "git fetch -v upstream" to find out more about the fetch02:57
anastasiamacthumper: $ git remote origin set-url git@github.com:anastasiamac/utils.git02:58
anastasiamacerror: Unknown subcommand: origin02:58
thumperanastasiamac: I got set-url and origin the wrong way around02:58
anastasiamacmenn0: with "git fetch -v upstream" i can se that 1.25 there but it's not being fetched for me :(02:59
veebersanastasiamac: I've kicked that node back into action03:00
anastasiamacveebers: awesome03:00
anastasiamacthumper: menno: finally after setting up ssh, i can checkout 1.25 \o/03:00
anastasiamacm moving on to creating my branch - THANK YOU :D03:00
menn0anastasiamac: schweet03:03
menn0thumper: prechecks wired up inside the InitiateMigration API handler: http://reviews.vapour.ws/r/5595/04:04
menn0thumper: so much better from a UX perspective (see QA steps)04:04
thumperlooking04:04
menn0thumper: just figured out the bug that jam filed a while back where migrations get stuck. it happens when you try to migrate a model back to a controller it's just been migrated from and the migrationmaster is still finishing up there.05:32
menn0thumper: the cause is subtle but I know how to fix it now.05:33
=== frankban|afk is now known as frankban
wallyworldaxw: hey, hope your macaroon stuff is going ok. you probs don't have time today, but if you did get a few minutes free, would love a pretty straightforward review on a change to list-models output http://reviews.vapour.ws/r/559407:43
axwwallyworld: going ok, but slowly. will take a look07:44
wallyworldonly if you are able07:45
=== admcleod_ is now known as admcleod
frobwaredimitern: ping - can we sync?09:14
dimiternfrobware: hey, sure, just give me 5m09:15
frobwaredimitern: ok, will be in standup HO09:16
babbageclunkwallyworld: Around?10:25
voidspacebabbageclunk: ping10:44
babbageclunkvoidspace: pong10:44
voidspaceI have a test failure on master11:14
voidspacestate/metrics_test.go:748:11:14
voidspace    c.Check(metricBatches[0].Unit(), gc.Equals, "metered/0")11:14
babbageclunkgodeps?11:21
babbageclunkvoidspace: ^^11:21
wallyworldbabbageclunk: hey11:21
voidspacebabbageclunk: nope, fully godep'ed up11:21
babbageclunkwallyworld: hey!11:21
voidspacebabbageclunk: probably a map ordering issue11:21
perrito666morning all btw11:22
voidspaceperrito666: o/11:22
babbageclunkwallyworld: Replying to your email - maybe worth a hangout if you can? (Sorry, realise it's late for you)11:23
wallyworldbabbageclunk: no worries, give me 5 and i'll ping11:23
babbageclunkwallyworld: awesome, thanks11:23
voidspacebabbageclunk: yeah, the result has two entries and they're swapped over11:29
voidspacebabbageclunk: so the test is order dependent11:29
babbageclunkbabbageclunk: stink11:29
voidspacebabbageclunk: easy enough to fix, I'll do it in my branch11:29
frobwaredimitern: which HO?11:33
dimiternfrobware: I've realized it's not there so I just added one11:33
dimiternhttps://hangouts.google.com/hangouts/_/canonical.com/juju-dns-nss11:33
dimiternjam: ^^11:33
jamdimitern: brt11:34
perrito666wow 500M of Res memory is a bit of a heavy footprint11:36
mupBug #1613992 changed: 1.25.6 "ERROR juju.worker.uniter.filter filter.go:137 tomb: dying" <landscape> <juju-core:Won't Fix> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1613992>11:45
wallyworldbabbageclunk: free now, did you want to hang out?11:47
babbageclunkwallyworld: yes please - how about in core?11:48
wallyworldsure got a link handy?11:48
wallyworldi don't have that one visible in my calendar11:49
babbageclunkwallyworld: https://hangouts.google.com/hangouts/_/canonical.com/core11:49
wallyworldbabbageclunk: ah damn, missed one place - ControllerInstances is called when restoring from backup12:21
babbageclunkwallyworld: doh12:21
wallyworldso we'll need that query by tag12:21
wallyworlddamn12:21
babbageclunkOh well12:21
wallyworldso close12:21
babbageclunkBut it's still only query by one tag for now, right? I don't need to do multiple calls and then intersect them together?12:22
* perrito666 hears backup and peeks in12:22
=== freyes__ is now known as freyes
babbageclunkwallyworld: Oh no, I do - the machines in the controller model are not all necessarily controllers.12:52
wallyworldcorrect12:53
wallyworldiscontroller=true && controller-uuid=blah12:53
frobwaredimitern: I pushed an update for bridging all interfaces - https://github.com/frobware/juju/tree/master-bridge-all-interfaces13:46
dimiternfrobware: ok, looking13:46
frobwaredimitern: that's just the unit test cases updated (and the bridge script updated). Was going to try some genuine deployments next.13:47
dimiternfrobware: at first glance looks like it does what we need13:47
frobwarevoidspace: standup?14:03
voidspacefrobware: oh yeah, thanks14:03
=== petevg is now known as petevg_afk
dimiternfrobware, voidspace, babbageclunk: can you please have a look at this tiny PR: http://reviews.vapour.ws/r/5597/14:48
babbageclunkdimitern: LGTM!14:56
dimiternbabbageclunk: thanks!14:58
dimiternfrobware: I'll land this unless you have comments I guess?14:58
frobwaredimitern: was just looking at it14:58
dimiternfrobware: ok, no rush then14:59
frobwaredimitern: do you know if the sysfs paths are consistent across kernel versions?15:05
dimiternfrobware: as far as I can see - yes, tested on trusty, xenial, and centos 715:06
frobwaredimitern: I wonder why "brif" is not listed in here: https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-net15:08
dimiternfrobware: not sure, but I've seen lots of examples using brif15:11
frobwaredimitern: OK I see this in if_bridge.h - #define SYSFS_BRIDGE_PORT_SUBDIR "brif"15:13
dimiternfrobware: also this - https://books.google.bg/books?id=ALapr7CvAKkC&pg=PT420&lpg=PT420&dq=sys+class+net+bridge+brif&source=bl&ots=gVdzaVkYPv&sig=PVTMP6WszdmaCcAj4v6hNmYY67c&hl=en&sa=X&ved=0ahUKEwje3OPnwfjOAhUDWxQKHVJqBBYQ6AEIKTAC#v=onepage&q=sys%20class%20net%20bridge%20brif&f=false15:13
frobwaredimitern: I'll believe the header file :)15:13
frobwaredimitern: LGTM15:16
dimiternfrobware: :) thanks!15:16
frobwaredimitern: stepping out for early dinner (read no breakfast and no lunch)...15:18
dimiternfrobware: enjoy!15:19
frobwaredimitern: neither were intentional, just the way the day planned out15:19
=== kadams54_ is now known as kadams54
=== psivaa_ is now known as psivaa
=== plars_ is now known as plars
=== marlinc_ is now known as marlinc
=== zeestrat_ is now known as zeestrat
=== frankban is now known as frankban|afk
dimiternfrobware: you've got a review on https://github.com/juju/juju/pull/6156 btw16:23
frobwaredimitern: thanks16:37
dimiternfrobware: I'm about to propose the next step - decided to split networkingcommon changes in 2 PRs for easier review16:37
frobwaredimitern: doh! :)16:37
dimiternfrobware: here's the next step: http://reviews.vapour.ws/r/5598/16:55
dimiternI don't expect you to review it tonight :) just FYI16:55
=== akhavr1 is now known as akhavr
axwwallyworld: sorry I was a bit rushed in my review yesterday. I'll try again later.22:58
axwwallyworld: it would be helpful if there were a definition for the access levels for models somewhere. we don't have that do we?22:58
wallyworldaxw: there's a doc, let me find it, but it is a bit vague tbh23:06
menn0thumper: standup?23:16
thumpercoming23:16
anastasiamac_thumper: have u made the decision about Jesse's MADE PRs?23:42
thumperno23:45
thumperI'm waiting until after 2.0 to look23:45
thumperno time right now23:45
thumperalso23:45
* thumper weeps at apiserver/params importing mongo23:45
* thumper looks at perrito66623:46
thumperUpgradeMongoParams23:47
thumperapiserver/params shouldn't import external packages23:47
thumperespecially not for arg structures23:47
thumperI'23:47
thumperI'll fix it in my branch23:47
thumperbecause I have introduced the cycle23:47

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!