| menn0 | thumper: I figured out the blobstore thing. Although Juju doesn't use github.com/juju/blobstore any more, charmstore.v5 still does. I've emailed rog about it. | 00:13 |
|---|---|---|
| wallyworld | thumper: can you take another look at my PR? | 01:02 |
| anastasiamac | thumper: u r an OCR \o/ my monday might get better after all :D could u PTAL http://reviews.vapour.ws/r/5590/? | 01:42 |
| thumper | yep | 01:44 |
| anastasiamac | tyvm! | 01:55 |
| anastasiamac | thumper: one line dependencies update - http://reviews.vapour.ws/r/5591/ | 02:21 |
| thumper | anastasiamac: timestamp is a lie | 02:22 |
| thumper | anastasiamac: do this: | 02:22 |
| thumper | godeps ./... | grep "juju/util" | 02:22 |
| thumper | you can then just copy that line | 02:22 |
| thumper | veebers: now good? | 02:23 |
| anastasiamac | thumper: done \o/ | 02:24 |
| thumper | anastasiamac: I used to hand craft those lines until I worked out that trick | 02:24 |
| anastasiamac | thumper: u r awesome \o/ we should have this in our wiki, I think :D | 02:25 |
| anastasiamac | thumper: i need to update these licecne on 1.25 branch of juju/utils but no amount of fetching/pull is giving me this branch to creat my own on... | 02:26 |
| anastasiamac | i suspect my upstrem/origin pair r not correct but can't figure out where m going wrong | 02:26 |
| anastasiamac | could anyone point me in the right direction? | 02:26 |
| thumper | anastasiamac: probably not worth fixing IMO | 02:27 |
| thumper | there are hoops we could jump through if someone thinks it is important enough | 02:28 |
| thumper | bit kinda icky due to godeps | 02:28 |
| thumper | I know we were looking at updating godeps to allow it to look at different branches | 02:28 |
| thumper | but AFAIK, this isn't done yet | 02:28 |
| anastasiamac | thumper: the thing is i don't think it's too hard.. i think the problem is my setup.. juju/utils does have 1.25 branch which juju 1.25 uses.. my thinking i branch from utils/1.25 to change licence and then do update deps for juju/1.25... | 02:29 |
| thumper | anastasiamac: well, it kinda is hard because godeps expects the revision to be in the master history | 02:30 |
| thumper | what you have to do is make a branch from the 1.25 hash | 02:30 |
| thumper | make the change | 02:30 |
| thumper | the merge in master | 02:30 |
| thumper | resolve conflicts | 02:30 |
| thumper | then propose that to merge into master | 02:30 |
| thumper | even though it may not change any files | 02:31 |
| anastasiamac | thumper: is this not utils for 1.25? https://github.com/juju/utils/tree/1.25 | 02:31 |
| thumper | then you need to update the hash that 1.25 uses to be the non-mainline hash | 02:31 |
| thumper | that is the tag on master from which 1.25 was released | 02:31 |
| thumper | well branch | 02:32 |
| thumper | but you can't specify non-master branch in godeps | 02:32 |
| thumper | yet | 02:32 |
| anastasiamac | ah ... k.. i'll mark as won't fix on 1.25 and if it makes someone cry, we'll fix then :D | 02:32 |
| thumper | it is not impossible | 02:32 |
| thumper | just difficult at the moment | 02:33 |
| anastasiamac | of course \o/ but since 1.25 is in critical only, i can downgrade it to High and if there is a burning desire to have it in, then we'll go the painful way... | 02:34 |
| anastasiamac | m sure there are other licencning inconsistencies in 1.25 deps :D | 02:34 |
| thumper | anastasiamac: menn0 thinks I'm wrong | 02:36 |
| thumper | which may well be trye | 02:36 |
| thumper | true | 02:36 |
| anastasiamac | thumper: menn0: which part wrong? tracking only master branches in dependencies.tsv? | 02:37 |
| thumper | to create a branch off the 1.25 branch do this | 02:37 |
| thumper | git branch update-1.25-foo upstream/1.25 | 02:37 |
| thumper | then checkout | 02:37 |
| thumper | we were arguing about how git works when fetching revisions | 02:38 |
| anastasiamac | thumper: menn0: fatal: Not a valid object name: 'upstream/1.25' | 02:43 |
| anastasiamac | i think my remotes r funny | 02:44 |
| thumper | anastasiamac: do you have upstream set as the remote? | 02:44 |
| menn0 | anastasiamac: what does "git remote -v" show? | 02:44 |
| anastasiamac | $ git remote -v | 02:44 |
| anastasiamac | origin https://github.com/anastasiamac/utils.git (fetch) | 02:44 |
| anastasiamac | origin https://github.com/anastasiamac/utils.git (push) | 02:44 |
| anastasiamac | upstream https://github.com/juju/utils (fetch) | 02:44 |
| anastasiamac | upstream https://github.com/juju/utils (push) | 02:44 |
| anastasiamac | menn0: ^^ | 02:45 |
| menn0 | anastasiamac: that looks ok | 02:50 |
| menn0 | anastasiamac: what about "git branch -r | grep 1.25" ? | 02:50 |
| anastasiamac | menn0: and yet it does not work :( must b monday... 'git branch' yields nothing, just returns | 02:51 |
| menn0 | anastasiamac: ok, do a "git fetch" and then try again | 02:52 |
| anastasiamac | menn0: did and it just returns too | 02:52 |
| anastasiamac | somehow m not "seeing" 1.25 in my git | 02:52 |
| anastasiamac | but I can see it against juju/utils on github in browser | 02:52 |
| anastasiamac | thumper: wallyworld: veebers: is it normal that landing jenkins says "(pending—juju-core-slave is offline)" | 02:53 |
| wallyworld | nope | 02:54 |
| thumper | anastasiamac: do you find that git asks for your github password everytime you push? | 02:55 |
| anastasiamac | yes | 02:55 |
| thumper | anastasiamac: considered using ssh rather than https? | 02:55 |
| veebers | anastasiamac: I'll see if I can find out whats happening | 02:56 |
| thumper | anastasiamac: make sure github has your public key | 02:56 |
| anastasiamac | i'd consider anything at this stage especially if it'll solve my current trip | 02:56 |
| wallyworld | eithet that or use a keyring | 02:56 |
| thumper | then set the remote url | 02:56 |
| thumper | git remote origin set-url git@github.com:anastasiamac/utils.git | 02:56 |
| thumper | then no more password requests | 02:56 |
| thumper | anastasiamac: do `git branch -r` | 02:57 |
| menn0 | anastasiamac: also worth trying "git fetch -v upstream" to find out more about the fetch | 02:57 |
| anastasiamac | thumper: $ git remote origin set-url git@github.com:anastasiamac/utils.git | 02:58 |
| anastasiamac | error: Unknown subcommand: origin | 02:58 |
| thumper | anastasiamac: I got set-url and origin the wrong way around | 02:58 |
| anastasiamac | menn0: with "git fetch -v upstream" i can se that 1.25 there but it's not being fetched for me :( | 02:59 |
| veebers | anastasiamac: I've kicked that node back into action | 03:00 |
| anastasiamac | veebers: awesome | 03:00 |
| anastasiamac | thumper: menno: finally after setting up ssh, i can checkout 1.25 \o/ | 03:00 |
| anastasiamac | m moving on to creating my branch - THANK YOU :D | 03:00 |
| menn0 | anastasiamac: schweet | 03:03 |
| menn0 | thumper: prechecks wired up inside the InitiateMigration API handler: http://reviews.vapour.ws/r/5595/ | 04:04 |
| menn0 | thumper: so much better from a UX perspective (see QA steps) | 04:04 |
| thumper | looking | 04:04 |
| menn0 | thumper: just figured out the bug that jam filed a while back where migrations get stuck. it happens when you try to migrate a model back to a controller it's just been migrated from and the migrationmaster is still finishing up there. | 05:32 |
| menn0 | thumper: the cause is subtle but I know how to fix it now. | 05:33 |
| === frankban|afk is now known as frankban | ||
| wallyworld | axw: hey, hope your macaroon stuff is going ok. you probs don't have time today, but if you did get a few minutes free, would love a pretty straightforward review on a change to list-models output http://reviews.vapour.ws/r/5594 | 07:43 |
| axw | wallyworld: going ok, but slowly. will take a look | 07:44 |
| wallyworld | only if you are able | 07:45 |
| === admcleod_ is now known as admcleod | ||
| frobware | dimitern: ping - can we sync? | 09:14 |
| dimitern | frobware: hey, sure, just give me 5m | 09:15 |
| frobware | dimitern: ok, will be in standup HO | 09:16 |
| babbageclunk | wallyworld: Around? | 10:25 |
| voidspace | babbageclunk: ping | 10:44 |
| babbageclunk | voidspace: pong | 10:44 |
| voidspace | I have a test failure on master | 11:14 |
| voidspace | state/metrics_test.go:748: | 11:14 |
| voidspace | c.Check(metricBatches[0].Unit(), gc.Equals, "metered/0") | 11:14 |
| babbageclunk | godeps? | 11:21 |
| babbageclunk | voidspace: ^^ | 11:21 |
| wallyworld | babbageclunk: hey | 11:21 |
| voidspace | babbageclunk: nope, fully godep'ed up | 11:21 |
| babbageclunk | wallyworld: hey! | 11:21 |
| voidspace | babbageclunk: probably a map ordering issue | 11:21 |
| perrito666 | morning all btw | 11:22 |
| voidspace | perrito666: o/ | 11:22 |
| babbageclunk | wallyworld: Replying to your email - maybe worth a hangout if you can? (Sorry, realise it's late for you) | 11:23 |
| wallyworld | babbageclunk: no worries, give me 5 and i'll ping | 11:23 |
| babbageclunk | wallyworld: awesome, thanks | 11:23 |
| voidspace | babbageclunk: yeah, the result has two entries and they're swapped over | 11:29 |
| voidspace | babbageclunk: so the test is order dependent | 11:29 |
| babbageclunk | babbageclunk: stink | 11:29 |
| voidspace | babbageclunk: easy enough to fix, I'll do it in my branch | 11:29 |
| frobware | dimitern: which HO? | 11:33 |
| dimitern | frobware: I've realized it's not there so I just added one | 11:33 |
| dimitern | https://hangouts.google.com/hangouts/_/canonical.com/juju-dns-nss | 11:33 |
| dimitern | jam: ^^ | 11:33 |
| jam | dimitern: brt | 11:34 |
| perrito666 | wow 500M of Res memory is a bit of a heavy footprint | 11:36 |
| mup | Bug #1613992 changed: 1.25.6 "ERROR juju.worker.uniter.filter filter.go:137 tomb: dying" <landscape> <juju-core:Won't Fix> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1613992> | 11:45 |
| wallyworld | babbageclunk: free now, did you want to hang out? | 11:47 |
| babbageclunk | wallyworld: yes please - how about in core? | 11:48 |
| wallyworld | sure got a link handy? | 11:48 |
| wallyworld | i don't have that one visible in my calendar | 11:49 |
| babbageclunk | wallyworld: https://hangouts.google.com/hangouts/_/canonical.com/core | 11:49 |
| wallyworld | babbageclunk: ah damn, missed one place - ControllerInstances is called when restoring from backup | 12:21 |
| babbageclunk | wallyworld: doh | 12:21 |
| wallyworld | so we'll need that query by tag | 12:21 |
| wallyworld | damn | 12:21 |
| babbageclunk | Oh well | 12:21 |
| wallyworld | so close | 12:21 |
| babbageclunk | But it's still only query by one tag for now, right? I don't need to do multiple calls and then intersect them together? | 12:22 |
| * perrito666 hears backup and peeks in | 12:22 | |
| === freyes__ is now known as freyes | ||
| babbageclunk | wallyworld: Oh no, I do - the machines in the controller model are not all necessarily controllers. | 12:52 |
| wallyworld | correct | 12:53 |
| wallyworld | iscontroller=true && controller-uuid=blah | 12:53 |
| frobware | dimitern: I pushed an update for bridging all interfaces - https://github.com/frobware/juju/tree/master-bridge-all-interfaces | 13:46 |
| dimitern | frobware: ok, looking | 13:46 |
| frobware | dimitern: that's just the unit test cases updated (and the bridge script updated). Was going to try some genuine deployments next. | 13:47 |
| dimitern | frobware: at first glance looks like it does what we need | 13:47 |
| frobware | voidspace: standup? | 14:03 |
| voidspace | frobware: oh yeah, thanks | 14:03 |
| === petevg is now known as petevg_afk | ||
| dimitern | frobware, voidspace, babbageclunk: can you please have a look at this tiny PR: http://reviews.vapour.ws/r/5597/ | 14:48 |
| babbageclunk | dimitern: LGTM! | 14:56 |
| dimitern | babbageclunk: thanks! | 14:58 |
| dimitern | frobware: I'll land this unless you have comments I guess? | 14:58 |
| frobware | dimitern: was just looking at it | 14:58 |
| dimitern | frobware: ok, no rush then | 14:59 |
| frobware | dimitern: do you know if the sysfs paths are consistent across kernel versions? | 15:05 |
| dimitern | frobware: as far as I can see - yes, tested on trusty, xenial, and centos 7 | 15:06 |
| frobware | dimitern: I wonder why "brif" is not listed in here: https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-net | 15:08 |
| dimitern | frobware: not sure, but I've seen lots of examples using brif | 15:11 |
| frobware | dimitern: OK I see this in if_bridge.h - #define SYSFS_BRIDGE_PORT_SUBDIR "brif" | 15:13 |
| dimitern | frobware: also this - https://books.google.bg/books?id=ALapr7CvAKkC&pg=PT420&lpg=PT420&dq=sys+class+net+bridge+brif&source=bl&ots=gVdzaVkYPv&sig=PVTMP6WszdmaCcAj4v6hNmYY67c&hl=en&sa=X&ved=0ahUKEwje3OPnwfjOAhUDWxQKHVJqBBYQ6AEIKTAC#v=onepage&q=sys%20class%20net%20bridge%20brif&f=false | 15:13 |
| frobware | dimitern: I'll believe the header file :) | 15:13 |
| frobware | dimitern: LGTM | 15:16 |
| dimitern | frobware: :) thanks! | 15:16 |
| frobware | dimitern: stepping out for early dinner (read no breakfast and no lunch)... | 15:18 |
| dimitern | frobware: enjoy! | 15:19 |
| frobware | dimitern: neither were intentional, just the way the day planned out | 15:19 |
| === kadams54_ is now known as kadams54 | ||
| === psivaa_ is now known as psivaa | ||
| === plars_ is now known as plars | ||
| === marlinc_ is now known as marlinc | ||
| === zeestrat_ is now known as zeestrat | ||
| === frankban is now known as frankban|afk | ||
| dimitern | frobware: you've got a review on https://github.com/juju/juju/pull/6156 btw | 16:23 |
| frobware | dimitern: thanks | 16:37 |
| dimitern | frobware: I'm about to propose the next step - decided to split networkingcommon changes in 2 PRs for easier review | 16:37 |
| frobware | dimitern: doh! :) | 16:37 |
| dimitern | frobware: here's the next step: http://reviews.vapour.ws/r/5598/ | 16:55 |
| dimitern | I don't expect you to review it tonight :) just FYI | 16:55 |
| === akhavr1 is now known as akhavr | ||
| axw | wallyworld: sorry I was a bit rushed in my review yesterday. I'll try again later. | 22:58 |
| axw | wallyworld: it would be helpful if there were a definition for the access levels for models somewhere. we don't have that do we? | 22:58 |
| wallyworld | axw: there's a doc, let me find it, but it is a bit vague tbh | 23:06 |
| menn0 | thumper: standup? | 23:16 |
| thumper | coming | 23:16 |
| anastasiamac_ | thumper: have u made the decision about Jesse's MADE PRs? | 23:42 |
| thumper | no | 23:45 |
| thumper | I'm waiting until after 2.0 to look | 23:45 |
| thumper | no time right now | 23:45 |
| thumper | also | 23:45 |
| * thumper weeps at apiserver/params importing mongo | 23:45 | |
| * thumper looks at perrito666 | 23:46 | |
| thumper | UpgradeMongoParams | 23:47 |
| thumper | apiserver/params shouldn't import external packages | 23:47 |
| thumper | especially not for arg structures | 23:47 |
| thumper | I' | 23:47 |
| thumper | I'll fix it in my branch | 23:47 |
| thumper | because I have introduced the cycle | 23:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!