[06:37] greatings; are there any Qt5 package maintainer online ATM? [06:37] err, make that greetings. [06:39] nIRV_: what do you need? :) [06:40] nIRV_: (not a package maintainer, just asking the question would make it easier to get an answer :) ) [06:41] tsimonq2: thanks for the quick reply; I'd like to get an assessement of whether I can cultivate some hope the following issue (https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1620173) will be addressed :) [06:41] Launchpad bug 1620173 in qtbase-opensource-src (Ubuntu) "Qt5 5.6 regression: conversion from QVariant to QString is broken" [Undecided,New] [06:42] Mirv: ^^^^ [06:43] it's a qt5 (5.5.x, 5.6.x) regression which is fixed in Qt5 5.7, and it's affecting a project I'm involved in (QGIS). We're hoping Ubuntu's package could have the Qt patch applied. [06:43] could you link to the Qt patch?\ [06:44] tsimonq2, http://code.qt.io/cgit/qt/qtbase.git/patch/src/corelib/tools/qlocale.h?id=726fed0d67013cbfac7921d3d4613ca83406fb0f [06:44] nIRV_: do you have experience working with Debian packaging? [06:45] I could walk you through attaching a debdiff to the bug report so the fix is quicker :) [06:47] tsimonq2, I unfortunatelly don't have experience in creating debdiff; how involving is that process when starting from scratch? :) [06:48] fairly simple if you know basic terminology :) [06:48] what system are you on right now? [06:48] (as in Linux distro and version) [06:49] 16.10 [06:49] ubuntu [06:49] oh great, that makes things really simple :) [06:50] nIRV_: would the fix need to be in 16.04 as well? [06:50] (they use 5.5) [06:51] I guess so, the bug report says it was introduced in 5.5, am I correct? [06:51] tsimonq2, ideally, although I'd focus on 5.6 ATM [06:51] yep [06:51] ok :) [06:51] tsimonq2: nIRV_: thanks for the bug report, sure it can be fixed. I just published a long prepared qtbase update to yakkety, this one can go in once I get the current one transitioned to release pocket [06:52] Mirv: where can we grab that source? I'd be much easier if the debdiff could be created against that to avoid fuzz [06:52] Mirv: that'd be great; it's a pretty nasty regression. [06:52] is it in proposed? [06:52] nIRV_: in the meantime, do you have an SSH key I can grab real quick? [06:52] I do not [06:53] would you like to generate one and if so, do you know how? [06:53] I'd be able to show you on a VPS I have [06:53] well wait no [06:53] sorry [06:53] I don't have GPG keys generated :/ [06:53] tsimonq2: in proposed yes https://launchpad.net/ubuntu/+source/qtbase-opensource-src/5.6.1+dfsg-3ubuntu3~3 , although the packaging itself (where the patch will be added) is at http://anonscm.debian.org/cgit/pkg-kde/qt/qtbase.git/log/?h=ubuntu - doing a debdiff however would be useful in the sense that it's known if the patch applies [06:54] Mirv: I was going to walk him through dgetting it, then using quilt to make a patch [06:54] if the patch applies as is (taken from 5.7) to our 5.6.1, then it's not a problem. if there's some rebasing needed, then it'd need some work. [06:54] tsimonq2: sounds good! [06:55] nIRV_: ok, so pop open a terminal, make a working directory, and cd into it please [06:55] Mirv, I'm hoping it applies as is (relatively small; http://code.qt.io/cgit/qt/qtbase.git/patch/src/corelib/tools/qlocale.h?id=726fed0d67013cbfac7921d3d4613ca83406fb0f) [06:56] tsimonq2: done [06:57] nIRV_: run dget https://launchpad.net/ubuntu/+archive/primary/+files/qtbase-opensource-src_5.6.1+dfsg-3ubuntu3~3.dsc [06:57] this'll download everything that's needed [06:57] Mirv: debian/changelog entry or will you handle that when it gets into Yakkety? [07:00] tsimonq2: downloading ... I'm behind a bad internet connection, ETA is 30min. [07:00] yeah it's a big package :/ [07:06] @yofel, 👍 [07:10] tsimonq2, done [07:11] cool :) [07:11] so could you get me the output of ls ? [07:11] (I want to know if it extracted it for you or not) [07:12] qtbase-opensource-src_5.6.1+dfsg-3ubuntu3~3.debian.tar.xz qtbase-opensource-src_5.6.1+dfsg.orig.tar.xz qtbase-opensource-src_5.6.1+dfsg-3ubuntu3~3.dsc [07:12] it did not [07:12] ok [07:12] extract both the tars [07:12] the orig tar will give you a dir [07:12] the debian tar will give you a debian dir [07:13] done [07:13] move the debian dir into the dir created by the orig tar [07:13] (if that makes sense) [07:13] ☑ [07:14] cd into that dir [07:14] now we get to the good part :) [07:14] is the quilt package installed? [07:15] it is now [07:15] great :) [07:16] so I assume you don't use quilt for anything else? [07:16] yeah, I'm not familiar with quilt [07:17] ok one sec here [07:19] nIRV_: put this in ~/.quiltrc : http://paste.ubuntu.com/23135947/ [07:19] ok [07:20] so now it's time to apply the patch [07:20] src/corelib/kernel/qvariant.cpp | 21 ++---- [07:20] src/corelib/tools/qlocale.cpp | 21 +++++- [07:20] src/corelib/tools/qlocale.h | 4 ++ [07:20] src/corelib/tools/qlocale.qdoc | 17 +++++ [07:20] src/corelib/tools/qlocale_tools.cpp | 30 +++++--- [07:20] src/corelib/tools/qlocale_tools_p.h | 4 +- [07:20] tests/auto/corelib/kernel/qvariant/qvariant.pro | 5 +- [07:20] .../auto/corelib/kernel/qvariant/tst_qvariant.cpp | 51 ++++++++++--- [07:21] tests/auto/corelib/tools/qlocale/test/test.pro | 4 ++ [07:21] tests/auto/corelib/tools/qlocale/tst_qlocale.cpp | 83 +++++++++++++++------- [07:21] 10 files changed, 173 insertions(+), 67 deletions(-) [07:22] nIRV_: first, run quilt new NAME-OF-PATCH.diff [07:22] be creative, figure out a name :) [07:22] Patch QT5-FIX-QVARIANT-CONVERSION is now on top [07:23] nIRV_: next, run quilt add src/corelib/kernel/qvariant.cpp src/corelib/tools/qlocale.cpp (etc.) [07:24] this is so it knows what the initial state of the file was [07:24] was? is? *shrug* :) [07:26] done [07:27] so according to the edited portion on http://stackoverflow.com/a/3418499 you should be able to download the git patch and use the patch command to apply it [07:27] (not sure, haven't tried it) [07:28] nIRV_: let me know if that works [07:29] tsimonq2, http://pastebin.ubuntu.com/23135972/ [07:31] nIRV_: then it's a matter of looking at each of the rejects and applying them manually [07:31] tsimonq2, those rejects, why are they not applying? [07:32] nIRV_: could you get me a pastebin of src/corelib/tools/qlocale.cpp.rej please? [07:33] tsimonq2: http://pastebin.ubuntu.com/23135982/ [07:34] so now it's time to look around [07:34] in src/corelib/tools/qlocale.cpp is there the following line? [07:34] if (form == DFDecimal) // optimize for numbers smaller than 512k [07:34] there is [07:35] then manually apply the diff :) [07:35] - if (form == DFDecimal) // optimize for numbers smaller than 512k [07:35] + if (precision == QLocale::FloatingPointShortest) [07:35] + bufSize += DoubleMaxSignificant; [07:35] + else if (form == DFDecimal) // optimize for numbers between -512k and 512k [07:35] however, there is no int bufSize = 1; line; searching qlocale.cpp for bufSize returns nothing [07:35] it's all in the rejects file [07:36] nIRV_: well it might be in different spots :) [07:36] rmember, Qt 5.6.1 =/ Qt 5.7 [07:37] things might have changed [07:37] so we have to accomodate for those changes :) [07:37] tsimonq2: right; so, basically, looking at qlocale.cpp (v5.7) reveals that the function we're trying to patch, doubleToString, has significantly changed, more than what the patch modifies. [07:38] so then figure out how to correctly apply the diff in a way that works :) [07:38] this is the tricky part [07:42] Mirv might be able to help in some cases if you get stuck nIRV_ :) [07:47] nIRV_: how's it going? [07:49] well, I think I've established that the patch I was referring to is effectively part 2, part 1 being this one: https://codereview.qt-project.org/#/c/104737/32//ALL,unified [07:50] oh ok [07:50] well then I showed you the process :) [07:50] if you want to just start fresh, cd .. and rm -rf the directory, then re-extract [07:51] nIRV_: which I'd recommend :) [07:52] Switching to the Telegram bridge [07:53] how could I get the .patch from this link: https://codereview.qt-project.org/#/c/104737/ [07:55] ok, got it: https://codereview.qt-project.org/gitweb?p=qt/qtbase.git;a=patch;h=8c2ca33073f20e1fe552bd8b5f663aec5b8a634d;hp=84042523f272c1d30247e9329eea21036ff793f4 [07:55] Hmm [07:56] Oh OK cool :) [07:56] I was wondering [07:58] tsimonq2, for files that are newly added by a patch, do I include those in quilt add too? [07:58] Yes I believe so [07:59] Try it :) [08:01] Ahhhhh shoot [08:01] Wait [08:01] You have to add everything before you apply the diff [08:02] You did that right? [08:02] (if not just redo, no big deal) [08:03] Ahhhhh yes that's what I told you to do earlier, all good :l [08:03] *:) === davmor2_hols is now known as davmor2 [08:05] nIRV_: so what's going on? [08:05] ok, I'll have to defer to higher authorities here, who actually know what they are doing ;) [08:06] Hey now [08:06] I had to double check [08:06] tsimonq2: well, the new patch I realized was needed first applies, mostly :) [08:07] Ok cool :) [08:07] oh don't read me wrong, I'm quite happy this identified another piece that's needed, that'll save the devs some time, and increase the propability we'll see ubuntu 16.10 shipping with a fixed QVariant double to string conversion :) [08:08] \o/ [08:09] So what now? [08:09] it also identified two additional QT-BUGs that this pair of patch would fix, all around double to string conversion. [08:10] tsimonq2: Mirv: the ubuntu qt team takes over? :) [08:10] morning everyone [08:10] Nice! :) [08:11] Kubuntu session at Akademy 2016 about to start, follow meeting notes here: https://notes.kde.org/p/KubuntuAkademy2016 [08:11] tsimonq2: thanks for the time you took walking me through this. [08:11] nIRV: could you stick around for a day or two to make sure everything is good to go? [08:12] No problem :) [08:12] nIRV: https://raphaelhertzog.com/2012/08/08/how-to-use-quilt-to-manage-patches-in-debian-packages/ [08:12] That's if you ever need to know how to do this again :) [08:12] tsimonq2: right, I'm definitively more than willing to help out if anything more is needed from me; [08:13] Cool 👍 [08:14] Alright it's 3 am and I need some sleep [08:14] Have a nice day mIRV_ :) [08:14] o/ [08:14] 3PM here, we're on opposite sides of earth it seems [08:14] cheers [08:14] Lol o/ === clivejo-dev is now known as clivejo-berlin [08:25] howdyy folks [08:34] well that's not working [08:36] next try [08:38] nah, needs fixing [09:12] @tsimonq2 please get in here: https://trello.com/c/f3ax0qf7/192-write-simple-tool-to-check-all-branches-for-patch-policy-compliance [09:14] /me wakes up [09:14] Why, what's up? [09:15] hi tsimonq2 [09:15] so we can all colaborate [09:15] on Kubuntu tasks [09:15] ninja stuffz [09:15] Ooh ok [09:15] I meant to join the board [09:15] we are cleaning up Trello right now, you might want to look at it evolving in RT :-) [09:15] do you have a trello account? [09:16] we want to add you to trello [09:16] Argh so no good sleep for me tonight :/ :P [09:16] Fine fine [09:16] Creating a Trello account now [09:16] no no, whenever you have time [09:17] we are just sorting stuff out [09:17] and thought you might be interested in some of the jobs-cards [09:19] OK wth [09:19] Confusing thing [09:20] yup :) [09:20] https://trello.com/tsimonq2 [09:20] Can y'all just add me to things so I can at least try to sleep? :P [09:21] yup [09:21] get some sleep [09:22] Good night then :P o/ [09:22] sweet dreams [09:23] *mutes notifications* [09:23] Thanks Clive :) [10:03] o/ ximion_ [10:04] heya [10:06] now I know who you are ! [10:19] and I am BACK [10:19] boy did I need those 3 weeks :) [10:19] how is everyone? [10:20] we're cleaning up Trello right now [11:05] good morning [11:23] morning santa_ [11:26] Hiyas all === pavlushka is now known as Guest17606 === pavlushka_ is now known as pavlushka [12:33] I know I missed it [12:48] can someone kick this dude on #kubuntu ? [12:48] and ban for good [12:49] +1 [12:50] soee_: my network is unstable, please call ops in #kubuntu [12:50] yofel: how ? [13:59] what is the telegram invitation link url ? [14:10] mparillo: whats the status of kubuntu wire? [14:14] I have not posted to the wire recently. I personally think posting any good news (including something available for testing) is a good thing, but not everybody seems to agree. [14:15] wire.kubuntu.org seems to be dead [14:15] has JR turned it off? [14:19] If he did intentionally, I suppose he would have posted something here or to the mailing list. If so, I missed it. Perhaps as KDE has been moving around some of the neon infrastructure, something was lost? [14:20] Im not sure [14:20] we just trying to figure it out what happened to it [14:22] I do not know, but if it is restored, and if the consensus is that my postings helped, I would be happy to resume. [14:24] how did you post to wire? [14:46] There is an admin URL (http://wire.kubuntu.org/wp-admin/). I know JR can give a password. [14:47] can you still access it? [14:47] Not today. The last time I tried before today was probably early summer. [14:48] I cant seem to connect either [14:48] seems to be dead [14:49] I wonder if somebody accidentally moved a server, changing its IP address, and not updating the DNS record? [14:50] Or was it deliberately killed? [14:51] dunno [14:51] thats what Im trying to determine [14:56] Is the consensus that we want to resuscitate it? If so, I think the first query would go to JR. [14:57] yakkety is such a pain in the axe [14:57] everything still depends on gnupg1, yet the gnupg-agent is version 2 [14:57] arrggh [14:57] * clivejo-bearlin nods [15:54] Morning o/ [16:07] hey o/ === yofel_ is now known as yofel [16:08] How are you today yofel_ ? [16:09] Mostly ok, but not feeling too good. So I'm on my way back home now, just said goodbye to the others an hour ago. Now sitting in the train [16:10] Aww :( [16:10] Now leaving feels real :( [16:10] How far is your home from the conference site? [16:11] 5h train ride (conference was in Berlin, I live in Stuttgart) [16:11] Ahh ok [16:11] So that means you won't be going back? [16:11] Or will you? [16:15] No [16:16] Aww OK :( [16:20] :) [16:20] yofel feel lucky you do not have screaming kids (and no free seat to change...) for 6 hours like I did on Saturday [16:21] xD [16:21] see ya in the evening guys! ciao! :) [16:28] How can I be added to edit on this Trello thing...? @yofel Clifford @ahoneybun @Sick_Rimmit [16:28] by being on the team [16:29] How do I do that? [16:29] someone has to do it [16:29] you can't [16:30] Well then add me Mr. Admin [16:30] :P [16:30] confirm your email for trello at some point [16:30] Ok [16:37] What were the tasks we wanted to assign to @tsimonq2 [16:37] ? [16:37] @ovidiuflorin, You wanted to assign stuff to me? As in give me more work? :D [16:38] Sure! :P === pavlushka is now known as Guest64188 === pavlushka_ is now known as Guest93617 === Guest93617 is now known as pavlushka === Quintasan_ is now known as Quintasan === Mamarok is now known as Guest36787 [16:47] * misses Yofel* [16:48] @Clifford, Get to say hi to Daniel Holbach yet? :D === BirthdayHandler is now known as nhandler [17:06] Create a Package search [17:06] https://trello.com/c/ye9mKiuy/199-create-a-package-search [17:06] Look [17:08] @CliffordTheBigRedDoggie nice nick :D === amichair_ is now known as amichair [18:06] I vaguely recall it was ditched [18:07] kubuntu wire ^^ [18:10] * ahoneybun is on Ubuntu Unity [18:14] Eew :P [18:15] I like it quite a lot [18:17] mm trying to build blaze's new ubiquity will be hard on this system without those deps [18:17] @tsimonq2 there's nothing wrong with Unity [18:19] nice the new daily has favorites fixed! [18:30] I saw the favourites were there. Not sure how that happened [19:00] Wasn't somebody here working on qtwebengine packages? Did that ever make it into Yakkety? [19:00] I was [19:00] Nope [19:00] Slowly getting into Debian first [19:01] Ah, OK. Thanks for letting me know, and thanks for the work! :) [19:02] Np :) [19:06] it's in KCI for YY, but not the archive [19:07] That too [19:07] And the one in KCI needs an update... [19:09] probably. I took the latest one on could find for 5.7, but could be newer now [19:26] Who fixed the favourites? [19:26] Brad Pitt [19:27] @CliffordTheBigRedDoggie, ? [19:28] Kickoff favourites [19:28] Maybe it was just an artifact of the undefined singularity that's preseeding plasma configs? [19:28] Are you drunk?!! [19:29] Lol [19:29] I might be just crazy, I'm chatting with Clifford the big red dog! [19:30] :P [19:30] No. Just tired of watching the landscape pass by me... [19:35]