[01:46] thumper: Fix for the "migrations get stuck" bug: http://reviews.vapour.ws/r/5599/ [01:46] * thumper looks [01:51] menn0: just one Q on the review [01:59] ok [01:59] oh ffs, will this branch die... [02:35] thumper: u reviewed Casey's PR yesterday (http://reviews.vapour.ws/r/5588/) r u k to stamp it? [02:53] wallyworld: still going on this, but if you have any time I'd appreciate if any early comments before I delve into unit tests: https://github.com/juju/juju/compare/master...axw:login-local-macaroon?expand=1 [02:53] ok, give me 10 [02:53] wallyworld: in particular, there's some UX changes [02:53] or 5 [02:53] sure, take your time [02:56] axw: menn0:wallyworld:thumper: any idea who is looking after https://github.com/juju/blobstore? us or Uros's team? [02:56] either [02:57] whoever needs to make changes does so [02:57] we created it initially [02:57] they have landed patches since [02:57] anastasiamac_: I emailed rog about it yesterday. what's up? [02:58] wallyworld: menn0: m trying to determine if the issues agaisnt this libraries are ours (and hnce need to be in launchpad) or theirs (and then I do not need to worry) [02:58] library* [02:59] i don't think we track bugs for that library on launchpad [03:00] any issues for those upstream libraries in github.com/juju are tracked in github IIANM [03:04] wallyworld: not all, there are some bugs in launchpad. for example, most recently, licence bugs were floating around [03:05] oh? ok. what project were they filed against? [03:05] wallyworld: and as far as I can see we r not *really* tracking in github [03:05] anastasiamac_: in case it's relevant, I emailed rog b/c we don't use github.com/juju/blobstore directly. We just the newer version at gopkg.in/juju/blobstore.v2. [03:05] oh, that needs to be fixed :-( [03:05] anastasiamac_: the only reason we still have it in dependencies.tsv is because charmstore.v5 still uses it [03:06] menn0: tyvm - u r the best \o/ we'll wait for rog :D [03:06] rog said that it shouldn't cause a problem b/c of the way it's used [03:06] we could do tha one ourselves if we really wanted to :-) [03:06] and that they're moving away from using mongodb for a blobstore "soon" anyway [03:06] oooh.. what r they moving toward to? [03:07] anastasiamac_: no idea, he didn't say [03:07] intersting ... :D [03:08] this is what rog said: We actually plan to move away from using mongo-based blobstore at some point but in the meantime we should probably move to v2. I don't see any potential harm in having both versions as deps in juju though in the meantime - neither have any global state AFAIR. [03:08] menn0: \o/ k [03:08] * wallyworld hates carrying unnecessary deps [03:08] adds to build time and landing bot time [03:09] wallyworld: so here is one for ur and thumper's delight: 2 PR against juju/cmd (on github) LGTM'ed in 2014.. one can be merged, one has conflicts :D [03:09] "delight" [03:09] wallyworld: thumper: could we plx decide if we close the or land them? [03:09] \o/ [03:10] always "delight" [03:10] hand-in-hnad with "wonder" :) [03:10] * thumper relocates [03:10] to OZ? [03:10] dropping kid at bjj and working from cafe there [03:10] back online from cafe [03:10] wallyworld: i thin u've just been delegated [03:11] * wallyworld is busy, will look later [03:11] awesome \o/ [03:16] axw: menn0: wallyworld: is https://github.com/juju/errgo officially deprecated in favour of juju/errors? [03:16] only in core [03:16] it's still used upstream :-( :-( [03:17] wallyworld: does it? macaroon stuff uses gopkg.in/errgo.v1 [03:17] axw: that's my point :-) [03:17] can't see any imports - I think it's dead [03:17] i want to use juju/errors everywhere [03:17] wallyworld: axw: so if there is a PR against this library, who is to review/land? [03:18] wallyworld: I just meant there's gopkg.in/errgo.v1, which != juju/errgo. but yes, we still have two [03:18] r we responsible for it? [03:18] we = rog [03:18] we != rog :D [03:19] juju core doesn't maintain errgo [03:19] juju core would like not to have to pull in errgo at all [03:19] \o/ [03:19] i'll happily ignore these PRs then :D [03:20] wallyworld: axw: menn0: what about https://github.com/juju/errors? [03:21] that's out error package [03:21] our [03:21] kinda need that one :) [03:22] we could just do better and stop creating errors [03:25] lol [03:26] oooh, axw, wallyworld: what about juju/go4?.. talking about lugging things around :D [03:27] anastasiamac_: I think rog is using that [03:27] k :) 4? isn;t he on the tip of go7? [03:28] that's not go the sdk [03:43] wallyworld: axwwhat about juju/ratelimit? is it rog too? [03:44] not sure, would need to search the code base [03:55] :-( cmd/juju/controller/listblocks_test.go | 124 ------------- [03:55] 49 files changed, 1014 insertions(+), 1238 deletions(-) [03:55] tim@elwood:~/go/src/github.com/juju/juju (block-cmd-rework)$ git diff master | wc -l [03:55] 3229 [03:55] wallyworld: sorry [03:55] yay! [03:55] and i know you'r enot sorry at all [03:56] http://reviews.vapour.ws/r/5600/ [03:56] wallyworld: just adding qa steps [03:58] wallyworld: it has been epic [03:59] wallyworld: that review addresses all the block related commands, and a few drive by fixes [03:59] some of which were necessary, others not entirely so [04:00] ok, am finishing something, then looking at andrew's diff then yours [04:00] * thumper nods [04:00] the change that introduced the import cycle that I had to fix was moving the CmdBlockHelper out of cmd/juju/common [04:00] it was the only file that brought gocheck into the package, which made gocheck a non-testing dependency [04:00] moved it into testing [04:01] that introduced an import cycle in the api package [04:01] due to the mongo.Version structure over the api [04:06] thumper: what an adventure! thank you :D [04:08] thumper: That PR removes the block, unblock commands right? [04:08] veebers: it renames [04:08] veebers: block -> disable-command [04:09] unblock -> enable-command [04:09] block list -> disabled-commands [04:09] thumper: sorry yeah renames. That's going to need a change to the assess_block CI test when it lands [04:09] * thumper nods [04:10] thumper: I should be able to rough it up now, but not sure if it'll land before/when your PR does [04:10] veebers: the branch is still being reviewed [04:12] thumper: ack, I'll get something ready in the wings [04:38] * thumper relocates again [05:01] wallyworld: I've just updated my branch, I think I've got all the loose ends now. now I need to write a bunch of tests [05:01] axw: ok, almost ready to look [05:11] axw: looking now. i've add to my PR to address the comments, but also added machine and core count to show-controller. a difference with current behavior is that it does an AllModels() api call to get the model info to stick in the output, rather than simply only looking at locally cached info [05:11] and that's more correct anyway [05:12] but it doesn't currently update the local yaml though [05:15] wallyworld: doesn't update the cache for list-controllers you mean? [05:15] axw: doesn't update the local model yaml [05:16] so this is for show-controller [05:16] previously, show controller would only look at local models yaml [05:16] now it makes an api call [05:17] as it needs to get the machine and core info [05:17] and so it also then gets the latest models as well [05:18] wallyworld: looks fine, but can you please get OCR to check too. it's over 500 lines now [05:18] ffs [05:18] i was going to propose separately [05:19] should have done that [05:19] at the expense of velocity [05:19] anastasiamac_: I improved that test as a result of your comment [05:19] wallyworld: I only say because I'm actually having trouble keeping track of all the changes [05:19] menn0: veni, vidi, vici [05:19] tiny brain [05:19] menn0: i've commented and stamped \o/ looks awesome [05:23] axw: you don't need to import errgo just to call Cause() - juju/errors.Cause() will work IIANM [05:24] wallyworld: ah ok, thanks [05:25] axw: errgo and errors both define their causer interface identically [05:27] wallyworld: it might be more useful for you to pull the branch and test it, than to try and review it as it is. I'll break it up later on and propose a few bits separately. mostly it'll have to be done as one though [05:28] if you don't have time, that's fine [05:28] axw: ok, can do. the fine detail of the auth stuff is a little out of my comfort zone [05:28] wallyworld: no worries. me too, hence why it's taken so long :) [05:28] have to wait for a 2nd review anyway :-/ [05:29] def get rog to look :-) [05:29] axw: axtually, looks like there will be a conflict, wanna rebase before i pull? [05:30] wallyworld: sure, just a minute [05:34] wallyworld: pushed. I just realised I missed something, which is that "juju logout" will need to clear any cookies for the controller. I might do that in a follow up though [05:34] ok [06:01] axw: appears to work ok. password change, deleting go-cookies etc. i get prompted as i would expect for the password and then from there it seems to use the macaroon ok. any thing in particular else to test? [06:02] wallyworld: not really, mostly just wanted to you sanity check. does it feel natural to you? as opposed to how it was, where you would get told that your login expired, and you had to run "juju login" [06:02] wallyworld: FYI, I also tested "juju register" to make sure you get logged in automatically still [06:02] axw: yeah, much nicer to have you simply prompted [06:02] cool [06:02] IMHO [06:02] wallyworld: thanks. updating tests now, will propose it for real later on [06:03] axw: eg with github, if my cached password expires, it simply just prompts again [06:03] * axw nods [06:12] anastasiamac_: if you get a chance, i'd love a 2nd look at this, it's a fraction over 500 lines sadly http://reviews.vapour.ws/r/5594/ [06:14] wallyworld: Morning! [06:14] hey [06:15] wallyworld: Any idea what this maas user data that thumper's talking about is? [06:15] wallyworld: I can't find it. [06:15] no :-( [06:15] i'm sure they maas guys told me to use tags [06:16] Seems kind of unlikely that there's yet another way of searching for machines. [06:16] yeah [06:16] ok cool - I was feeling a bit silly there [06:17] you and me both [06:17] might pay to ask a maas person directly [06:26] are there any in a convenient timezone? [06:28] I'll ask allenap once he's up. === frankban|afk is now known as frankban [07:10] wallyworld: was afk - kids/school/lif (apparently, there is that). I can have a look after dinner/kids bedtime :D is it k? [07:10] anastasiamac_: sure, am working on the next bit in preparation [07:11] wallyworld: \o/ tyvm :) hope u have dinner in btw too :D [07:11] yeah, at some point :-) [08:04] wallyworld menn0: to what degree is migration supposed to be stable in 2.0? there's some macaroon stuff in there that will need to change [08:04] axw: you mean model migration or schema changes for upgrades? [08:05] wallyworld: model migration [08:06] axw: we have some lattitude - an external tool is being used to handle parts of the model the 2.0 agent doesn't know about [08:06] assuming the stuff you need done doesn't make 2.0 [08:07] wallyworld: well I'm going to have to disable the ability to use macaroons to do the migration, so it would only be usable if you have a password in accounts.yaml === MmikeM is now known as Mmike [08:48] mgz: you about? [08:48] mgz: ah, no... you're crewing... [10:35] babbageclunk: ping [10:38] voidspace: pong [13:04] * rick_h_ pokes head up and looks around [13:11] frobware: You have 5 mins? Wanna stay in that HO? [13:11] macgreagoir: I'm still in there [13:12] frobware: Hmmm... I can't see you... === frankban is now known as frankban|afk [15:55] bbl lunch === frankban|afk is now known as frankban === frankban is now known as frankban|afk [17:28] perrito666, ping [17:29] alexisb: pong [17:30] perrito666, have you pick up a bug yet? [17:30] yes I have, https://bugs.launchpad.net/juju/+bug/1616197 [17:30] Bug #1616197: juju restore-backup error [17:30] but I am in time to switch if you have something not backup related [17:31] anyting at all [17:31] perrito666, ok proceed thank you [17:31] nope that is a good one for you to take [17:31] k, Ill proceed [17:31] * perrito666 puts the hazmat suit again [20:28] morning folks [20:33] going to fetch some meds, bbl [20:39] morning thumper === natefinch is now known as natefinch-afk [21:16] alexisb: morning [21:18] Thumper sorry for whatever I broke that you where saying last night [21:18] I already forgot what it was [21:19] perrito666: already fixed and landed [21:19] reminder though not to use external package structures over the api [21:19] apiserver/params was using mgo.Version [21:19] no [21:19] mongo.Version [21:19] anyway [21:19] now it isn't [21:20] thumper: what's the easiest way to find out which beta version the block command was added to? [21:21] veebers: um... block has been around for a long time [21:21] do you mean my change to block? [21:21] thumper: oh no, I meant originally added, this is for updating the ci tests :-) [21:21] thumper: all good, that pretty much answers my question [21:21] if `juju block list` returns non-zero, it isn't found and has new commands [21:22] veebers: it is in 1.25 [21:22] thumper: ah right, thanks :-) [21:24] BOOM! [21:24] success on that test [21:28] wallyworld: ping [21:28] hey [21:35] thumper: Am I right in my reading that you changed all-changes -> all for enable-command? (the PR says you did but the help text still says 'all-changes') [21:37] veebers: yes, "all-changes" is now just "all" [21:38] thumper: Cool, I'll file a bug for the help text [21:40] Bug #1620830 opened: destroyEnvSuite.TestDestroyEnvironmentCommandEFlag interface is nil

[21:40] Bug #1620832 opened: github.com/juju/juju/featuretests MSpan_Sweep: bad span state

[21:42] * redir goes to make tea and change computers, brb [22:25] menn0 or other reviewer? http://reviews.vapour.ws/r/5609/ [22:26] thumper: looking [22:27] axw: ping me when you're around regarding migrations + macaroon issues [22:29] update juju/testing dep http://reviews.vapour.ws/r/5610/ [22:29] one line review [22:31] wallyworld: ^^ [22:35] thumper: more ship its [22:36] menn0: cheers [22:55] menn0: I'm here now [23:12] review board not picking this up for some reason.https://github.com/juju/juju/pull/6172 [23:12] https://github.com/juju/juju/pull/6172 [23:40] wallyworld: access stays unknown... http://pastebin.ubuntu.com/23143762/ [23:41] hmm... older controller [23:41] perhaps wasn't sending right data back [23:41] thumper: correct. did you even read the messsage [23:41] --refresh [23:41] see the last line [23:41] with --refresh [23:41] oh [23:42] in that case the controller is sending back the access, i'll have to understand the repor steps [23:42] bootstrapping newer [23:43] thumper: at bootstrap, access and version is filled in, it should never say unknow unless tyoy are running an older version [23:44] wallyworld: I think it was probably due to it being an older controller [23:44] my guess is you had an older version bootstrapped [23:44] yep, that won't work