=== shardy is now known as shardy_afk | ||
=== shardy_afk is now known as shardy | ||
=== shardy is now known as shardy_lunch | ||
=== Hazelesque_ is now known as Hazelesque | ||
=== shardy_lunch is now known as shardy | ||
=== rangerpbzzzz is now known as rangerpb | ||
smoser | harlowja, around ? | 16:43 |
---|---|---|
smoser | looking at cloudinit/distros/rhel.py i realize i think we have multiple paths doing the same thing now. | 16:43 |
smoser | actually, i think _write_network is probably never called now. | 16:55 |
smoser | except for very explicit dsmode=pass on openstack config drive. | 16:56 |
smoser | larsks, ping | 17:26 |
smoser | https://code.launchpad.net/~bregeer-ctl/cloud-init/+git/cloud-init/+merge/305058 | 17:26 |
smoser | i'd appreciate your eyes on that. | 17:26 |
smoser | and rangerpb also | 17:27 |
larsks | smoser: taking a look... | 17:33 |
x58 | smoser: This better? :P | 17:34 |
smoser | x58, sure. and x58 i just asked larsks to review your mp also | 17:35 |
x58 | Cheers :-) | 17:35 |
harlowja | smoser what up | 17:40 |
harlowja | yes, we have multiple paths for networking :-/ | 17:40 |
smoser | i think the one there is dead now. | 17:40 |
harlowja | sweet | 17:40 |
harlowja | dead code removal ftw | 17:41 |
smoser | as in never used. | 17:41 |
harlowja | as in deaded? | 17:41 |
harlowja | not alive? | 17:41 |
harlowja | dead as a doorknob | 17:41 |
smoser | except for oepnstack case where user feeds 'dsmode=pass' | 17:41 |
smoser | which actually doesnt work that well anyway | 17:41 |
harlowja | ya, i bet, never tried that way | 17:41 |
x58 | Sorry gents, thanks for the review, but I can't in good conscience allow Canonical to take my code and potentially relicense it under a different license. | 18:38 |
smoser | rharper, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/305137 | 19:26 |
smoser | if you want to read that quick... seems simple. probably necessary for curtin too | 19:26 |
smoser | actually not necessary for curtin | 19:27 |
* smoser updates bug | 19:27 | |
=== rangerpb is now known as rangerpbzzzz |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!