| === aps-sids is now known as aps | ||
| === shardy is now known as shardy_mtg | ||
| smoser | rharper, cpaelzer you convinced me that the copy was odd | 13:10 |
|---|---|---|
| smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/305137 | 13:10 |
| smoser | i had originally added it to avoid updating the original if there were no "old" keys ... so i wouldnt delete things in 'needtoconvert' loop | 13:10 |
| smoser | but since we modify the input in other places, the right thing would be to either change it wholesale (including in convert_to_v3_apt_format). | 13:11 |
| smoser | so, just going to drop the copy | 13:11 |
| === shardy_mtg is now known as shardy | ||
| cpaelzer | ok | 13:16 |
| cpaelzer | that is what discussions are for | 13:16 |
| cpaelzer | are your tests still good with that? | 13:16 |
| cpaelzer | smoser: ^^ | 13:16 |
| cpaelzer | or did you have to modify them | 13:16 |
| smoser | cpaelzer, tests dont care. | 13:16 |
| smoser | and wrt your comment about my copy in the test... i had done that to avoid typing the same thing twice. | 13:17 |
| smoser | to be safe from the function i called changing the data that i passed in. | 13:17 |
| smoser | ie, avoiding this bad test: | 13:17 |
| smoser | def foo(mydict): | 13:17 |
| smoser | mydict['a'] = '1' | 13:17 |
| smoser | return mydict | 13:17 |
| cpaelzer | got it | 13:17 |
| cpaelzer | copy and make sure it (still) is the same | 13:18 |
| smoser | m = {'1': 2} | 13:18 |
| smoser | foo(m) | 13:18 |
| smoser | self.assertEqual(m, foo(m)) | 13:18 |
| smoser | or whatever. | 13:18 |
| smoser | right. | 13:18 |
| smoser | the behavior of calling a function and it modifying a dictionary and returning that dictionary is odd. | 13:19 |
| smoser | but for now, oh well. | 13:19 |
| cpaelzer | I still lack some python style badges - this is one that I have to still internalize | 13:22 |
| rharper | smoser: heh | 13:32 |
| === rangerpbzzzz is now known as rangerpb | ||
| === aps is now known as Guest78392 | ||
| === rangerpb is now known as rangerpbzzzz | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!