=== aps-sids is now known as aps === shardy is now known as shardy_mtg [13:10] rharper, cpaelzer you convinced me that the copy was odd [13:10] https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/305137 [13:10] i had originally added it to avoid updating the original if there were no "old" keys ... so i wouldnt delete things in 'needtoconvert' loop [13:11] but since we modify the input in other places, the right thing would be to either change it wholesale (including in convert_to_v3_apt_format). [13:11] so, just going to drop the copy === shardy_mtg is now known as shardy [13:16] ok [13:16] that is what discussions are for [13:16] are your tests still good with that? [13:16] smoser: ^^ [13:16] or did you have to modify them [13:16] cpaelzer, tests dont care. [13:17] and wrt your comment about my copy in the test... i had done that to avoid typing the same thing twice. [13:17] to be safe from the function i called changing the data that i passed in. [13:17] ie, avoiding this bad test: [13:17] def foo(mydict): [13:17] mydict['a'] = '1' [13:17] return mydict [13:17] got it [13:18] copy and make sure it (still) is the same [13:18] m = {'1': 2} [13:18] foo(m) [13:18] self.assertEqual(m, foo(m)) [13:18] or whatever. [13:18] right. [13:19] the behavior of calling a function and it modifying a dictionary and returning that dictionary is odd. [13:19] but for now, oh well. [13:22] I still lack some python style badges - this is one that I have to still internalize [13:32] smoser: heh === rangerpbzzzz is now known as rangerpb === aps is now known as Guest78392 === rangerpb is now known as rangerpbzzzz