| nottrobin | @webteam: Does ubuntu.com have a pattern for alert rows? I want to make a row saying "This section doesn't work without JavaScript". | 11:03 |
|---|---|---|
| ant__ | nottrobin, can you not make it progressive? If not it should be hidden with a simple message? | 11:05 |
| nottrobin | ant__: yes of course I'm only showing it if JavaScript isn't there. I'm saying, how can I style it? | 11:05 |
| nottrobin | ant__: oh you mean hide the whole contents of the page? | 11:06 |
| nottrobin | ant__: it's for /download/desktop/contribute. You can't submit through PayPal without JavaScript, so the page is pointless. | 11:06 |
| nottrobin | ant__: we're going to avoid linking there for people who don't have JavaScript | 11:06 |
| nottrobin | ant__: but still people could land there by choice | 11:07 |
| === ant__ is now known as antdillon | ||
| antdillon | mmm ... interesting ... PayPal requires js? | 11:08 |
| antdillon | nottrobin, ^ | 11:08 |
| nottrobin | antdillon: https://github.com/ubuntudesign/www.ubuntu.com/pull/848#issuecomment-246305796 | 11:08 |
| nottrobin | antdillon: about the 6th bullet | 11:09 |
| nottrobin | antdillon: this is what I've done for now: http://i.imgur.com/eQXmpSr.png | 11:10 |
| nottrobin | sewaddle: I've hopefully addressed all your concerns: https://github.com/ubuntudesign/www.ubuntu.com/pull/848#issuecomment-246318587 | 11:21 |
| nottrobin | antdillon: If you get this done then I'll do my QA stuff: https://github.com/ubuntudesign/www.ubuntu.com/pull/846#discussion_r78285696 | 11:28 |
| antdillon | nottrobin, can you add the link to continue to the download too please | 11:58 |
| nottrobin | antdillon: done | 12:28 |
| antdillon | nottrobin, how you getting on with this review? https://github.com/ubuntudesign/www.ubuntu.com/pull/846 | 14:34 |
| nottrobin | antdillon: waiting on your response to my comment, mentioned above ^^^^ | 14:42 |
| antdillon | nottrobin, ok | 14:44 |
| antdillon | nottrobin, done ^ | 14:59 |
| nottrobin | antdillon: https://github.com/ubuntudesign/www.ubuntu.com/pull/846#issuecomment-246378053 | 15:06 |
| nottrobin | antdillon: and 2 other comments which you can ignore if you want | 15:06 |
| antdillon | nottrobin, done again ^ | 15:21 |
| nottrobin | antdillon: cool. QAing | 15:22 |
| nottrobin | antdillon: could you rebase your branch on top of master? I'm getting JavaScript errors in firefox which I think are fixed. | 16:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
