| menn0 | thumper: easy one: http://reviews.vapour.ws/r/5658/ | 00:02 |
|---|---|---|
| mup | Bug #1622738 changed: Multi-series charms failing in 1.25.6 <juju:Triaged> <juju-core:Won't Fix> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1622738> | 00:03 |
| mup | Bug #1622738 opened: Multi-series charms failing in 1.25.6 <juju:Triaged> <juju-core:Won't Fix> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1622738> | 00:12 |
| redir | wallyworld: updated http://reviews.vapour.ws/r/5640/ | 00:21 |
| mup | Bug #1622738 changed: Multi-series charms failing in 1.25.6 <juju:Triaged> <juju-core:Won't Fix> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1622738> | 00:21 |
| wallyworld | ta, looking | 00:21 |
| redir | mup stuttering? | 00:21 |
| * redir wonders if that usually happens or if that is a new rocket feature. | 00:27 | |
| wallyworld | redir: lgtm ty. const also looks nicer separated out from all the text | 00:27 |
| redir | wallyworld: tx | 00:27 |
| redir | merging and heading out for EoD | 00:28 |
| wallyworld | redir: one mup was for opening the bug, the other for changing it | 00:28 |
| wallyworld | have fun | 00:28 |
| redir | OIC, changed open changed | 00:28 |
| redir | wallyworld: Is the --file some.yaml flag only for app config? | 00:32 |
| wallyworld | yes | 00:32 |
| wallyworld | IIANM | 00:32 |
| redir | heh | 00:32 |
| redir | tx | 00:33 |
| anastasiamac | axw: veebers: http://reviews.vapour.ws/r/5659/ | 00:51 |
| axw | anastasiamac: thanks, reviewed | 01:00 |
| anastasiamac | axw: sure, off-the-top-of ur-head, after bootstrap, what's GUI's URL? | 01:06 |
| axw | anastasiamac: just run "juju gui" | 01:06 |
| anastasiamac | axw: tyvm | 01:06 |
| wallyworld | veebers: can you let me know when that set-config change is merged? | 01:46 |
| veebers | wallyworld: for the CI test? It's done now oh wait I'll just update the jenkins machines right now too | 01:50 |
| veebers | sorry I should have retyped that, but characters are expensive over here <_< | 01:50 |
| wallyworld | veebers: awesome, cause a merge job failed because it complained about set-config | 01:50 |
| veebers | wallyworld: oh? do you have a link? | 01:50 |
| wallyworld | http://juju-ci.vapour.ws:8080/job/github-merge-juju/9193/ | 01:51 |
| veebers | thanks | 01:51 |
| veebers | wallyworld: sorry that's totally my fault, I merged it all etc. but forgot to update the jenkins machines with the updated code | 01:52 |
| veebers | The update job is running now | 01:52 |
| wallyworld | no worries | 01:52 |
| wallyworld | ty | 01:52 |
| menn0 | wallyworld: migration prechecks now use your new MachineStatus helper: http://reviews.vapour.ws/r/5660/ | 02:12 |
| wallyworld | great | 02:13 |
| wallyworld | menn0: i have a quibble about the message in the down case | 02:17 |
| menn0 | wallyworld: ok | 02:17 |
| menn0 | wallyworld: the message came from the fact that we're checking if the machine agent has StatusStarted | 02:18 |
| menn0 | we call it "started" in status too | 02:19 |
| menn0 | I'll try to think of something | 02:19 |
| wallyworld | sure, but consider where it was started and is now down | 02:19 |
| wallyworld | down may be transient | 02:19 |
| wallyworld | so i think we need to special case that status | 02:19 |
| menn0 | wallyworld: how about I just use the status string directly? "machine 0 agent is down" "machine 0 agent is pending" etc | 02:22 |
| menn0 | wallyworld: actually, that doesn't work for error... "machine 0 agent is error" | 02:24 |
| wallyworld | yeah | 02:26 |
| menn0 | wallyworld: I think I'll go with: "machine 0 agent is not functioning (down)" | 02:26 |
| wallyworld | or "not functioning at this time" | 02:27 |
| menn0 | wallyworld: hmmm, a tad long but I see where you're going | 02:27 |
| wallyworld | just want to convey that it is likely transient | 02:27 |
| menn0 | yeah, fair enough. i'll go with that. | 02:28 |
| natefinch | not functioning, to me, mean broken | 02:29 |
| natefinch | is it just not responding? or not yet made it to a good state? | 02:30 |
| menn0 | natefinch: in this case it could be either | 02:34 |
| menn0 | natefinch: I think "not functioning at this time" covers both reasonably | 02:34 |
| menn0 | natefinch: this is only for the error returned by migration prechecks. juju status will provide more detail. | 02:35 |
| menn0 | wallyworld, thumper: FYI I'm looking at bug 1616531 | 03:03 |
| mup | Bug #1616531: "panic: unknown OS for series" when running client on Fedora <juju:In Progress by menno.smits> <https://launchpad.net/bugs/1616531> | 03:03 |
| wallyworld | sgtm | 03:03 |
| thumper | k | 03:03 |
| menn0 | thumper, wallyworld, axw: the client won't work on fedora at all b/c we don't explicitly support it | 04:03 |
| natefinch | ^^^^ this kills me | 04:03 |
| menn0 | but we have Arch support | 04:03 |
| menn0 | what do you think about me changing the support for Arch (which is only supported on the client) to "generic linux" | 04:04 |
| menn0 | ? | 04:04 |
| menn0 | so any linux system which isn't ubuntu or linux uses that | 04:04 |
| menn0 | ? | 04:04 |
| natefinch | yes... please... although why is ubuntu special? | 04:04 |
| menn0 | ubuntu and centos need to be special because we support them server side | 04:05 |
| natefinch | sure, but that's server side | 04:05 |
| menn0 | so we need to know how to interact with package managers etc | 04:05 |
| wallyworld | menn0: sorry, had to talk to a roofing man. my roof, my roof, my roof (is not on fire) but needs lots of repairs :-( | 04:09 |
| * wallyworld reads backscroll | 04:09 | |
| natefinch | maybe I was misunderstanding... we should absolutely be able to run the client on any linux. IIRC, when I was looking at it in December of last year, there's a spurious check in the version package that ensures it understands what series it is running on | 04:11 |
| wallyworld | menn0: yeah, so client and server are different for the reasons you say. also, the basis for strictly knowing the series goes back to juju 0.1 when tools were series specific. they sort of still are but don't need to be. the issue though is still bootstrap but there the main problem is matching the arch which I think will be solved by your suggested approach | 04:12 |
| wallyworld | natefinch: that's to build the tools | 04:12 |
| wallyworld | there's some work to be done to uncouple tools from series | 04:12 |
| wallyworld | it's not necessarily a totally trivial exercise but really needs to be done | 04:13 |
| natefinch | wallyworld: IIRC we hit this just running the client on unknown series.. but I could be mistaken | 04:13 |
| wallyworld | yes, correct | 04:13 |
| wallyworld | the series needs to be known in some circumstances | 04:14 |
| wallyworld | i think it may possibly over eager | 04:14 |
| wallyworld | in checking for it, but i'd need to look at the code | 04:14 |
| menn0 | it's used to decide on paths | 04:14 |
| menn0 | not sure if that's for good reasons yet | 04:14 |
| wallyworld | ah yes, that rings a bell | 04:14 |
| wallyworld | it's probably all tied up to when tools had series in the path name | 04:14 |
| menn0 | that code probably only needs to know about the OS | 04:14 |
| wallyworld | and we didn;t have simplestreams | 04:15 |
| wallyworld | so juju just had to read a directory listing | 04:15 |
| wallyworld | and pick tools matching series from the path name | 04:15 |
| natefinch | paths *should* only be OS-specific | 04:15 |
| wallyworld | i agree, just explainign the history | 04:15 |
| natefinch | yep | 04:15 |
| wallyworld | the assumption was that tools could be different on precise vs trusty | 04:15 |
| wallyworld | but IIANM that has never been somthing we have ever done | 04:16 |
| wallyworld | we have always shipped the same binary on all *nix etc | 04:16 |
| natefinch | yep | 04:16 |
| wallyworld | goes to show how decisions made in juju 0.1 we are still paying for :-) | 04:16 |
| natefinch | in theory you could compile with different versions of go to get different binaries, but they'd still all work on all distros/series | 04:17 |
| wallyworld | true | 04:17 |
| wallyworld | compile with the most modern/optimised compiler | 04:17 |
| menn0 | so the way I see it there's 3 courses of action for me right now | 04:18 |
| menn0 | 1. add support for Fedora explicitly - pretty dumb but gets us out of the immediate problem | 04:18 |
| menn0 | 2. change the support for Arch to be support for GenericLinux - slightly more work but means the client will work on all Linuxes | 04:18 |
| menn0 | 3. Work out all the places series is used where OS should be and fix them - lots more work and more risky | 04:19 |
| menn0 | I'm thinking | 04:19 |
| menn0 | #2 | 04:19 |
| menn0 | thumper, wallyworld, natefinch: thoughts? | 04:19 |
| wallyworld | yeah i think 2 sounds ok. will need careful testing | 04:20 |
| natefinch | #2, but with the addition of removing this line: https://github.com/juju/version/blob/master/version.go#L143 which I think would fix our "Every 6 months juju breaks" problem because the client encounters series it doesn't know about. | 04:20 |
| wallyworld | yeah, it breaks if people's distroinfo package is not up to date | 04:21 |
| wallyworld | we could remove the need to read the distro info file entirely maybe | 04:21 |
| wallyworld | on the client at least | 04:21 |
| natefinch | that would be awesome | 04:22 |
| wallyworld | ah wait | 04:22 |
| wallyworld | we need the series to parse simplestreams onthe client | 04:22 |
| wallyworld | but that may just be to see what tools are needed server side | 04:22 |
| natefinch | sure | 04:22 |
| wallyworld | so inother words, there be dragons | 04:22 |
| wallyworld | we'll just need to think carefully | 04:22 |
| natefinch | and if you have series = xxxxxxxx then it won't find tools, big deal | 04:22 |
| wallyworld | well no tools = no bootstrap | 04:23 |
| natefinch | yes | 04:23 |
| natefinch | but once the tools are in streams bam, bootstrap | 04:23 |
| wallyworld | and that's not good | 04:23 |
| wallyworld | i thinking about the custom tools case | 04:23 |
| wallyworld | anyway, it just needs careful thought and testing to cover all the cases we support | 04:24 |
| mup | Bug #1598362 changed: MongoDB replica error in machine-0 <bootstrap> <mongodb> <juju-core:Expired> <https://launchpad.net/bugs/1598362> | 04:25 |
| natefinch | the local series shouldn't impact what you bootstrap, anyway, IMO. Why would I want my laptop's OS to change what OS juju runs on? | 04:25 |
| wallyworld | it used to matter if you compiled tools | 04:26 |
| wallyworld | but we can make it not matter. but there's a bunch of code to change | 04:26 |
| natefinch | yeah | 04:26 |
| wallyworld | and tests | 04:27 |
| wallyworld | that will be the most sucky biyt | 04:27 |
| menn0 | ok, I'll proceed with caution | 04:29 |
| wallyworld | will be good to get this fixed though | 04:29 |
| mup | Bug #1598362 opened: MongoDB replica error in machine-0 <bootstrap> <mongodb> <juju-core:Expired> <https://launchpad.net/bugs/1598362> | 04:31 |
| natefinch | menn0: proceed with a large hammer and good protective gear :) | 04:32 |
| * wallyworld weeps making changes which affect uniter tests. oh the joy | 04:39 | |
| anastasiamac | wallyworld: opportunity to improve uniter tests? :D | 04:42 |
| wallyworld | that would require a week all on its own sadly | 04:42 |
| wallyworld | they're not that bad, just fiddly | 04:42 |
| wallyworld | they use a DSL, and when one bit breaks, a lot of failures occur | 04:43 |
| axw | menn0: I'd keep Arch, and add generic linux | 04:45 |
| mup | Bug #1598362 changed: MongoDB replica error in machine-0 <bootstrap> <mongodb> <juju-core:Expired> <https://launchpad.net/bugs/1598362> | 04:46 |
| menn0 | axw: do we support arch server side? there's some indications that the azure provider does (but maybe I reading that wrong) | 04:46 |
| axw | menn0: I wish we used a format that retained OS + version | 04:46 |
| axw | err, distro | 04:46 |
| axw | menn0: no we don't. I guess we could just replace it and add it back later if we need it | 04:46 |
| mup | Bug #1622836 opened: Cannot bootstrap to Google Compute Engine <juju-core:New> <https://launchpad.net/bugs/1622836> | 05:25 |
| mup | Bug #1622836 changed: Cannot bootstrap to Google Compute Engine <juju-core:New> <https://launchpad.net/bugs/1622836> | 05:31 |
| menn0 | wallyworld: with a very small change I can use the client on fedora | 05:35 |
| wallyworld | great | 05:35 |
| menn0 | wallyworld: bootstrap works if I use --agent-version to grab a published version | 05:35 |
| menn0 | wallyworld: but trying to use my own binaries fails to find local tools | 05:36 |
| wallyworld | menn0: try hacking the client version to a released version and should shoul dnot need --agent-version either | 05:36 |
| wallyworld | that's because it is using rc1 | 05:36 |
| wallyworld | as the version | 05:36 |
| wallyworld | oh wait | 05:36 |
| menn0 | wallyworld: I thought it could have been something to do with the series being "unknown" | 05:36 |
| wallyworld | you have built jujud locally | 05:37 |
| wallyworld | yeah, in that case, series will be reported by jujd as "unknown" i think yeah | 05:37 |
| wallyworld | i'd have to look into it to be sure | 05:38 |
| menn0 | i've got to stop for now... will keep digging later | 05:39 |
| menn0 | wallyworld: thanks | 05:39 |
| wallyworld | i'll look as well | 05:39 |
| wallyworld | i just need to finish something | 05:40 |
| urulama_ | wallyworld: hey, did you have time to check charm caching issue? should i just file a bug? | 05:41 |
| wallyworld | urulama_: the relevant folks know about it; it's been on the radar for a few weeks I found out. there's a meeting tonight to discuss further | 05:42 |
| wallyworld | i hope something will be fixed over the next week or so | 05:43 |
| wallyworld | not sure if there's a bug already filed | 05:43 |
| === urulama_ is now known as urulama | ||
| urulama | wallyworld: kk | 05:44 |
| mup | Bug #1622836 opened: Cannot bootstrap on Google Compute Engine <juju-core:New> <https://launchpad.net/bugs/1622836> | 05:46 |
| thumper | laters folks | 05:50 |
| mup | Bug #1622836 changed: Cannot bootstrap on Google Compute Engine <juju-core:New> <https://launchpad.net/bugs/1622836> | 06:07 |
| mup | Bug #1622836 opened: Cannot bootstrap on Google Compute Engine <juju-core:New> <https://launchpad.net/bugs/1622836> | 06:13 |
| mup | Bug #1622836 changed: Cannot bootstrap on Google Compute Engine <eda> <cloud-images:New> <juju:Triaged> <https://launchpad.net/bugs/1622836> | 06:16 |
| === frankban|afk is now known as frankban | ||
| babbageclunk | voidspace, frobware, fwereade_: anyone fancy a boring mechanical review? http://reviews.vapour.ws/r/5665/ | 11:22 |
| frobware | babbageclunk: as it touches apiserver is there any impact to other users/clients? | 11:26 |
| babbageclunk | frobware: Hmm, good question. It doesn't change any of the values, just the names, so I don't think so, but I'll have a closer look. | 11:28 |
| fwereade_ | babbageclunk, LGTM | 11:41 |
| fwereade_ | frobware, babbageclunk: re apiserver, indeed, you *can* change type names and field names so long as the serialization doesn't change | 11:42 |
| fwereade_ | frobware, babbageclunk: but it's easier to say and remember "don't touch apiserver" | 11:42 |
| babbageclunk | fwereade_: Cool - thanks! | 11:45 |
| voidspace | fwereade: if you have time https://github.com/juju/juju/pull/6231 | 13:58 |
| rick_h_ | natefinch: ping for standup | 14:02 |
| rick_h_ | frobware: ping for standup | 14:02 |
| frobware | rick_h_: ah, yes. omw. | 14:02 |
| alexisb | perrito666, ping | 15:44 |
| perrito666 | alexisb: pong | 15:44 |
| alexisb | heya perrito666 | 15:44 |
| perrito666 | hey :) how's health? | 15:44 |
| alexisb | wanted to confirm that you were on the critical backup and restore bug: https://bugs.launchpad.net/juju/+bug/1622677 | 15:45 |
| mup | Bug #1622677: Agents lost after restore-backup <backup-restore> <ci> <regression> <restore-backup> <xenial> <juju:In Progress by hduran-8> <https://launchpad.net/bugs/1622677> | 15:45 |
| alexisb | I am feeling better, still sick but functional today | 15:45 |
| alexisb | perrito666, anything blocking you on teh bug above? | 15:45 |
| perrito666 | alexisb: nope, running the test now to see if my fix worked :) | 15:46 |
| alexisb | nice :) | 15:46 |
| dimitern | frobware: ping | 15:49 |
| dimitern | frobware: updated https://github.com/juju/juju/pull/6219, now running make check and later will do a live test on maas | 15:50 |
| dimitern | frobware: but I'll appreciate if you test it live locally as well - it shouldn't cause issues for cases where it worked before | 15:51 |
| babbageclunk | Hmmm, my build's failing in godeps with `cannot create repo: cannot find project root: unrecognized import path "google.golang.org/cloud"` | 15:52 |
| frobware | dimitern: trying again | 16:01 |
| frobware | dimitern: btw, I see something similar to brad using the manual provider | 16:02 |
| dimitern | frobware: what's that? | 16:02 |
| redir | morning | 16:03 |
| frobware | dimitern: just chooes lxdbr0 in lieu of all the bridges available | 16:03 |
| frobware | dimitern: any chance you could try and gently persuade the big data charmers to try the NSS plugin... ? :) | 16:04 |
| dimitern | frobware: sure :) will talk to them | 16:04 |
| frobware | dimitern: Azure (surprise suprise) is the odd ball | 16:04 |
| dimitern | frobware: yeah - frustrating.. I've read your update re reverse lookups | 16:05 |
| frobware | dimitern: so even there it's nothing to do with the plugin. you cannot reverse lookup the hosts IP address. | 16:05 |
| dimitern | frobware: oh - at all? that's weird indeed | 16:06 |
| frobware | dimitern: in your testing are you layering my bridge-tout-le-monde on top of your changes? | 16:06 |
| dimitern | frobware: no, intentionally | 16:07 |
| dimitern | frobware: just tip of master with my PR | 16:07 |
| frobware | dimitern: OK, I'm going to add the bridge script changes as well | 16:08 |
| dimitern | frobware: one of the nodes is using the same config as CI - eth0 = unconf, eth1 = static | 16:08 |
| frobware | mgz: would you expect a bootstrapped azure instance to last more than a few hours or are they automatically GC'd? | 16:09 |
| dimitern | frobware: IIRC they are, for the shared account | 16:10 |
| frobware | dimitern: I thought so too. but, equally, I thought I'd get a least an afternoon. :) | 16:11 |
| dimitern | frobware: :) | 16:12 |
| === frankban is now known as frankban|afk | ||
| mgz | frobware: we've had various fun issues with azure cleanup | 16:16 |
| frobware | mgz: everytime I go back to my azure science experiment... it's all gone away | 16:17 |
| mgz | but I'm not sure the winazurearm script actually deletes machines | 16:17 |
| mgz | let me check | 16:17 |
| mgz | frobware: OLD_MACHINE_AGE is 6, and that's in hours | 16:18 |
| mgz | so, it shouldn't wipe your stuff before that | 16:18 |
| * frobware gives up on lunch | 16:18 | |
| frobware | mgz: in this case it's possible that it has been 6 hours. bootstrapped, got sidetracked... | 16:19 |
| dimitern | frobware: so my PR seems to work fine on maas 1.9 with xenial and trusty nodes - both fullly conf'd and with some unconf'd NICs (mix of vlans and just phys); lxds come up with multiple NICs, as expected | 16:23 |
| dimitern | frobware: make check also passed in the meantime, now testing the same on maas 2.0 | 16:23 |
| natefinch | good god, aliases are annoying to code | 17:29 |
| * redir is expecting a power outage in the near future. | 18:20 | |
| * redir got an SMS that I might experience one from the power company. | 18:21 | |
| natefinch | redir: not sure if I would be impressed they're texting me or annoyed they're turning off my power | 18:28 |
| natefinch | redir: probably both :) | 18:28 |
| redir | natefinch: agreed | 18:28 |
| redir | there was a bunch of beeping (sounded like nearby UPSen) but I haven't lost power yet. So maybe I'm spared | 18:29 |
| natefinch | alexisb: you around? | 19:12 |
| === mwhudson is now known as Guest72628 | ||
| alexisb | natefinch, I am now | 19:26 |
| alexisb | whats up? | 19:26 |
| natefinch | alexisb: was working on expenses... things seems to have changed some since the last time I submitted them (granted, it was a few months ago). what category do I give to expenses for using cloud services for work? | 19:33 |
| redir | easy review: http://reviews.vapour.ws/r/5668/ | 20:14 |
| redir | anyone ^ | 20:14 |
| natefinch | redir: whoa, a Get function that didn't return anything? Wacky | 20:20 |
| perrito666 | .Get(lost) | 20:22 |
| natefinch | redir: I actually prefer it the old way (except for the get function that doesn't actually get)... but still looks correct | 20:22 |
| natefinch | redir: ship it! | 20:23 |
| redir | natefinch: we talked about changing get to ensure and api to client | 20:23 |
| redir | but there's a bunch of legacy stuff that isn't broken | 20:23 |
| redir | so why fix it | 20:23 |
| natefinch | yep | 20:23 |
| redir | intertia wins, this time. | 20:23 |
| redir | tx | 20:24 |
| babbageclunk | redir- I'm looking too | 20:27 |
| babbageclunk | redir - why cache the client on the command if you're going to pass it into the methods? | 20:29 |
| redir | babbageclunk: I wasn't goign to pass it. | 20:29 |
| babbageclunk | But In the diff you've got a kind of hybrid approach - you're caching it in getApi and then still passing it around. | 20:30 |
| redir | babbageclunk: we collapsed 3 commands into one. They share an API in the same command, so why pass it to the three helper functions rather than make it an object member | 20:30 |
| babbageclunk | Sure - call getApi in Init and store it in c.api? | 20:31 |
| redir | babbageclunk: the c.api is for allowing tests to pass in a fake api at test time | 20:31 |
| babbageclunk | Can the tests set c.api? | 20:32 |
| redir | if there's c.api isn't nil the newcommandfortest func has attached one and we use it | 20:32 |
| redir | babbageclunk: yes | 20:32 |
| babbageclunk | Then just setting it directly seems ok | 20:32 |
| babbageclunk | (Maybe I'm misunderstanding?) | 20:32 |
| redir | babbageclunk: https://goo.gl/1AjCqJ is where the test sets the api for testing | 20:33 |
| redir | babbageclunk: 2 primary reasons we put it back this way are: it's the way things already to it and returning the client makes it the callers responsibility to call client.Close when done. | 20:34 |
| redir | hopefully that made sense | 20:35 |
| babbageclunk | I don't think clients should have to get the api from one method and pass it in again, just so they can indicate when they're done. Instead they can call a close method on the thing that holds the api. | 20:37 |
| babbageclunk | otherwise you kind of smear the ownership of api out between the two bits of code. | 20:38 |
| redir | babbageclunk: I agree | 20:38 |
| babbageclunk | Ok cool - sorry to stick my oar in, just got excited by the prospect of an easy review! :) | 20:41 |
| redir | hah | 20:42 |
| redir | I know what you mean. | 20:42 |
| babbageclunk | Ha, I got a trophy because my review id was a palindrome! | 20:50 |
| rick_h_ | marcoceppi_: ping, trying to snap install charm but fails without sudo and sudo gives it to root but not me? | 20:57 |
| === Guest72628 is now known as mwhudson | ||
| thumper | menn0: oh look who is on call reviewer today... another one for ya http://reviews.vapour.ws/r/5670/ | 21:13 |
| thumper | menn0: I was wondering about adding juju/errors to juju/txn | 21:16 |
| thumper | it doesn't currently use it at all | 21:16 |
| menn0 | thumper: ok, of course. leave it then | 21:16 |
| thumper | ok | 21:16 |
| menn0 | thumper: rick_h_ created a dup ticket with bug 1623097 | 21:24 |
| mup | Bug #1623097: remove juju list-shares <juju:In Progress by thumper> <https://launchpad.net/bugs/1623097> | 21:24 |
| * menn0 sorts it out | 21:24 | |
| rick_h_ | menn0: oh sorry there | 21:25 |
| menn0 | rick_h_: np. I kept the new one since that's referenced by the work thumper did | 21:25 |
| menn0 | thumper: ship it | 21:26 |
| thumper | menn0: just doing another with the updated juju/txn | 21:26 |
| thumper | running the state tests | 21:26 |
| menn0 | thumper: ok | 21:26 |
| thumper | I figure if they pass (which they should), I don't have to run them all | 21:26 |
| thumper | I'll push and prep review now | 21:26 |
| thumper | menn0: http://reviews.vapour.ws/r/5671/ | 21:28 |
| menn0 | thumper: interesting theory regarding the tests :) | 21:29 |
| menn0 | thumper: when I make that assumption I'm usually wrong | 21:29 |
| menn0 | thumper: ship it anyway | 21:29 |
| thumper | well, the bot still runs them all | 21:29 |
| menn0 | sure | 21:29 |
| thumper | but this should give me a good check | 21:29 |
| menn0 | the bot usually proves me wrong | 21:29 |
| thumper | hmm... bot got stuck on one of my other branches | 21:29 |
| thumper | didn't pick it up again | 21:30 |
| menn0 | thumper: are you using $$merge$$? apparently it's been changed to only accept that | 21:30 |
| thumper | oh really? | 21:31 |
| menn0 | thumper: that bit me yesterday | 21:31 |
| thumper | how boring | 21:31 |
| menn0 | I know! | 21:31 |
| thumper | I didn't | 21:31 |
| * menn0 likes being rude to the bot | 21:31 | |
| thumper | used $$intermittent$$ | 21:31 |
| menn0 | yeah, that doesn't work any more | 21:32 |
| === menn0 is now known as menn0-exercise | ||
| wallyworld | thumper: i'm -1 on removing list-shares. show-model is yaml by default. list-shares is a nice tabular output and has a different focus to show-model | 21:44 |
| wallyworld | i have found it very useful | 21:45 |
| thumper | wallyworld: merge is in progress... | 21:45 |
| thumper | wallyworld: fight with rick_h_ | 21:45 |
| wallyworld | i think we really should get input from john etc first | 21:45 |
| wallyworld | did you ask him? | 21:45 |
| thumper | no, was just going through critical bugs on the milestone | 21:46 |
| wallyworld | well, that was a mistake IMO :-/ | 21:47 |
| thumper | wallyworld: seeing if we can stop the merge | 21:48 |
| wallyworld | it could well be that it should be removed, but let's get a broader opinion from rick, john etc first. you can say "told you so" | 21:48 |
| wallyworld | ok | 21:48 |
| thumper | I have on strong opinons | 21:48 |
| thumper | but I do like tabular output of things | 21:48 |
| wallyworld | :-) | 21:48 |
| thumper | over yaml | 21:48 |
| redir | how can I get the current cloud/model/region in a command? | 21:48 |
| thumper | whoami | 21:48 |
| thumper | ? | 21:49 |
| wallyworld | thumper: yeah, that's part of it, the tabular. plus the focused question "who can see/access my model" | 21:49 |
| thumper | perhaps I should argue more | 21:49 |
| rick_h_ | yea, rick_h_ fight, I'm -1 on keeping it for just that output format | 21:50 |
| rick_h_ | it's clear in show-model, does't require us to find a new name for a command that does't fit anythingt | 21:50 |
| redir | can't tabular just be a --format | 21:50 |
| rick_h_ | it's a show-* command | 21:51 |
| rick_h_ | so it's yaml output | 21:51 |
| rick_h_ | besides it's an uncapped list | 21:51 |
| redir | oh, missed that bit of docs | 21:51 |
| redir | but at least it has a --format flag | 21:53 |
| redir | just not a tabular option | 21:53 |
| * thumper sighs | 22:05 | |
| wallyworld | thumper: talked to rick. we agree to "juju list-users <modelname>" | 22:11 |
| wallyworld | so give list-users an optional positional arg for modl | 22:11 |
| thumper | update the bug plz | 22:11 |
| wallyworld | will do | 22:11 |
| thumper | with whatever the resulting discussion was | 22:11 |
| thumper | so this is a controller command? | 22:11 |
| wallyworld | bug number? | 22:11 |
| wallyworld | it is now a controller command yes | 22:12 |
| wallyworld | i think it can probably stay as one, access the model manager facade | 22:12 |
| wallyworld | which is a controller facade | 22:12 |
| wallyworld | the output for list-users model vs list-users for controller can stay the same; in both cases show user name, display name, access level, last connected time etc | 22:13 |
| anastasiamac | wallyworld: https://bugs.launchpad.net/bugs/1623097 | 22:16 |
| mup | Bug #1623097: remove juju list-shares <juju:In Progress by thumper> <https://launchpad.net/bugs/1623097> | 22:16 |
| anastasiamac | wallyworld: it looks like there is a "tag escape" \o/ bug 1623186 | 22:23 |
| mup | Bug #1623186: Login response for user-info includes user tag prefix <juju:Triaged> <https://launchpad.net/bugs/1623186> | 22:23 |
| === menn0-exercise is now known as menn0 | ||
| menn0 | wallyworld: I think http://reviews.vapour.ws/r/5639/ is rick_h_ testing out the "develop" branch for the new dev process :) | 22:29 |
| menn0 | wallyworld: or were you being sacarstic | 22:30 |
| wallyworld | menn0: no, i had no idea what it was | 22:30 |
| menn0 | wallyworld: the description could have explained that better I guess | 22:30 |
| menn0 | wallyworld: I just happened to remember the develop branch in the new process | 22:30 |
| wallyworld | menn0: or i was just dumb | 22:30 |
| wallyworld | it makes sense now :-) | 22:31 |
| wallyworld | redir: did you want to chat? | 22:32 |
| redir | sure | 22:32 |
| redir | brt | 22:32 |
| redir | I just tune those calendar alerts sometimes | 22:32 |
| redir | tune out | 22:32 |
| === mup_ is now known as mup | ||
| mup | Bug #1623217 opened: juju bundles should be able to reference local resources <juju-core:New> <https://launchpad.net/bugs/1623217> | 22:40 |
| menn0 | natefinch: ping | 22:43 |
| perrito666 | wallyworld: axw any of you is familiar with https://gist.github.com/anonymous/ed1d1878b8de26ce43e8b73a59c0a602 ? | 22:48 |
| === rmcall_ is now known as rmcall | ||
| perrito666 | this happened while bootstraped beta18 in gce | 22:51 |
| mup | Bug #1623217 changed: juju bundles should be able to reference local resources <juju-core:New> <https://launchpad.net/bugs/1623217> | 22:52 |
| wallyworld | perrito666: sorry, otp will look in a se | 22:58 |
| wallyworld | c | 22:58 |
| perrito666 | when you return, this seems to be because in agent/agentbootstrap/bootstrap.go line 98 we seem to be crafting and instantiating a tag in an unsafe manner | 22:59 |
| perrito666 | that is the cause of the panic, there is something else causing the error in gce | 23:00 |
| mup | Bug #1623217 opened: juju bundles should be able to reference local resources <juju-core:New> <https://launchpad.net/bugs/1623217> | 23:07 |
| mup | Bug #1623217 changed: juju bundles should be able to reference local resources <juju:Triaged> <https://launchpad.net/bugs/1623217> | 23:10 |
| thumper | wallyworld: menn0 http://reviews.vapour.ws/r/5673/ | 23:16 |
| perrito666 | axw: fwiw your name is on the faulty piece of code :p | 23:16 |
| axw | perrito666: what's that? | 23:17 |
| axw | perrito666: oh the invalid cloud cred code | 23:17 |
| axw | hum, should be ok... | 23:18 |
| axw | perrito666: we're only allowing alphanumeric, dot, and hyphen | 23:20 |
| axw | (in the credential name portion) | 23:20 |
| perrito666 | so, if you check the if above that? | 23:21 |
| perrito666 | it is checking for the existence of 2 variables, but then for the construction of the credentials its using other ones | 23:21 |
| perrito666 | so, we just found that gce was choosing a zone that is not explicitly supported by us | 23:22 |
| perrito666 | and have no clue why | 23:22 |
| perrito666 | trying now with an explicitly supported region | 23:23 |
| axw | perrito666: hrm, that code looks ok to me? all that info should be validated in the CLI already... | 23:25 |
| perrito666 | axw: well I say that if a panic is the option, an extra validation is not bad | 23:25 |
| axw | perrito666: sure, if we *are* validating up front and it's panicking, that suggests that something is terribly wrong... | 23:26 |
| axw | maybe some validation got dropped along the way | 23:26 |
| perrito666 | indeed | 23:27 |
| perrito666 | I have no clue how that is happening | 23:27 |
| perrito666 | we clearly dropped a validation somewhere | 23:28 |
| perrito666 | ok the bug was reported last night by antonio its number 1622789 this should be critical | 23:41 |
| perrito666 | cheers all | 23:43 |
| anastasiamac | axw: if by any chance, u do get to credentials today, ther is this bug that came in recently.. https://bugs.launchpad.net/juju/+bug/1619830 | 23:43 |
| mup | Bug #1619830: Unhandled panic: "cloud1-region1/admin@<email address hidden>" is not a valid cloud credential ID <landscape> <juju:Triaged by wallyworld> <https://launchpad.net/bugs/1619830> | 23:43 |
| perrito666 | Anastasia it's the same as what I just pasted | 23:44 |
| perrito666 | Heh | 23:44 |
| axw | yeah, seems we're not validating in the client | 23:44 |
| perrito666 | Si people are being bit by this all over | 23:45 |
| axw | we could probably allow @ in the name too | 23:45 |
| perrito666 | We should clean the string before using it that is all | 23:45 |
| wallyworld | anastasiamac: anyone can fix that bug, not just andrew :-) | 23:45 |
| axw | perrito666: true, we could add some form of escaping | 23:46 |
| anastasiamac | wallyworld: m not allocating.. just highlighting it's presence | 23:46 |
| wallyworld | ok | 23:46 |
| perrito666 | Wallyworld we know we just give him a hard time because of git blame :p | 23:46 |
| perrito666 | Also the one Antonio reported is actually assigned to you :p | 23:47 |
| anastasiamac | perrito666: not the same bug 9numbers differ) but i've marked one as duplicate as the underlying issue is the same | 23:47 |
| mup | Bug #9: Rosetta's po parser is too strict <lp-translations> <Launchpad itself:Fix Released by carlos> <https://launchpad.net/bugs/9> | 23:47 |
| perrito666 | I meant duplicate bear with my lack of English when on a phone's irc | 23:47 |
| perrito666 | Mmmm what is that mup? | 23:48 |
| thumper | ah fuck! | 23:49 |
| perrito666 | Thumper: ok | 23:49 |
| anastasiamac | perrito666: i don't *think* it was a suggestion :) | 23:50 |
| menn0 | thumper: one thing fwereade mentioned last night is that we need to migrate the URLs for dead charms | 23:54 |
| menn0 | thumper: to recreate placeholder dead charm docs on the other side | 23:54 |
| thumper | hmm... | 23:54 |
| thumper | sounds icky | 23:54 |
| menn0 | thumper: yep. otherwise there's a danger of reuse | 23:54 |
| menn0 | thumper: we also need a new precheck to ensure that no charms are dying (now that charms have life) | 23:55 |
| menn0 | wallyworld: axw and I talked to fwereade last night about the charm work. | 23:56 |
| menn0 | wallyworld: the work for ensuring charms are cleaned up from the blobstore correctly has been done | 23:56 |
| wallyworld | awesome | 23:56 |
| wallyworld | shouldn't be too hard to add the cahrmcache cleanup | 23:57 |
| menn0 | wallyworld: the on disk cache in the API server is still there and fwereade won't get to it before he finishes | 23:57 |
| menn0 | wallyworld: but I've got a card for that | 23:57 |
| wallyworld | ok | 23:57 |
| menn0 | wallyworld: it'll be trivial | 23:57 |
| wallyworld | menn0: also need to consider how charms are unpacked via /tmp etc | 23:57 |
| menn0 | wallyworld: yeah. I know that code fairly well. | 23:58 |
| menn0 | wallyworld: the apiserver cache was there when charms used to be kept in cloud storage | 23:58 |
| menn0 | wallyworld: now that they're stored locally in gridfs there's not much benefit to having it | 23:58 |
| menn0 | wallyworld: and it's causing problems obviously | 23:58 |
| wallyworld | menn0: my take is that i know we want models isolated, but if model A and B both reference a charm with the same bits, then all that should be shared | 23:59 |
| wallyworld | and yeah, the blobstore dedupes | 23:59 |
| wallyworld | so even if the path is different per model, we store once | 23:59 |
| menn0 | wallyworld: so that's fine then (as long as it's working as it should) | 23:59 |
| wallyworld | got removing charmcache sounds like a good move | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!