| * axw goes to do school pickup | 00:00 | |
| axw | err | 00:00 |
|---|---|---|
| axw | dropoff | 00:00 |
| veebers | wallyworld: is the juju trunk tagged for each 'beta release', i.e. if I wanted to build a binary for juju-beta11 etc. can I check out a tag? | 00:31 |
| wallyworld | yes | 00:31 |
| wallyworld | QA does that, i'm not sure what the tags are called exactly | 00:31 |
| veebers | wallyworld: cheers, I'll figure it out | 00:31 |
| thumper | wallyworld: just pushing update to list-users | 00:32 |
| wallyworld | ok | 00:32 |
| thumper | wallyworld: http://reviews.vapour.ws/r/5670/diff/# | 00:33 |
| thumper | wallyworld: `juju list-users some-model` now also shows logged in user with * (and green) | 00:33 |
| wallyworld | great | 00:34 |
| thumper | wallyworld: I also changed the output to better match list-users | 00:34 |
| axw | menn0: we don't support arch on azure. did you get the right line number? | 00:34 |
| thumper | however we don't have date-created returned from the server | 00:34 |
| menn0 | axw: the line number might be different in my checkout | 00:34 |
| axw | line 901 is something else entirely | 00:34 |
| menn0 | hang on | 00:34 |
| menn0 | axw: https://github.com/juju/juju/blob/master/provider/azure/environ.go#L834 | 00:35 |
| axw | menn0: so if we separated series from kernel, I'd just be checking "is it linux" there | 00:36 |
| axw | menn0: could you just change it to GenericLinux please? | 00:36 |
| axw | menn0: actually | 00:36 |
| axw | menn0: just drop it | 00:37 |
| axw | menn0: if we were to support something server side, "generic" wouldn't be helpful | 00:37 |
| menn0 | axw: that's what i'm thinking | 00:37 |
| axw | I'll just need to grow the list as we add it | 00:37 |
| menn0 | axw: this is about the instance's series AFAICS | 00:37 |
| axw | menn0: yeah it is, but the code there only cares that it's linux - not which distro | 00:37 |
| axw | menn0: but "generic linux" isn't going to apply to anythign we actually support server-side | 00:38 |
| menn0 | axw: no it won't | 00:38 |
| menn0 | axw: and Arch won't work either without further support elsewhere | 00:38 |
| axw | menn0: indeed | 00:38 |
| * axw bbs | 00:39 | |
| wallyworld | thumper: i asked for the deleted feature test to be added back, and menn0 was naughty for not requesting Qa steps be done | 00:43 |
| wallyworld | axw: ping when you're back | 00:54 |
| axw | wallyworld: pong | 00:54 |
| wallyworld | axw: with credential parsing. the cred name can have "_" in it. so 2 options. one is to use "__" as the separator for the parts. the other is to retain the use of "_" and instead of strings.Replace(s, "__", "/", -1) just look for the first 2 "_" in the string. but the latter might get confusing to read | 00:56 |
| wallyworld | the former also allows for __ in the use rname | 00:57 |
| wallyworld | bah, _ | 00:57 |
| wallyworld | fred_bloggs@local | 00:57 |
| wallyworld | for example | 00:57 |
| axw | wallyworld: I was thinking that we'd just add escape sequences | 00:58 |
| axw | wallyworld: e.g. use URL encoding | 00:58 |
| wallyworld | yeah could do, i was going for something human readable easily | 00:59 |
| axw | wallyworld: then the user can use whatever characters they want in the cred name | 00:59 |
| axw | wallyworld: well, most things will still be unescaped | 00:59 |
| wallyworld | but yeah i can escape | 00:59 |
| axw | veebers: CI seems unhappy: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9231/console | 01:16 |
| axw | merge job anyway | 01:16 |
| * veebers looks | 01:17 | |
| veebers | axw: I think I see what was wrong. I've just fired that off now and will watch it | 01:22 |
| axw | veebers: thanks | 01:36 |
| thumper | wallyworld: back | 01:39 |
| thumper | I didn't show QA, but did do it | 01:39 |
| wallyworld | ok | 01:39 |
| thumper | menn0 reviewed it when it was just removal | 01:39 |
| wallyworld | you need to add it to PR :-) | 01:39 |
| wallyworld | that's another thing about RB - it has a QA section | 01:40 |
| wallyworld | gh doesn't | 01:40 |
| thumper | did just | 01:40 |
| veebers | axw: that went through that time | 01:46 |
| axw | veebers: thanks for your help | 01:46 |
| veebers | nw | 01:49 |
| thumper | wallyworld: how do I add credentials? | 01:50 |
| thumper | is there a command for it? | 01:50 |
| * thumper needs coffee | 01:50 | |
| wallyworld | juju add-credential | 01:50 |
| wallyworld | juju autoload-credentials | 01:50 |
| thumper | ah... I had a trailing s | 01:51 |
| wallyworld | there's 2 commands :-) | 01:51 |
| menn0 | wallyworld: I can have a quick HO to discuss tools selection | 01:53 |
| menn0 | ? | 01:53 |
| menn0 | can I | 01:53 |
| menn0 | brain not functioning | 01:53 |
| wallyworld | menn0: sure, give me a couple of minutes | 01:53 |
| menn0 | actually, I might be a while | 01:53 |
| wallyworld | axw: here's that credentials change https://github.com/juju/names/pull/73 | 02:00 |
| wallyworld | menn0: ping when you are ready | 02:00 |
| thumper | wallyworld: how do we set model config now? | 02:07 |
| thumper | set-model-config has gone | 02:08 |
| thumper | juju config doesn't look like it does it | 02:08 |
| * wallyworld considers pointing thumper to the relse notes | 02:08 | |
| wallyworld | juju model-config foo=bar | 02:08 |
| wallyworld | foo=bar | 02:08 |
| thumper | how about adding model-config to see also of config? | 02:08 |
| wallyworld | can do | 02:09 |
| thumper | oh ffs | 02:10 |
| thumper | why is my tab completion broken? | 02:10 |
| thumper | who knows bash bollocks? | 02:10 |
| thumper | juju control_juju_complete_2_0: command not found | 02:10 |
| thumper | who wants good news? | 02:13 |
| thumper | ha in gce seems fine | 02:13 |
| rick_h_ | thumper: when you kill the master | 02:17 |
| rick_h_ | .,? | 02:17 |
| rick_h_ | ? | 02:17 |
| rick_h_ | wheb i tried it today it didn't work | 02:17 |
| thumper | rick_h_: see the bug, added output | 02:19 |
| thumper | it all works | 02:19 |
| thumper | hang on... | 02:20 |
| thumper | when you say "kill the master" what do you mean? | 02:20 |
| thumper | I ssh'ed to the machine and stopped the agent | 02:20 |
| axw | wallyworld: reviewed on gh. I'm a little concerned that as we go along, we'll want to grow the allowed characters. I'd rather nip it in the bud and use URL query encoding | 02:23 |
| thumper | axw: agreed | 02:23 |
| wallyworld | bah gh :-( | 02:23 |
| wallyworld | ok, can change encoding | 02:24 |
| wallyworld | so where's the Fixed button once an issue is fixed on gh? | 02:26 |
| thumper | rick_h_: it is possible that you hit the edge case of attempting to connect to the agent while it was busy thinking about who the leader is | 02:30 |
| thumper | it seems that mongo either decides very quickly, or in two minutes | 02:30 |
| menn0 | wallyworld: ok, are you around? | 02:36 |
| wallyworld | yep | 02:36 |
| menn0 | wallyworld: stand up hangout? | 02:36 |
| wallyworld | standup works | 02:36 |
| thumper | # github.com/juju/juju/state/backups | 02:40 |
| thumper | state/backups/restore_test.go:123: not enough arguments in call to setAgentAddressScript | 02:40 |
| thumper | wallyworld: ^^^ | 02:40 |
| thumper | that is from the ci failure | 02:40 |
| wallyworld | thumper: that's perrito666's work | 02:41 |
| wallyworld | i can let him know | 02:41 |
| thumper | how did it get in? | 02:41 |
| wallyworld | nfi i didn't review it | 02:43 |
| thumper | I mean land at all... | 02:43 |
| thumper | is it os specific? | 02:43 |
| wallyworld | might be os specific | 02:45 |
| wallyworld | is this a windows test failure? | 02:45 |
| axw | natefinch: don't suppose you're awake and around? | 02:49 |
| veebers | wallyworld: when I use an older beta (either 11 or 14 in this case) I see this message and a panic, any idea what's going wrong? http://pastebin.ubuntu.com/23180523/ | 02:54 |
| thumper | wallyworld: no. it isn't | 02:55 |
| wallyworld | veebers: haven't seen that message, are you running a snap? | 02:56 |
| veebers | wallyworld: no, this is a juju binary from a deb that I pulled from a pervious run | 02:56 |
| wallyworld | thumper: in that case not sure sorry, i am not across the latest restore code that was just done | 02:56 |
| wallyworld | veebers: what are you doing? bootstrap? | 02:58 |
| menn0 | wallyworld: huzzah! I just hacked in the relaxing of the OS comparison and I now have a fedora client bootstrapping a xenial controller on AWS | 03:07 |
| wallyworld | awesome | 03:07 |
| natefinch | axw: here now | 03:08 |
| axw | natefinch: just wondering if you have a personal Azure account? | 03:08 |
| natefinch | axw: yeah | 03:08 |
| axw | natefinch: ok. I don't need anything yet, but will need someone to test out some changes I'm making. I'll poke you when it's ready - probably not till tomorrow | 03:09 |
| natefinch | axw: cool | 03:09 |
| axw | natefinch: if you're actually working, I'd appreciate a review on this: https://github.com/juju/juju/pull/6249 | 03:15 |
| natefinch | axw: heh ok | 03:17 |
| veebers | wallyworld: sorry was distracted by the merge bot stuff; No this is after bootstrap, but I'm doing a couple of odd things as I'm installing stuff on the controller to collect system stats. I'll try get some proper information shortly | 03:29 |
| wallyworld | veebers: but this is all from beta15 or whatever right, you are not mixing betas? | 03:30 |
| wallyworld | you know that betas are not compatibile with each other | 03:30 |
| veebers | wallyworld: no, this is all fresh bootstrap et. al from the same binary (and juju version) | 03:31 |
| axw | wallyworld: you know you haven't pushed your change? | 03:31 |
| wallyworld | let me check | 03:32 |
| wallyworld | damn for got -f | 03:32 |
| wallyworld | veebers: i haven't seen that message, but a quick grep of the code suggestions something with migrations, but not sure | 03:33 |
| veebers | wallyworld: ok, I'll have another go at it, possible that I'm doing something screwy (although that would be surprising) | 03:34 |
| wallyworld | veebers: probs not your fault, i just haven't seen that message before | 03:35 |
| wallyworld | you do need to ensure it's a clean slate though | 03:35 |
| natefinch | axw: are we trying out github reviews? | 03:47 |
| axw | natefinch: I've been using it | 03:48 |
| axw | natefinch: and I'm happy for you to review my code using it | 03:48 |
| menn0 | wallyworld or thumper: https://github.com/juju/utils/pull/237 | 03:53 |
| * thumper looks | 03:53 | |
| wallyworld | axw_: looks like we have a revoked attribute on cloud.Credential but it's not saved anywhere yet | 03:59 |
| thumper | menn0: review done | 04:00 |
| natefinch | axw_: reviewed | 04:00 |
| axw_ | wallyworld: yep - didn't you add that? :) | 04:00 |
| axw_ | natefinch: thanks | 04:00 |
| natefinch | axw_: oh, I suppose I should run the QA tests | 04:00 |
| wallyworld | axw_: can't recall now. but i'll add it to the mongo doc | 04:01 |
| axw_ | natefinch: if you like. I did run them myself | 04:01 |
| menn0 | thumper: I replied to your comment | 04:02 |
| menn0 | ok to merge? | 04:02 |
| menn0 | ah I see you've already approved | 04:02 |
| thumper | yep | 04:02 |
| natefinch | axw_: this seems straight forward enough. I'd rather not right now, given how slow azure is and how late it is for me. | 04:02 |
| axw_ | natefinch: yep, I think it's fine - thanks | 04:03 |
| menn0 | thumper: do you know if the bot merges for juju/utils or is it manual? | 04:03 |
| * thumper looks | 04:04 | |
| thumper | bot | 04:04 |
| thumper | menn0: look for the github-merge-juju-* jobs http://juju-ci.vapour.ws:8080/view/Juju%20Ecosystem/ | 04:05 |
| menn0 | thumper: of course. | 04:05 |
| menn0 | it just took a while so I was beginning to wondering | 04:05 |
| menn0 | wonder | 04:05 |
| wallyworld | axw_: if you get time later, here's a small pr that adds a watcher for a specific credential tag to state http://reviews.vapour.ws/r/5690/ | 04:18 |
| anastasiamac | axw_: wallyworld:veebers: i think i know why my PR failed some tests - not on images side (have it too engrained that simplestreams is images and gui) but on tools | 04:18 |
| natefinch | menn0: btw, figured out why hardwarecharacteristics has json tags, at least : the API | 04:18 |
| anastasiamac | when stream is pulled for tools metadata, I *think* sometimes it causes confusion.. investigating | 04:19 |
| menn0 | natefinch: a bit ick that a struct that lives there is used directly for the API | 04:19 |
| menn0 | natefinch: the yaml tags aren't used though? | 04:19 |
| natefinch | menn0: not that I can tell. I didn't look too deeply into that part, once I realized at least one of the tags was used. We notably do not use that to serialize the values to yaml, since we just serialize the whole struct as that one line string. | 04:20 |
| menn0 | yep | 04:21 |
| anastasiamac | axw_: wallyworld: actually, no cannot be as tool sections ignores resolve info anyway... | 04:22 |
| wallyworld | axw_: thank you, doing the facade bits after lunch | 04:37 |
| axw_ | wallyworld: np | 04:37 |
| natefinch | menn0, wallyworld: I updated http://reviews.vapour.ws/r/5656/ ... I eneded up doing a wholesale find and replace for cpu-cores, since some tests were using the wrong one to check the output, and it was easier to just change everything than try to only fix the exact right ones that were failing. | 04:37 |
| menn0 | natefinch: i'm about to do a kid pickup but I can look afterwards | 04:38 |
| natefinch | menn0: I'm going to bed, no rush :) | 04:38 |
| wallyworld | natefinch: haven't looked yet, but using "core" everywhere sounds good to me. | 04:39 |
| wallyworld | we just handle the cpu-ocres when doing the deprecation | 04:39 |
| natefinch | yep | 04:40 |
| veebers | wallyworld: oh, so it seems that panic is releated to trying to deploy a bundle, in this case: cs:~landscape/bundle/landscape-scalable | 05:13 |
| wallyworld | that makes more sense | 05:13 |
| wallyworld | it seems like it's trying to get a snap or something from the edge channel | 05:13 |
| wallyworld | or a charm | 05:14 |
| veebers | wallyworld: any idea if there is a fix or a work around? :-\ If it's due to a newer bundle/charm can I force a previous version? | 05:14 |
| veebers | wallyworld: ah that makes sense | 05:14 |
| wallyworld | don'tknow off hand, i'd have to look inside the bundle to see what the issu eis | 05:14 |
| veebers | Interesting. I imagine there is something in place or that there is a branch for 1.25 as I was able to deploy it with 1.25 (although that uses quickstart and a slightly different uri scheme, assuming I've got that right) | 05:15 |
| veebers | wallyworld: who would be a good person to query re: my charm/panic question? I would love to run it with a previous beta, but don't want to eat your your limited time | 05:45 |
| wallyworld | veebers: um, not sure, any juju dev really. you'd need to start by looking inside the bundle. i'd love to help but i have so much to do before tomorrow when i leave | 05:46 |
| veebers | wallyworld: ack, understood :-) | 05:46 |
| veebers | axw, anastasiamac_ would you have a moment to help me with this charm? I'm wanting to deploy it with an older juju (i.e. beta14 and beta11) to get some performance details, but it causes a panic | 06:13 |
| === frankban|afk is now known as frankban | ||
| veebers | anastasiamac_: this is a pastebin of what I see when I try deploy using beta11 or beta14: https://pastebin.canonical.com/165624/ | 06:33 |
| veebers | like wallyworld mentioned, it looks like something snap related | 06:34 |
| anastasiamac_ | yeah and it's coming from charmrepo.v2-unstable.. i woner who knows much about charmrepo | 06:35 |
| anastasiamac_ | axw_: : wallyworld: urulama ^^ | 06:35 |
| anastasiamac_ | wonder* | 06:35 |
| veebers | anastasiamac_: fyi for beta14 the commit for charmrepo in dependancies.trv is 6e6733987fb03100f30e494cc1134351fe4a593b | 06:36 |
| urulama | old clients can't deal with charms in channels other than stable | 06:36 |
| anastasiamac_ | veebers: ans since master tip is 73c1113f7ddee0306f4b3c19773d35a3f153c04a something might have changed... | 06:36 |
| anastasiamac_ | urulama: \o/ | 06:37 |
| anastasiamac_ | veebers: any particualr reason why u r interested in beta 11/14? | 06:37 |
| urulama | the way core was written, if they see anything other then development (deprecated) or stable, they'll panic | 06:37 |
| veebers | ah ok. urulama is there a 'stable' version of cs:~landscape/bundle/landscape-scalable> | 06:37 |
| urulama | veebers: you need beta 16+ | 06:37 |
| veebers | anastasiamac_: I'm wanting to compare data of runs (performance comparison) | 06:37 |
| anastasiamac_ | veebers: my hero \o/ thank you :D | 06:37 |
| urulama | veebers: there is, the thing is ... if it's in two channels (one of them edge), client will panic | 06:37 |
| veebers | urulama: ah right, which is what I'm seeing here | 06:38 |
| urulama | breaking changes all the way for betas :) | 06:38 |
| veebers | urulama: thanks for clarifying that :-) | 06:38 |
| urulama | veebers: np | 06:38 |
| veebers | urulama: I take it there is no way to deploy that bundle with an older beta? | 06:38 |
| urulama | veebers: sorry for the great experience :) | 06:38 |
| veebers | urulama: heh | 06:39 |
| urulama | veebers: directly from store, no. dl it to disk and deploy as local | 06:39 |
| veebers | urulama: oh interesting. So I can just grab the .zip from the store and use that? | 06:40 |
| urulama | veebers: in case of bundles, you can use bundle.yaml only ... however, i suspect landscape charms will be both channels as well and will rewquire same local download, therefore changes to bundle.yaml | 06:41 |
| urulama | veebers: but yes, you can always grab the zip and do local deploys | 06:42 |
| veebers | urulama: ah right, you're suggesting that I need to download the charms locally as well and update the bundle.yaml file to reflect that? | 06:43 |
| urulama | veebers: yeah | 06:43 |
| urulama | veebers: if possible, upgrading to beta18 could be faster :D | 06:43 |
| veebers | urulama: cool, thanks :-) | 06:43 |
| veebers | urulama: hah, I want to get data from previous versions to compare a couple of things | 06:43 |
| huwshimi | wallyworld, axw_: Are either of you around and available for some fun debugging? | 07:12 |
| wallyworld | huwshimi: depends :-) | 07:12 |
| huwshimi | haha | 07:13 |
| urulama | wallyworld: you know you love our bug reports :) | 07:13 |
| huwshimi | wallyworld: one sec while I write out the issue :) | 07:14 |
| * wallyworld can't wait | 07:14 | |
| urulama | http://www.reactiongifs.com/r/2013/07/happy-dance-.gif | 07:15 |
| perrito666 | Nothing beats waking up after only 4hs sleep to discover your commit broke CI | 07:38 |
| wallyworld | perrito666: not your fault, bot was broken | 07:39 |
| wallyworld | axw_: ping | 07:43 |
| axw_ | wallyworld: pong | 07:44 |
| wallyworld | axw_: how busy are you? | 07:44 |
| wallyworld | i have a bug | 07:44 |
| wallyworld | bug 1623808 | 07:44 |
| mup | Bug #1623808: CreateModel can't find existing creds <juju:Triaged> <https://launchpad.net/bugs/1623808> | 07:44 |
| axw_ | wallyworld: fairly... | 07:44 |
| wallyworld | ok, | 07:44 |
| * axw_ looks | 07:44 | |
| wallyworld | i see if i can get to it | 07:44 |
| wallyworld | axw_: recall in my PR today i messed with the code to look up a credential; i ran into this same issue | 07:45 |
| axw_ | hrm, ok | 07:45 |
| wallyworld | i'll see if i can get to it later tonight | 07:45 |
| axw_ | wallyworld: possibly somewhere along the line we're not using the canonical user name | 07:45 |
| axw_ | e.g. being persisted without the @local | 07:45 |
| wallyworld | yeha, that what it seems like | 07:45 |
| wallyworld | i'll have dinner, propose ny current pr, and come back to look | 07:46 |
| huwshimi | wallyworld, axw_: sorry | 07:46 |
| wallyworld | huwshimi: what for? finding a bug in our code? | 07:47 |
| wallyworld | beyyer to find it now | 07:47 |
| huwshimi | wallyworld: And making you work late | 07:47 |
| wallyworld | it's our own fault | 07:47 |
| wallyworld | if the bug weren't there, nothing to fix | 07:47 |
| huwshimi | wallyworld: And then what would you do with your evening?! | 07:47 |
| wallyworld | drink! | 07:47 |
| wallyworld | and shit, i have got to fill in the census tonight, been threatened with a fine :-( | 07:48 |
| huwshimi | wallyworld: Exciting times | 07:48 |
| urulama | wallyworld: you should behave in public, don't yell at people or scare they away ... not all of them are programmers! | 07:48 |
| wallyworld | indeed. i need to make up some fake details for them | 07:48 |
| wallyworld | urulama: who did i yell at? | 07:49 |
| urulama | wallyworld: just read you've been threatened with a fine :) | 07:49 |
| wallyworld | urulama: by the government for not filling in the census | 07:50 |
| urulama | heh, why so serious? ;) | 07:50 |
| wallyworld | i don't want to give them my data | 07:50 |
| wallyworld | stress :-) | 07:50 |
| mup | Bug #1623811 opened: locally updated credentials not uploaded to controller <juju-core:New> <https://launchpad.net/bugs/1623811> | 07:54 |
| mup | Bug #1623814 opened: Multiple local providers all write to the same all-machines.log <juju-core:New> <https://launchpad.net/bugs/1623814> | 07:54 |
| mup | Bug #1623811 changed: locally updated credentials not uploaded to controller <juju-core:New> <https://launchpad.net/bugs/1623811> | 08:06 |
| mup | Bug #1623811 opened: locally updated credentials not uploaded to controller <juju:Triaged> <https://launchpad.net/bugs/1623811> | 08:15 |
| mup | Bug #1623811 changed: locally updated credentials not uploaded to controller <juju-core:New> <https://launchpad.net/bugs/1623811> | 08:21 |
| babbageclunk | wallyworld: looking at bug 1584193 - just want to confirm the final state | 08:45 |
| mup | Bug #1584193: juju deploy <bundle> is in a different form than jujucharms.com <2.0> <landscape> <usability> <juju:Triaged by alexis-bruemmer> <https://launchpad.net/bugs/1584193> | 08:45 |
| mup | Bug #1623814 changed: Multiple local providers all write to the same all-machines.log <juju:Triaged> <juju-core:Invalid> <juju-core 1.25:Won't Fix> <https://launchpad.net/bugs/1623814> | 09:06 |
| babbageclunk | urulama: ping? | 09:34 |
| urulama | babbageclunk: you rang? | 09:34 |
| babbageclunk | urulama: Hi - I'm working on bug 1584193 - just want to confirm the final state | 09:34 |
| mup | Bug #1584193: juju deploy <bundle> is in a different form than jujucharms.com <2.0> <landscape> <usability> <juju:Triaged by 2-xtian> <https://launchpad.net/bugs/1584193> | 09:35 |
| urulama | babbageclunk: still using cs:~ format only | 09:35 |
| babbageclunk | urulama: That's the current required bundle url format? | 09:36 |
| urulama | babbageclunk: that's about URL format, not bundle format (as in content of .json) | 09:37 |
| urulama | sorry .yaml :D | 09:37 |
| babbageclunk | urulama: And we want to accept :user/:name/:series/:revision (no cs:), where everything except name is optional? | 09:37 |
| urulama | babbageclunk: we'd like to accept /u/:user/:name/:series/:revisions but don't currently | 09:38 |
| babbageclunk | urulama: I guess what I'm asking is should juju be super-tolerant for all of the historical formats as well as the new ones? | 09:39 |
| urulama | babbageclunk: yeah, if you break cs:~ format, all the bundles are broken | 09:40 |
| urulama | babbageclunk: we wouldn't want to do that :) | 09:40 |
| babbageclunk | urulama: so we want to add the new format for the URL (with and without /u/), as well as all of the others that are currently handled? | 09:42 |
| babbageclunk | (I mean, as well as keep all of the others...) | 09:42 |
| urulama | babbageclunk: looking at comment #3 from Rick, looks like it, yes | 09:43 |
| babbageclunk | urulama: Ok, thanks - I think I get it now. I'm going to start adding test cases. | 09:44 |
| urulama | babbageclunk: i'd double check, but i don't think /u/ is needed in charms | 09:44 |
| urulama | babbageclunk: plan to do it for RC? | 09:44 |
| babbageclunk | urulama: Yeah, dropping /u/ is how I'd interpreted your comment (#5) | 09:45 |
| babbageclunk | urulama: Hopefully (as long as no surprises today). | 09:45 |
| urulama | babbageclunk: means you need a list of series to verify if second or third parameter in URL is a revision :-/ | 09:47 |
| urulama | as in user/mysql/xenial/1 or mysql/xenial/1 vs user/mysql | 09:47 |
| babbageclunk | urulama: Isn't revision always a number while series never is? | 09:48 |
| babbageclunk | urulama: Oh, you mean user/name vs name/series? | 09:48 |
| urulama | babbageclunk: sorry, s/revision/series | 09:48 |
| urulama | babbageclunk: yeah | 09:48 |
| babbageclunk | urulama: do we have a list like that anywhere else? | 09:49 |
| urulama | babbageclunk: i think it's in charmrepo | 09:49 |
| babbageclunk | urulama: cool, thanks | 09:50 |
| urulama | babbageclunk: it's not in charmrepo | 09:56 |
| urulama | babbageclunk: we have it in charm store code, but not sure where it is on juju client side | 09:56 |
| babbageclunk | urulama: No, I hadn't been able to spot it there. Hmm. | 09:56 |
| urulama | babbageclunk: what you need is something like this https://github.com/juju/charmstore/blob/v5-unstable/internal/series/series.go#L37 but probably best to put in https://github.com/juju/charm/tree/v6-unstable | 10:01 |
| urulama | and then we start using it as single source of truth for core and charm store | 10:01 |
| babbageclunk | urulama: sounds good | 10:01 |
| wallyworld | babbageclunk: sorry, missed ping | 10:20 |
| wallyworld | axw_: if you get a chance later, here's a fix for that crederntials issue. i'd like a second opinion on the approach. i've validated that it solves the issue i found before when adding the new watcher code (even though i've retained the altered apporach from the watcher pr). i can't test if it fixes the gui issue but it should given the mode of failure i saw with my test code from previously http://reviews.vapour.ws/r/5692/ | 10:22 |
| wallyworld | axw_: from what i can see, the root of the issue is that if you have a credential tag made from a user name "fred", and the CloudCredentials call makes a map keyed on tag made from "fred@local", then the map look up can fail even though for both tags, tag.Canonical() is the same | 10:27 |
| babbageclunk | wallyworld: no worries, urulama's been giving me some background | 10:30 |
| wallyworld | rightio | 10:30 |
| wallyworld | he can give better info than me on that topic | 10:31 |
| wallyworld | i'd have to go look up a bunch of stuff | 10:31 |
| babbageclunk | urulama, wallyworld - how does the development channel fit into url format? | 10:43 |
| wallyworld | babbageclunk: i don't think it does from memory; i think it's a separate search param, but not 100% | 10:44 |
| babbageclunk | wallyworld: the reason I ask is that there are some examples in the tests in https://github.com/juju/charm/blob/v6-unstable/url_test.go#L302 | 10:48 |
| wallyworld | babbageclunk: yeah, you'll need to ask urulama; i've not been involved in that side of it | 10:50 |
| babbageclunk | urulama: the tests for charm.v6-unstable/url.go include an "exact" url - I guess this is something that gets echoed back to the user at some point? Presumably we want those to be canonicalised into the new format, to fit with docs/examples? | 11:04 |
| frobware | rick_h_: you about? | 12:30 |
| mgz | it might be a little early for him still, given the flight back | 12:33 |
| frobware | mgz: he just approved my travel req | 12:35 |
| mgz | in which case he is nuts :) | 12:35 |
| frobware | since I started asking DNS questions on the Azure slack channel.... and now there's a multi-region DNS outgage... :) | 12:49 |
| frobware | https://azure.microsoft.com/en-gb/status/ | 12:50 |
| frobware | who needs names anyway? We're just cells in a spreadsheet. :-D | 12:51 |
| === DaveJ__ is now known as DaveJ | ||
| wallyworld | axw_: responded to comment, hope it makes sense what i'm trying to say | 13:19 |
| wallyworld | axw_: we would have to make it so that fred@local did not store domain="local", and reserve domain attribute for non-local; that's what you're saying right? | 13:27 |
| axw_ | wallyworld: yes | 13:28 |
| wallyworld | +1 to that | 13:28 |
| wallyworld | if i land this now, it won't break the api, and we can do the bigger change soon | 13:28 |
| axw_ | wallyworld: np | 13:28 |
| wallyworld | but what is stored in the db will need to be handled | 13:28 |
| wallyworld | i guess it won't be too hard to throw away @local | 13:29 |
| axw_ | wallyworld: not sure. we may have to accept @local and drop the domain | 13:29 |
| wallyworld | right | 13:29 |
| axw_ | would be better to reject it if possible | 13:29 |
| wallyworld | we have a few days till rc, i can land this to unblock gui | 13:29 |
| wallyworld | and easy then to follow up before tuesday | 13:30 |
| wallyworld | hmm, i wonder how big the change would be | 13:30 |
| wallyworld | might be nice not to have to mess with the map key types | 13:30 |
| wallyworld | probably a can or worms | 13:31 |
| wallyworld | axw_: the other thing i did which needs a second optinion is to add the credential watcher to apiserver/provisioner and apiserver/storageprovisioner as those are the bits i think will need it; adding it now gets the apis in place for later | 13:32 |
| wallyworld | we can hook up tomorrow about it | 13:33 |
| === benji__ is now known as benji | ||
| axw_ | wallyworld: I LGTM'd your branch, but just thinking... I don't think storageprovisioner needs it | 13:46 |
| axw_ | or provisioner actually? | 13:46 |
| axw_ | wallyworld: I think only the environ tracker wants to watch it, and restart when it changes | 13:46 |
| wallyworld | axw_: yeah, wasn't sure, until we dig in and implement something. | 13:46 |
| wallyworld | the provisioners would need it if they were responsible for passing creds to the environ | 13:47 |
| wallyworld | depends on how we want to model it. i don't have to land the work | 13:47 |
| babbageclunk | natefinch: Review this tiny test fix for juju/charm? Knock-on from a change you made to juju/version. https://github.com/juju/charm/pull/219 | 13:48 |
| axw_ | wallyworld: the environ-tracker is solely responsible for maintaining the Environ | 13:48 |
| natefinch | babbageclunk: looking | 13:48 |
| babbageclunk | natefinch: thx | 13:48 |
| axw_ | wallyworld: the provisioners depend on the environ-tracker to get the Environ | 13:48 |
| axw_ | let's deal with it tomorrow | 13:48 |
| wallyworld | yep, sgtm | 13:49 |
| wallyworld | changing @local handling will be messy | 13:49 |
| natefinch | babbageclunk: isn't "beta18" the tag? or is "beta" the tag and 18 the patch? | 13:49 |
| urulama | wallyworld: aren't you happy we filed that bug today? :) | 13:49 |
| wallyworld | urulama: oh, i'm positively estatic | 13:50 |
| urulama | :D | 13:50 |
| babbageclunk | natefinch: not sure - at the moment it'll be parsed as tag:beta, patch:18. | 13:50 |
| wallyworld | urulama: there's a quickie fix landing | 13:50 |
| wallyworld | should work but we can't reproduce as the cli passes what's expecyed | 13:50 |
| natefinch | babbageclunk: yeah, that's right, according to the tests on juju/version | 13:51 |
| wallyworld | but you guys can tell us if it fixes it | 13:51 |
| urulama | wallyworld: ok, thanks. will reply on that bug if it's fixed | 13:51 |
| wallyworld | not yet | 13:51 |
| wallyworld | need to see the landing happen | 13:51 |
| urulama | wallyworld: just out of curiosity, internal handling of @local is going to be for 2.1? | 13:51 |
| babbageclunk | natefinch: maybe I should add another case to that charm test to make that a bit more explicit. | 13:51 |
| wallyworld | urulama: i would like for 2.0 if possible, but we'll need to look at it. it should be transparent to outside | 13:52 |
| urulama | kk | 13:52 |
| natefinch | babbageclunk: nah, I think it's ok as is | 13:53 |
| babbageclunk | natefinch: cool | 13:53 |
| natefinch | babbageclunk: it's just our string output of versions is confusing, since we munge together the tag and the patch | 13:53 |
| natefinch | babbageclunk: man, I love being able to review right on github. | 13:54 |
| babbageclunk | natefinch: :) | 13:55 |
| rick_h_ | frobware: sorry, did that while getting ready to crash | 14:19 |
| frobware | rick_h_: no harm done :) | 14:20 |
| rick_h_ | frobware: around for a few for the cross team call | 14:20 |
| frobware | rick_h_: was going to book travel but need to know whether I'm going to the cloud sprint too | 14:21 |
| rick_h_ | frobware: yes if you're ok with it | 14:21 |
| rick_h_ | frobware: I got you added to the list | 14:21 |
| frobware | rick_h_: is there an invite; do I need to use 2 evt codes? | 14:21 |
| natefinch | go build is very effective in its use of every single core on my laptop | 14:42 |
| mup | Bug #1587644 opened: jujud and mongo cpu/ram usage spike <canonical-bootstack> <canonical-is> <eda> <performance> <juju:Fix Released> <juju-core:Triaged> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1587644> | 14:48 |
| babbageclunk | hatch: ping? | 15:29 |
| hatch | babbageclunk: morning | 15:29 |
| natefinch | niemeyer: had some weird timeout from CI trying to get gopkg.in repos... not sure if this was just a network glitch or what, but figured it might be worth looking to make sure things are running smoothly: http://pastebin.ubuntu.com/23182542/ | 15:29 |
| natefinch | niemeyer: worked fine when I retried, btw | 15:30 |
| dimitern | frobware: ping | 15:30 |
| frobware | dimitern: pong | 15:31 |
| babbageclunk | hatch: Hi! I'm working on bug 1584193 | 15:31 |
| mup | Bug #1584193: juju deploy <bundle> is in a different form than jujucharms.com <2.0> <landscape> <usability> <juju:Triaged by 2-xtian> <https://launchpad.net/bugs/1584193> | 15:31 |
| dimitern | frobware: let's sync? | 15:32 |
| frobware | dimitern: give me 10-15. ok? | 15:33 |
| babbageclunk | hatch: Just wanted to make sure that what I'm proposing (comment at the bottom) sounds right. | 15:33 |
| dimitern | frobware: sure, np | 15:33 |
| hatch | babbageclunk: alright let me take a look | 15:33 |
| babbageclunk | hatch: Also, I'm not totally sure how to handle the development channel - should that just be another component of the URL? The existing tests include it. | 15:33 |
| babbageclunk | hatch: Thanks! | 15:33 |
| dimitern | frobware: I have the provider/maas PR ready, just need to test it some more | 15:33 |
| frobware | dimitern: ok now | 15:36 |
| dimitern | frobware: omw to standup HO | 15:36 |
| redir | morning | 15:36 |
| hatch | babbageclunk: I think you're on the right track, gimme aminute to bounce this off others | 15:37 |
| frobware | dimitern: in there now | 15:37 |
| hatch | babbageclunk: so it looks good, but channels should _not_ be in the url | 15:48 |
| babbageclunk | hatch: Ok. At the moment the tests include them https://github.com/juju/charm/blob/v6-unstable/url_test.go#L302 | 15:50 |
| urulama | and the channels are: edge, beta, candidate, stable | 15:50 |
| babbageclunk | urulama: Ok, I'm just looking back at the code for the deploy command to understand how it handles channel. | 15:51 |
| urulama | babbageclunk: best person to ask is frankban | 15:53 |
| babbageclunk | urulama: Does that mean charm.URL should lose .Channel? It seems like it's included in the charmstore.CharmID instead. | 15:54 |
| babbageclunk | I'll talk to frankban about it. | 15:54 |
| frankban | babbageclunk: we should remove the channel part of charm.URL, and the corresponding tests | 15:55 |
| frankban | babbageclunk: that code is obsolete | 15:55 |
| babbageclunk | frankban: ok great - thanks! | 15:55 |
| frankban | np | 15:55 |
| frankban | babbageclunk: and sorry as that's a leftover from us | 15:56 |
| babbageclunk | shrugs. :) | 15:56 |
| babbageclunk | Code rots, I guess - easy to delete! | 15:56 |
| babbageclunk | urulama, frankban: Hmm - is this the kind of change that means we should bump the version of juju/charm? | 16:03 |
| frankban | babbageclunk: in theory yes, but I don't think there is code relying on that URL field, and btw that's -unstable | 16:04 |
| babbageclunk | frankban: Ah, of course! Cool cool. | 16:04 |
| niemeyer | natefinch: The timeout is generally an ancient version of git in use, typical in some CIs.. (fix was committed upstream ~6 years ago) | 16:27 |
| babbageclunk | frankban, could you review this? Removing channel from charm.URL. https://github.com/juju/charm/pull/220 | 16:47 |
| babbageclunk | frankban: There were a couple of (trivial) uses in charmstore, I'm doing a PR for that too. | 16:48 |
| babbageclunk | Oops, didn't realise what time it was for him. hatch, would you mind reviewing https://github.com/juju/charm/pull/220? | 16:52 |
| natefinch | niemeyer: ahh, interesting. sinzui, mgz, see niemeyer's response to my query about this timeout from CI: http://pastebin.ubuntu.com/23182542/ | 16:53 |
| hatch | babbageclunk: I'm not really the right person to review a juju core branch :D | 16:54 |
| hatch | but I can certainly take a look | 16:54 |
| babbageclunk | hatch: Sorry! I can get frankban to look at it tomorrow instead if you'd prefer. | 16:55 |
| hatch | sure, it's just that my review won't be a voting one :) | 16:55 |
| babbageclunk | hatch: :) | 16:56 |
| mgz | natefinch: not sure that's right, you're looking at a gating merge job? | 16:58 |
| natefinch | mgz: yep | 16:58 |
| mgz | natefinch: that's on a xenial box, so the git version is pretty current | 16:58 |
| mgz | $ git version | 16:58 |
| mgz | git version 2.7.4 | 16:58 |
| mgz | more likely to be random network blips | 16:58 |
| natefinch | mgz: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9243/console | 16:59 |
| natefinch | mgz: you mean the network isn't reliable? | 16:59 |
| sinzui | mgz: natefinch: yes, we have seen network issues with gopkg and github in the past | 17:00 |
| sinzui | natefinch: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9244/console shows we got the packges | 17:00 |
| natefinch | sinzui: yep, I mentioned it worked when I retried. I hadn't seen that particular error before, so I figured it might be worth a look just in case. . | 17:03 |
| frankban | balloons: done, thanks a lot | 18:01 |
| alexisb | frankban, I think you mean babbageclunk who seems ot be out fo rthe day :) | 18:03 |
| alexisb | thanks for the review | 18:04 |
| frankban | alexlist: ah, right, damn you autocomplete! | 18:29 |
| frankban | oh... again | 18:29 |
| frankban | alexlist: nm | 18:29 |
| === frankban is now known as frankban|afk | ||
| * redir goes for lunch and to run a couple quick errands bbiab | 18:42 | |
| natefinch | sinzui, mgz: my branch won't trigger the bot: https://github.com/juju/juju/pull/6221 | 19:32 |
| sinzui | natefinch: once the bot accepts, you cannot ask it to try again. you need to forge a fail reply or just rerun the jenkins build. I don't see your job was canceled though, | 19:35 |
| sinzui | natefinch: oh, it was this build, the one where we couldn't get a build. that broken the chain | 19:36 |
| sinzui | http://juju-ci.vapour.ws:8080/job/github-merge-juju/9247/console | 19:36 |
| * sinzui manually retries the build | 19:36 | |
| natefinch | sinzui: dangit, I forgot to save one of the files I edited... that build's going to fail | 19:45 |
| sinzui | natefinch: okay. I can requeue when you shout that the branch has the right files | 19:45 |
| natefinch | sinzui: just did, it's fixed. Sorry about that,. | 19:48 |
| sinzui | natefinch: np | 19:49 |
| sinzui | natefinch: the job is playing http://juju-ci.vapour.ws:8080/job/github-merge-juju/9251/console | 19:49 |
| natefinch | sinzui: thanks | 19:49 |
| redir | back | 20:07 |
| natefinch | super easy review anyone? https://github.com/juju/juju/pull/6259 | 20:23 |
| redir | natefinch: looking | 20:47 |
| alexisb | thumper, our HO just don't like each other | 20:59 |
| thumper | heh | 20:59 |
| thumper | yeah | 20:59 |
| alexisb | thanks for the input | 20:59 |
| alexisb | redir, did you encounter this bug when doing the config naming collapse work?: https://bugs.launchpad.net/juju/+bug/1532130 | 21:23 |
| mup | Bug #1532130: Config item 'version' vanishes under 2.0 <2.0-count> <regression> <juju:Triaged> <https://launchpad.net/bugs/1532130> | 21:23 |
| redir | alexisb: looking | 21:24 |
| redir | alexisb: I did not see that bug but also wasn't using postgres, nor specifically trying any charms with a version attribute. | 21:27 |
| redir | alexisb: want me to try postgres when I fixup app config to use --reset as a stringvar? | 21:27 |
| alexisb | redir, yes please | 21:28 |
| redir | alexisb: added card with bug attached to current iteration | 21:31 |
| alexisb | thumper, can you join the release call today please | 21:32 |
| thumper | coming | 21:32 |
| === mup_ is now known as mup | ||
| alexisb | sorry anastasiamac_, thumper lost my browser | 22:00 |
| alexisb | anything happen at teh end of the release call that I need to know about? | 22:01 |
| thumper | just bashing aussies | 22:02 |
| alexisb | :) | 22:04 |
| alexisb | anastasiamac_, would you have time after standup to go over your test plan and actions for the sprint | 22:04 |
| wallyworld | natefinch: gofmt is sad: | 22:07 |
| wallyworld | core/description/machine.go | 22:07 |
| wallyworld | i wonder how that got though the bot? | 22:07 |
| anastasiamac_ | alexisb: before/after/anytime \o/ | 22:10 |
| alexisb | I have meetings before | 22:10 |
| anastasiamac_ | alexisb: enjoy :) | 22:10 |
| alexisb | so it will have to be after, but I love your spreadsheet | 22:10 |
| anastasiamac_ | \o/ | 22:10 |
| redir | \/o\ | 22:23 |
| menn0 | wallyworld and thumper: https://github.com/juju/juju/pull/6261 | 22:29 |
| wallyworld | looking in a bit | 22:30 |
| menn0 | wallyworld: I couldn't see any unit test for bootstrapping with local tools so I added them, but I might have missed them somehow | 22:30 |
| wallyworld | yeah, they are there somewhere | 22:31 |
| wallyworld | maybe spread across cmd/juju/boothstrap and environs/bootstrap | 22:31 |
| wallyworld | can't recall exactly | 22:31 |
| axw_ | anastasiamac_: what prompted the latest revert? can you please point me at the offending stream data that broke it? | 22:42 |
| anastasiamac_ | axw_: centos iagemetadta was malformed- we used "." instead of ":" to separate tokens in content_id | 22:43 |
| axw_ | anastasiamac_: ah, doh | 22:43 |
| anastasiamac_ | axw_: rackspace was using modtly simplestreams data that we generate and our index file and product file do not agree on stream - index says "released", product says "custom" | 22:43 |
| axw_ | :/ | 22:44 |
| anastasiamac_ | axw_: in cannonistack, it's even better where image stream used is "ubuntu" | 22:44 |
| axw_ | heh | 22:44 |
| anastasiamac_ | axw_: since these files can be hand-crafted there is no guarantee that the 2 sources of stream value are consistent | 22:44 |
| anastasiamac_ | axw_: the *right* thing to do, before parsing simplestreams files is to validate them | 22:45 |
| axw_ | anastasiamac_: indeed. we should be less lenient about crap data, otherwise it'll stay that way | 22:45 |
| anastasiamac_ | axw_: I think we should also wrk closer with Scott Morser once we get to clean up simplestreams implementation to ensure that we cater for windows special-casing ":" | 22:45 |
| anastasiamac_ | axw_: \o/ yes so m pushing simplestream review/re-implement to wishlist :) | 22:46 |
| axw_ | anastasiamac_: ok, thank you | 22:46 |
| anastasiamac_ | axw_: what we currently have kind of works but we ned to have a better approach | 22:46 |
| anastasiamac_ | axw_: \o/ thank you for asking - love to know that people care :D | 22:46 |
| wallyworld | menn0: lgtm, was such a simple change in the end | 22:47 |
| anastasiamac_ | axw_: i think tech board has to have a say before we tackle simplestreams and will do a write-up for it based on alexisbgreat suggestions :) | 22:47 |
| axw_ | okey dokey | 22:47 |
| axw_ | wallyworld: thanks for the review. I got interactive auth working last night. just need to hook it up to add-credential now | 23:09 |
| wallyworld | awesome | 23:09 |
| axw_ | atm it only works when you add it to credentials.yaml, which is a crappy experience (have to do interactive auth each time you bootstrap) | 23:09 |
| wallyworld | progress though | 23:10 |
| * thumper sighs and dives further into the rabbit hole | 23:14 | |
| mup | Bug #1587644 changed: jujud and mongo cpu/ram usage spike <canonical-bootstack> <canonical-is> <eda> <performance> <juju:Fix Released> <juju-core:Won't Fix> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1587644> | 23:56 |
| mup | Bug #1587644 opened: jujud and mongo cpu/ram usage spike <canonical-bootstack> <canonical-is> <eda> <performance> <juju:Fix Released> <juju-core:Won't Fix> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1587644> | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
