| tjaalton | RAOF: so i broke the mir egl patch? | 04:33 |
|---|---|---|
| tjaalton | haven't touched it since 12.0.1, and that was a simple rebase | 04:35 |
| tjaalton | oh and is there hope to see it upstream during the next cycle?-) | 04:50 |
| RAOF | tjaalton: Yeah, the code in dri2_egl_initialize changed around the patch, so the patch became incorrect. | 04:58 |
| RAOF | tjaalton: Cross fingers, upstream. That requires that we finish MirRenderSurface, though, because that is a fundamental change. | 04:59 |
| RAOF | I wonder if https://bugs.launchpad.net/ubuntu/+source/mesa/+bug/1620934 is the same bug? | 05:04 |
| ubottu | Launchpad bug 1620934 in qtubuntu (Ubuntu) "[regression] Starting in Mesa 12.0.2, Qt/QML apps don't render any more (logs say "QEGLPlatformContext: eglMakeCurrent failed: 3001")" [Critical,Confirmed] | 05:04 |
| tjaalton | RAOF: could be | 05:11 |
| tjaalton | actually probably not | 05:26 |
| tjaalton | I think that's due to de695014eb6c819 | 05:26 |
| tjaalton | the crash is from e82567c02b3796c | 05:27 |
| RAOF | I'm not sure that it is? | 05:31 |
| tjaalton | + return _eglError(EGL_BAD_MATCH, "eglMakeCurrent"); | 05:32 |
| RAOF | eglMakeCurrent seems to be failing with 0x3001, which is EGL_NOT_INITIALIZED. | 05:32 |
| tjaalton | ah | 05:32 |
| RAOF | EGL_BAD_MATCH would be 3009 | 05:33 |
| tjaalton | ok | 05:33 |
| RAOF | Oh! | 05:34 |
| RAOF | Yes, the fix *is* likely to fix that. | 05:34 |
| RAOF | Because what was going wrong is that we fail to initialise the dri2_dpy ref_count to 1 in eglInitialize. | 05:34 |
| RAOF | So when you do something that would decrement that refcount - like make a different context current - we destroy the display. | 05:35 |
| RAOF | Which would likely result in EGL_NOT_INITIALIZED. | 05:35 |
| tjaalton | oh I see what needs changing | 05:42 |
| RAOF | Yup. | 05:43 |
| RAOF | Would you like me to test that it fixes both bugs before pushing it, or just push it now? :) | 05:43 |
| RAOF | break; rather than return. | 05:43 |
| RAOF | And also remove the superfluous TestOnly check. | 05:43 |
| tjaalton | I'm fine with whatever | 05:44 |
| tjaalton | push to git, I'll merge 12.0.3 too and add a patch for llvm-3.9 | 05:44 |
| RAOF | OK. I'll push now then. | 05:44 |
| tjaalton | then poke doko that we're good | 05:44 |
| tjaalton | to switch | 05:45 |
| RAOF | tjaalton: Now pushed to git. Enjoy! | 05:55 |
| tjaalton | RAOF: great, thanks | 05:55 |
| tjaalton | hmm, I'll drop the llvm migration from this upload.. it needs further work elsewhere | 07:05 |
| === JanC is now known as Guest68752 | ||
| === JanC_ is now known as JanC | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!