[04:33] <tjaalton> RAOF: so i broke the mir egl patch? 
[04:35] <tjaalton> haven't touched it since 12.0.1, and that was a simple rebase
[04:50] <tjaalton> oh and is there hope to see it upstream during the next cycle?-)
[04:58] <RAOF> tjaalton: Yeah, the code in dri2_egl_initialize changed around the patch, so the patch became incorrect.
[04:59] <RAOF> tjaalton: Cross fingers, upstream. That requires that we finish MirRenderSurface, though, because that is a fundamental change.
[05:04] <RAOF> I wonder if https://bugs.launchpad.net/ubuntu/+source/mesa/+bug/1620934 is the same bug?
[05:11] <tjaalton> RAOF: could be
[05:26] <tjaalton> actually probably not
[05:26] <tjaalton> I think that's due to de695014eb6c819
[05:27] <tjaalton> the crash is from e82567c02b3796c
[05:31] <RAOF> I'm not sure that it is?
[05:32] <tjaalton> +      return _eglError(EGL_BAD_MATCH, "eglMakeCurrent");
[05:32] <RAOF> eglMakeCurrent seems to be failing with 0x3001, which is EGL_NOT_INITIALIZED.
[05:32] <tjaalton> ah
[05:33] <RAOF> EGL_BAD_MATCH would be 3009
[05:33] <tjaalton> ok
[05:34] <RAOF> Oh!
[05:34] <RAOF> Yes, the fix *is* likely to fix that.
[05:34] <RAOF> Because what was going wrong is that we fail to initialise the dri2_dpy ref_count to 1 in eglInitialize.
[05:35] <RAOF> So when you do something that would decrement that refcount - like make a different context current - we destroy the display.
[05:35] <RAOF> Which would likely result in EGL_NOT_INITIALIZED.
[05:42] <tjaalton> oh I see what needs changing
[05:43] <RAOF> Yup.
[05:43] <RAOF> Would you like me to test that it fixes both bugs before pushing it, or just push it now? :)
[05:43] <RAOF> break; rather than return.
[05:43] <RAOF> And also remove the superfluous TestOnly check.
[05:44] <tjaalton> I'm fine with whatever
[05:44] <tjaalton> push to git, I'll merge 12.0.3 too and add a patch for llvm-3.9
[05:44] <RAOF> OK. I'll push now then.
[05:44] <tjaalton> then poke doko that we're good
[05:45] <tjaalton> to switch
[05:55] <RAOF> tjaalton: Now pushed to git. Enjoy!
[05:55] <tjaalton> RAOF: great, thanks
[07:05] <tjaalton> hmm, I'll drop the llvm migration from this upload.. it needs further work elsewhere