=== sterfield_ is now known as sterfield | ||
=== rangerpbzzzz is now known as rangerpb | ||
mdorman_ | running into an issue on EL7 where the network generate_fallback_config process where reading the /sys/class/net/eth0/carrier and /dormant generate an IOError (Invalid Argument) if the NIC isn’t up yet. I think we have a fix just by catching the IOError exception and passing. I’m looking through bugs to see if anything is there for this already, but not coming up with anything. does this sound familiar to anybody? If no | 18:07 |
---|---|---|
mdorman_ | I’ll report a new bug. | 18:07 |
mdorman_ | i think the better way to do this ( https://git.launchpad.net/cloud-init/tree/cloudinit/net/__init__.py#n139 ) is check the nic’s operstate first, and then only if it’s up check the carrier and dormant. i’ll send in a review | 18:18 |
rharper | mdorman_: I belive that one is known; lemme find the bug and the MR that addresses that | 19:13 |
rharper | https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 handles this; IIRC | 19:16 |
* rharper checks the channel logs | 19:16 | |
mdorman_ | thanks i’ll check it out | 19:19 |
rharper | https://bugs.launchpad.net/cloud-init/+bug/1625766 | 19:22 |
rharper | someone from Arch saw this | 19:22 |
rharper | I updated the bug description and summary to match | 19:22 |
* rharper links the MR to the bug as well | 19:22 | |
* rharper pokes harlowja and smoser for review tomorrow | 19:23 | |
mdorman_ | cool | 19:25 |
harlowja | i fixed that? | 20:13 |
harlowja | hahaha | 20:13 |
harlowja | mdorman_ maybe fixed :-P | 20:14 |
harlowja | someone needs to merge all that stuff, lol | 20:14 |
mdorman_ | yeah me and jim have it merged locally and are testing it. then i will comment on the LP review with results | 20:31 |
harlowja | kk | 20:34 |
mdorman_ | so far it’s looking good | 21:02 |
nrezinorn | that part looks great :p | 21:06 |
harlowja | greatttt | 21:59 |
harlowja | lol | 21:59 |
mdorman_ | https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 i think we can confidently say is good | 22:14 |
nrezinorn | harlowja: rpm builds happily from what we can see, plan on doing roll ups for merge tomorrow . i had a Q about the requirements.txt tho, where we dont need 2 lines in the rpm build - should i make and apply a .patch to build the RPM or is there another way to handle? | 22:29 |
=== rangerpb is now known as rangerpbzzzz | ||
harlowja | i did its | 23:25 |
harlowja | lol | 23:25 |
harlowja | smoser so in https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/308304 | 23:28 |
harlowja | if people still have cheetah installed, and there templates say to use cheetah explicitly | 23:28 |
harlowja | then it will still continue using cheetah | 23:28 |
harlowja | the default though does change | 23:28 |
harlowja | from | 23:29 |
harlowja | - LOG.debug("Using Cheetah as the renderer for unknown template.") | 23:29 |
harlowja | - return ('cheetah', cheetah_render, text) | 23:29 |
harlowja | to jinja | 23:29 |
harlowja | this maybe should cause a 0.8.0 version, id | 23:29 |
harlowja | *idk | 23:29 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!