powersj | smoser: trying to build cloud-init all of a sudden I am getting errors: https://jenkins.ubuntu.com/server/job/cloud-init-integration/17/console | 12:44 |
---|---|---|
rharper | powersj: didn't you proposed the added coverage report =) | 12:46 |
powersj | yes lol | 12:46 |
powersj | so adding "coverage" to test-requirements.txt is the issue | 12:49 |
powersj | that is what pypi calls the package and curtin does the same thing | 12:51 |
rharper | wonder if it just needs to be versioned? | 13:00 |
powersj | I tried adding "coverage=4.2" and got same error | 13:04 |
rharper | hrm | 13:05 |
rharper | can you repro off of jenkins ? | 13:05 |
powersj | let me see. I'll try that after this next session | 13:05 |
=== shardy is now known as shardy_lunch | ||
rharper | powersj: I can repro local | 13:06 |
powersj | rharper: ah! thank you :) | 13:08 |
rharper | insane | 13:08 |
rharper | powersj: I think we need to add the same package to the requirements.txt and map it to the python-package in archive | 13:10 |
rharper | powersj: found a fix | 13:14 |
rharper | http://paste.ubuntu.com/23420677/ powersj | 13:15 |
=== smoser changed the topic of #cloud-init to: cloud-init 0.7.8 released 2016-09-12. 0.7.9 open. reviews: https://code.launchpad.net/~cloud-init-dev/cloud-init/+git/cloud-init/+ref/master/+activereviews | fly the W | ||
smoser | powersj, looking | 13:16 |
smoser | powersj, hm | 13:16 |
smoser | oh, yeah. the package build will use it, forgot about that. need to add a build dep | 13:16 |
smoser | rharper, is right. i'll grab that quick | 13:17 |
rharper | smoser: morning! | 13:17 |
smoser | hey | 13:18 |
smoser | rharper, coverage was already in test-requirements though | 13:18 |
rharper | smoser: yeah, but not in my branch, sorry | 13:18 |
smoser | http://paste.ubuntu.com/23420684/ should work | 13:19 |
smoser | adding it to "standard named packages" | 13:19 |
rharper | smoser: sure, didn't reallize it's standard (which makes sense) | 13:19 |
smoser | as "standard" is 'coverage' pypy package makes python-coverage and python3-coverage | 13:19 |
rharper | right | 13:19 |
smoser | so as this is, we dont need that in the package buidl dependency | 13:24 |
smoser | as Makefile test does not run coverage. | 13:24 |
smoser | for now i think we leave that as it is. | 13:24 |
smoser | and just add the coverage to the list. it'll get installed in bddeb but not used. | 13:25 |
rharper | y | 13:26 |
powersj | rharper: thank you! | 13:31 |
smoser | powersj, fixed in trunk now. | 13:32 |
powersj | smoser: confirmed working now. Thank you! | 13:33 |
=== shardy_lunch is now known as shardy | ||
smoser | harlowja, does this make sense to you: https://code.launchpad.net/~bbaude/cloud-init/+git/cloud-init/+merge/309478 | 15:00 |
tlonoy | hi all, I'm wondering if there is docs presents on how to modify and test cloud-init before submitting code. I've seen this page (https://cloudinit.readthedocs.io/en/latest/topics/hacking.html) but it doesn't goes into great details | 15:11 |
tlonoy | e.g. there doesn't seem to be a test-suite to run | 15:12 |
smoser | https://git.launchpad.net/cloud-init/tree/HACKING.rst | 15:44 |
smoser | dont know why readthedocs is out of date. i will update it. | 15:44 |
smoser | ie, i just merged that | 15:44 |
smoser | tlonoy, reload https://cloudinit.readthedocs.io/en/latest/topics/hacking.html | 15:49 |
harlowja | brb, gotta restart | 17:38 |
harlowja | will check out in a few smoser | 17:38 |
smoser | harlowja, ok. | 17:41 |
smoser | had some review commetns for you in a couple mp yesterday to | 17:41 |
harlowja | yuppers | 17:42 |
harlowja | smoser https://code.launchpad.net/~bbaude/cloud-init/+git/cloud-init/+merge/309478 seems ok to me, i guess such a ordering is needed? | 17:52 |
harlowja | weird software be weird, lol | 17:53 |
=== rangerpbzzzz is now known as rangerpb | ||
=== rangerpb is now known as rangerpbzzzz |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!