[12:44] smoser: trying to build cloud-init all of a sudden I am getting errors: https://jenkins.ubuntu.com/server/job/cloud-init-integration/17/console [12:46] powersj: didn't you proposed the added coverage report =) [12:46] yes lol [12:49] so adding "coverage" to test-requirements.txt is the issue [12:51] that is what pypi calls the package and curtin does the same thing [13:00] wonder if it just needs to be versioned? [13:04] I tried adding "coverage=4.2" and got same error [13:05] hrm [13:05] can you repro off of jenkins ? [13:05] let me see. I'll try that after this next session === shardy is now known as shardy_lunch [13:06] powersj: I can repro local [13:08] rharper: ah! thank you :) [13:08] insane [13:10] powersj: I think we need to add the same package to the requirements.txt and map it to the python-package in archive [13:14] powersj: found a fix [13:15] http://paste.ubuntu.com/23420677/ powersj === smoser changed the topic of #cloud-init to: cloud-init 0.7.8 released 2016-09-12. 0.7.9 open. reviews: https://code.launchpad.net/~cloud-init-dev/cloud-init/+git/cloud-init/+ref/master/+activereviews | fly the W [13:16] powersj, looking [13:16] powersj, hm [13:16] oh, yeah. the package build will use it, forgot about that. need to add a build dep [13:17] rharper, is right. i'll grab that quick [13:17] smoser: morning! [13:18] hey [13:18] rharper, coverage was already in test-requirements though [13:18] smoser: yeah, but not in my branch, sorry [13:19] http://paste.ubuntu.com/23420684/ should work [13:19] adding it to "standard named packages" [13:19] smoser: sure, didn't reallize it's standard (which makes sense) [13:19] as "standard" is 'coverage' pypy package makes python-coverage and python3-coverage [13:19] right [13:24] so as this is, we dont need that in the package buidl dependency [13:24] as Makefile test does not run coverage. [13:24] for now i think we leave that as it is. [13:25] and just add the coverage to the list. it'll get installed in bddeb but not used. [13:26] y [13:31] rharper: thank you! [13:32] powersj, fixed in trunk now. [13:33] smoser: confirmed working now. Thank you! === shardy_lunch is now known as shardy [15:00] harlowja, does this make sense to you: https://code.launchpad.net/~bbaude/cloud-init/+git/cloud-init/+merge/309478 [15:11] hi all, I'm wondering if there is docs presents on how to modify and test cloud-init before submitting code. I've seen this page (https://cloudinit.readthedocs.io/en/latest/topics/hacking.html) but it doesn't goes into great details [15:12] e.g. there doesn't seem to be a test-suite to run [15:44] https://git.launchpad.net/cloud-init/tree/HACKING.rst [15:44] dont know why readthedocs is out of date. i will update it. [15:44] ie, i just merged that [15:49] tlonoy, reload https://cloudinit.readthedocs.io/en/latest/topics/hacking.html [17:38] brb, gotta restart [17:38] will check out in a few smoser [17:41] harlowja, ok. [17:41] had some review commetns for you in a couple mp yesterday to [17:42] yuppers [17:52] smoser https://code.launchpad.net/~bbaude/cloud-init/+git/cloud-init/+merge/309478 seems ok to me, i guess such a ordering is needed? [17:53] weird software be weird, lol === rangerpbzzzz is now known as rangerpb === rangerpb is now known as rangerpbzzzz