[03:09] RAOF: Care to jam in a last minute review before this one lands? https://code.launchpad.net/~vanvugt/mir/fix-1638774/+merge/309910 [03:09] duflu: Sure. [03:12] RAOF: Ta. I would write proper make_ functions if it was important but they're only tests which compare pointer values [04:34] ??? [04:35] This backtrace makes no sense. === chihchun_afk is now known as chihchun === davmor2_HOLS is now known as davmor2 === chihchun is now known as chihchun_afk === marcusto_ is now known as marcustomlinson [12:02] greyback: fixed as requested, but should I port it over to lp:qtmir? https://code.launchpad.net/~alan-griffiths/miral/WindowControllerInterface-isVisible/+merge/310039 [12:05] alan_g: great, thank you. Our current plan is the following: we moved all of lp:miral/miral-qt to lp:~unity-team/qtmir/miral-qt-integration - we are developing on top of this branch, making MPs on top of it, and merging manually [12:06] alan_g: I think it would be logical to remove lp:miral/miral-qt - less duplication. wdyt? [12:08] greyback: Agreed. There should only be one. I think I'll stop poking at that code for a while to minimise churn. [12:12] greyback: there are a couple of [miral-qt] MPs in flight (including the one I asked about). What's the plan for them? [12:12] alan_g: we'll integrate them into our branch [12:14] * alan_g decides its SEP for the next week or so. ;) [12:19] alan_g: ok, I've cleaned up the MP list. Aside from your branch, everything else has been included in lp:~unity-team/qtmir/miral-qt-integration [12:19] "SEP" ? [12:19] Someone Else's Problem [12:19] :) [12:22] Will you pick up my PM too? [12:22] Ah, just see comment [12:22] *seen [12:46] sil2100: can I talk you into landing this? https://bileto.ubuntu.com/#/ticket/2155 === hikiko is now known as hikiko|ln [12:55] alan_g: sure, let me take a look [13:02] alan_g: done [13:02] sil2100: thanks === alan_g is now known as alan_g|lunch === dandrader is now known as dandrader|afk === marcust__ is now known as marcustomlinson === hikiko|ln is now known as hikiko === dandrader|afk is now known as dandrader === alan_g|lunch is now known as alan_g [14:29] greyback, you there? [14:31] alan_g, I suppose you eventually want to remove that from miral::Window? "operator std::shared_ptr() const;" [14:32] dandrader: no, it's needed internally (or something equivalent) and I don't want to ban use of it, just make it mostly unnecessary. [14:58] dandrader: I assume you're good with this: https://code.launchpad.net/~alan-griffiths/miral/purge-miral-qt/+merge/310192 [15:00] * dandrader looks [15:38] bschaefer: not tried snapping it yet, but a POC https://github.com/AlanGriffiths/mircade [15:39] alan_g, ooo very nice [15:39] * bschaefer tries it [15:40] game not found, but i have a few others :) [15:41] Yeah, there's a few bits need writing [15:41] yeah, but nice looking [15:42] * bschaefer was going to start looking at emulation station on his half days [15:43] alan_g, also, the games werent fullscreen when i started them [15:43] could be one of those things that just need extra writing :) [15:44] bschaefer: I noticed that too. Was wondering if miral-kiosk ought to force fullscreen [15:44] * bschaefer thinks thats a good choice [15:45] The question is "when?" - obviously not for *all* windows [15:45] o true hmm [15:45] Ones without parents? The first one? [15:46] (First for the app) [15:46] alan_g, possibly yeah the first? Right after your exec command? [15:47] well i guess you already do then :) [15:47] mir_surface_set_state(surface, mir_surface_state_fullscreen); [15:47] but i suppose you'll need to apply the spec [15:47] bschaefer: that's just the mircade client, It can't fiddle with other applications [15:47] (but not sure if you have access to the mir surface for it) [15:47] yeah [15:48] alan_g, can you always force fullscreen for *new* cleans only? [15:48] not sure what would happen with something like gimp though [15:49] miral-kiosk can do whatever I decide [15:49] :) [15:49] apps with a "splash" screen could also be "difficult" [15:49] o right... [15:50] * alan_g wonders what surface type they are [15:50] thats left up to the client :) [15:50] (ie. could we depend on it? being a specific type?) [15:51] * alan_g is tempted by "type=normal, parent=(none)" => fullscreen [15:52] that seems far... i suppose there could be a few edge cases === dandrader is now known as dandrader|afk [15:53] Yeah, but "kiosk" isn't intended as a fully functional desktop [15:54] exactly, i think thats a fair assumption to put on [15:54] alan_g, i can only think of a couple cases? *Such as gimp but you can force 1 window IIRC* [15:55] * alan_g doesn't think running gimp on a "kiosk" needs to be supported [15:55] yeah [15:55] but maybe a *drawing* station haha [15:55] kgunn might disagree [15:55] with touch (idk if its even supported) [16:02] yeah, i wouldn't think gimp kiosk would be a top seller ;) [16:04] kgunn: bschaefer and I have been discussing using miral-kiosk for an "arcade" style interface and for that scenario it makes sense to force "fullscreen" for main windows (for some definition of main window) [16:04] hm I have a photo of an ubuntu drawing kiosk in a sport cloth shop [16:05] alan_g, yeah i think thats a good way to go... i cant think of anything else that would be *strange* but i suppose they are out there! [16:07] anpok: was that gimp? :) [16:07] hm nope.. === dandrader|afk is now known as dandrader [17:27] anpok: hey, do you know what's happening with keymap support? is the shell taking over there? [17:27] or is the client still expected to do the key event translation? === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader [21:17] attente: yes .. the shell is in charge.. i.e the shell is now able to configure the keymapping per keyboard in its own process, it will receive mapped keys including compose key results [21:17] attente: but it still could configure client windows to have different keymap [21:17] (again per keyboard) [21:19] anpok: i don't understand, does that mean clients could both receive already translated key events and non-translated key events as well? [21:19] they get enough information yes.. [21:19] key events contain the original scan code and the mapped key [21:19] ah, ok [21:19] thanks! [21:20] and for the forseeable future - due to xmir - unity8 will configure keymaps for client windows