[00:34] <babbageclunk> thumper, perrito666, redir: Anyone up for a review? https://github.com/juju/juju/pull/6544
[00:49] <redir> babbageclunk: someone lookin?
[00:50] <babbageclunk> redir: I think thumper said he would.
[00:50] <redir> ack
[00:50] <babbageclunk> haha, mistyped that as thumber first
[00:51] <thumper> yeah, I'm looking
[01:27] <thumper> babbageclunk: sorry for the delay
[01:27] <babbageclunk> thumper: no worries
[01:27] <thumper> got myself confused with something in the review
[01:27] <thumper> but all good
[01:45] <babbageclunk> veebers: my build failed due to lack of memory: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9627/console
[01:45] <babbageclunk> veebers: can you give something a kick? Should I just restart the build?
[01:48] <veebers> babbageclunk: let me have a look
[01:53] <veebers> babbageclunk: the issue is there are a bunch of (probably) leaked lxd containers running on that machine, i'm just attempting to clarify what I can kill safely to free up space
[02:13] <veebers> babbageclunk: ok, hopefully I haven't destroyed the universe (just killed a bunch of machines) can you go ahead and !!build!! that PR of yours? It should get through this time
[02:16] <babbageclunk> veebers: Thanks!
[02:20] <veebers> babbageclunk: nw, let me know if you have any other issues
[02:40] <thumper> poo
[02:40] <thumper> something screwy is happening
[02:53] <veebers> thumper: with CI? (he asks after having removed some machines)
[03:21] <thumper> veebers: no, with migration
[03:39] <thumper> babbageclunk: around to be a rubber duck?
[03:43] <babbageclunk> thumper: sure - actually I could use a rubber duck in turn
[03:44] <thumper> ok, 1:1 HO?
[10:20] <mup> Bug #1640113 opened: In LXD machines in localdomain not resolvable <juju-core:New> <https://launchpad.net/bugs/1640113>
[10:34] <SimonKLB> uhm, i just deployed wordpress+mysql on one machine and haproxy on another then BOOM it deployed 15 machines all of a sudden on aws
[10:34] <SimonKLB> i have no idea how that happened
[11:04] <perrito666> morning all
[11:43] <dooferlad> mgz: is http://juju-ci.vapour.ws:8080/job/github-merge-develop-to-staging/ really the merge develop to staging job?
[11:43]  * dooferlad has a conflict I can't resolve because develop hasn't merged back into staging
[12:25] <mgz> dooferlad: that should be it
[12:35] <mgz> dooferlad: if you want to actually land your branch you'll need to merge the conflicting change from staging into it to resolve (or rebase on later change)
[15:08] <rick_h> voidspace: can you join the other #juju please and help someone out?
[15:08] <voidspace> rick_h: #juju on canonical?
[15:08] <rick_h> voidspace: yes please
[15:08] <voidspace> rick_h: in standup now, but will take a look as well
[15:08] <rick_h> K
[15:11] <natefinch> rick_h: standup?
[15:12] <rick_h> natefinch: can't ATM. About to give a lightening talk.
[15:12] <natefinch> rick_h: kk
[15:12] <rick_h> Phone irc'ing while in line
[15:12] <natefinch> ahh
[15:26] <aisrael> Is there a reason why action names can't include numbers, i.e., an action named iperf3 will throw a "ERROR bad action name iperf3" when trying to deploy/upgrade the charm.
[15:34] <voidspace> at the moment my girl is at "science club" on Tuesdays, so I can stay for the whole of standup
[15:35] <voidspace> just FYI
[15:35] <voidspace> and I have a hospital appointment tomorrow morning
[15:36] <mgz> science club sounds fun
[15:38] <voidspace> mgz: only her second one today, they made a dinosaur tooth last week but she really wants explosions which they have been promised at some point by "Atomic Tom" who takes it...
[15:39] <mgz> ehehe, in it for the bangs
[15:39] <voidspace> always
[15:39] <voidspace> :-)
[15:40] <voidspace> katco: o/
[15:47] <voidspace> uhm, nope, my hospital appointment is Thursday morning
[15:48] <voidspace> perrito666: can you answer aisrael's question about actions?
[15:48] <voidspace> aisrael: I suspect the answer maybe "no good reason"... Can you file a bug about it?
[15:49] <natefinch> AFAIK, no good reason
[15:49] <natefinch> var actionNameRule = regexp.MustCompile("^[a-z](?:[a-z-]*[a-z])?$")
[15:49] <aisrael> voidspace: Yep, I'll do that. I figured if it was for a reason, the docs/charm tools need to be updated to reflect it.
[15:49] <voidspace> aisrael: yep
[15:49] <voidspace> aisrael: natefinch: looks easy to fix then...
[15:50] <aisrael> voidspace: natefinch: excellent, thanks. Filing a bug now.
[15:50] <voidspace> assuming there is no good reason
[15:50] <voidspace> aisrael: if we find a reason we'll let you know :-D
[16:18] <perrito666> voidspace: no, I dont know why that is
[16:38] <dooferlad> voidspace: do you know why we have a networking interface defined for vsphere? https://bugs.launchpad.net/juju/+bug/1638401 exists because provider/vsphere/environ_network.go exists
[16:38] <mup> Bug #1638401: vsphere: spaces spams the logs with an error <juju:Triaged> <https://launchpad.net/bugs/1638401>
[16:39] <perrito666> dooferlad: that was done by third party so they might have just cargo culted
[16:39] <dooferlad> perrito666: ah, thanks
[16:57] <voidspace> dooferlad: no, no idea
[16:58] <dooferlad> voidspace: no worries, the question was answered by perrito666.
[16:58] <voidspace> dooferlad: cool :-)
[17:07] <perrito666> bbl relocation
[19:11]  * redir steps out to vote and grab lunch on the way back.
[19:32] <perrito666> bbl
[20:20] <thumper> o/ babbageclunk
[20:21] <babbageclunk> morning thumper!
[20:22] <babbageclunk> exciting day today
[20:23] <perrito666> back
[20:23] <SimonKLB> seeing this when bootstraping an LXD controller: ERROR juju.state database.go:231 using unknown collection "remoteApplications"
[20:23] <SimonKLB> any ideas?
[20:24] <SimonKLB> 2.0.1-xenial-amd64
[20:25] <thumper> babbageclunk: terrifying day you mean?
[20:25] <thumper> babbageclunk: I worked out how to work around the bug in migrations to finish QAing my branch
[20:25] <babbageclunk> thumper: yes, that
[20:25] <babbageclunk> thumper: oh, nice!
[20:25] <thumper> so doing that now
[20:26] <babbageclunk> thumper: I think I worked out an approach to sharing some of the code in logsink, trying it out.
[20:28] <perrito666> SimonKLB: oh, that looks like a bug, what bootstrap command did you use?
[20:30] <SimonKLB> perrito666: just `juju bootstrap localhost a-name`
[20:31] <SimonKLB> i saw this: https://bugs.launchpad.net/juju/cross-model-relations/+bug/1634956
[20:31] <mup> Bug #1634956: unknown remoteApplications on deploy <ci> <deploy> <jujuqa> <juju:Incomplete> <juju cross-model-relations:Triaged> <https://launchpad.net/bugs/1634956>
[20:31] <SimonKLB> but in my case it was right away after the controller was installed
[20:31] <SimonKLB> i didnt deploy anything
[20:32] <perrito666> SimonKLB: I see, I believe we can work around this bug by setting a flag, let me look for it
[20:33]  * redir back
[20:35] <thumper> babbageclunk: hazaar, have now confirmed it works
[20:47] <perrito666> SimonKLB: JUJU_DEV_FEATURE_FLAGS=cross-model
[20:49] <SimonKLB> perrito666: great, thanks! i realized why i saw it early btw, it shows up when i run juju status
[21:16] <thumper> babbageclunk: https://github.com/juju/juju/pull/6548
[21:17] <babbageclunk> thumper: ooh, longish - let me finish the thought I'm sketching out then I'll review yours.
[21:18] <thumper> babbageclunk: ta
[22:13] <babbageclunk> thumper: Sorry, got a bit caught up in the weeds there. Can you look at this https://github.com/juju/juju/commit/eafd1f8286d4898907bf826af12c8512b1e76f8a and tell me what you think of the approach?
[22:13] <babbageclunk> thumper: reviewing your PR now
[22:13] <thumper> ok
[22:14] <thumper> babbageclunk: where should I comment?
[22:16] <babbageclunk> thumper: not sure. On the commit? Or here is fine.
[22:19] <thumper> newStrategy as a member of logSinkHandler seems weird, dbStrategy ?
[22:19] <thumper> is it always a db strategy?
[22:21] <babbageclunk> Well, it's a func that makes a strategy (because the strategy is stateful).
[22:21] <thumper> ugh....
[22:21] <thumper> it is doing two things, and I think it should do one
[22:22] <babbageclunk> thumper: it's always a db strategy, but it also has an opinion about the log file prefix.
[22:22] <thumper> should be a dbStrategy and a fileStrategy
[22:22] <thumper> I don't think the migration logs should be put into the same file as the logsink file
[22:22] <babbageclunk> thumper: no, they wouldn't - I'd expect that we'd give it a different directory
[22:23] <thumper> hmm...
[22:23] <thumper> like what?
[22:25] <babbageclunk> I guess it depends how we want the migrated logs to look after the migration is finished.
[22:25] <babbageclunk> Should they be in the same places they would've been on the source controller machine?
[22:26] <babbageclunk> Or is it ok to have them mashed in to one place? Basically I haven't thought about the file side of it.
[22:27] <thumper> the logsink file is really just a backup of the logs that the controller has received
[22:28] <thumper> not normally meant for user consumption
[22:28] <babbageclunk> Right - so we mostly care about the DB logs then?
[22:28] <thumper> much more, yes
[22:29] <babbageclunk> ok
[22:29] <thumper> I'm just thinking about how much we care about migration logs on the disk of the controller
[22:29] <thumper> problem is that it won't get rolled
[22:29] <thumper> unlikely to be too big, but you never know
[22:29] <thumper> and how many we may have on any particular controller
[22:29] <babbageclunk> True - it could be big, although it's not growing.
[22:30]  * thumper nods
[22:32] <babbageclunk> A different file prefix sounds alright to start with then.
[22:33] <thumper> yeah
[22:33] <babbageclunk> Also, these are model logs - I was thinking about controller logs, which have much more in them, right?
[22:34] <thumper> true
[22:34] <thumper> although I have been talking with menno about how to make the models have the apiserver logs for that model
[22:34] <thumper> so, small for now
[22:43] <mgz> thumper: yo, you wanted a repo bot-managed?
[22:44] <thumper> it already is
[22:44] <thumper> so no worries
[22:51] <babbageclunk> thumper: oops, misunderstood what fileprefix was doing there - I thought it was a filename prefix, not a log line prefix
[22:54] <babbageclunk> thumper: In that case maybe I move all of the logging into the strategy, as well as the version number parsing.
[22:54]  * thumper nods
[22:55] <babbageclunk> thumper: not at all attached to the name strategy, by the way, if you can think of something better - just picked something so I could try it.
[22:55] <mgz> thumper: as in, someone did it yesterday, or we'd done it before and forgot?
[23:20] <babbageclunk> thumper: reviewd
[23:20] <babbageclunk> e