| Trevinho | dmj_s76: hey, sorry... its quite late here... So I can't now, and andyrock is in holidays, but we'll take care of it. | 02:18 |
|---|---|---|
| vigo | morning | 07:44 |
| cimi | morning pstolowski, how are we supposed to proceed implementing what we discusses yesterday? you start working on the API then when you have it we add on the dash or I already add that to the dash? also, do we want to document this somewhere? | 09:22 |
| pstolowski | cimi, morning | 09:23 |
| pstolowski | cimi, there is no new api, you just need to support it via category renderer attribute, and then we fix scopes | 09:23 |
| pstolowski | cimi, and yeah, it needs to be documented in the scopes api doc | 09:24 |
| cimi | pstolowski, when will you start that? can I add this to the dash today? | 09:29 |
| pstolowski | cimi, ah, I'll probably need to add it to CATEGORY_JSON_DEFAULTS in shell plugin, but that should be enough. | 09:31 |
| pstolowski | cimi, let me know when you have a branch and then i'll do it in the plugin and music scope, should be quick | 09:31 |
| cimi | pstolowski, oki | 09:31 |
| cimi | tsdgeos, still building but I hope that something like this will work http://paste.ubuntu.com/23489853/ | 10:28 |
| tsdgeos | i guess | 10:29 |
| tsdgeos | you'll want some expandable ones in the fake plugin thoguh | 10:29 |
| tsdgeos | so you can still see/less more | 10:29 |
| cimi | Saviq, interesting, if we set cardtool template collapsed-rows to 0 we were basically hiding see more/less | 10:30 |
| cimi | Saviq, maybe this is what you remembered? | 10:30 |
| Saviq | cimi, with how many rows? | 10:30 |
| cimi | mmm | 10:31 |
| cimi | yeah 0 doesnt make much sense | 10:31 |
| cimi | tsdgeos, yeah I will tweak just for the first index | 10:32 |
| tsdgeos | cimi: it means "show everything" | 10:32 |
| tsdgeos | which is not what we want here | 10:33 |
| tsdgeos | we want "show 2 rows without see more/less" | 10:33 |
| cimi | tsdgeos, need to test it | 10:33 |
| tsdgeos | what's the name of the channel with the bileto status reports for silos? | 10:34 |
| * tsdgeos forgot | 10:34 | |
| tsdgeos | Saviq: ↑↑ | 10:34 |
| Saviq | tsdgeos, #ubuntu-ci-eng | 10:34 |
| cimi | tsdgeos, yeah you're right | 10:36 |
| cimi | tsdgeos, works http://paste.ubuntu.com/23489903/ | 10:45 |
| tsdgeos | you don't need the expanded one, no? | 10:46 |
| tsdgeos | after all you're already changing expandable | 10:46 |
| cimi | maybe should rename to notExpandable | 10:46 |
| cimi | tsdgeos, if I don't change readonly property bool expanded: baseItem.expanded || !baseItem.expandable | 10:47 |
| cimi | tsdgeos, then height: expanded ? item.expandedHeight : item.collapsedHeight | 10:47 |
| cimi | and height will be of the expanded | 10:47 |
| cimi | so I need to force the collapsed height | 10:47 |
| cimi | does this make sense? | 10:47 |
| tsdgeos | cimi: yes/no maybe | 10:48 |
| cimi | :D | 10:49 |
| tsdgeos | i guess it depends where you want to make this count | 10:49 |
| tsdgeos | and if you want item.exapndedHeight know that it will always be just 2 rows or not | 10:49 |
| tsdgeos | or you want to force that at the GSV level | 10:49 |
| tsdgeos | both are ok approaches i guess | 10:50 |
| tsdgeos | but yeah we need better names for those variables | 10:50 |
| tsdgeos | was a bit of a headache reading | 10:50 |
| tsdgeos | expanded exandanble and noExpandable | 10:50 |
| tsdgeos | :D | 10:50 |
| cimi | tsdgeos, better name for template["expandable"] == false? | 10:54 |
| cimi | like, the property noExpandable | 10:55 |
| cimi | that could be notExpandable | 10:55 |
| cimi | or forceNotExpandable | 10:55 |
| cimi | or some other crap | 10:55 |
| tsdgeos | i like the force | 10:58 |
| cimi | tsdgeos, problem is, if expandable is not set, the property forceNotExpandable is true | 11:21 |
| cimi | tsdgeos, shall I check for the property to be defined, or I expect pawel to always define expandable to true? | 11:21 |
| tsdgeos | no | 11:23 |
| tsdgeos | check for it to be defined | 11:23 |
| cimi | pstolowski, oki | 11:49 |
| cimi | pstolowski, https://code.launchpad.net/~cimi/unity8/dash-forceNotExpandable/+merge/311134 | 11:49 |
| cimi | pstolowski, building on silo 2202 right now | 11:50 |
| pstolowski | cimi, cool, i'll create my part today too | 11:56 |
| cimi | tsdgeos, https://code.launchpad.net/~cimi/unity8/dash-forceNotExpandable/+merge/311134 | 12:01 |
| === JanC_ is now known as JanC | ||
| === jhodapp_ is now known as jhodapp | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| cimi | pstolowski, managed to get something working? | 16:00 |
| pstolowski | cimi, i haven't started yet, about to | 16:01 |
| === JanC is now known as Guest90855 | ||
| === JanC_ is now known as JanC | ||
| === alan_g is now known as alan_g|tst | ||
| === dandrader is now known as dandrader|afk | ||
| === alan_g|tst is now known as alan_g | ||
| pstolowski | cimi, are we targeting vivid with this fix? | 16:47 |
| cimi | pstolowski, I guess too | 16:51 |
| cimi | pstolowski, for clicks? ask Saviq too | 16:52 |
| pstolowski | ? | 16:54 |
| pstolowski | cimi, we've been told to land only critical fixes that are targeted for OTA | 16:54 |
| pstolowski | cimi, my stuff is in silo 2217; will try to test tomorrow morning (not sure how exactly since my phone and tablet are vivid) | 17:07 |
| pstolowski | the scope will probably need a few iterations to make sure it looks good in all circumstances | 17:08 |
| === dandrader|afk is now known as dandrader | ||
| cimi | pstolowski, I only have vivid devices too | 17:09 |
| pstolowski | anyway.. i'll figure this out tomorrow. eod, cu! | 17:11 |
| cimi | cu! | 17:11 |
| mterry | josharenson: hey btw I am aware of your session-icon MP but have been too busy with snappy work | 17:18 |
| mterry | josharenson: I will point out that depending on session-lightdm is a sure way to not land for a long time anyway | 17:18 |
| mterry | josharenson: I think I need to pull out the mock refactoring in that branch | 17:18 |
| josharenson | mterry: haha ok | 17:18 |
| josharenson | mterry: 90% of the branch depends on the new mock... | 17:19 |
| josharenson | mterry: but I can backport if you think its a better idea | 17:19 |
| mterry | josharenson: yeah. I can't live without that mock refactor | 17:19 |
| mterry | That's why I have like 6 branches depending on session-lightdm | 17:19 |
| mterry | But I need to pull it out or they'll never land | 17:19 |
| mterry | When the u8 snap calms down... | 17:19 |
| josharenson | mterry: sure thing | 17:20 |
| === boiko_ is now known as boiko | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!