[02:18] dmj_s76: hey, sorry... its quite late here... So I can't now, and andyrock is in holidays, but we'll take care of it. [07:44] morning [09:22] morning pstolowski, how are we supposed to proceed implementing what we discusses yesterday? you start working on the API then when you have it we add on the dash or I already add that to the dash? also, do we want to document this somewhere? [09:23] cimi, morning [09:23] cimi, there is no new api, you just need to support it via category renderer attribute, and then we fix scopes [09:24] cimi, and yeah, it needs to be documented in the scopes api doc [09:29] pstolowski, when will you start that? can I add this to the dash today? [09:31] cimi, ah, I'll probably need to add it to CATEGORY_JSON_DEFAULTS in shell plugin, but that should be enough. [09:31] cimi, let me know when you have a branch and then i'll do it in the plugin and music scope, should be quick [09:31] pstolowski, oki [10:28] tsdgeos, still building but I hope that something like this will work http://paste.ubuntu.com/23489853/ [10:29] i guess [10:29] you'll want some expandable ones in the fake plugin thoguh [10:29] so you can still see/less more [10:30] Saviq, interesting, if we set cardtool template collapsed-rows to 0 we were basically hiding see more/less [10:30] Saviq, maybe this is what you remembered? [10:30] cimi, with how many rows? [10:31] mmm [10:31] yeah 0 doesnt make much sense [10:32] tsdgeos, yeah I will tweak just for the first index [10:32] cimi: it means "show everything" [10:33] which is not what we want here [10:33] we want "show 2 rows without see more/less" [10:33] tsdgeos, need to test it [10:34] what's the name of the channel with the bileto status reports for silos? [10:34] * tsdgeos forgot [10:34] Saviq: ↑↑ [10:34] tsdgeos, #ubuntu-ci-eng [10:36] tsdgeos, yeah you're right [10:45] tsdgeos, works http://paste.ubuntu.com/23489903/ [10:46] you don't need the expanded one, no? [10:46] after all you're already changing expandable [10:46] maybe should rename to notExpandable [10:47] tsdgeos, if I don't change readonly property bool expanded: baseItem.expanded || !baseItem.expandable [10:47] tsdgeos, then height: expanded ? item.expandedHeight : item.collapsedHeight [10:47] and height will be of the expanded [10:47] so I need to force the collapsed height [10:47] does this make sense? [10:48] cimi: yes/no maybe [10:49] :D [10:49] i guess it depends where you want to make this count [10:49] and if you want item.exapndedHeight know that it will always be just 2 rows or not [10:49] or you want to force that at the GSV level [10:50] both are ok approaches i guess [10:50] but yeah we need better names for those variables [10:50] was a bit of a headache reading [10:50] expanded exandanble and noExpandable [10:50] :D [10:54] tsdgeos, better name for template["expandable"] == false? [10:55] like, the property noExpandable [10:55] that could be notExpandable [10:55] or forceNotExpandable [10:55] or some other crap [10:58] i like the force [11:21] tsdgeos, problem is, if expandable is not set, the property forceNotExpandable is true [11:21] tsdgeos, shall I check for the property to be defined, or I expect pawel to always define expandable to true? [11:23] no [11:23] check for it to be defined [11:49] pstolowski, oki [11:49] pstolowski, https://code.launchpad.net/~cimi/unity8/dash-forceNotExpandable/+merge/311134 [11:50] pstolowski, building on silo 2202 right now [11:56] cimi, cool, i'll create my part today too [12:01] tsdgeos, https://code.launchpad.net/~cimi/unity8/dash-forceNotExpandable/+merge/311134 === JanC_ is now known as JanC === jhodapp_ is now known as jhodapp === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader [16:00] pstolowski, managed to get something working? [16:01] cimi, i haven't started yet, about to === JanC is now known as Guest90855 === JanC_ is now known as JanC === alan_g is now known as alan_g|tst === dandrader is now known as dandrader|afk === alan_g|tst is now known as alan_g [16:47] cimi, are we targeting vivid with this fix? [16:51] pstolowski, I guess too [16:52] pstolowski, for clicks? ask Saviq too [16:54] ? [16:54] cimi, we've been told to land only critical fixes that are targeted for OTA [17:07] cimi, my stuff is in silo 2217; will try to test tomorrow morning (not sure how exactly since my phone and tablet are vivid) [17:08] the scope will probably need a few iterations to make sure it looks good in all circumstances === dandrader|afk is now known as dandrader [17:09] pstolowski, I only have vivid devices too [17:11] anyway.. i'll figure this out tomorrow. eod, cu! [17:11] cu! [17:18] josharenson: hey btw I am aware of your session-icon MP but have been too busy with snappy work [17:18] josharenson: I will point out that depending on session-lightdm is a sure way to not land for a long time anyway [17:18] josharenson: I think I need to pull out the mock refactoring in that branch [17:18] mterry: haha ok [17:19] mterry: 90% of the branch depends on the new mock... [17:19] mterry: but I can backport if you think its a better idea [17:19] josharenson: yeah. I can't live without that mock refactor [17:19] That's why I have like 6 branches depending on session-lightdm [17:19] But I need to pull it out or they'll never land [17:19] When the u8 snap calms down... [17:20] mterry: sure thing === boiko_ is now known as boiko