mup | Bug #1623275 changed: neutron-gateway juju-agent lost forever <juju-core:Expired> <juju-core 1.25:Expired> <https://launchpad.net/bugs/1623275> | 04:26 |
---|---|---|
thumper | babbageclunk: https://github.com/juju/juju/pull/6586 | 21:22 |
babbageclunk | thumper: ok - just going through your comments, looking at that in 2 mins. | 21:24 |
thumper | babbageclunk: np | 21:24 |
thumper | I'm just preparing another one :) | 21:24 |
thumper | babbageclunk: https://github.com/juju/juju/pull/6587 | 21:36 |
babbageclunk | thumper: 6586 lgtm! | 21:37 |
babbageclunk | thumper looking at the next | 21:37 |
thumper | babbageclunk: it isn't big either | 21:37 |
babbageclunk | thumper: 6587 looks good to - a minor typo in a comment. | 21:43 |
babbageclunk | thumper: What's up with all the formatting breakage lately? | 21:43 |
babbageclunk | thumper: I say all-the - this is the second instance I've seen in 2 days. | 21:44 |
babbageclunk | thumper: can you rereview https://github.com/juju/juju/pull/6573 since I've made your changes? | 21:46 |
thumper | no idea, I thought the merge bot would reject poorly formatted proposals | 22:01 |
thumper | yes, I can rereview | 22:01 |
thumper | babbageclunk: why are your approvals not green ticks? | 22:01 |
babbageclunk | thumper: not sure - maybe because I had a line comment as well? | 22:11 |
* thumper shrugs | 22:24 | |
babbageclunk | thumper: man, what's going on with Mongo on Windows today? | 22:51 |
thumper | it is always a bit screwy no? | 22:54 |
babbageclunk | yeah, but two in a row seems excessive. | 22:54 |
=== axw_ is now known as axw | ||
thumper | babbageclunk: hmm... the remove flag branch landed second time | 23:15 |
babbageclunk | yay | 23:16 |
thumper | babbageclunk: can you join our 1:1 hangout? | 23:22 |
thumper | I need to talk something throguh | 23:22 |
babbageclunk | sure | 23:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!