=== JanC is now known as Guest78373 === JanC_ is now known as JanC [07:34] Trevinho: Hello! === duflu_ is now known as duflu === boiko__ is now known as boiko [13:56] hey om26er [13:57] Trevinho: Hi! it was about a bug in zesty, which has since been fixed. https://bugs.launchpad.net/ubuntu/+source/lightdm/+bug/1637758 [13:57] Ubuntu bug 1637758 in lightdm (Ubuntu) "lightdm greeter session not properly shut down at login" [High,Fix released] === dandrader is now known as dandrader|afk [15:02] hey folks. I'm having trouble with a QML test in this MR (https://code.launchpad.net/~pete-woods/ubuntu-settings-components/add-ethernet-item/+merge/311503) [15:02] for some reason line 246: compare(getChild("labelName").text, data.name) [15:02] is failing to find the "labelName" child widget [15:02] strangely, if I comment it out, the following lines find their widgets [15:03] i.e. "labelStatus" and "statusIcon" [15:03] I was hoping someone with more QML-fu than me might spot what's wrong [15:41] * pete-woods plays small violin [15:42] ltinkl_, mzanetti: maybe obvious to one of you guys? ^ [15:42] (it's a pretty small MR) [15:42] pete-woods, looking at it [15:42] thanks! [15:43] pstolowski: I've added a feature to unity8 that fixes lp:1575319 However, it introduces a UI hang when dealing with a large number of scopes. For example, on the ScopesList page, if you drag the scope in position #20 to position #0, there is a several second hang as moveFavoriteTo is called. I assume something expensive is happening with the model, but do you have any insight as to why it hanging for so long? [15:43] pete-woods, visible: text !== "" (so if that label isn't visible, it won't find it; I think it's as simple as that :) [15:43] ltinkl_, no... you can find invisible things [15:44] ltinkl_: good suggestion. I thought that there *was* text, though [15:44] even so, I'm going to try it [15:44] mzanetti, pete-woods: sure, I meant _if_ it doesn't have text [15:45] * mzanetti suspects it's just not ready yet... perhaps waitForRendering(root) [15:47] pete-woods, yup, that too maybe; so in getChild(), instead of verify() try to use tryCompare() [15:49] josharenson, hi. yeah, i was looking at it a few months ago and i thought i eliminated the most important bottlenecks there. apparently not :( [15:50] ltinkl_: right, will see what happens there! [15:50] josharenson, would be good to know if it's actually moveFavoriteTo(), or if its storeFavorites() called by moveFavoriteTo [15:56] pstolowski: I'll instrument it and see [16:03] ltinkl_, mzanetti: adding the waitForRendering, (and also removing the visible property), didn't seem to help [16:04] I couldn't think of a way to use tryCompare in that method [16:04] I don't know how to do a tryCompare(getChild(...), NOT NIL)? [16:04] type construct [16:05] pete-woods, check out "tryCompareFunction" in unity8 [16:05] but not sure if that's really your issue [16:05] nor am I [16:05] at this point I'd need to run your code and debug it [16:05] fair enough [16:06] I can't see any difference between this widget and the other text widget now [16:06] (after I removed the visible condition) === dandrader|afk is now known as dandrader [16:11] mzanetti: looks like that helped you mentioned has been integrated into the UbuntuTestCase class already [16:11] could very well be, yes [16:13] mzanetti: you were correct that this isn't the problem, though [16:13] it just waits until the timeout now [16:13] (but still succeeds for the other widgets) [16:13] pete-woods, well, worst case, you can print the object tree [16:14] and check if it's there or not [16:14] mzanetti: print(ethernetItem) ? [16:14] or more difficult than that? [16:14] more difficult [16:14] but not much :D [16:15] JSON.stringify(anything) ? [16:15] ethernetItem.children.foreach(print("have item", item); callTheSameRecursiveForAll(item)) [16:15] pseudo-code-ish :D [16:17] pete-woods, or, you getChild() the parent of it and print direct children only [16:17] something like that [16:18] function banana(item) {item.children.foreach(print("have item", item); banana(item)) } [16:18] ? [16:20] did you invent the foreach function? [16:20] it seems like I need to do a more traditional index based iteration [16:24] hmm, can't see the print output [16:24] oh no, I can [16:24] just not getting any children [16:26] haha [16:26] .length, not .size [16:27] the DOM is interesting [16:27] looks like the object name is being overwritten [16:28] and set to "label" [16:28] mzanetti: any idea how that could happen? [16:29] the test passes if I look for "label", rather than "labelStatus" [16:29] sorry, "labelName" [16:30] tell me I've not spelled the property wrongly [16:34] there's something seriously weird going on [16:35] pete-woods, qml should not overwrite the objectName on its own. but perhaps it happens where the component is used? [16:35] mzanetti: I don't think it does? [16:35] pete-woods, I did not invent the foreach function, there is such a thing in JS, but I never remember the syntax [16:35] as I said, pseudo-code [16:35] mzanetti: I'm now in the situation where the DOM isn't changing when I tweak the component under test [16:36] which makes me think the test env is a bit wacky [16:36] dammit [16:36] you need to run make each time [16:36] are you perhaps loading the wrong thing? e.g. something installed in the system instead of the one in the build tree? [16:36] that's very un-QML [16:36] depends on the build-system really [16:36] fair enough [16:36] but still, at least I know why my changes are having no effect [16:37] that's something [16:37] and now the tests pass [16:38] woo! [16:38] great! [16:38] well, I learned an important lesson [16:38] know what the build scripts are doing! [16:38] haha [16:50] Saviq, resubmitted https://code.launchpad.net/~mzanetti/unity8/disable-spread-while-locked/+merge/311515 [16:50] Saviq, also kicked the silo build [16:50] needs reapproval, ltinkl_ perhaps? ^ === ltinkl_ is now known as ltinkl [16:55] mzanetti, yup [16:58] mzanetti, in http://bazaar.launchpad.net/~mzanetti/unity8/disable-spread-while-locked/revision/2700, the change test_spreadDisabled(data) looks like a bad merge? or was this intentional? [16:59] ltinkl, bad merge indeed [17:02] ltinkl, fixed [17:04] mzanetti, tx [17:04] we seem to have some other trouble in the silo though [17:05] greyback_, any idea what could've caused FTBFS on zesty (across the board) https://launchpadlibrarian.net/294546675/buildlog_ubuntu-zesty-amd64.qtmir_0.5.0+17.04.20161122.1-0ubuntu1_BUILDING.txt.gz [17:07] Saviq: duplicate gmocks? === dandrader is now known as dandrader|afk [17:08] I'll look into it [17:08] tx [17:08] it's in silo 2202 https://bileto.ubuntu.com/#/ticket/2202 [17:09] there's only 3 qtmir MPs [17:09] @unity: please sanity-check the list of MPs in https://bileto.ubuntu.com/#/ticket/2202 - if there's anything missing, or something that maybe shouldn't land yet - please let me know === dandrader|afk is now known as dandrader === JanC_ is now known as JanC