=== chihchun_afk is now known as chihchun
=== dandrader_ is now known as dandrader
=== hikiko is now known as hikiko|ln
=== marcusto_ is now known as marcustomlinson
=== hikiko|ln is now known as hikiko
=== dandrader is now known as dandrader|afk
=== chihchun is now known as chihchun_afk
=== dandrader|afk is now known as dandrader
attentealan_g: hey, are you getting those errors when building miral-shell? ^15:11
alan_gattente: no. Compiler? Platform?15:13
attentealan_g: gcc via ccache15:15
attenteon zesty15:15
attentegcc 4:6.2.1-1ubuntu1, ccache 3.3.3-115:16
* greyback also got that today15:21
* alan_g hasn't got zesty to hand15:27
attentegreyback, alan_g: adding an extra comma there fixes it15:31
greybackattente: alan_g: ack I'll look after it15:32
attentegreyback: thanks15:32
alan_ggreyback: that's down to a gtest change?15:48
greybackattente: where did you add a comma? To designate an extra macro argument?16:03
attentegreyback: yeah: )); -> ),);16:07
attentegreyback: in all three places the error occurred16:07
greybackattente: bah, I thought I had tried that and compiler rejected it16:08
attenteoh. really?16:08
* attente shakes fist at googletest16:09
greybackalan_g: well, this is the patch. I'm unclear what's really changed: http://bazaar.launchpad.net/~gerboland/miral/gtest-bug-workaround/revision/45716:16
ubot5`Ubuntu bug 457 in k3b (Ubuntu) "k3b doesn't have any dependencies on cdrdao" [Medium,Invalid]16:16
greybackooh ubot got that wrong16:17
alan_ggreyback: for earlier versions of googletest (vivid, xenial, yakkety) that will break. "error: macro "INSTANTIATE_TEST_CASE_P" passed 4 arguments, but takes just 3),);16:18
greybackalan_g: yeah I guessed that16:18
greybackbut I'm still unclear what really changed16:19
greybackqtmir uses that macro in one test, and it compiles.16:19
alan_ggreyback: could you paste the definition of INSTANTIATE_TEST_CASE_P?16:23
alan_gI see: # define INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator) \ etc16:25
greybackalan_g: yep it has changed since: http://pastebin.ubuntu.com/23549170/16:27
alan_gWhy do they do these things? AFAICS qtmir doesn't use "-pedantic" which would be the difference16:33
alan_ggreyback: you still working on fix? or shall I take over?16:34
greybackalan_g: I'm still investigating16:35
greybackjust comparing qtmir testcase with miral: http://pastebin.ubuntu.com/23549194/16:35
greybackdifference is not obvious to me yet16:35
greybackno obviously different compiler flag16:36
alan_gI didn't see -pedantic in qtmir16:36
greybackI didn't think pedantic was reported with -Werror16:37
greybackok, that must be it16:37
greybackalan_g: wdyt? http://pastebin.ubuntu.com/23549271/16:54
greybackI can't see any way to get the googletest version, to gate it on 1.816:54
alan_gI'd prefer not to rely on a gcc extension: https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Variadic-Macros.html16:56
alan_gAnd I remember the  GTest .cmake doesn't set the standard properties16:57
alan_ggreyback: I'll sleep on it.17:02
=== alan_g is now known as alan_g|EOD
greybackalan_g: ack17:02
greybackhave a nice evening17:02
* greyback not sure what is least worst fix 17:02
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
=== JanC_ is now known as JanC

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!