/srv/irclogs.ubuntu.com/2016/11/29/#ubuntu-mir.txt

=== chihchun_afk is now known as chihchun
alan_ggreyback: does this work on zesty? https://code.launchpad.net/~alan-griffiths/miral/fix-for-zesty-gtest/+merge/31201808:31
greybacklet me try08:32
duflualan_g, greyback: You might want to link that to bug 164406208:32
ubot5`bug 1644062 in content-hub (Ubuntu) "googletest 1.8.0-2 (on zesty) breaks existing builds [add_library cannot create target "gmock" ...]" [Critical,In progress] https://launchpad.net/bugs/164406208:32
=== JanC is now known as Guest13710
=== JanC_ is now known as JanC
alan_gduflu: that looks like a different issue with the gtest changes08:35
duflualan_g: It's the same thing. RAOF made the same fix as yours in his branch08:35
dufluAlthough the bug title would make you think not08:35
alan_gand the bug description. (And yes, I stole his approach)08:36
greybackalan_g: no luck: http://pastebin.ubuntu.com/23552386/08:36
dufluAnd I spent most of a day fixing that one and others related to gtest 1.8 last week08:36
alan_ggreyback: can you check if HAS_W_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS is getting set?08:38
greybackalan_g: it's not getting set08:39
alan_ggreyback: ack. I wonder why08:41
greybackI'll have a look08:42
dufluDoes anyone apart from Xmir use mir_buffer_stream_swap_buffers (i.e. asynchronous swap callbacks)?08:43
anpok_duflu: i was tinkering with it in gtk08:45
anpok_in conjunction with the gdk frame clock08:45
anpok_but iirc that part has not landed yet08:45
dufluHa. mir::client::FrameClock is the name of the class I'm working on08:45
anpok_.. yes it has not08:45
anpok_first I or someone else has to clean up the resize handling08:46
dufluJust wondering... if I introduce a new feature for swap_buffers_sync only initially will most users benefit?08:47
dufluThe async case requires threads and mess. I'd rather separate it08:47
dufluPossibly an event loop instead08:47
dufluHurray, EGL uses a different code path, unnecessarily?08:54
alan_ggreyback: sorry, that seems to be a clang flag08:55
greybackok08:55
alan_ggreyback: pushed a version that works with g++09:14
alan_gI hope09:15
greybackack09:15
greybackalan_g: I believe you have a NOT missing in your logic. You check if "-Wno-something" is set, and if it is, append -Wno-something.09:29
alan_gI think I check if  "-Wno-something" is supported by the compiler and, if it is, set it. I guess it doesn't work?09:30
alan_gGot a meeting, back soon09:30
greybacknope, sorry09:31
greybackhttp://pastebin.ubuntu.com/23552532/ - the clang cmd line option is added09:33
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
alan_g/sigh check_cxx_compiler_flag() isn't as magic as I thought.10:28
alan_ggreyback: I think I've got it10:34
greybackalan_g: well that fixes gcc!10:37
greybackzesty clang now found another error10:37
greybackhttp://pastebin.ubuntu.com/23552717/10:38
* alan_g mutters about users10:43
greybackhttp://pastebin.ubuntu.com/23552731/ fixes that issue (and a class/struct complaint) for clang10:43
alan_gFeel free to propose that (you can drop "public" too)10:45
greybackok10:46
=== chihchun is now known as chihchun_afk
=== hikiko is now known as hikiko|ln
=== hikiko|ln is now known as hikiko
=== dandrader is now known as dandrader|afk
=== alan_g is now known as alan_g|bbiab
=== dandrader|afk is now known as dandrader
=== greyback is now known as greyback|afk
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
=== greyback|afk is now known as greyback

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!