| axw | mgz: forgot to ask you about the failure in https://github.com/go-goose/goose/pull/33. how does one update deps for that package's CI? it needs github.com/juju/loggo | 00:02 |
|---|---|---|
| bradm | is there any plans for 1.25.9? 1.25.8 seems suuuuper memory hungry | 00:45 |
| thumper | bradm: hey, yeah, I'm looking into a leak in 1.25.8 now | 00:59 |
| thumper | bradm: do you have any data points for me? | 00:59 |
| bradm | thumper: how does 12G res jujud on node 0 sound? | 01:01 |
| thumper | it sounds entirely unreasonable | 01:01 |
| thumper | how big a model? | 01:01 |
| bradm | 23G virtual and "0.012t" res, which is an interesting way to put it | 01:02 |
| bradm | thumper: 10 physical machines, a bunch of containers | 01:02 |
| thumper | how many units? | 01:02 |
| bradm | its a HA openstack deployment, so lots | 01:03 |
| thumper | 40? | 01:03 |
| thumper | 60? | 01:03 |
| bradm | including subordinates, about 290 units | 01:03 |
| thumper | 100? | 01:03 |
| thumper | huh | 01:03 |
| thumper | ok | 01:03 |
| thumper | on only 10 physical machines? | 01:04 |
| thumper | wow | 01:04 |
| bradm | yup | 01:04 |
| bradm | fairly standard deployment | 01:04 |
| bradm | that includes landscape client, nrpe, ksplice, things like that | 01:04 |
| thumper | hmm... | 01:05 |
| bradm | looks like nearly 50 lxcs on there | 01:05 |
| thumper | so ~5 units per machine | 01:06 |
| bradm | about that | 01:06 |
| thumper | I suppose that isn't terrible | 01:06 |
| thumper | what version did you upgrade from? | 01:06 |
| bradm | fresh 1.25.8 install | 01:06 |
| thumper | and do you have any indication of memory it used before? | 01:06 |
| thumper | ah | 01:06 |
| thumper | ok | 01:06 |
| * thumper taps fingers | 01:06 | |
| bradm | we were hitting the tomb dying error last week, and ended up having to go with fresh 1.25.8 | 01:07 |
| thumper | tomb dying error? | 01:07 |
| thumper | what is that? | 01:07 |
| thumper | is it related to this? https://bugs.launchpad.net/juju-core/+bug/1645729 | 01:07 |
| mup | Bug #1645729: environment unstable after 1.25.8 upgrade <juju-core:Triaged> <https://launchpad.net/bugs/1645729> | 01:07 |
| thumper | ok, I think I'm going to have to work out how to read the go heap profile dumps | 01:08 |
| bradm | https://bugs.launchpad.net/juju-core/1.25/+bug/1613992 <- that one | 01:08 |
| mup | Bug #1613992: 1.25.6 "ERROR juju.worker.uniter.filter filter.go:137 tomb: dying" <canonical-is> <cdo-qa-blocker> <landscape> <juju-core:Fix Committed> <juju-core 1.25:Fix Committed> <https://launchpad.net/bugs/1613992> | 01:08 |
| thumper | bradm: in the 1.25 agents, there is a point where we can get the agent to dump us a heap profile | 01:09 |
| thumper | maybe this could point to the leak | 01:09 |
| thumper | axw: do you have some familiarity in reading the go heap profiles? | 01:10 |
| bradm | thumper: well, anything we can do to help out, let me know. | 01:12 |
| thumper | bradm: will do | 01:12 |
| bradm | we'd just handed the stack over to the customer last week, but they're only doing testing now | 01:12 |
| bradm | thumper: interestingly the other state servers aren't leaking as much, something like 13G virt, 10G res on one, 11G virt, 8G res on the other | 01:17 |
| thumper | HA right? | 01:17 |
| bradm | yeah | 01:17 |
| thumper | multi-model? | 01:17 |
| thumper | probably not | 01:17 |
| thumper | was still behind a feature flag | 01:18 |
| bradm | nope, just a simple openstack deploy | 01:18 |
| babbageclunk | menn0, thumper: review plz? https://github.com/juju/juju/pull/6633 | 01:57 |
| babbageclunk | menn0: So I was thinking that tracking the latest log time seen every 2 minutes of log messages would probably be an ok balance between DB activity and getting annoyed by double-ups. Sound alright? | 02:08 |
| thumper | bugger... | 02:08 |
| babbageclunk | menn0: Works out to 864 extra writes over 3 days worth of logs. | 02:08 |
| thumper | crawled through all the code changes from 1.25.6 to 1.25.8 | 02:08 |
| thumper | nothing obvious | 02:08 |
| babbageclunk | thumper: stink | 02:08 |
| menn0 | babbageclunk: that seems ok, especially given that in most cases it won't be interrupted | 02:09 |
| menn0 | thumper: how sure are we that the problem actually started since 1.25.6? | 02:10 |
| thumper | menn0: I'm not entirely | 02:10 |
| thumper | could well be before | 02:10 |
| babbageclunk | menn0: oops, that was 5 mins - 2 mins is 2160 writes. | 02:10 |
| thumper | menn0: I have logs of 1.25.6 and prior where controller was running for weeks or months without restarting | 02:11 |
| thumper | but 1.28 OOMs very quickly | 02:11 |
| thumper | so I was using that as a basis | 02:11 |
| thumper | one unit has ~ 37 watchers | 02:11 |
| thumper | with 60 units | 02:12 |
| thumper | that is ~2100 watchers | 02:12 |
| thumper | each server side watcher has more than one goroutine | 02:12 |
| menn0 | thumper: well the fact that you see 1.25.6 lasting for long periods is a pretty strong indicator | 02:17 |
| menn0 | thumper: it might be something that isn't obvious from the commit logs | 02:17 |
| thumper | 1.25.6 up for 50 days | 02:18 |
| menn0 | thumper: can you reproduce the issue yourself by spinning up a reasonably sized model? | 02:18 |
| thumper | ~4-12 hours up time since upgrade | 02:18 |
| thumper | you need many machines and many units | 02:18 |
| thumper | I wonder if there were charm deployments that used newish features that were updated at a similar time | 02:19 |
| thumper | code that may have been in the older version but not touched | 02:19 |
| menn0 | babbageclunk: ship it | 02:31 |
| anastasiamac | thumper: dunno about code diff btw 1.25.6 and 1.25.8 but just looking at the bugs that went in, including 1.25.7, it's plausible... | 02:32 |
| thumper | I've done a git diff between the tag juju-1.25.6 and tip of 1.25 branch | 02:32 |
| thumper | only ~3k lines | 02:32 |
| thumper | and nothing obvious | 02:32 |
| anastasiamac | thumper: was anything changed in dependent libraries? diff versions? | 02:33 |
| thumper | only three | 02:33 |
| thumper | juju/utils goamz and one other | 02:33 |
| thumper | juju/charms | 02:33 |
| anastasiamac | riiiight | 02:33 |
| * thumper goes to look at them | 02:33 | |
| anastasiamac | thumper: i *think* we also still patch our own mgo at release time... would b great to know if 1.25.8 was patched as well.. | 02:35 |
| anastasiamac | i'd like to know the magic involved... | 02:35 |
| thumper | there was no change between 1.25.6 and 1.25.8 in that | 02:35 |
| anastasiamac | k | 02:35 |
| menn0 | thumper: alexisb has been trying migrations and is getting lots of precheck failures regarding machines not being running | 02:36 |
| menn0 | thumper: and this is with your fix | 02:36 |
| thumper | is she sure? | 02:36 |
| menn0 | thumper, alexisb: unless --build-agent didn't work? | 02:36 |
| menn0 | alexisb: to be really sure you're running the code you think you are: tear down the controllers, go install ./..., rebootstrap, try migrate again | 02:37 |
| thumper | only change in utils is different TLS cyphers | 02:37 |
| anastasiamac | thumper: :( | 02:38 |
| thumper | I don't use --build-agent | 02:38 |
| menn0 | thumper: you should, b/c otherwise when a release comes out and you haven't rebased/merged your work you end up bootstrapping with the released version | 02:38 |
| thumper | I'm careful to watch whether it uploads or not | 02:39 |
| natefinch | anyone know openstack? I seem to be getting different json back from it than goose expects | 02:42 |
| babbageclunk | menn0: Ta! | 02:42 |
| natefinch | nevermind, figured it out | 02:46 |
| anastasiamac | natefinch: \o/ | 02:46 |
| anastasiamac | thumper: did u see axw's last comment on https://bugs.launchpad.net/bugs/1587644 | 02:47 |
| mup | Bug #1587644: jujud and mongo cpu/ram usage spike <canonical-bootstack> <canonical-is> <eda> <performance> <juju:Triaged> <juju-core:Triaged> <juju-core 1.25:In Progress by axwalk> <https://launchpad.net/bugs/1587644> | 02:47 |
| anastasiamac | thumper: there is another bug in mgo that could b potentially biting us on both 1.25.x and 2.x, spiking cpu, etc... | 02:48 |
| thumper | axw: can I grab you for 10 minutes before the tech board? | 02:50 |
| anastasiamac | thumper: axw is on school rotation | 02:51 |
| anastasiamac | he wasn't going to tech board | 02:51 |
| thumper | he has to go to school? | 02:51 |
| anastasiamac | :) | 02:51 |
| anastasiamac | we all have to at some stage | 02:51 |
| thumper | menn0: can you read the go heap profile? | 02:51 |
| menn0 | thumper: no sorry, never tried | 02:52 |
| anastasiamac | menn0: r u still planning to discuss the topic m interested in at tech board? | 02:54 |
| anastasiamac | menn0: nm. i see minutes | 02:54 |
| menn0 | anastasiamac: recovering from mgo/txn corruption? | 02:54 |
| menn0 | yes | 02:55 |
| anastasiamac | menn0: k \o/ i might join later on in the meeting then! thnx | 02:55 |
| menn0 | anastasiamac: cool. do you want me to let you know when the topic comes up? | 02:56 |
| alexisb | ok I will try tearing down | 02:57 |
| alexisb | thumper, ^^^ | 02:57 |
| alexisb | if that doesnt work I will open a bug as it is not urgent | 02:57 |
| alexisb | what logs do you guys need if I need to open a bug? | 02:57 |
| anastasiamac | menn0: sure :) if u keen... | 03:00 |
| anastasiamac | u r* | 03:00 |
| menn0 | alexisb: the controller machine-0 logs at DEBUG level should do it | 03:00 |
| alexisb | k | 03:00 |
| thumper | bradm: I don't suppose I could get you to grab me a heap profile could you? | 03:08 |
| bradm | thumper: we can certainly make it happen, just fighting some stuff elsewhere - how do I do it? | 03:10 |
| thumper | bradm: let me find you the instructions | 03:10 |
| thumper | bradm: this is mostly accurate for the 1.25 code https://github.com/juju/juju/wiki/pprof-facility | 03:12 |
| thumper | see the heading of heap profile | 03:12 |
| thumper | I'm also interested in the goroutines | 03:12 |
| bradm | thumper: so which bits do you need? its a 56M file | 03:25 |
| thumper | bradm: unfortunately the whole thing | 03:50 |
| thumper | either private filestore or support files | 03:50 |
| thumper | gzipped probably a little smaller | 03:50 |
| bradm | yeah, definitely going to gzip | 03:51 |
| bradm | the goroutines is only 59k or something | 03:51 |
| thumper | babbageclunk: if you are adding start time to debug-log, can you add end time too? | 03:52 |
| thumper | babbageclunk: that is something I have wanted for quite some time | 03:52 |
| thumper | been meaning to get around to it | 03:53 |
| babbageclunk | thumper: not adding anything to the command at the moment. Also it's a bit more work - start time was already in LogTailer, but end time isn't. | 03:53 |
| babbageclunk | thumper: also, I've already done it! Maybe I'll cycle back and put end time in once I've done the rest of the restartable logtransfer stuff. | 03:54 |
| blahdeblah | thumper: I've picked up the task to get you the info you asked jacekn for in lp:1645729; I'm just pulling down his debug logs now - let me know if there's anything else you want other than unit counts. | 03:55 |
| thumper | blahdeblah: I think we're good for now, but my EOD | 04:06 |
| thumper | will continue tomorrow | 04:06 |
| blahdeblah | OK - will update the ticket in a sec | 04:06 |
| thumper | cheers | 04:09 |
| natefinch | lol @ openstack provider rejecting a 200 ok response with valid json | 04:11 |
| natefinch | because it requires a 300 Multiple Choices | 04:12 |
| natefinch | really? 300? geez people | 04:12 |
| natefinch | the best is the error message: "request (http://127.0.0.1:40020/) returned unexpected status: 200 error info: <valid json> | 04:15 |
| anastasiamac | jam: i've linked the PR in the bug :) | 04:42 |
| axw | wallyworld anastasiamac: I've added 2 new commits to https://github.com/juju/juju/pull/6623. main thing is adding a functional test for the statemetrics worker in the agent | 06:18 |
| axw | wallyworld anastasiamac: would appreciate your eyes on that bit in particular, in case you have an idea of how I can make it more of a unit test | 06:19 |
| wallyworld | ok | 06:20 |
| wallyworld | axw: the existing tests for other workers do nothing more than patch the worker.New and check that the worker is started, rather than anything functional | 06:22 |
| axw | wallyworld: yeah, that feels pretty dirty to me | 06:22 |
| wallyworld | it does | 06:22 |
| axw | trying to avoid patching | 06:22 |
| wallyworld | axw: there's maybe not a lot else you can do - i'd almost be inclided to more the test to featuretests | 06:24 |
| axw | wallyworld: I'll have a look at doing that. there is an instrospection suite there already, could piggy back on that | 06:25 |
| wallyworld | could do yeah, since it really is testing the moving parts al lworking together | 06:25 |
| anastasiamac | axw: i'll look a bit later but m happy to delegate if wallyworld is happy \o/ | 06:29 |
| axw | anastasiamac: one set of eyes is probably enough, thanks | 06:30 |
| anastasiamac | axw: :D it's also the quality of that set that gives me comfort :) | 06:33 |
| === frankban|afk is now known as frankban | ||
| axw | ermahgerd, out of ec2 instances again | 08:34 |
| mgz | axw: sorry, missed you last night. goose deps are hard coded in the merge job still, we probably need to make a dependencies.tsv at some point | 08:43 |
| mgz | for now, updated and tried merge again | 08:43 |
| axw | mgz: okey dokey. thank you | 08:43 |
| axw | mgz: are you able to delete an instance or two so http://juju-ci.vapour.ws:8080/job/github-merge-juju/9739/ can be retried too? | 08:43 |
| mgz | anda we're out of instances? I did manual cleanup on monday... | 08:43 |
| axw | mgz: seems so :( | 08:44 |
| mgz | having a look | 08:44 |
| mgz | okay, terminating about 50 in us-east-1 | 08:46 |
| axw | mgz: :o | 08:47 |
| axw | mgz: thanks | 08:47 |
| mgz | mostly ha-recovery, a couple of other things | 08:47 |
| mgz | axw: goos change merged | 09:04 |
| axw | mgz: yup, thanks. juju one to use it has now arrived :) | 09:04 |
| macgreagoir | frobware: ping | 09:22 |
| frobware | macgreagoir: hi | 09:23 |
| macgreagoir | HO? | 09:23 |
| jam | mgz: poke | 09:54 |
| mgz | jam: heya | 10:07 |
| mgz | can I get a stamp on https://github.com/juju/juju/pull/6602 please? | 10:19 |
| mgz | did the cherrypick of changes required for the utils bump, so should be good to go now | 10:19 |
| frobware | anybody running MAAS 2.1.1 and seeing DHCP occasionally failing? Answers some of my wtf moments today. | 10:23 |
| === iatrou_ is now known as iatrou | ||
| mgz | frobware: CI is still in 2.1.0 | 10:28 |
| frobware | mgz: ack | 10:28 |
| gnuoy | mgz, http://paste.ubuntu.com/23557786/ | 12:05 |
| mgz | thanks! | 12:05 |
| jam | mgz: standup? | 12:35 |
| === freyes__ is now known as freyes | ||
| * frobware lunches | 13:39 | |
| perrito666 | of course, the bug must be in the most complex patch :p | 14:12 |
| mgz | perrito666: can I bug you to be a second pair of eyes on a small good review? | 14:29 |
| perrito666 | sure | 14:30 |
| mgz | https://github.com/go-goose/goose/pull/37 | 14:30 |
| mgz | s/good/goose/ | 14:30 |
| mgz | good as well hopefully. | 14:31 |
| natefinch | mgz: goose is not good, but that's not your fault ;) | 14:32 |
| perrito666 | mgz: lgtm | 14:32 |
| mgz | perrito666: thanks! | 14:33 |
| === cmars` is now known as cmars | ||
| perrito666 | bbl, errand | 14:53 |
| === icey is now known as Guest28168 | ||
| natefinch | so... we're supposed to branch off staging and then PR onto develop, right? | 16:19 |
| mgz | natefinch: ideally, but that's not realistic at present | 16:21 |
| natefinch | well, even ideally it doesn't actually work | 16:21 |
| natefinch | like, if there's any kind of conflict, you just have to rebase onto develop and fix the merge conflict | 16:22 |
| natefinch | so, might as well just branch off develop anyway | 16:23 |
| gnuoy | mgz, fwiw I've put up pull requests for juju 1.25 and 2.0 to update deps. The Jenkins job has failed due to the http://paste.ubuntu.com/23557786/ compat bugs | 16:24 |
| mgz | gnuoy: right, we're going to need to bundle those changes into the juju code along with the dep update | 16:25 |
| gnuoy | mgz I'm happy to update my pull requests | 16:25 |
| mgz | but I'd generally start with the (off develop) dep bump for 2.1 | 16:25 |
| mgz | either way around is fine | 16:26 |
| mgz | I've not sent email yet about compat breakage, but just fixing for 1.25 seems okay | 16:26 |
| perrito666 | mgz: that will never work, git does not work the way whoever wrote that thinks it works | 16:28 |
| mgz | perrito666: which bit in particular? | 16:29 |
| mgz | the branch from develop, merge to staging? | 16:30 |
| perrito666 | branches must return to their source | 16:30 |
| perrito666 | yes | 16:30 |
| mgz | it technically can work, but requires a bunch of discipline | 16:30 |
| perrito666 | mgz: not really, there is no amount of discipline that can make a branch diverged enough merge cleanly | 16:30 |
| mgz | perrito666: the point is diversion should really be only a day or twos worth of commits | 16:31 |
| mgz | and if you get a bad set you roll the lot back | 16:31 |
| perrito666 | you could make it a bit better by forcing anyone to squash their commits and even then the conflicts you solve are useless if all of the commits dont do it to staging | 16:31 |
| perrito666 | I bet there is no actual practical reason for that (there actually is no gain in the process as it is suggested) | 16:32 |
| perrito666 | if we all squashed our commits (that would give you roughly 2 commits per feature) you can remove the offending commit only without altering much the rest | 16:34 |
| natefinch | I thought we had agreed to squash commits? if we also had the bot do a squash & merge, it could be exactly one commit per feature. | 16:45 |
| perrito666 | that would be glorious, things like git bisect would work properly for instance | 16:50 |
| === icey_ is now known as icey | ||
| redir | brb reboot | 17:33 |
| === frankban is now known as frankban|afk | ||
| frobware | rick_h: bonding - I wonder if an up-front limitation is that we have is... if you're using bonds then you need to B-A-T (bridge-ahead-of-time) via MAAS. Otherwise all I can guarantee is that at somepoint the machine will wedge with ifdown/up | 18:04 |
| frobware | macgreagoir: ^^ | 18:04 |
| frobware | rick_h: I just spent all the afternoon watching it fail in subtle ways. macgreagoir is my witness. :) | 18:05 |
| frobware | rick_h: generally, bridging vlans, aliases, and non-bonded interfaces seems OK | 18:05 |
| frobware | jam: ^^ | 18:06 |
| rick_h | frobware: +1 | 18:06 |
| frobware | rick_h: it seems I could spent the rest of my days trying to make this work. it seems fundamentally racy. | 18:07 |
| natefinch | lol, of course, I added checks to ensure that endpoints represent real clouds, and now all my unit tests fail because - tada - they weren't adding real clouds. | 18:13 |
| natefinch | (where all == 4, but still) | 18:14 |
| natefinch | (and where unit == full stack, obv) | 18:15 |
| rick_h | frobware: full support of that being maas driven | 18:44 |
| frobware | rick_h: I need to take a step back and ensure what we have in 2.0.2 actually works on the node I'm using. Having said that, the new stuff we did see working today but the ratio of good:bad is like 1:50. | 18:45 |
| frobware | rick_h: and when you get it wrong systemd graciously spends 5 minutes trying to bring up the interfaces (which fails) before you get to a login prompt. Grrr. | 18:45 |
| frobware | rick_h: ifupdown is not happy in the modern world. | 18:46 |
| frobware | rick_h: and I haven't tested at all on trusty. different kernel, different ... fun. | 18:47 |
| * frobware heads to the pub. | 18:48 | |
| natefinch | oh, external tests, you are the worst | 19:02 |
| katco | need some assistance figuring out what has failed: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9743/ | 19:56 |
| katco | i see some things which might be an issue in lxd-err.log? but that's about it? | 19:57 |
| katco | trusty-out.log is impossible to scan now | 19:57 |
| natefinch | katco: console output says lxd failed | 20:08 |
| natefinch | katco: the output in lxd-err.log is pretty hard to read, but I see "error: controller merge-juju-lxd not found" | 20:08 |
| natefinch | oh wait, that's the just in case cleanup, it should fail, that's ok | 20:09 |
| katco | natefinch: i am a bit stumped | 20:09 |
| natefinch | katco: I guess the exception at the end there... seems like printing out the stack trace is extraneous | 20:10 |
| natefinch | Command '('juju', '--debug', 'bootstrap', '--constraints', 'mem=2G', 'lxd/localhost', 'merge-juju-lxd', '--config', '/tmp/tmpsoEIYE.yaml', '--default-model', 'merge-juju-lxd', '--agent-version', '2.1-beta2', '--bootstrap-series', 'xenial')' returned non-zero exit status 1 | 20:10 |
| natefinch | ahh here we go: | 20:11 |
| natefinch | 19:33:59 ERROR cmd supercommand.go:458 failed to bootstrap model: cannot start bootstrap instance: unable to get LXD image for ubuntu-xenial: Error adding alias ubuntu-xenial: already exists | 20:11 |
| katco | natefinch: sounds spurious? | 20:11 |
| katco | balloons: ^^ ? | 20:11 |
| natefinch | sounds like we don't have code in the test to handle this codepath where the image already exists. | 20:12 |
| natefinch | or rather, I guess that's a Juju message | 20:13 |
| katco | natefinch: not sure why this commit is triggering this though | 20:13 |
| natefinch | katco: no clue | 20:13 |
| katco | sinzui: balloons: mgz: any idea if the CI environment is to blame here? | 20:15 |
| sinzui | katco: that is lxd | 20:15 |
| sinzui | katco: I have seen it from time to time over the year | 20:16 |
| katco | sinzui: should i just requeue? | 20:16 |
| sinzui | katco: yes | 20:16 |
| katco | sinzui: ta | 20:16 |
| balloons | ty sinzui | 20:17 |
| balloons | and that's annoying :-( | 20:17 |
| thumper | blahdeblah: you around? | 20:35 |
| natefinch | rick_h, alexisb: I think that SSL issue might be the openssl version (yay dependencies) | 20:36 |
| natefinch | rick_h, alexisb: http://stackoverflow.com/questions/38489767/ssl-error-on-python-request | 20:36 |
| rick_h | natefinch: rgr | 20:37 |
| blahdeblah | thumper: I shouldn't be, but... | 20:45 |
| thumper | blahdeblah: if you shouldn't be, then don't be | 20:46 |
| blahdeblah | thumper: Well, now that I'm here, what's up? :-) | 20:46 |
| thumper | blahdeblah: mup tells me that it is very early for you, is that right? | 20:46 |
| blahdeblah | nah - not a big deal | 20:47 |
| blahdeblah | been up for about 4 hrs already :-\ | 20:47 |
| thumper | blahdeblah: yesterday bradm got a heapprofile from a misbehaving apiserver process for me, but hasn't passed on details... | 20:47 |
| thumper | wat? | 20:47 |
| thumper | seriously? | 20:47 |
| blahdeblah | Long story | 20:48 |
| thumper | blahdeblah: was wondering if I could get a heapprofile from the apiserver (hopefully not too soon after restarting) | 20:48 |
| thumper | to see if we can work out where the leak is | 20:48 |
| thumper | details of getting the heap profile from 1.25 are documented here https://github.com/juju/juju/wiki/pprof-facility | 20:48 |
| blahdeblah | The one bradm was working on was an OpenStack, IIRC | 20:48 |
| blahdeblah | Different from the env I gathered data for yesterday | 20:49 |
| thumper | yeah, a different environment, but showing similar problems | 20:49 |
| blahdeblah | thumper: I can gather that from our environment later today. | 20:54 |
| thumper | blahdeblah: thanks | 20:54 |
| alexisb | rick_h, ping | 21:03 |
| natefinch | it is just me, or is calling strings.TrimSpace on someone's password a bad idea? | 21:21 |
| menn0 | natefinch: seems like a problem | 21:21 |
| babbageclunk | natefinch: I mean, it doesn't seem like a *good* idea. | 21:21 |
| natefinch | reminds me of a website, I forget which, that just truncated your password if it was too long | 21:22 |
| babbageclunk | nice | 21:24 |
| natefinch | wallyworld: are you on yet? | 21:38 |
| wallyworld | somewhat | 21:38 |
| natefinch | wallyworld: can you explain what this comment means? https://github.com/juju/juju/blob/staging/cmd/juju/cloud/addcredential.go#L330 | 21:39 |
| wallyworld | for now, we don't support allowing the user to type in a multi-line attribute - they only have the option of specifying a filepath to a file which contains the attribute | 21:40 |
| wallyworld | the concrete case for that is the GCE credential info from memory | 21:41 |
| natefinch | wallyworld: but what does that have to do with the line below it? | 21:43 |
| natefinch | wallyworld: also, it looks like if that if statement is false, then we do validation against value which hasn't been set? | 21:44 |
| wallyworld | give me a minute to read the code | 21:44 |
| wallyworld | that comment block looks like it's a general statement about what's supported for credential attr entry in the code block below in the entire loop, rather that specifically the line of code just below | 21:46 |
| wallyworld | so the location of the comment is a bit crap | 21:47 |
| natefinch | oh ok, that makes a lot more sense :) | 21:47 |
| wallyworld | sorry | 21:47 |
| natefinch | I'm in that code, so I can add a blank line to make it more obvious | 21:47 |
| wallyworld | ty | 21:47 |
| wallyworld | or move it outside the loop or something | 21:48 |
| natefinch | yeah | 21:48 |
| wallyworld | sad when you comment code and then need to explain the comment | 21:48 |
| natefinch | heh | 21:48 |
| babbageclunk | man, I really don't like the code font they've started using on golang.org. | 21:49 |
| natefinch | heh... I use it in my editor | 21:49 |
| natefinch | It did take a little getting used to, but I stopped noticing it after the first half hour | 21:51 |
| natefinch | bbl | 21:56 |
| === natefinch is now known as natefinch-afk | ||
| babbageclunk | menn0, thumper, anyone else: review please? https://github.com/juju/juju/pull/6641 | 22:10 |
| redir | babbageclunk: looking | 22:19 |
| babbageclunk | redir: thanks! | 22:19 |
| perrito666 | axw: ping | 23:19 |
| alexisb | perrito666, I have him occupied atm | 23:21 |
| * perrito666 imagines axw cutting the lawn on alexisb house | 23:21 | |
| alexisb | perrito666, that takes a tractor and several days | 23:22 |
| menn0 | thumper: Fix for migration of charms with ~user component: https://github.com/juju/juju/pull/6642 | 23:24 |
| * thumper looks while being in a call | 23:24 | |
| babbageclunk | menn0, thumper: can one of you look at https://github.com/juju/juju/pull/6641 | 23:39 |
| babbageclunk | menn0, thumper: redir likes it but it could do with some migrationy eyes too | 23:40 |
| menn0 | babbageclunk: will look after standup | 23:41 |
| axw | perrito666: cutting lawn?? (I barely cut my own, it's a mess) | 23:50 |
| perrito666 | axw: I pay someone to do it because I dont own a big enough machine :( | 23:50 |
| axw | such things can be purchased ;) but here service-to-hardware ratio is probably higher | 23:51 |
| perrito666 | yep, over 500USD for the machine and under 15 for the cut | 23:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!