/srv/irclogs.ubuntu.com/2016/12/01/#snappy.txt

mupPR snapcraft#937 opened: Incorporate all part properties into state tracking <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/937>00:53
josharensonWhen I run refresh-bits ala git@github.com:zyga/devtools, I get an error about not having systemd installed? (running zesty)01:18
mupBug #1646333 opened: bind mounts related to content interface plugs remain stale on snap disconnect/connect or snap updates <Snappy:New> <https://launchpad.net/bugs/1646333>03:46
mupPR snapd#2391 opened: Discard mount namespace on a content i/f plug connect/disconnect <Created by albaguirre> <https://github.com/snapcore/snapd/pull/2391>03:53
=== chihchun_afk is now known as chihchun
=== Ian|zh_CN is now known as IanLi-AFK
foxmaskbonjello07:38
mupPR snapd#2390 closed: tests: do not use external snaps <Created by fgimenez> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/2390>07:57
dholbachhey hey07:57
zygao/07:57
seb128hey dholbach zyga, how are you?07:58
dholbachsalut seb12807:59
dholbachdoing all right - how about you?07:59
seb128I'm good thanks :-)07:59
zygaseb128: hey, I'm good :-) how are you?08:49
seb128zyga, I'm good thanks ;-)09:07
tsdgeosguys, snapcraft should never use one of my libs from /usr to end up in the snap but instead use the libs from the .deb files it downloads, no?09:32
kalikianaI would intuitively expect the .deb files to take priority09:35
tsdgeosbecause i think i found a case in which is not happening09:36
tsdgeoswhich i have to say was unexpected09:36
Chipacatsdgeos: that's a bug09:38
Chipacatsdgeos: without knowing the details I can't say whether it's a bug in snapcraft, or in your yaml09:38
tsdgeosChipaca: how would the yaml make that happen?09:41
Chipacatsdgeos: if the lib needed isn't in the deb you download (or maybe even if it's in the deb but needs the library path tweaked by postinst)09:42
tsdgeosok09:44
mupBug #1646415 opened: cannot run configure hook <Snappy:New> <https://launchpad.net/bugs/1646415>09:45
mupBug #1646415 changed: cannot run configure hook <Snappy:Invalid> <https://launchpad.net/bugs/1646415>09:48
mupPR snapd#2392 opened: partition: add support for native grubenv read/write and use it <Created by mvo5> <https://github.com/snapcore/snapd/pull/2392>10:43
caio1982ng11:02
caio1982good morning11:02
zygahey caio198211:02
grigiohi, I get ❯ env LANG=C ./electron-quick-start  ./electron-quick-start: line 6: cd: /lib/node_modules/electron-quick-start: No such file or directory ./electron-quick-start: line 7: /bin/npm: No such file or directory11:11
grigioI tried this example http://bazaar.launchpad.net/~3v1n0/+junk/electron-quick-start-snap/files11:12
renato__mvo, hi, could you approve this MR? https://myapps.developer.ubuntu.com/dev/click-apps/6062/rev/21/11:19
mvorenato__: sure11:26
renato__mvo, thanks11:27
mupPR snapd#2393 opened: interfaces/apparmor: use distinct apparmor template for classic <Created by zyga> <https://github.com/snapcore/snapd/pull/2393>11:45
mupPR snapd#2372 closed: interfaces/seccomp: add support for classic confinement <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/2372>11:52
=== __alecu__ is now known as alecu
renato__mvo, could you approve two more packages: https://myapps.developer.ubuntu.com/dev/click-apps/6019 rev 7 and 813:00
renato__mvo, same for address-book-app: https://myapps.developer.ubuntu.com/dev/click-apps/6010 rev 19 and 2013:12
ondraogra_ ping13:21
ogra_hey ondra13:21
ondraogra_ hi, this would be simple one, in shell script, what is best reliable way to detect app is running as snap?13:22
ogra_hmm ... check the path of the binary ?13:23
ogra_something like that13:23
ogra_there is a bunch of $SNAP_ variables you could look for13:23
ondrahow about check is SNAP_COMMON exist?13:23
ogra_SNAP_NAME or SNAP_VERSION ....13:23
ondraogra_ is it something we will keep for foreseeable future?13:24
ogra_i guess so13:24
ondraogra_ OK, then I will stick to those :)13:24
ondraogra_ cheers!13:24
ogra_install hello-world, run hello-world.sh ...13:24
ogra_then check the env13:24
ogra_(or there is even a hello-world.env i think)13:25
ondraogra_ yeah there is13:25
mvojdstrand, renato__: I approved https://myapps.developer.ubuntu.com/dev/click-apps/6010/ - what is needed to make this automatic?13:31
renato__mvo,  I know that jdstrand is working on it. I am not sure about the status13:32
mvorenato__: aha, sure, thats fine then13:32
renato__mvo, could you approve 6019 too?13:33
mvorenato__: I did, didn't i?13:34
renato__mvo, no still blocked13:34
mvorenato__: oh, you are right13:36
renato__mvo, thanks13:36
iceyshould I push a BS commit to trigger the autopgktests on this again, or maybe merge in master for the commit to get the fix from master? https://github.com/snapcore/snapcraft/pull/90813:49
mupPR snapcraft#908: Let Rust plugin fetch dependencies in pull <Created by ChrisMacNaughton> <https://github.com/snapcore/snapcraft/pull/908>13:49
renato__mvo, sorry to keep disturbing you, but 6019 rev 9 still blocked :(13:49
jdstrandrenato__ (cc mvo): you need to request a manual review13:51
jdstrandrenato__: it doesn't show up in the list unless you do that13:51
renato__jdstrand, humm sorry I miss this one13:52
jdstrandrenato__: and the person who pushes that button can't then approve it13:52
jdstrand(so it can't be us)13:52
jdstrandmvo: I handled it13:52
renato__thanks13:52
jdstrandrenato__: done13:52
mvojdstrand: thanks, was in a meeting14:00
=== mup_ is now known as mup
flexiondotorgsergiusens, kyrofa I've discovered a bug with source-type: deb14:12
flexiondotorgWant to find out if it is known.14:12
flexiondotorgIf you use a deb as source and that deb has sym-links in it, the link names are created as directories in the snap.14:13
flexiondotorgIn my use case the binary is trying to load a lib which is effectively doesn't exist.14:14
=== chihchun is now known as chihchun_afk
mupPR snapd#2394 opened: snap: show last update time <Created by mvo5> <https://github.com/snapcore/snapd/pull/2394>14:23
mupPR snapcraft#938 opened: store: return specific error when already owned <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/938>14:26
=== jamespag` is now known as jamespage
alex-abreumvo, could you comment on https://github.com/snapcore/snapweb/pull/101 ?14:32
mupPR snapweb#101: replace find vs findone <Created by AlexandreAbreu> <https://github.com/snapcore/snapweb/pull/101>14:32
mupPR snapd#2395 opened: make state and squashes immutable when appropriate <Created by chipaca> <https://github.com/snapcore/snapd/pull/2395>14:36
mvoalex-abreu: let me have a look14:39
timpjdstrand: hello, I have a question about this bug https://bugs.launchpad.net/ubuntu-ui-toolkit-examples/+bug/164537714:47
mupBug #1645377: AppArmor policy error for networking at initialization, even with the correct network plug. <snapd-interface> <Snappy:Invalid> <ubuntu-ui-toolkit-examples:New> <https://launchpad.net/bugs/1645377>14:47
timpjdstrand: that app just wants to download something from internet, for that it should not need to use the network-manager interface right?14:48
timpany ideas why it currently needs that?14:48
renato__popey, hey, could you review this? https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/unity8-snap/+merge/31226014:54
timprenato__: why do you need unity7 and unity8?14:56
renato__timp, the unity8 session that tedg is working needs unity8 interface.  And unity7 is to keep it compatible with unity714:57
timprenato__: ah, ok. Will we need to add unity8 to all GUI apps?14:59
renato__timp, I think so14:59
timprenato__: hmm.. and all GUI apps also need opengl I guess. So maybe we should find out if it is possible for [platform] to also imply [opengl, unity7, unity8]15:00
timpI don't know if it would work if we simply add those plugs to the ubuntu-app-platform snap.15:00
timpsergiusens: ^how would we do that?15:02
renato__timp, I am not sure about that. I think that is ok to explicitly say which interface you app request. S15:02
renato__timp, and some apps can be ready only for unity715:02
timprenato__: but if you use the platform snap, you'll need all those plugs15:03
renato__timp, some apss can uses plataform and does not have any ui15:03
timprenato__: ah, that's true.15:03
timphmm15:03
timpwell the core of the platform (at least the dependencies that we put in there first) is the UITK15:03
renato__timp, i can have a app that only uses qtcore or network, etc..15:04
timphmm15:04
timpyeah15:04
timpbut would you use the platform snap then? Platform has a lot more than just qt.15:04
timpbut if you don't want to compile qt, then currently the platform snap is what you need to use.15:04
renato__timp, if the plataform is part of the system already. I do not see why not use that15:04
timpThat really depends on the use case.15:07
renato__if I have a gadget that only runs my app problably I can pack qt on it.15:07
timpyes15:07
timprenato__: ok. We can leave it as it is for now then :)15:07
renato__popey, one more: https://code.launchpad.net/~renatofilho/ubuntu-clock-app/unity8-snap/+merge/31226315:09
jdstrandtimp: you are right, it shouldn't need network-manager. It is (almost certainly) only accessing network-manager to see if the network is available. this is a very longstanding conversation regarding Qt and network-manager and is precisely why connectivity-api was developed. see bug #134154815:13
mupBug #1341548: Online detection does not work with confined apps on Nexus 4 <rtm14> <touch-2014-08-21> <Dekko:Fix Released by dpniel> <Network Menu:Fix Released by kaijanmaki> <apparmor-easyprof-ubuntu (Ubuntu):Fix Released by jdstrand> <connectivity-api (Ubuntu):Fix Released by kaijanmaki>15:13
mup<indicator-network (Ubuntu):Fix Released by kaijanmaki> <connectivity-api (Ubuntu RTM):Fix Released by kaijanmaki> <indicator-network (Ubuntu RTM):Fix Released by kaijanmaki> <https://launchpad.net/bugs/1341548>15:13
timpjdstrand: so I will be required to use connectivity-api whenever I access the network, even when I use the [network] plug already?15:17
timpin which channel should I ask about snap store reviews and automatic publishing of LP projects to the store?15:24
timpmaybe here?15:24
ogra_here :)15:25
timpOk. :) I configured https://launchpad.net/~ubuntu-sdk-team/+snap/ubuntu-ui-toolkit-examples to automatically upload a snap on the edge channel in the store, but on https://myapps.developer.ubuntu.com/dev/click-apps/6427/rev/3/ it appears in the Release channel15:25
timp^is that a bug?15:25
zygarenato__: no idea, sorry15:25
zygarenato__: did you trace the calls from that failure back to base policy?15:25
timpignore my question. It was already answered somewhere else <noise> timp: that's not a channel name, that's the action button to release it into channels15:26
ogra_heh15:26
ogra_i was about to ask what you mean with release channel15:26
zygaogra_: new channels, there's one every weekend ;)15:27
zygamatrix keeps changing15:27
ogra_heh15:27
timpogra_: right :)15:27
timpwho can I kick to review the ubuntu-ui-toolkit-examples snap in the store?15:28
sborovkovHello. snap store seems to be very slow. I get constant timeouts when clicking on revision? Any idea what's up with it?15:28
jdstrandtimp: if your app is trying to check if the network is available, it will need to plugs something else, yes. if it is using network-manager, it needs to plugs network-manager (that will require a snap interface manual connect), if it is using connectivity-api, it needs to plugs it (that will be auto-connected)15:30
jdstrandtimp: note that connectivity-api interface isn't available yet. it is part of the Ubuntu Personal work. I don't know the status15:30
timpjdstrand: so if you use network you will always need network-manager or connectivity-api?15:31
jdstrandzyga: fyi, you mentioned not looking for other occurences of the i2c bug. I just did. i2c is the only thing not using utils.go and utils.go is fine15:31
timpI assume when you use the network, it will check whether that's available.15:31
jdstrandtimp: plenty of apps need only 'plugs: [network]'. your app is trying to be smart and as a result it needs to plugs something else15:32
jdstrand(in addition to network)15:32
zygajdstrand: good to know, thank you15:33
jdstrandtimp: in Ubuntu Touch, we put connectivity-api in the network policy group. the core snap does not have the connectivity-api daemon in it, so it will be provided via a snap. as such, you will need to 'plugs: [network, connectivity-api]' on snappy (whenever connectivity-api is available)15:33
zygajdstrand: I'm iching to rewrite interfaces internally as we discussed, maybe over xmas :)15:33
zygaitching*15:33
jdstrandzyga: heh, please make sure that the policy remains easily auditable within the codebase. that's all tyhicks and I are asking :)15:34
timpjdstrand: This is the full app http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/examples/jokes/jokes.qml15:35
zygajdstrand: as agreed :)15:35
timpIt does not seem to do anything smart, I guess the XMLHttpRequest(); does that then.15:35
zygajdstrand: I'd definitely do that to ensure my sanity :)15:35
timpI'm just thinking how to make it easy for developers to use that.15:35
timpI don't know the details of what the XMLHttpRequest object does, just trying to snap the UITK examples.15:36
jdstrandtimp: if this is for qtubuntu apps, seems reasonable to default the snapcraft.yaml to use 'plugs: [network, connectivity-api]' just like for click it use '"policy_groups": ["network"]'15:37
jdstrandtimp: in the sdk15:37
timpjdstrand: yes, it is a qtubuntu app (using the ubuntu-app-platform snap) with "network" int he policy groups.15:40
timpjdstrand: I'll add a note in my snapcraft.yaml to add that when the connectivity-api is done. Let's see if I can find the bug for that.15:41
Odd_Blokeogra_: Still looking at this week for that Azure bug?15:47
ogra_Odd_Bloke, bug 1639878 ?15:48
mupBug #1639878: pc-kernel.snap missing drivers necessary for Hyper-v <Snappy:Fix Committed by ogra> <https://launchpad.net/bugs/1639878>15:48
Odd_Blokeogra_: Yep.15:48
ogra_(new kernel snap is in edge with the modules included)15:48
Odd_BlokeOh, I must not be subscribed, I hadn't seen updates.15:48
Odd_BlokeFail.15:48
ogra_not sure when the next release is planned though ... mvo might know15:49
ogra_then it should hit stable15:49
mvoogra_: next release is next thursday15:51
mvoOdd_Bloke: -^15:51
ogra_:)15:51
Odd_BlokeCool, thank you both!15:52
mvoogra_: I think we can bump the kernel to beta now (if it booted) and then I can ask qa to test it15:52
ogra_mvo, yeah, though we are missing an updated rpi2 one it seems15:53
ogra_dragon and pc broth had updates since my vacation15:53
ogra_pi not15:53
mvook15:54
ogra_not sure what keeps it in proposed ... ppisati ?15:54
ogra_but we can indeed push the others up to beta15:54
mvoogra_: thank you!15:57
alex-abreumvo, btw this wont be added back to 2.18 right ? https://github.com/snapcore/snapd/pull/239415:58
mupPR snapd#2394: snap: show last update time <Created by mvo5> <https://github.com/snapcore/snapd/pull/2394>15:58
mvoalex-abreu: correct, this is targeted for 2.1915:59
alex-abreumvo, ok thx15:59
mvo(which is just one week away :)15:59
alex-abreumvo, even better thx :)15:59
mupPR snapd#2396 opened: tests: fix incorrect restore of the current symlink <Created by mvo5> <https://github.com/snapcore/snapd/pull/2396>16:31
zygajdstrand: can you join a call about classic confinement and the store now?16:32
kyrofaflexiondotorg, just ANY symlink?16:34
kyrofaflexiondotorg, not known by me anyway16:34
kyrofaflexiondotorg, ah, wait, LP: #163481316:35
mupBug #1634813: Symbolic links inside .deb pulled as directories <sources> <Snapcraft:Confirmed> <https://launchpad.net/bugs/1634813>16:35
flexiondotorgkyrofa, Yep, that is the issue.16:35
flexiondotorgI'll subscribe to that.16:35
flexiondotorgI've got a fix in progress.16:36
kyrofaflexiondotorg, thanks for the poke. Ah! You know what the issue is?16:36
flexiondotorgkyrofa, The issue is apt_install.extractall() doesn't do the right thing.16:36
flexiondotorgThe Tar() class in internal/sources.py does the right thing, so can be the basis of a fix.16:37
kyrofaGood deal. Happy to investigate if you're short on time, let me know?16:37
flexiondotorgWell, I'll be leaving the office in a bit.16:38
kyrofaflexiondotorg, alright I'll take a look once I'm done with my current PR16:39
flexiondotorgkyrofa, Thanks.16:39
flexiondotorgI'm just finishing something else too.16:39
kyrofaflexiondotorg, thanks for the pointers :)16:40
flexiondotorgIn the Tar() class you'll see the _extract() method. That is what I was going to reimplement for the Deb() class.16:40
bitpushrHowdy all - setting up snappy, however the key on my ubuntu one account was dsa - and I can't SSH in with it because it is a rejected protocol. Anyway to trigger the snappy device to redownload my ssh public keys?16:44
bitpushr(without logging in or running a fresh install)16:45
kyrofaogra_, do you know the answer to that question? ^^16:50
ogra_nope16:57
ogra_i saw the question before ... have never used a dsa key16:57
ogra_(i think someone asked the same at the beginning of the week)16:57
ogra_kyrofa, sounds more liek a question to some store person :)16:59
ogra_*like16:59
kyrofaogra_, indeed, thank you. nessita, are you around?17:00
kyrofamvo, you might be able to help with that as well. Is there any way to trigger Ubuntu Core to re-download SSH keys? 1) as a logged in user, and 2) without being able to login?17:01
nessitakyrofa, around otp, could you repeat the question?17:08
jdstrandniemeyer: can you meet now for snap decl talk>?17:10
niemeyerjdstrand: Yep, is your mic working agian?17:10
niemeyerhttps://hangouts.google.com/hangouts/_/canonical.com/base-declaration17:10
jdstrandniemeyer: I'll get it to work. can you start a new hangout and I'll join?17:10
jdstrandok17:10
jdstrandniemeyer: it says I am the first to join17:12
kyrofanessita, sure thing-- bitpushr had a dsa key on his SSO, so when Ubuntu Core fetched the keys that's all it got, and it doesn't work. If he's since uploaded an rsa key, do you know if there's a way to re-trigger the key download?17:12
nessitakyrofa, hum, I have no idea, the store is not involved in that part17:22
nessitaother than providing an API to get all the public sshs for an emai;17:22
nessitaemail*17:22
kyrofanessita, yeah, me neither :( . Alright, thanks for your time!17:23
nessitakyrofa, :-)17:33
bitpushrkyrofa: you have same issue?17:33
pedroniskyrofa: refreshing keys is still a TODO afaik17:33
kyrofabitpushr, I'm afraid not, I use rsa keys17:33
bitpushrIt would be a good idea to refresh them on boot at least17:34
bitpushrI thought it might but it does not17:34
kyrofapedronis, so what is the path forward. A reinstall?17:34
pedronisI don't know17:34
bitpushrNo worries, but I would like to put that in as a feature request. Would also help handle expired keys, updated keys, etc17:35
bitpushrThis was an old key I had17:35
sergiusensflexiondotorg will look into it17:35
sergiusensflexiondotorg but we are using the python deb extraction implementation17:36
renato__jdstrand, could you approve messaging-app package in the store: https://myapps.developer.ubuntu.com/dev/click-apps/6192 rev 4 e 517:41
pedronisbitpushr: I created this https://bugs.launchpad.net/snappy/+bug/164655917:45
mupBug #1646559: should periodically refresh ssh keys that were obtained from SSO/store for local users <Snappy:New> <https://launchpad.net/bugs/1646559>17:45
mupBug #1646559 opened: should periodically refresh ssh keys that were obtained from SSO/store for local users <Snappy:New> <https://launchpad.net/bugs/1646559>17:45
bitpushrThank you pedronis18:00
jdstrandrenato__: looking now. sorry was in meetings18:07
renato__jdstrand, np. thanks18:12
zygatyhicks, jdstrand: https://github.com/snapcore/snap-confine/pull/19918:40
mupPR snap-confine#199: Add error support code <Created by zyga> <https://github.com/snapcore/snap-confine/pull/199>18:40
zygathis is a prelude to https://github.com/snapcore/snap-confine/commit/f7ee6df44916109731ce8a611ff57d9a70954b5618:41
zygaand on top a small patch that adds --classic support18:42
mupPR snapcraft#900 closed: ftp source support <Created by 3v1n0> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/900>18:44
zygawhich is https://github.com/snapcore/snap-confine/commit/6f289caa3a7adcfcedef25c13378fb9bd5de2f9518:47
mupPR snapcraft#939 opened: Replace coveralls with codecov <Created by elopio> <https://github.com/snapcore/snapcraft/pull/939>18:47
zygaI got a +0.5 from mvo on telegram, I'd love a review from you18:47
zygaone more branch and I'll switch to that for parsing command line18:47
zygaand then (no-op) classic can be dput to a image ppa18:48
mupPR snapd#2387 closed: asserts: introduce auto-aliases header in snap-declaration <Critical> <Created by pedronis> <Merged by niemeyer> <https://github.com/snapcore/snapd/pull/2387>18:48
mupPR snapd#2396 closed: tests: fix incorrect restore of the current symlink <Created by mvo5> <Merged by niemeyer> <https://github.com/snapcore/snapd/pull/2396>18:51
mupPR snapd#2369 closed: snap: disable support for socket activation <Created by stolowski> <Merged by niemeyer> <https://github.com/snapcore/snapd/pull/2369>18:52
mupPR snapcraft#940 opened: Implement delta uploads in push <Created by squidsoup> <https://github.com/snapcore/snapcraft/pull/940>19:26
alex-abreuniemeyer, do you have an update on the snapd-control & install/connect issue for local snaps?19:58
jdstrandalex-abreu (cc niemeyer): we had a meeting today. we are getting close to having an answer20:02
alex-abreujdstrand, ok it will be backported to 2.18 right ?20:03
jdstrandalex-abreu: that is the intent, yes20:03
alex-abreujdstrand, thank you, ... any eta?20:04
jdstrandalex-abreu: well, no since we don't have the answer yet20:04
jdstrandbut getting there. once we've worked through the answer, someone will send something to the list20:05
alex-abreujdstrand, ok, ... thank you20:05
iceyis there anny chance of (non-root) installable snaps?20:05
kyrofaicey, probably not, at least not in the near future20:09
tedgjdstrand: Are the snap confine tools closing all the file descriptors?21:30
tedgjdstrand: Trying to pass one through and it's not making it...21:30
zygajdstrand: hey21:37
jdstrandtedg: not that I can see21:37
zygajdstrand: wow, you are here :)21:37
tedgjdstrand: Hmm, okay, must be messing something else up :-)21:38
zygatedg: no, but remember there are snap-run snap-exec there as well21:38
zygatedg: being in go they may do that in the runtime21:38
zygatedg: can you show me a reprouction test case?21:38
tedgUhg, yeah.21:38
tedgNot really right now, I have things heavily modified to recreate it.21:38
zygajdstrand: hey, is there a chance for you to look at https://github.com/snapcore/snap-confine/pull/199 today21:38
mupPR snap-confine#199: Add error support code <Created by zyga> <https://github.com/snapcore/snap-confine/pull/199>21:38
zygatedg: even a small test case I can run locally would be great21:39
zygatedg: e..g something hacked in shell21:39
tedgzyga: Let me chase down a couple other threads first, might be me screwing things up as well.21:40
mupBug #1646625 opened: on first boot rpi2 cannot configure (core16) <Snappy:New> <https://launchpad.net/bugs/1646625>21:41
zygatedg: that's ok, it's pretty late for me anyway, if you share something I can tinker with I'll try to help you out tomorrow21:41
jdstrandzyga: looking at that PR I would want to spend some time with it (more than I have this afternoon). I can look at it first thing tomorrow21:42
jdstrandzyga: if you need it sooner, perhaps tyhicks could look at it, but I don't know what he has going on21:42
zygajdstrand: thanks, if you want more context look at https://github.com/snapcore/snap-confine/branches (specifically https://github.com/snapcore/snap-confine/tree/arguments )21:42
zygahttps://github.com/snapcore/snap-confine/commit/a84be35d70be79b6f92dd192d40a82f6f071785621:43
zygathis patch21:43
jdstrandzyga: what is the motivation of this patch?21:46
tyhickszyga: hey - those look a little more like code churn than a PR that we should drop other stuff and review today21:46
tyhicksmaybe I'm missing something21:47
tyhicks(it is really nice to have non-fatal error message handling)21:48
zygatyhicks: it's okay, you don't have to review it today21:48
jdstrandtyhicks: well, fatal message handling has the nice benefit that you know you fail closed21:48
zygajdstrand: argument parsing is going to grow a little and I didn't want to add more hackery to main()21:48
zygajdstrand: and I wanted to write code that can follow one style of error handling and die()/death in proper places21:49
tyhicksjdstrand: that's true21:49
zygajdstrand: and lastly I wanted something that can be unit tested a little bit better21:49
jdstrandzyga: what arguments are being added?21:49
zygajdstrand: --classic21:49
zygajdstrand: but I be we'll need more soon21:49
zygajdstrand: e.g. --base to switch base snaps21:49
zygajdstrand: perhaps --revision to not care about current symlinks21:50
* zyga EODs22:09
zygagood night everyone22:09
mupPR snapcraft#937 closed: Incorporate all part properties into state tracking <Created by kyrofa> <Closed by kyrofa> <https://github.com/snapcore/snapcraft/pull/937>22:14
mupPR snapcraft#937 opened: Incorporate all part properties into state tracking <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/937>23:08
mupBug #1545871 opened: Be able to query with multiple terms <Snappy:New for chipaca> <https://launchpad.net/bugs/1545871>23:39

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!