[00:51] <RAOF> You know what would be ace? If our mutexs had some form of documentation of the invariants they're protecting.
[01:37] <RAOF> Hm. I might have managed megabytes of valgrind output here!
[01:50] <duflu> Finely valground
[01:59] <RAOF> Hah. That output gets much more readable if you spread it out over the width of two monitors!
[02:24] <RAOF> Oh!
[02:24] <RAOF> Yes, that's right.
[02:24] <RAOF> MirWaitHandle being terrible.
[02:33] <duflu> I'm pretty sure MirWaitHandle works perfectly. If it's not perfect then add a regression test for what fails. But we may also not need it...
[02:41] <RAOF> Right, it works, but it's architecturally horrible.
[02:41] <RAOF> (Mostly works; it still doesn't distinguish responses)
[03:02] <duflu> Indeed, it was invented by someone who only envisioned single responses. Then fixed by someone (me) who realised it failed for multiple responses. Then later probably can simply be not mentioned in the client API in future
[03:03] <duflu> Although I much prefer using a wait object of some form than callbacks. Anything is nicer than callbacks
[03:04] <duflu> And you could convert a wait object into a callback if it was well designed
[04:09] <RAOF> I was in favour of foo_begin/foo_complete at the beginning.
[04:09] <RAOF> That would be nice wait-objects :)
[04:10] <RAOF> Oh, dear.
[04:10] <RAOF> Mocks.
[06:35] <RAOF> Oh, good.
[06:35] <RAOF> Pulling in more recent trunk and resolving the conflicts *also* resolves some of the test errors. Yay!
[06:46] <RAOF> Woot!
[06:46] <RAOF> Now down to 5 sets of failures.
[09:55] <alan_g> dandrader: would this address some of your concerns about moving child windows? https://code.launchpad.net/~alan-griffiths/miral/fix-1646735/+merge/312447
[10:11] <dandrader> alan_g, will comment on the mp
[11:08] <alan_g> greyback: your position on this? https://code.launchpad.net/~alan-griffiths/miral/fix-1646735/+merge/312447/comments/811089
[11:24] <greyback> alan_g: needed to give it a think. Yep I think your suggestion is worth a go (commented as much)