wallyworldbabbageclunk: i have to head out for a bit soon to take kid to doctor in case you need me00:14
babbageclunkwallyworld: no, I'm good for now00:14
menn0babbageclunk: bug 1641824 is fixed right?00:45
mupBug #1641824: Migrating a model back to controller fails: model XXXX has been removed <model-migration> <juju:In Progress by 2-xtian> <https://launchpad.net/bugs/1641824>00:45
babbageclunkmenn0: hmm - all but the last case.00:46
babbageclunkmenn0: I need to chase down the stuff that calls the NewHandlerArgs.Connect function and ensure that it calls release on the state at some point. I tried a while back but got lost in all the component stuff.00:48
menn0babbageclunk: ah right. that rings a bell.00:50
menn0babbageclunk: critical for 2.1?00:50
babbageclunkmenn0: oh hey, you fixed that bit to use my stateForRequestAuthenticatedTag func - that should make it easier.00:51
menn0babbageclunk: hooray :)00:53
menn0babbageclunk: that rings a bell too :)00:53
babbageclunkmenn0: I guess so - state leak on any model that uses resources.00:53
babbageclunkmenn0: sorry - I mean, I guess it's critical in that case.00:53
menn0babbageclunk: if you can find to take a look before the release goes out that would be awesome.00:53
anastasiamacbabbageclunk: menn0: this week only beta release is going out (beta3), first week of Jan - rc1 (tentative), 2nd week final (tentative too)... just an fyi \o/00:55
babbageclunkmenn0, anastasiamac: I'll take another look now.00:56
menn0anastasiamac: ok thanks00:56
babbageclunkmenn0: Ok, I think I see how to do it now.01:00
anastasiamacmenn0: thumper: Ci is still seeing this issue https://bugs.launchpad.net/juju/+bug/162043801:03
mupBug #1620438: model-migration pre-checks failed to catch issue: not idle <ci> <intermittent-failure> <regression> <juju:Fix Committed by thumper> <https://launchpad.net/bugs/1620438>01:03
anastasiamacthe latest failure was on Dec 13.... on 2.101:03
anastasiamacmenn0: thumper: is there a backport that needed to happen?01:04
menn0anastasiamac: not sure when the fix was made. thumper ?01:06
anastasiamacmenn0: last PR on the bug was merged 14 days ago...01:07
anastasiamacmenn0: and since it went into develop... I am guessing the issue is not fixed :(01:07
menn0anastasiamac: or the test is trying to start a migration before the model has actually finished deploying01:08
anastasiamacmenn0: http://reports.vapour.ws/releases/issue/57ce2d2b749a563a65a5263101:09
menn0anastasiamac: let's reopen it for now01:09
anastasiamacmenn0: or that :)01:09
menn0so we don't forget01:09
anastasiamacmenn0: doen01:10
anastasiamacdone even01:10
menn0anastasiamac: that last resource migration PR landed btw01:21
anastasiamacmenn0: \o/ (I saw)01:21
anastasiamacmenn0: well done01:21
babbageclunkmenn0: What's a charm I can deploy that uses resources?01:21
menn0babbageclunk: cs:~cmars/mattermost01:23
menn0babbageclunk: that actively uses them01:23
menn0babbageclunk: etcd uses a resource too but it's only tied to a specific action01:24
menn0babbageclunk: just a placeholder resource after deploy01:24
menn0depends what you want to test01:24
babbageclunkmenn0: wow, the resources stuff doesn't have good test coverage, huh? I just changed the signature of several bits and still have a know nil pointer exception in my code but I can't make any of the tests fail.01:24
menn0babbageclunk: yep :(   I've found a bunch of places where there's no tests at all01:25
menn0babbageclunk: fixing one of those now while fixing a bug01:25
anastasiamacmenn0: should bug 1649738 be targeted to 2.1.1? or later like 2.2?01:32
mupBug #1649738: migrations should support renaming of models <model-migration> <juju:New> <https://launchpad.net/bugs/1649738>01:32
anastasiamacmenn0: my understanding that 2.1.1 should b mainly bug fixes for 2.1.x rather than new functionality..01:33
menn0anastasiamac: 2.2 is more realistic given that it's potentially a big piece of work but alexis suggested 2.1.101:33
menn0anastasiamac: depending on where model names are still used to tag things, it might be quite small/easy or big/horrible01:34
anastasiamacmenn0: k. this means alexisb has a plan \o/ will go with her suggestion :D01:34
anastasiamacmenn0: well, we are all about extremes nowdays - nothing in the middle ;)01:34
alexisbbabbageclunk, validation complete :)01:39
alexisbthank you01:39
babbageclunkalexisb: yay!01:40
menn0thumper, anastasiamac or babbageclunk: https://github.com/juju/juju/pull/670202:15
* anastasiamac looking02:16
menn0thumper: so what do we want the policy to be wrt downgrades with migrations?02:22
menn0thumper: 1.2.4 to 1.2.3 is ok?02:23
anastasiamacmenn0: lgtm02:24
menn0thumper: that is, only check major.minor?02:24
menn0anastasiamac: tyvm02:24
anastasiamacmenn0: anytime (...almost) \o/02:25
babbageclunkmenn0: to make mattermost use resources, do I need to deploy it with an overriding resource, or is just deploying it enough?02:26
menn0babbageclunk: with mattermost, deploying it is enough02:26
babbageclunkI can't get it to hit my problem code.02:26
menn0babbageclunk: the mattermost binary distribution is a resource, used during the install hook02:27
wallyworldmenn0: thumper: is there a meeting today?03:01
* thumper votes no03:01
menn0wallyworld: I'd forgotten about it. I vote no as well.03:02
thumpermenn0: re downgrade, I'd suggest patch only03:04
thumperso 2.0.3 -> 2.0.203:04
thumper2.1.0 -> 2.0.2 seems more dodgy03:04
menn0thumper: cool, that's what I've done.03:05
thumpermenn0: we don't have a way to negotiate a version to talk to03:05
menn0thumper: basically, patch, build and tag are ignored03:05
thumperwhat if 2.0.3 modifies the descritpion format and 2.0.2 doesn't understand03:05
menn0thumper: 2.0.3 shouldn't do that03:06
menn0thumper: it's for bug fixes only03:06
thumperwe should ensure that is the case then03:06
menn0thumper: the description format should arguably only be allowed to change if the minor version increases03:06
thumpersomething to add to a checklist03:06
* thumper is testing HA pubsub branch03:07
menn0thumper: or we can allow downgrades only if the build or tag is different?03:07
jammenn0: did you still want to meet in an hour?03:07
thumperI like your first idea better03:07
thumperensure that the descirption format doesn't change in bug fix releases03:07
menn0jam: i'm happy to skip. lots of little bits of tidy up for the 2.1 release.03:08
jammenn0: sgtm, hope you have a good day.03:08
jambtw, I agree with the "major.minor" stuff03:08
anastasiamacmenn0: resources fix landed on 2.1... if ther is a chance plz forwardport to 2.2 (develop)03:08
menn0jam: and we only just had the sprint03:08
jamthough we have *not* been good about keeping real differences out of the micro releases03:08
menn0anastasiamac: not forgotten. I have a list of branches to forward port and that's on it.03:09
anastasiamacjam: mayb it should b our NY resolution :D03:09
anastasiamacmenn0: \o/03:09
menn0jam, thumper: i'm not sure how we robustly enforce it...03:09
thumperI'm not sure we can effectively...03:10
thumpercould just be convention03:10
thumperand beatings03:10
anastasiamaca cycle on a team that supports users?03:11
menn0anastasiamac: that's just crazy talk...03:12
menn0so a checklist then ... where to keep it?03:13
anastasiamacmenn0: part of review checklist? along with the item of 'did u consider upgradability?'03:14
menn0anastasiamac: but it's more of a thing to check at review time03:14
menn0anastasiamac: when commiting a PR you don't always know which version of Juju your change is going to land in03:14
menn0thumper, jam: there's a problem with relaxing the migration version check: post-migration you end up with a model with agents that are running tools ahead of the controller03:15
anastasiamacmenn0: hmmm if only we had some set of rules that could check codebase...03:15
thumpermenn0: no...03:15
thumpermenn0: we shouldn't support that03:16
thumperconsider this03:16
thumpermigrating from 2.0.2 -> 2.0.3 controller03:16
thumperthe model doesn't change03:16
thumperit is still 2.0.203:16
thumperyou can migrate it back then03:16
thumperbut if you upgrade the model03:16
thumperno move back for you03:16
menn0thumper: well that's already supported as it is now, without my PR03:17
thumperthat is what we need to support...03:18
thumperI don't think we should support other than that03:18
menn0thumper: ok... well that works right now03:18
menn0thumper: what's missing is that we don't check controller versions, only the model version to the target controller version03:20
menn0thumper: there's a gap there where the model might be compatible with the target controller but the source controller is ahead of the target controller, meaning that migration API support might be missing03:20
menn0thumper: fixing that now03:20
thumperbut ...03:22
thumperso testing that target controller version >= source controller version, or just patch levels behind, yes?03:23
thumpermenn0: ^^ that03:23
menn0thumper: quick HO?03:23
babbageclunkmenn0, thumper: could one of you take a look at https://github.com/juju/juju/pull/670303:28
babbageclunkIt fixes the resource state leak.03:29
babbageclunkI'mm'a go for a run03:31
* babbageclunk goes for a run03:31
babbageclunkgah, no I'm not - still doesn't work03:43
wallyworldbabbageclunk: i'll have a PR ready for review a bit later, after your EOD. if you could look when you start tomorrow that would be greate03:45
babbageclunkwallyworld: wilco03:45
wallyworldbabbageclunk: it's to change how register remote relation works so we can remove a hack needed to lookup the remote app id on the consuming side03:46
anastasiamacwallyworld: have u seen this one? remoteRelationsSuite.TestRemoteRelationsDead got nil instead of changes: https://bugs.launchpad.net/juju/+bug/164686103:47
mupBug #1646861: remoteRelationsSuite.TestRemoteRelationsDead got nil instead of changes <ci> <intermittent-failure> <regression> <unit-tests> <juju:Triaged> <https://launchpad.net/bugs/1646861>03:47
wallyworldthat got fixed last week IIANM03:47
anastasiamacwallyworld: do u have a PR? and do u know what branch it landed on?03:48
anastasiamacbefore we branched?03:48
wallyworldno idea03:49
wallyworldmaybe after03:49
anastasiamacaccording to http://reports.vapour.ws/releases/issue/58418a80749a5656beeae59f, it was seen on Dec 12 on 2.103:49
wallyworldmust have been after then03:50
wallyworldbackport time03:50
anastasiamaccould u plz backport to 2.1? u may need to consider if it needs to b on 2.0 too03:50
=== frankban|afk is now known as frankban
voidspacejam: ping12:19
jamvoidspace: ?12:19
voidspacejam: hey, you said you thought you'd seen code explicitly discarding constraints  when there is placement12:20
voidspacejam: above the container creation level12:20
voidspacejam: and indeed the bundledata spec explicitly states this to be the case (but we'd like to change it)12:20
voidspacejam: I wondered if you recalled whereabouts you'd seen this code?12:20
jamvoidspace: checking12:21
voidspacejam: I don't *think* the charm package itself discards this information12:21
jamvoidspace: I don't see it right now. It was just something I came across in the past, might have been in lots of places as I've been digging in a lot of code lately.12:25
voidspacejam: ok, no problem12:25
voidspacejam: I'll keep digging12:26
voidspacejam: it is explicitly documented in charm bundledata - so I'll construct a test to see if it does come out of that package12:26
jamvoidspace: I didn't think it was there, I thought it was somewhere like worker/provisioner12:33
voidspacejam: rick_h: juju deploy ubuntu --constraints="mem=888M" --to kvm:012:59
voidspacejam: rick_h: the constraint is honoured and works12:59
voidspacejam: rick_h: definitely bundle specific12:59
jamvoidspace: good to know, sad to hear :)13:39
alexisbperrito666, ping14:05
perrito666alexisb: pong14:11
perrito666sorry was taking a pill because yesterday I used my back in the wrong way14:11
perrito666plus my internet is down :p good thing I have a backup internet14:12
perrito666feels like monday14:12
alexisbperrito666, it is monday for you isnt it?14:17
perrito666it is, nad I have not had a Monday so Monday in months14:17
alexisbperrito666, to help improve your monday...14:18
alexisbI have a bug for you14:18
mupBug #1640210: Restore-backup model is not usable because upgrade in progress <ci> <intermittent-failure> <regression> <restore-backup> <juju:Triaged> <https://launchpad.net/bugs/1640210>14:18
perrito666also something triggered my differencial breaker in the office so after EOD ill have to run a full diagnostic to make sure nothing is leaking current14:18
alexisbyour favorite kind of bug14:18
alexisbperrito666, please dont burn your new house down14:19
perrito666alexisb: lol, lovely, Ill jump on it since my pending work from the sprint is awaiting for axw's patch to merge14:19
alexisbI knew you would appreciate that bug ;)14:20
voidspacewallyworld: ping - don't suppose you're around yet?17:32
perrito666brb, relocation17:41
perrito666voidspace: he will be here in about 5 hs17:42
alexisbvoidspace, wallyworld typcially starts around 9PM UTC17:43
voidspacealexisb: thanks17:46
voidspaceperrito666: I guess I'll catch him later tonight17:46
voidspaceI have questions about the bundlechanges packages17:46
katcovoidspace: it's a lie; he is omnipresent17:46
katcovoidspace: he's watching right now17:46
voidspacekatco: that would be nice...17:46
jamfrobware: voidspace: do you know if we ever implemented the default space as a configuration setting?17:47
voidspaceno-one has much experience with bundlechanges, but as usual it's more wallyworld's fault than anyone else17:47
voidspacejam: I don't believe so17:47
jamI'm wondering if "machine.AllSpaces" should be returning the default space if nothing else has been specified17:47
voidspacejam: it would be better for us always to be explicit about spaces17:48
voidspacejam: so machine.AllSpaces can always tell the truth17:49
=== frankban is now known as frankban|afk
jamvoidspace: well at some point we need to do *something* when requesting a container or machine that doesn't have a "--bind" or "--constraint space=" set17:50
jamso *something* has to determine that the container/machine needs to go in the default space17:50
jamvoidspace: is there a bit of code that knows about the default space, or is it just that we let MAAS/EC2 give us a machine, which can be in any subnet/space ?17:51
jamvoidspace: theoretically there was supposed to be a default space that you would bootstrap into (detected at bootstrap time if nothing else supplied)17:51
jamthe extra cheap has is that it is the one that is named "default", but that especially feels bad on MAAS where you want to name them something meaningful to you17:52
voidspacejam: my goodness, this was a while ago and you're making me think17:52
voidspacejam: yep, on maas you should be able to specify which is the default17:52
voidspacejam: I don't think we *enforce* the restriction that every machine must be in "the controller space", we just assume that everything is routable17:53
jamvoidspace: right, but there should also be a default space that applies to all machines when you don't specify something17:54
voidspacejam: for ec2 we always have a default space and we don't let you remove spaces17:54
jamwhich is not the controller space17:54
jambut if you specify *nothing* then controller = default = whatever we bootstrap into17:54
jamvoidspace: but is that *named* default, or is it a named space that we treat as default ?=17:54
jamnamed "default"17:54
voidspacejam: bah, so my understanding was a named space called "default" as it wasn't configurable17:55
voidspacejam: I may be incorrect I'm afraid though17:55
voidspacejam: gah, it's near EOD and I have my head in the bundlechanges code - I ought to be able to navigate this though17:56
jamvoidspace: sorry to distract you. good luck17:57
jamvoidspace: able to trace the calls through?17:57
voidspacejam: no problem, I'm annoyed it isn't clearer17:57
jam(for containers, if you haven't specified anything, but end up on a machine, if *it* is in a single space, then it seems ok to just use it)17:57
voidspaceyep, that has to be true17:58
jambut that feels more like it should have only picked a machine that would have fit in the first place17:58
natefinchrick_h, katco: currently add-credential requires a parameter specifying the cloud to which you're adding a credential.  Do we want to make that optional?  It would be more consistent with add-cloud if you could run interactive with zero args18:46
rick_hnatefinch: not at the moment18:47
rick_hnatefinch: for now let's leave that part18:47
natefinchrick_h: yeah, outside the scope of this PR, you're right18:47
rick_hnatefinch: i agree that in interactive mode that's the consistent work we want, but there's bigger fish to fry atm18:47
fengxia41103Any document on developing juju provider?19:13
=== frankban|afk is now known as frankban
redirfengxia41103: There's this https://github.com/juju/juju/wiki/Implementing-environment-providers19:16
natefinchruh roh  juju.tools.lxdclient client_instance.go:278 while removing instance "juju-e2f2ef-0": Failed to destroy ZFS filesystem: cannot open 'lxd-pool/containers/juju-e2f2ef-0': dataset does not exist19:19
natefinchhmm... that might be fixed by now, realized this is an old test19:21
natefincher old test run19:21
natefinchmgz, sinzui: is there something wonky with the representative tests?19:59
natefinchabentley: ^20:00
mgznatefinch: they have sadly been pretty wonky for a while20:00
mgzanything in particular? I'll look.20:00
natefinch19:30:24 ERROR cmd supercommand.go:458 failed to bootstrap model: refreshing addresses: instances not found20:00
mgzoh, that message again... that's a new(ish) thing masking real problems20:01
mgznatefinch: means the lxd container didn't come up20:02
mgznatefinch: machine is probably full or similar again20:02
mgznatefinch: request, can you send a message to a list, any list, mentioning that the check job is failing your branch?20:02
mgzI've been fixing this stuff as people mention it and I think the overall message about things being screwed has not propogated upwards20:03
redirbrb reboot20:05
=== tvansteenburgh2 is now known as tvansteenburgh
=== frankban is now known as frankban|afk
abentleysinzui: could you please review https://code.launchpad.net/~abentley/juju-ci-tools/manual-endpoint-xfail/+merge/313274 ?20:18
=== tvansteenburgh1 is now known as tvansteenburgh
natefinchmgz: will do20:25
abentleymgz: Do you suppose it's because the representative tests can run concurrently?20:38
redirhow does one relate application in different models?20:46
mgzabentley: I think that is certainly a factor20:46
abentleymgz: test_check_token_win_remote_failure is failing on my machine.  Is this due to your "OSX/Windows client tests now more useful" changes?20:48
rick_hredir: that's the cross model relations work that wallyworld is driving and is behind a feature flag20:53
rick_hredir: what makes you ask?20:53
redirrick_h: OCR trying to verify QA but I don't know the spelling for making that relation.20:54
redirrick_h: on a CMR bit wallyworld has a PR for20:54
rick_hredir: juju relate model/application:endpoint I think20:54
redirfigured I'd dig up the spec if the lazy IRC didn't help20:55
redirahh / I tried :20:55
redirbut that's already used, duh.20:55
redirdoesn't work. I bet I need to run with a feature flag or something20:58
rick_hredir: yea, need to have the FF enabled, probably at bootstrap time20:59
wallyworldredir: rick_h: that syntaxt isn't used yet. for now you 1. offer "juju offer mysql:db local:/u/me/mysql" and 2. relate "juju relate wordpress local:/u/me/mysql". steps 1 and 2 are done in different models20:59
rick_hwallyworld: doh! ok I wasn't sure20:59
wallyworldtis ok, all wip20:59
redirwallyworld: what's the FF magic incantation?20:59
wallyworldff is called "cross-model"21:00
babbageclunkwallyworld: sorry, still going through yours - thumper tried to trick me into looking at one of his, he was all "he's asleep, he won't mind"21:14
babbageclunkAlice is taking the baby birds we found in our Christmas tree to the SPCA.21:16
natefinchmgz, abentley, sinzui: is there a fix for the representative tests machines?  I can't land stuff right now because I don't know if the representative tests pass.  I mean, I guess I could just ignore it and try to merge anyway, but that seems bad.21:24
rick_hnatefinch: what branch is this?21:25
redirbabbageclunk: are you looking at 670721:25
natefinchrick_h: the add cred updates and model status stuff21:26
rick_hnatefinch: so the add-cred updates we were going to hold until beta3 is tagged?21:26
natefinchrick_h: right, right, sorry, got distracted by the test failures21:27
rick_hnatefinch: all good21:27
rick_hnatefinch: might as well hold both at this point since we're looking to tag just to not introduce anything the day of please21:27
rick_hnatefinch: and that'll give folks time to look and correct things21:27
natefinchrick_h: sure thing21:27
rick_hnatefinch: ty for the email21:27
babbageclunkredir: yeah, wallyworld emailed me it last night21:28
* redir stops looking21:31
wallyworldredir: sorry, i thought you we almost done and when babbageclunk stood me up in favour of thumper i figured you would come to the rescue :-)21:32
redirwell QA checked out21:32
wallyworldgood cause it worked for me too21:33
redirand I got as far as that one comment.21:33
redirbut I know babbageclunk is working on CMR with you so prolly more useful to have him looking at it21:34
natefinchtrivial port anyone? https://github.com/juju/juju/pull/6710    +10 -40, exactly same code merged into 2.121:34
anastasiamacnatefinch: ports do not need review unless they r vastly different from original21:35
natefinchanastasiamac: cool21:35
anastasiamacnatefinch: self-stamp :D21:35
alexisbwallyworld, ping21:42
alexisbdo you mind if we meet early for our 1x1?21:42
alexisbI am ready anytime21:43
wallyworldalexisb: sure, give me 10?21:43
alexisbyep meet you in the HO21:43
=== frankban|afk is now known as frankban
=== petevg is now known as petevg_afk
babbageclunkwallyworld: reviewed, sorry for the delay!22:32
wallyworldnp at all ty22:32
=== frankban is now known as frankban|afk
wallyworldbabbageclunk: changes pushed23:14
perrito666I am getting a few mins late to standup caught in traffic23:32
thumperperrito666: no standup today23:33
perrito666Oh didn't know, why?23:34
* perrito666 stops driving like a mad man23:35
perrito666Irc on the phone is fantastic for traffic jams23:35
thumperperrito666: due to not many people23:35
veebersthumper: hah, the one time since I'm back that I remember about the standup and it's not happening :-)23:37
redirwell looks like bluejeans isn't happening either23:44
perrito666I wanted to try my new webcam :p23:44
redirso maybe bluejeans is working fine, but chromium 53 is not.23:47
menn0redir: i'm on chromium 53 and bluejeans appears to be working23:47
redirmenn0: don't update23:47
rediror something. Appears related to https://sslmate.com/blog/post/ct_redaction_in_chrome_5323:49
redirwhich is definitely happening for me on other sites (smile.amazon.com)23:49
redirand if I look at the network requests when loading bluejeans I see that error too23:50
redirthis started after I updated and rebooted today.23:50
anastasiamacmenn0: redir: chromium did not work for me with bluejeans. had to use chrome :D otherwise i had no sound23:53
redirare we not having standups this week or just today?23:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!