=== chihchun_afk is now known as chihchun
=== olly_ is now known as olly
=== chihchun is now known as chihchun_afk
smoseri get mails like http://paste.ubuntu.com/23653970/16:12
smoserfor this recipe: https://code.launchpad.net/~cloud-init-dev/+recipe/cloud-init-daily16:13
smoseri think that occurss basically because the version i have16:13
smoser {latest-tag}-{revtime}-g{git-commit}-0ubuntu1~trunk16:13
smoserwill have the same source code version any time this thing runs twice with the same upstream source16:14
smoseris there any way to avoid this noise ?16:14
smosermaybe i just need to use '{time}' instead of '{revtime}'16:16
dobeyi would recommend not having multiple "-" in the version string there. would suggest + or ~ instead; multiple - can mess things up in the future; and yeah, if {revtime} is the same for two different commits, then g{git-commit} can end up being resolved lower than a previous build16:19
cjwatsonYou should probably have {SOMETHINGOROTHER:ubuntu-pkg} in that version16:19
cjwatsonIn general there should be some element from all the branches you're assembling16:20
smoserdobey, i'm sticking with the multiple -. it is debian-valid, and its more like upstream where i use 'git describe'  (which is what i'd rather use).16:20
cjwatson(probably after the last -, in this case)16:20
cjwatsonI really wouldn't use {time}.  Ideally recipes should be deterministic16:21
smosercjwatson, is that what is causing it ?16:21
cjwatsonThe lack of any {...:ubuntu-pkg} variables?  Yes.16:21
dobeysmoser: i know it's valid. but from experience it's definitely caused me problems in the past.16:21
smoserwell, i've not seen too many issues in my useage in cloud-init. i  know its non-standard, but git describe is *so* useful.16:22
smoserso then i get a build failure any time i push to the packaging branch but the upstream branch doesnt change.16:23
cjwatsonOnly because your version doesn't contain any elements that depend on the packaging branch.16:24
smosercjwatson, you have a suggestion for what to use ?16:24
smoserbzr revno was nice in all its simplicity16:24
cjwatson{revno:ubuntu-pkg} works16:24
cjwatson{revtime:ubuntu-pkg} is more git-ish, but as you say revno is nice and simple16:24
cjwatsonwhich is why I implemented a shim for it16:24
cjwatsonthere's a note about this in https://help.launchpad.net/Packaging/SourceBuilds/Recipes#Version_numbers_and_substitution_variables16:25
cjwatsonspecifically about this kind of case16:25
smoseroh i didnt' know revno works.16:26
smoserthat is really nice.16:26
smoseri'll go with that.16:28
smoserdobey, oh yeah, i do remember... i had one thing that i was stuck by16:45
smoser https://bugs.launchpad.net/git-build-recipe/+bug/161121916:45
ubot5`Ubuntu bug 1611219 in git-build-recipe "git build recipe seems not to like multiple - in version" [Undecided,New]16:45
dobeynot quite the problem i was referring to from my past experience. had version comparison issues in past with dpkg16:46
dobeyanyway, i'm not going to fight you about it :)16:46
cjwatsonI don't think that has anything to do with multiple -16:47
cjwatsonI need to think about what it actually does have to do with16:47
smosergit-build-recipe format 0.4 deb-version {latest-tag}-{rev}-g{git-commit}-0ubuntugit-build-recipe format 0.4 deb-version {latest-tag}-{revno}-g{git-commit}-{debversion:ubuntu-pkg}+{revno:ubuntu-pkg}~trunk16:47
smosergit-build-recipe format 0.4 deb-version {latest-tag}-{revno}-g{git-commit}-{debversion:ubuntu-pkg}+{revno:ubuntu-pkg}~trunk16:47
smoserdoes that seem to make sense ?16:47
cjwatsonmy eyes glazed over, sorry16:48
smoseryeah i know.16:48
cjwatsonI don't really want to get into sanity-checking versions :)16:48
smoserthats fime.16:48
smosermy changes there were16:48
smoser{revtime} -> {revno}16:48
smoser0ubuntu1 -> {debversion:ubuntu-pkg}+{revno:ubuntu-pkg}16:49
smoseryou dont need to help any more, thanks for your help.16:49
dobeycjwatson: it's because the version comparison splits upstream versus debian version between a single -, and so can get weird in some cases. i guess it's ok though if you're extra careful to ensure you never end up adding extra - chars AFTER the -MubuntuN16:49
cjwatsondobey: no, it's not16:50
cjwatsondobey: look at the exception message16:50
cjwatsonInvalid version string '{debupstream:ubuntu-pkg}-0.7.7~git1029-gb56d7a1-0ubuntu1+trunk~ubuntu16.10.1'16:50
dobeycjwatson: no, i mean the issue i was talking about with having multiple versions16:50
cjwatsonthat is indeed not a valid version, and it's because that substitution variable hasn't been expanded for some reason16:50
cjwatsondobey: well, sure, but I don't know why you were addressing that to me then :)16:50
cjwatsonI was replying to smoser's bug title16:51
dobeycjwatson: oh, you didn't prefix with "smoser:" and it looked like you were replying to me in irssi. sorry :)16:51
cjwatsonfair enough16:51
smoserwell, possibly similar fail to the bug above16:57
smoserValueError: Invalid version string '0.7.8-1368-gc9c9197-{debversion:ubuntu-pkg}+1365~trunk~ubuntu16.04.1'16:57
=== nacc_ is now known as nacc

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!