[01:25] <smoser> rharper, ?
[01:25] <rharper> here
[01:25] <smoser> what is user_data.sh ? context ?
[01:26] <smoser> above, tox -e citest == tox-venv citest
[01:26] <rharper> maas bug
[01:26] <rharper> Bug 1644229
[01:27] <rharper> Read from http://10.2.0.50/MAAS/metadata/2012-03-01/user-data (200,
[01:27] <rharper> 18443b) after 1 attempts
[01:27] <rharper> util.py[DEBUG]: Writing to /var/lib/cloud/instance/scripts/user_data.sh - wb: [448] 13399 bytes
[01:27] <rharper> I was wondering if maas always sense a "user_data.sh" during deployment, or if that's custom user-data from the maas user
[01:28] <rharper> the bug is that the user_data.sh script doesn't exit 0; so cloud-init says the deployment failed
[01:36] <smoser> i'm not sure what woudl write user_data.sh
[01:37] <smoser> how do i open a x-7z ?
[01:42] <magicalChicken> smoser: 7z program, it has args like tar
[01:43] <magicalChicken> it doesn't do directories right though
[01:46] <rharper> smoser: p7zip-full
[01:47] <rharper> then 7z x <file>
[01:47] <smoser> rharper, i really dont know what wrote that.
[01:48] <smoser> that too is obnoxious
[01:48] <smoser> but anyway... id ont kow what wrote that file.
[01:48] <smoser> cloud-inti in user-ata is getting a multi-part input
[01:48] <rharper> ok, I don't think it's "normal"
[01:48] <smoser> and one of the parts is file name user_data.sh
[01:48] <rharper> right
[01:49] <smoser> i dont see it in maas though
[01:49] <rharper> right
[01:49] <rharper> I suspect it's something they added for debugging or something but that's the cause of the failure (the script)
[01:49] <rharper> if they remove it,  things should work.
[01:49] <smoser> ok. there it is
[01:49] <smoser>  generate_user_data
[01:50] <rharper> in maas?
[01:50] <smoser> yeah
[01:50] <rharper> what data does it pull in ?
[01:51] <rharper> looks like power info for one
[01:51] <rharper> hrm, but that's config, not a script
[01:52] <smoser> no. its a mime multipart
[01:52] <smoser> one part x-shellscript
[01:52] <smoser> which gets put inthere
[01:52] <smoser> i really woudl like to get the contents of /var/lib/cloud/
[01:52] <smoser> that'd be sufficient
[01:52] <rharper> ok
[01:55] <smoser> its wierd that it doesnt output anything
[01:55] <smoser> it just exits fail
[01:56] <smoser> i hvae to run
[04:02] <magicalChicken> powersj, rharper: 'run tests on current code' functionality is done, PR is at:
[04:02] <magicalChicken> https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/314496
[14:50] <rharper> magicalChicken: sweet!
[15:54] <powersj> magicalChicken: thanks! will test it out later this morning
[16:52] <powersj> magicalChicken: fyi - I like the previous layout of having an inheritance model with common interfaces and I wish to continue using that model. My hope was to determine the flow and methods we use inside the KVM interface.
[16:54] <powersj> The issue we may have is the model we use to interact with a VM versus a container. With the container we can execute commands directly, with the VM we would need SSH or turn the system off and mount.
[17:00] <magicalChicken> powersj: An additional setup option to set a root password and enable ssh could be used, something like setup_image.backdoor
[17:00] <magicalChicken> Then we could just ssh in with those credentials for everythign
[17:01] <magicalChicken> Since the vm would be running on our local host, or at least on the same LAN there wouldn't be much cost to ssh
[17:02] <magicalChicken> The execute method could still get stdout and exit code over ssh
[17:02] <powersj> magicalChicken: as long as smoser is fine with us modifying the image like that, ok :) I was trying to avoid modifying the image in a way that may affect a test. However, when we add additional platforms like the clouds, we will have to add SSH anyway it seems.
[17:02] <rharper> I think smoser is right with exec;
[17:02] <rharper> I think we want to use exec over whatever transport
[17:02] <rharper> and the substrate layer should do what it needs to enable exec (remote ssh, if needed)
[17:02] <magicalChicken> Yeah, I think for everything other than lxd, ssh is the easiest way to handle exec
[17:03] <powersj> ok
[17:03] <magicalChicken> I think its also a fair assumption that after a certain timeout, if the system isn't accessible over the network, it can just be stopped
[17:04] <magicalChicken> For kvm, we could just send SIGKILL to qemu for shutdown
[17:04] <rharper> why not use a trailing collect script to shutdown like we do in vmtest ?
[17:05] <rharper> at least in powersj proposal, we're injecting the collect scripts anyhow;  no reason not to also have a boiler plate to shutdown the instance at the end of collection
[17:05] <magicalChicken> the platform objects are used with a context manager that shuts down using instance.shutdown()
[17:05] <magicalChicken> i don't think it makes sense to inject collect scripts
[17:05]  * smoser has to read
[17:06] <rharper> magicalChicken: that's fair (no inject) if we're settled on exec
[17:06] <magicalChicken> push_file() can be implemented wiht execute
[17:06] <magicalChicken> yeah, so run_script() is just push_file() + execute('/bin/bash file')
[17:06] <powersj> yeah it sounds like usin exec means using ssh over injecting files + running + shutdown + pull files
[17:07] <rharper> well, pull_files and then shutdown ?
[17:07] <magicalChicken> pull_files() can be done over ssh as well
[17:07] <rharper> the alternative is using a secondary disk image which can be accessed directly offline
[17:07] <magicalChicken> and shutdown is just execute('shutdown')
[17:07] <rharper> ala vmtests 'collect disk'
[17:08] <magicalChicken> that would require collect behavior to change based on platform though
[17:08] <magicalChicken> it wouldn't be too bad, just for part of collect, but its still more work
[17:09] <rharper> sure but that's why we're having platform abstraction ?
[17:09] <magicalChicken> the abstraction was originally just over how we get to the point where we have something we can call execute() on
[17:10] <magicalChicken> it may also be nice to have ssh set up so we can get in for debugging
[17:11] <rharper> I think file pull via execute is fine;  we can avoid adding the secondary disk if possible;
[17:12] <rharper> I would like a 'keep the instance on failure' flag like we have in vmtest
[17:12] <rharper> specifically for live inspection
[17:12] <rharper> in which case, it could emit the ssh info to connect
[17:12] <magicalChicken> Yeah, 'keep instance on failure' would be nice
[17:12] <magicalChicken> I've been meaning to do that for lxd as well
[17:13] <magicalChicken> And have it configurable via cmdline
[17:13] <magicalChicken> Yeah, there could be a debug message with ssh info during setup
[17:15] <powersj> magicalChicken: rharper: sounds like the current model then is to get image, modify image by adding ssh backdoor, for each test exec will run the commands specified via ssh and output collected then, not when turned off.
[17:15] <magicalChicken> Also, for the most part, run_script() is the only consumer of execute(), since pull_file() is only used by 'bddeb' and push_file() is only used if running with --deb or --rom
[17:16] <magicalChicken> powersj: Yeah, I think it makes sense to do it like that
[17:16] <magicalChicken> For the image modification and setup, images.execute() could just be a call through to mount-image-callback
[17:17] <rharper> there's possibly a missing step of uploading the modified image
[17:17] <rharper> on clouds, we'll need to create the backdoored image, upload it, then use the uploaded image
[17:17] <rharper> but at least for the 'local' case lxd and kvm, mic is fine
[17:17] <magicalChicken> There's a snapshot object in between image modification and launching instances
[17:18] <magicalChicken> It should work fine for the snapshot to represent a remote image that can be launched right away
[17:18] <magicalChicken> So the upload could happen during snapshot.__init__
[17:21] <smoser> i'm pretty happy with the backscroll there. :)
[17:22] <smoser> magicalChicken, yes, snapshot was intended to do the upload... basically that takes an "image" and turns it into something that can be strated.
[17:22] <smoser> wrt ssh... do we have a test that disables ssh ?
[17:22] <smoser> if we do not, then at the momentn we can punt on baackdoring image
[17:22] <smoser> and just use port 22
[17:23] <magicalChicken> default root password might differ between distros though
[17:23] <smoser> well, we're not going to go in as root.
[17:23] <smoser> well, maybe you would
[17:23] <powersj> don't believe we have a disable ssh test at the moment. just a number of ssh key generation tests
[17:23] <smoser> but if you backdoor, you just add a user that can sudo
[17:23] <magicalChicken> right, shutdown cloud be a 'sudo shutdown'
[17:24] <magicalChicken> i don't think any of the collect scripts really need to be root
[17:24] <smoser> well, execute() assumes root
[17:24] <smoser> it shoudl at least
[17:24] <magicalChicken> it could just always sudo then
[17:24] <smoser> that can be done over ssh easily enough
[17:24] <magicalChicken> it cmd as a list so just ['sudo'] + cmd should work fine
[17:25] <smoser> almost
[17:25] <smoser> :)
[17:25] <smoser> http://smoser.brickies.net/git/?p=snippits.git;a=blob;f=bash/ssh-attach;hb=HEAD
[17:25] <smoser> more context on taht basic path at
[17:25] <smoser>  https://gist.github.com/smoser/88a5a77ab0debf268b945d46314ea447
[17:26] <magicalChicken> Oh, that's really nice
[17:26] <magicalChicken> So it doesn't flatten everything into 1 cmd
[17:26] <magicalChicken> s/cmd/arg
[17:27] <smoser> well, yeah. the wrapper unflattens
[17:28] <smoser> if we're doing ssh, we probably do want to use a python library for it...
[17:28] <smoser> paramiko
[17:28] <smoser> but the command execution wrapper business still can be managed.
[17:29] <magicalChicken> Yeah, that should be cleaner than using subp
[17:30] <magicalChicken> The new img_conf format in the devel version of the test can automatically apply certain setup options to images on certain platforms, so that handles enabling backdoor on kvm
[17:30] <magicalChicken> There's a lot of general cleanup in that branch other than just enabling debian/centos, so its probably best to build this off of there
[17:33] <powersj> magicalChicken: didn't see any comments from you on image sourcing. rharper suggested reusing curtin's sync. smoser any comments there?
[17:34] <magicalChicken> powersj: We'd need to have something url based as well for other distros, but that could be files thrown into the same directory with a separate index for them
[17:34] <magicalChicken> I think curtin image sync makes sense
[17:34] <smoser> powersj, well, we want to sync yes.
[17:34] <smoser> but curtin syncs maas images
[17:34] <rharper> what we don't have AFAIK, is any streams data for other distro images
[17:35] <smoser> which require a kernel external
[17:35] <smoser> no boot loader
[17:35] <rharper> it may be we need a sync per 'distro'
[17:35] <magicalChicken> rharper: that's what i meant with having a raw download url as well
[17:35] <rharper> well, that's not what I mean
[17:35] <magicalChicken> oh
[17:35] <rharper> streams publishes where the URL is
[17:35] <smoser> well... http://smoser.brickies.net/image-streams/
[17:35] <magicalChicken> just for ubuntu though
[17:35] <rharper> ie, if they're building new ones, you can't just blindly wget $URL which may not get you what you want
[17:36] <rharper> magicalChicken: even for ubuntu, we use the streams data to figure out what we want from what's available
[17:36] <smoser> so that is just  manually maintained and updated
[17:36] <magicalChicken> rharper: I thought at least for debian there was a kind of 'lastest build' url
[17:36] <rharper> smoser: sneaky =)
[17:36] <smoser> but, it works. and we could do something similar
[17:36] <rharper> magicalChicken: right but that's still not what we want
[17:36] <magicalChicken> rharper: right o
[17:36] <rharper> if you can only recreate on a specific image or release; you  sort of want history
[17:37] <magicalChicken> yeah that makes sense
[17:37] <magicalChicken> but: http://smoser.brickies.net/image-streams/ would work
[17:37] <rharper> yeah
[17:37] <magicalChicken> thats actually pretty nice
[17:37] <smoser> we do want to at least be able to easily see that somethig changed between two runs
[17:38] <smoser> my images are currently synced into serverstack
[17:38] <rharper> nice
[17:38] <rharper> would be nice to see if there are other sources of published images that are newer
[17:38] <rharper> like AMIs ?
[17:38] <rharper> surely there are newer centos7 images
[17:38] <rharper> smoser: in general do you want to host the pulling of images ?
[17:39] <smoser> so.. in my design i really just pushed this all off to the "platform"
[17:39] <rharper> we might need to mirror that service to prodstack
[17:39] <smoser> i forget what i called it, but essentially you ask the platform to get you an image that you can modify
[17:39] <rharper> yeah
[17:39] <smoser> platform.get_me_an_image("ubuntu/foo")
[17:39] <rharper> I think that's a good abstraction
[17:39] <rharper> since we'll need to poke a each substrate differently
[17:39] <magicalChicken> smoser: that had to be modified a bit
[17:40] <magicalChicken> there's basically an image config with information about how to locate the image
[17:40] <magicalChicken> which can be different on each platform
[17:40] <magicalChicken> so 'xenial' -> 'os=ubuntu release=xenial arch=amd64'
[17:40] <smoser> thats more an 'alias' than a 'config'
[17:41] <magicalChicken> theres more information there as well
[17:41]  * smoser looks
[17:41] <magicalChicken> like timeouts for stuff and setup options that may be required
[17:41] <magicalChicken> don't look at master, its broken
[17:41] <magicalChicken> look in wesley-wiedenmeier/cloud-init:integration-testing
[17:42] <magicalChicken> That's the main reason I want to base the kvm development off of the current version of the tests, the new img_conf format is much cleaner
[17:43] <smoser> hm... i'll read some. i'm not convinced :)
[17:43] <magicalChicken> smoser: the version in master is pretty bad, it shouldn't be used
[17:44] <magicalChicken> but there is always going to have to be a kind of alias system, since we want the same os_name to refer to the same release on every platform
[17:45] <smoser> i still dont follow really.
[17:45] <magicalChicken> so whether the identification info is in 1 place or inside the platform or inside releases.yaml doesn't really matter, its the same thing
[17:45] <magicalChicken> smoser: each release has a name, so 'xenial', or 'stretch' or 'centos70'
[17:45] <magicalChicken> and the new img_conf maps that name and the platform name to all config needed to locate and use that image on that platform
[17:46] <magicalChicken> so that platform.get_image() can just be passed config.load_os_config('platform_name', 'image_name')
[17:46] <powersj> so saying xenial in a run of the integration tests knows which AMI to pick on AWS or what lxc command line option to use or what simplestreams command to run to get for kvm
[17:52] <smoser> i agree that something needs to translate 'ubuntu/xenial' into an image, and that takes some additional information.
[17:52] <smoser> a.) 'ubuntu' is the os, and 'xenial' means 16.04 ...
[17:53] <smoser> b.) where to get this image or create access to it (get an ami or use lxc or ... )
[17:53] <smoser> i think though, that i really consider thedetails of that to be a platform thing
[17:53] <smoser> possibly even configurable through the platform
[17:54] <magicalChicken> smoser: it is configurable for each platform separately
[17:54] <magicalChicken> in the new format
[17:54] <magicalChicken> the main reason for having the image config and per-platform image location information together
[17:54] <magicalChicken> is that some of the image config may change based on the platform
[17:55] <magicalChicken> i.e. the timeout for booting xenial on lxd is not necessarily the same as the timeout for booting xenial on aws
[17:55] <magicalChicken> or setup_image options that are enabled by default are not the same for all platforms
[17:56] <magicalChicken> the actual implementation of downloading the image is handled by the platform object, the img_conf information is just used by that
[17:57] <smoser> thats fine and makes sense. but you've made the 'Platform.get_image()' much less easily usable
[17:57] <smoser> you can't do anything without a platform
[17:57] <magicalChicken> getting an image is just platform.get_image(config.load_os_config('lxd', 'xenial'))
[17:57] <smoser> so having that platform thing be easily usable is important.
[17:58] <magicalChicken> I could also do the config.load_os_config silently inside the platform
[17:58] <magicalChicken> so it could be platform.get_image('xenial')
[17:58] <magicalChicken> or even change os names to be in the 'ubuntu/xenial' format
[17:59] <smoser> i dont have strong feelings on 'ubuntu/xenial'. it is obvious what that means to you and me ('xenial').
[17:59] <smoser> but it is not so obvious if you just use '7'
[17:59] <smoser> rather than centos/7
[18:00] <magicalChicken> the centos ones are 'centos70' and 'centos66' rn
[18:00] <smoser> i think having a delimeter there makes sense.
[18:00] <smoser> but... meh. not all that important.
[18:01] <smoser> you're right in that something has to take htat string and make sense of it.
[18:01] <smoser> i think we're mostly in agreement.
[18:01] <magicalChicken> yeah, the delimiter might look nicer
[18:01] <magicalChicken> the name is just used as a dictionary key, so its pretty easy to replace
[18:03] <smoser> its ok if  we have some alias thing that turns one into another.
[18:07] <smoser> for  now, i think we should just not bother with non-ubuntu on kvm. dont halt yourself on that. we'll find images, and then we'll enable other os there.
[18:08] <magicalChicken> that makes sense
[18:08] <magicalChicken> if the sstreams mirror is per distro, it would be no trouble to add another one once a source is found
[18:09] <magicalChicken> There's also a spreadsheet I have going to track all this at:
[18:09] <magicalChicken> https://docs.google.com/spreadsheets/d/1DAzBlh-wk-rv-WRjllNRG6nnHtAmD0EFBLEYtu8weII/edit#gid=0
[18:12] <smoser> something that comes to my mind...
[18:12] <smoser> the kvm 'platform'
[18:13] <smoser> lxd is a cloud platform. because it handles metadata for us (and puts that stuff into /var/lib/cloud/seed/)
[18:13] <smoser> kvm is not a cloud platform
[18:14] <smoser> kvm+NoCloud is analogous to lxd in that sense.
[18:14] <smoser> i think when we say 'kvm', we're really meaning "kvm+NoCloud" and even then probably kvm+NoCloud-attachedDisk (versus seeding noCloud).
[18:15] <magicalChicken> yeah, i think kvm + seed disk makes the most sense to do
[18:15] <magicalChicken> since that's used by some cloud setups
[18:21] <smoser> well, seed disk differs.
[18:21] <smoser> no cloud to my knowledge uses Nocloud other than uvt
[18:21] <smoser> ConfigDrive is different
[18:22] <smoser> how do id eal with root...
[18:23] <magicalChicken> we could try basing this on ConfigDrive then
[18:23] <magicalChicken> to test openstack support
[18:32] <smoser> i think nocloud is fine and rpobably best now. cofigdrive is a bit mroe entailed.
[18:32] <smoser> and we can get that easily enough from a real-ish opesnstack
[18:32] <smoser> https://gist.github.com/smoser/b32bb1c33564d1d46971cd9ded2e8477
[18:32] <smoser> magicalChicken, ^ that is a failsafe ssh that i had set up.
[18:33] <smoser> i think there are some bugs in it, but it is a starting point
[18:33] <smoser> and https://code.launchpad.net/~smoser/+junk/backdoor-image
[18:33] <magicalChicken> smoser: nice, that looks pretty easy to use
[18:33] <smoser> that backdoors an image, adding a user that can sudo
[18:34] <smoser> it might be nice to hook in the failsafe root console too
[18:34] <smoser> for debugging
[18:35] <magicalChicken> yeah, I could add that as a setup_image option
[18:35] <smoser> you add that, and then hit 'alt-f2' and 'enter' and root prompt
[18:35] <smoser> :)
[18:35] <magicalChicken> smoser: nice, would be good for vmtests too
[20:21] <powersj> magicalChicken: when I check out your branch I need to create a tag before I build it looks like
[20:22] <magicalChicken> powersj: the integration-testing-invocation-cleanup branch?
[20:22] <powersj> do you run something like `git tag -a 0.7.9 -m "my test"`
[20:22] <powersj> yeah
[20:22] <magicalChicken> no
[20:22] <magicalChicken> it should just work
[20:22] <magicalChicken> it commits inside the build container, so it doesn't mess with the main repo
[20:22] <powersj> well running the tox citest_run fails because git describe fails
[20:22] <magicalChicken> I'm not sure why that's happening
[20:22] <magicalChicken> is git describe failing inside the build or on the host?
[20:23] <powersj> Is this the proper way to check out your branch?
[20:23] <powersj> git clone -b integration-testing-invocation-cleanup https://git.launchpad.net/~wesley-wiedenmeier/cloud-init
[20:23] <powersj> host
[20:23] <magicalChicken> I'm not even sure what would be calling git describe in the host other than tox
[20:23] <powersj> well that is where it fails
[20:23] <magicalChicken> and the zip build by tox isn't used for anythign really, it shouldn't affect anything
[20:24] <magicalChicken> does tox -e flake8 work?
[20:24] <powersj> here is an example of what I was doing but via jenkins: https://jenkins.ubuntu.com/server/job/cloud-init-citest-run/1/console
[20:25] <powersj> and no flake8 or just 'tox' doesn't work until I create a tag with 0.7.9 in it
[20:25] <magicalChicken> its failing before cloud_tests are even called
[20:25] <magicalChicken> something broke in the git clone
[20:25] <powersj> after cloning I don't have any tags from your branch
[20:26] <magicalChicken> ?
[20:26] <magicalChicken> why
[20:26] <powersj> no idea but git tag -l shows nothing
[20:26] <magicalChicken> Let me try to clone in a clean environment, I have no idea how that would happen
[20:27] <powersj> (this is where my git foo is lacking)
[20:33] <magicalChicken> powersj: I'm seeing the same issue with git describe from cloning with that url
[20:33] <nacc> what repo (i can try and help resolve the git side, at least)?
[20:34] <magicalChicken> nacc: ~wesley-wiedenmeier/cloud-init:integration-testing-invocation-cleanup
[20:34] <magicalChicken> nacc: I think it must be something to do with cloning via https on launchpad, because using my ssh key it works
[20:35] <nacc> magicalChicken: hrm, i see no tags over in your repo?
[20:35] <nacc> https://git.launchpad.net/~wesley-wiedenmeier/cloud-init/refs
[20:36] <nacc> seems to only list branches?
[20:36] <magicalChicken> nacc: that is really strange, i see tags on my working copy
[20:37] <nacc> magicalChicken: with a fresh clone? let me also try locally
[20:37] <magicalChicken> maybe I'm only seeing the tags from my upstream remote and they didn't get pulled in
[20:37] <magicalChicken> I'm going to try with a fresh clone again, maybe my repo just doesn't have tags at all
[20:38] <nacc> magicalChicken: it's possible you only pusehd your branches and not tags by refspec? (or with --tags)
[20:39] <magicalChicken> nacc: I might have, would 'git push --tags' resolve?
[20:39] <nacc> magicalChicken: presuming that's what you want to do (push all your local tags) (and you might need to specify a remote, depending on your git configuration for that repository)
[20:40] <magicalChicken> nacc: I have my repo set as default remote, I think it worked
[20:40] <magicalChicken> There's the same tags as upstream at https://git.launchpad.net/~wesley-wiedenmeier/cloud-init/refs now
[20:40] <magicalChicken> I must have just messed up when I set my repo up originally
[20:40] <nacc> yep i see tags now
[20:41] <magicalChicken> nacc: thanks for the help, I'm still not great with git
[20:42] <magicalChicken> powersj: clone + describe is working now
[20:42] <powersj> magicalChicken: ok
[20:42] <powersj> nacc: thank you!
[20:42] <magicalChicken> http://paste.ubuntu.com/23783539/
[20:42] <nacc> magicalChicken: np! i think by default, unless you specify a push refspec in your git config, `git push` only pushes your current branch (see `man git-push` for the defaults)
[20:43] <magicalChicken> i guess that makes sense as default behavior since you may have tags just for your own reference
[20:43] <nacc> yep
[20:51] <smoser> powersj, you dont have the tags locally
[20:51] <smoser> nacc knows that sort of stuff
[20:52] <smoser> powersj should be relying on the upstream tag
[20:52] <powersj> smoser: yeah I believe nacc got us all sorted out now :)
[20:52] <smoser> ah. i see.
[20:52] <powersj> no more little hack
[20:53] <powersj> magicalChicken: https://paste.ubuntu.com/23783582/ on my laptop things timed out, on jenkins it is running just dandy :\
[20:54] <powersj> jenkins run so far: https://jenkins.ubuntu.com/server/job/cloud-init-citest-run/2/consoleText
[20:54] <powersj> is there a way to triage where it is getting stuck or slowing down?
[20:57] <magicalChicken> this is all running on old pylxd so stuff may be failing silently
[20:57] <magicalChicken> looks like jenkins run is working perfectly though
[20:57] <powersj> yeah
[20:57] <magicalChicken> I'm not sure what caused timeout on your laptop
[20:57] <powersj> hmm
[20:57] <magicalChicken> looks like it failed before the first instance ever booted
[20:57] <powersj> I will disconnect from VPN and make sure that isn't killing me again
[20:57] <magicalChicken> yuo may want to try increasing timeout a bit for bddeb
[20:58] <magicalChicken> i thought about adding a flag to adjust it but it didn't seem needed on a decent internet connection
[20:58] <magicalChicken> because the initial boot for bddeb installs devscripts and that has a ton of deps
[20:59] <magicalChicken> also, looking at this, I should have used run_stage for the tree_* commands, since it tried to go and do the actual run even though build failed
[20:59] <magicalChicken> I'll switch to using that real quick, it'll be cleaner too
[20:59] <powersj> ok and which timeout should I bump?
[20:59] <magicalChicken> xenial boot timeout
[20:59] <powersj> ok
[21:00] <powersj> ah ok so the generic timeout for a release
[21:00] <magicalChicken> with the old img_conf there's only one
[21:00] <powersj> ah that's right
[21:01] <magicalChicken> it takes ~80 seconds for me to do initial boot including installing devscripts for bddeb, so I could see it taking 120s if you're on vpn
[21:05] <powersj> yep it took just under 3 mins
[21:05] <magicalChicken> :(
[21:06] <magicalChicken> that's way slower than it should be, but i guess its just network speed
[21:06] <powersj> I don't have the best connection when I'm in WA
[21:06] <magicalChicken> the problem is devscripts has py2 deps
[21:06] <magicalChicken> so tons of stuff gets pulled in
[21:07] <smoser> nothing you can really do about it.
[21:07] <smoser> you cant test a deb without buildling a deb
[21:07] <magicalChicken> its fine for jenkins since the servers have good network
[21:07] <smoser> still not really ok.
[21:07] <smoser> its still a *ton* of io
[21:08] <smoser> but, dont know what we can really do about it.
[21:08] <magicalChicken> I think the bddeb/tree_run paths are really only for testing stuff in local branches anyway
[21:08] <smoser> bddeb could probably us dpkg-buildpackage
[21:08] <magicalChicken> Jenkins can just build 1 deb and use it for all tests
[21:08] <smoser> which has a bunch less
[21:08] <magicalChicken> yeah, debuild may be overkill
[21:08] <smoser> well, it can also just use the daily build ppa
[21:09] <smoser> and not build anything
[21:09] <magicalChicken> yeah, that's probably the cleanest way to do it
[21:09] <magicalChicken> ppa support works well, I pretty much only use that for local testing
[21:14] <powersj> magicalChicken: so the use case for this was a local developer (e.g. rharper) creating a test and wanting to try it out without needing a whole build env.
[21:14] <rharper> smoser: in general, when I'm working on a fix that adds a test-case change, it'd be nice to be able to push the current try into the image and run that; like we have with curtin;  a close second is building out of tree, which is what magicalChicken was doing;  at least for me, that's a useful workflow for iterating on code/testcases
[21:14] <powersj> ^^^ that :P
[21:14] <rharper> powersj: well, waiting on ppa build sucks
[21:15] <powersj> right, so help you
[21:15] <powersj> so waiting for this is a small price to pay versus a ppa
[21:15] <rharper> and the followup for magicalChicken was that his package/bddeb didn't work so do it in a "clean" environment
[21:15] <smoser> rharper, of course it is.
[21:15] <rharper> I think it would be nice if we had a pack equivalent since that's even faster but
[21:15] <smoser> i wasnt saying that it wasnt.
[21:15] <magicalChicken> Yeah, my python installation is most likely the cause
[21:15] <rharper> smoser: ah, sorry
[21:16] <smoser> we could add an "install from trunk"
[21:16] <smoser> but then you end up building yourself a package manager or all the stuff that is being put intot he package already.
[21:17] <magicalChicken> The bddeb route can run completely (bddeb + 1 test case) in 3 minutes for me, which isn't too bad
[21:17] <magicalChicken> s/3/4
[21:17] <magicalChicken> Once we're preserving images as well instead of downloading each time it'll be closer to 2, so I think that's fast enough
[21:23] <rharper> magicalChicken: and we re-use the base-image-download + inject bddeb
[21:23] <rharper> so, we shouldn't pay that cost more than one per base-image
[21:23] <rharper> right ?
[21:24] <magicalChicken> rharper: yeah, we'd just keep all the base images downloaded
[21:24] <magicalChicken> then make a copy (which uses zfs copy on write) for the snapshot+instance used to build the deb in and the snapshot+instances for tests
[21:24] <magicalChicken> so only 1 download, and possibly none if we already had an up to date image from running tests before
[21:25] <rharper> y
[21:35] <powersj> magicalChicken: https://paste.ubuntu.com/23783735/ a timing example for you
[21:36] <magicalChicken> powersj: that's pretty slow, but 4 minutes of that were downloading images
[21:36] <powersj> let me hop off vpn and try again brb
[21:38] <magicalChicken> I just ran with 'tox -e citest_run -- -n xenial -t modules/final_message' and got 'real    5m5.283s' for time
[21:38] <magicalChicken> not much better, but a bit
[21:49] <powersj> well that made no difference
[21:49] <magicalChicken> probably limit is local isp, not the vpn then
[21:50] <magicalChicken> I'm working on config for keeping images right now, going to cherry pick new img_conf format out of devel branch back to version in master, add it on there, then rebase bddeb on that
[21:50] <magicalChicken> that'll be the biggest speed increase possible
[21:52] <powersj> magicalChicken: ok I'm about to comment on the merge with the tests I have run so far
[21:53] <magicalChicken> cool