| === chihchun_afk is now known as chihchun | ||
| === LiQiong_Lee1 is now known as LiQiong_Lee | ||
| === chihchun is now known as chihchun_afk | ||
| === _salem is now known as salem_ | ||
| kalikiana | timp: the MR for MainWindow is https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow/+merge/301278 - see the segfault on applicationName here (search for mainwindow) https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1343/console | 12:26 |
|---|---|---|
| timp | checking | 12:40 |
| timp | kalikiana: does it only fail on specific architectures? | 12:42 |
| timp | kalikiana: I would add some prints to setApplicationName() to see more precisely where it fails | 12:45 |
| kalikiana | No, multiple architectures. Just the latest builds ran into flaky tests so the failure looks different. | 12:46 |
| kalikiana | timp: Yeah, I might just do that. I'm running out of ideas what to check for by manual code review. | 12:46 |
| timp | where is setApplicationName called? | 12:47 |
| timp | kalikiana: note that in ucmainviewbase.cpp we have if (applicationName != QStringLiteral("")) { | 12:51 |
| timp | so not applicationName.isEmpty() | 12:51 |
| timp | I wonder if the applicationName QString can be not properly defined | 12:51 |
| timp | maybe it is just a performance optimization | 12:52 |
| timp | but you'd want to do that too then | 12:52 |
| kalikiana | timp: Hmmmm, will give that a go. I was aiming to stick to the same behavior anyway for consistency | 12:54 |
| kalikiana | Those are exactly the things that are easy to miss | 12:54 |
| timp | my guess is that it was a performance optimization that zbenjamin was doing. So not sure if it has something to do with the current failure | 12:55 |
| timp | but consistency is good | 12:56 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!