| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === JanC is now known as Guest39941 | ||
| === JanC_ is now known as JanC | ||
| === ricardokirkner is now known as pindonga | ||
| === _salem is now known as salem_ | ||
| === pindonga- is now known as pindonga | ||
| === ricardokirkner is now known as pindonga | ||
| zsombi | kalikiana: shouldn't we add theme property to MainView in addition to units and i18n? | 12:37 |
|---|---|---|
| zsombi | in this way it could replace the context property | 12:37 |
| zsombi | kalikiana: I can add that in an incremental MR if you think... | 12:38 |
| kalikiana | zsombi: Maybe; I wanted to get the MainWindow in first for exactly those benefits. So the proof that it works is there. But I wasn't sure if we'd want to add to MainView - we'd probably prefer everyone to migrate and that's one of several benefits you get from moving over. | 12:40 |
| kalikiana | And we can't remove the context properties anyway since existing apps could still be relying on them. | 12:41 |
| zsombi | ok, so I'll add the theme as increment | 12:41 |
| kalikiana | zsombi: Or did you mean 'to the MainWindow'? | 12:50 |
| kalikiana | Maybe I misunderstand the q | 12:50 |
| zsombi | yes, to the mainwindow... crap, I wrote MainView... | 12:50 |
| kalikiana | zsombi: Right, in that case yes | 13:10 |
| zsombi | kalikiana: so, do you want to add it, or want me to do it? | 13:10 |
| kalikiana | zsombi: Also, any opinion on the organizationName? Unity needs it - we could add it; otherwise they'd have to keep using C++ for that | 13:10 |
| zsombi | kalikiana: we could add it, but we make it as empty by default? | 13:11 |
| kalikiana | zsombi: Yeah, that's what I was thinking. The default would match the current behavior, and any app that needs it can set it | 13:11 |
| zsombi | kalikiana: yup | 13:12 |
| kalikiana | Mirv: Mind having a look at this gles-only failure? It looks as if the temporary folder isn't being created properly https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1350/console | 15:22 |
| kalikiana | Before this MR it wouldn't fail since it silently skipped errors | 15:23 |
| kalikiana | ^^ This is https://code.launchpad.net/~kalikiana/ubuntu-ui-toolkit/wrapAndSort/+merge/314411 | 15:23 |
| Mirv | kalikiana: maybe that dirname $0 works differently than what one would think, but that seems mysterious enough to not be solved without some manual test output like echo $(dirname $0) , ls -l ../debian/ , ls -l $tmpdir/ on various lines to try to decipher what's wrong. at least the original check did report problems earlier, so I can't imagine how control.gles would not be there | 15:33 |
| === chihchun is now known as chihchun_afk | ||
| kalikiana | Mirv: Hmmm good idea, didn't think of that | 15:42 |
| kalikiana | Thanks | 15:43 |
| kalikiana | mzanetti: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/organizedWindow/+merge/314631 We talked about the organizationName in context of Unity using the MainWindow I think, so FYI | 15:43 |
| mzanetti | kalikiana, mhm, ok, not 100% sure what to do with it though | 16:24 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!