| === chihchun_afk is now known as chihchun | ||
| zsombi | kalikiana: we have a small problem with the theming in MainWindow | 09:21 |
|---|---|---|
| zsombi | the theming extension is made for QQUickItem, and that doesn't really work now on the window | 09:21 |
| matv2 | I already asked over at #ubuntu-touch but this probably the better group | 09:26 |
| matv2 | I did an update to an app of mine in the store yesterday which got aproved okay but isnt getting published | 09:26 |
| matv2 | am I missing something or is this a click store issue | 09:27 |
| popey | matv2: or here :) | 09:34 |
| matv2 | oh hi popey | 09:35 |
| matv2 | stUd | 09:35 |
| matv2 | is the appname :) | 09:35 |
| matv2 | matv1 is my devname | 09:35 |
| popey | looking... | 09:36 |
| === faenil is now known as faenil_ | ||
| popey | matv2: click the publish button at the bottom of https://myapps.developer.ubuntu.com/dev/click-apps/4735/rev/9/ | 09:36 |
| matv2 | popey argh | 09:40 |
| matv2 | sorry | 09:40 |
| popey | np | 09:41 |
| popey | it's a silly place to have a button IMO | 09:41 |
| * popey pokes pindonga :) | 09:41 | |
| popey | you're not the first and won't be the last not to find a button at the bottom of the page. | 09:41 |
| matv2 | on the other hand, I apparently had no trouble finding that button the previous 8 times as this is the 9th update :) So its really me going senile. No way around it :( | 09:45 |
| kalikiana | zsombi: Hmmmmm so QQuickWindow can't be themed, as it's a QObject... but we don't actually need to load a theme, right? All we need is to propagate the value | 09:49 |
| zsombi | kalikiana: it can be themed, but I need to do more modifications on the UCThemingExtension and UCTheme so it works with other than QQuickItem | 09:50 |
| zsombi | yes, all we need to propagate the theme changes to the children | 09:50 |
| zsombi | that's what UCThemingExtension also does | 09:50 |
| kalikiana | zsombi: I might have to check the code again.. I'm not sure why it would matter if it's an Item or an Object | 09:53 |
| zsombi | kalikiana: it uses some Item specific things, but I am in the middle to adjust the things | 09:54 |
| zsombi | it is the UCTheme which does watch some itemXXXChanged things | 09:55 |
| kalikiana | zsombi: Ah, I see now. We never expected to deal with objects there. I ran into that assumption even with a simple unit test earlier this week, where getting an *item* by object name used QQuickItem for no reason and didn't work for a window for that reason | 09:57 |
| zsombi | +! | 09:57 |
| zsombi | so a Window needs special treatment... | 09:58 |
| kalikiana | Yes and no... the logic of children and properties doesn't even need an Item | 09:58 |
| kalikiana | But we assume that's what we always get | 09:59 |
| kalikiana | The code just has some prejudice | 09:59 |
| kalikiana | artmello: I don't know if you've seen yet, but your MR now gets CI results https://code.launchpad.net/~artmello/ubuntu-ui-toolkit/ubuntu-ui-toolkit-clipboard-dbus/+merge/314072 Although it looks like a flaky one anyway so you can probably ignore that and focus to the ones you're adding | 10:58 |
| artmello | kalikiana: yep, I saw that, thx. We got new design spec for the clipboard ui so I put the tests on hold until I finish implementing that. Hopefully I am back to finishing the tests today | 10:59 |
| kalikiana | artmello: Oh, okay. So just FYI if you get them ready in the next couple of days we might be having a landing including your code | 11:00 |
| artmello | kalikiana: cool, I think it will be done by that | 11:01 |
| === faenil_ is now known as faenil | ||
| === faenil is now known as faenil_ | ||
| === _salem is now known as salem_ | ||
| === faenil_ is now known as faenil | ||
| daker | Does "Ubuntu.Components.TextArea" support support "append", i only see "insert" with position | 15:00 |
| daker | ? | 15:00 |
| kalikiana | daker: I'm afraid not. It's basically a matter of convenience: TextArea mirrors the most important API from TextEdit (QtQuick) | 15:06 |
| kalikiana | You can use insert, effectively appending it, or of course you can just .text += as well | 15:07 |
| kalikiana | If you were to propose a small MR adding "append" I'd say that's welcome - I don't know that it's absolutely necessary, personally, but it makes sense to add it for completeness | 15:08 |
| daker | kalikiana: TextEdit does have "append", for now i am doing textArea.text = textArea.displayText + str | 15:09 |
| kalikiana | daker: Right, hence my saying 'most important API'. It's a manual cherry-picking processes where someone finds a method worth having and we add it. | 15:24 |
| daker | kalikiana: ya i'll do it | 15:25 |
| kalikiana | Cool | 15:29 |
| kalikiana | Let me know when you, and I'll be happy to review it | 15:29 |
| daker | kalikiana: is this correct https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1658121/ ? | 15:56 |
| === chihchun is now known as chihchun_afk | ||
| kalikiana | daker: I see some unrelated changes in there | 15:59 |
| kalikiana | The last bit looks fine, though, if you could fix that | 15:59 |
| daker | kalikiana: ya not sure how do you branch guys, i just pulled trunk, made the change, commited and proposed the MR against staging | 16:01 |
| kalikiana | daker: You need to have a branch based on staging, not trunk | 16:01 |
| kalikiana | Probably need to rebase it | 16:01 |
| daker | kalikiana: ah ok tha's why, how can i rebase ? | 16:02 |
| kalikiana | Only landings go to trunk | 16:02 |
| kalikiana | daker: It might be easiest to just bzr branch lp:ubuntu-ui-toolkit/staging, and copy the changed TextArea.qml there, since you don't have any other changes | 16:03 |
| kalikiana | And make a new MR | 16:03 |
| daker | kalikiana: ok | 16:04 |
| daker | kalikiana: https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1658121/+merge/315241 | 16:13 |
| kalikiana | happroved! | 16:30 |
| daker | kalikiana: thanks! | 16:34 |
| === faenil is now known as faenil_ | ||
| === faenil_ is now known as faenil | ||
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!