[00:31] axw: Welcome back! How do you feel about advising on how to handle some juju2 controller unresponsive type of bugs? :-) [00:31] blahdeblah: thanks. absolutely miserable ;p just kidding, what can I help with? [00:33] So, I've got a juju2 controller not responding, meaning juju status doesn't work on either the controller model, or the single model it's supporting. [00:34] blahdeblah: ok, got logs for the controller? [00:34] Yep, but there's been nothing in machine-0.log since 2017-01-20 10:24:10 [00:34] (UTC) [00:35] Oh, looks like logsink.log is the new hotness [00:36] Nothing in that for over half an hour, though [00:36] blahdeblah: is CPU pegged? memory? disk? [00:37] axw: None of the above? :-) [00:37] hmmk [00:37] axw: Our normal process for this is just to restart jujud-machine-0, and it usually works, but I'm keen to get it narrowed down to which bug this is, and get you folks something useful to make progress on. [00:38] Oh, just got some log activity [00:38] Lots of API terminations [00:38] blahdeblah: what ports is jujud listening on? [00:39] tcp6 0 0 :::17070 :::* LISTEN 53852/jujud [00:39] after that flurry of log messages, juju status is now responsive [00:40] blahdeblah: huh :/ [00:40] blahdeblah: can you share the logs? maybe there's something buried that'll jump out [00:42] axw: So it turns out someone else started working on this too, and just restarted the agents [00:42] blahdeblah: doh [00:43] So I guess this will have to wait until next time [00:44] It's been happening reasonably regularly, though, so hopefully it will be something we can gather again soon. [01:09] axw, wallyworld or thumper: https://github.com/juju/juju/pull/6859 [01:10] says it's merged [01:10] menn0: wrong PR? [01:10] axw: right you are: https://github.com/juju/juju/pull/6866 [01:11] ok, looking [01:15] menn0: should we also be changing the cleanup job to now remove dead local charm docs, since we don't need them for revnum checking anymore [01:16] wallyworld: yeah, I almost did that but left it out for now to save time [01:16] wallyworld: i'll do that tomorrow [01:16] ok [01:29] axw: do you remember if we create an ubuntu user for centos? [01:29] axw: and whether centos has sudo? [01:30] thumper: cloud-init creates the ubuntu user [01:30] thumper: and yes it does [01:31] axw: can lxd provider on ubuntu deploy a centos container? [01:31] menn0: LGTM [01:31] oh, I see wallyworld has some comments tho [01:31] axw: thank you [01:31] a few yeah [01:32] thumper: not at the moment. there's probably not *too* much to do to get it to work [01:33] hmm... ok [01:33] thumper: I did try using manual with the centos LXD image at one point, IIRC it didn't work because they didn't have sshd running by default? [01:33] thumper: or something else was missing, I forget [01:33] * thumper nods [01:37] thumper: lxc image list lcorg: | grep -i centos [01:37] thumper, axw: if sshd isn't running you can always lxc exec in and sort that out [01:55] * redir is eod [01:58] menn0: if there are existing tests for removing dead charm docs and checking new rev numbers, how did they pass without sequence support? [01:59] wallyworld: previously charm revs were calculated by keeping all charm docs around, including dead ones [01:59] menn0: yeah, it was just that it wasn't working OOTB. I think there may have been other things too [01:59] also, with the addition of "-1" to the charm urls in MakeCharm(), was that an across the board change or just for those metrics ones? [01:59] too long ago, can't remember now [02:00] axw: yeah, the images don't even have sshd installed, they are very bare bones [02:00] wallyworld: it should never have been valid to add charms with no revision, but State.AddCharm was allowing it and those (buggy) tests were taking advantage of it [02:01] wallyworld: with my changes that's no longer possible, which caused the tests to fail [02:04] so in apiserver/uniter/uniter_test [02:04] s.meteredCharm = s.Factory.MakeCharm(c, &jujuFactory.CharmParams{ [02:04] Name: "metered", [02:04] URL: "cs:quantal/metered", [02:04] isn't that a case where the revision is missing? [02:06] my other comment about testing the url rev number incrementing - unless we remove dead charm docs manually in the unit tests, they will still be around right? which means we are not 100% sure we are testing that the seqence behaviour is hooked in [02:08] wallyworld: ah ha, the prep code which requires a revision is specified only applies to local charms and that's a store charm [02:08] wallyworld: that's why the test still passed [02:08] doh! missed that [02:08] wallyworld: it's technically not correct though right? [02:08] probably not, but outside the scope of this change [02:09] wallyworld: I'll do the removal of charm docs tomorrow (and will make it part of that PR) [02:09] ok, ta. do you agree with my point about thAT? [02:09] * wallyworld hates caps lock being next to the A key [02:10] wallyworld: I see your point (although you can obviously see that the code which queries the collection to find the next rev number has been replaced) [02:10] oh FFS [02:11] poop [02:11] i can. but...... uness we remove the old artifacts that made it possbile for the old behaviour to work, we can't be sure [02:11] i relaise it's pedantry [02:11] TDD, write failing test, fix code, make tests pass [02:12] there's no failing tests here [02:12] since the dead docs still exist [02:12] well, i guess if the code is removed they would have fsiled [02:17] menn0: that dutch skit was great thanks [02:19] redir: my wife showed it to me last night. i had tears rolling down my face [02:22] well, fuck me, that worked [02:22] I'm mildly surprised... [02:36] axw: azure pagination - if I don't pass anything for the top-n parameter to a list, will it return all the results at once, or do I still need to handle next-result getting? [02:36] babbageclunk: I believe you have to handle next result still [02:36] babbageclunk: (we're not doing that anywhere yet, I know) [02:36] axw: yeah, thought that might be the case - thanks [02:37] babbageclunk: limits on VMs, vnets, etc. preclude there being too many of a single resource AFAIK, but when you're listing all resources it might be needed [02:38] axw: ok - it's not too fiddly, just thought I'd make sure. [02:49] axw: gah - I can't work out what resourceProviderNamespace and parentResourcePath should be in the CreateOrUpdate call. The docs only tell me helpful things like "The namespace of the resource provider." [02:50] axw: sorry to keep bugging [02:50] babbageclunk: no worries [02:50] babbageclunk: un moment [02:54] babbageclunk: the namespace is something like "Microsoft.Compute", and parent resource path is the URL path proceeding the namespace, preceding the resource type. e.g. for security rules, the parent resource path will be something like "networkSecurityGroups/{network-security-group-name}" (I think) [02:54] babbageclunk: compare https://docs.microsoft.com/en-us/rest/api/resources/resources to the path template in https://msdn.microsoft.com/en-us/library/azure/mt163645.aspx [02:55] babbageclunk: Microsoft.Network is the namespace, "securityRules" is the resource type, {security-rule-name} is the resource name [02:55] babbageclunk: everything between the namespace and the resource type is the parent resource path [02:56] axw: thanks, that's awesome! There turns out to be a lot of azure to understand. [02:59] thumper: are we using the tech-board HO? [04:58] axw: can you take a look at this? https://github.com/juju/juju/pull/6868 [04:59] babbageclunk: okey dokey [04:59] axw: WIP at the moment - I'm doing tests now. [04:59] babbageclunk: just eating atm, will look soon [04:59] axw: thanks, no rush! [05:19] babbageclunk: you should be able to get the azure creds that CI uses [05:19] babbageclunk: and test with them [05:21] babbageclunk: just looking for them, will pm [05:35] wallyworld: can you please review https://github.com/juju/juju/pull/6869 when you're free? [05:35] sure, give me 5 [06:01] axw: looks good, a nice refactoring [06:01] wallyworld: thanks [07:20] wallyworld: got time for a HO? I need to brainstorm on a problem I've encountered with LXD creds [07:21] axw: otp with uros, give me 10? [07:21] wallyworld: no rush, let me know when [07:42] axw: free now [07:43] wallyworld: I think I figured out what I need to do. I'll ping you later if I'm wrong :) [07:47] axw: ok, no worries. i may be afk for dinner or whatever but i'll be around [07:47] wallyworld: np. it can wait if not [07:47] wallyworld: enjoy your long weekend [07:47] will do :-) [07:48] i still need to land a pr first === frankban|afk is now known as frankban === rvba` is now known as rvba [09:33] Morning [12:09] morning perrito666 [12:09] anyone want to review my attempt to make "juju ssh" better when the remote machine has multiple addresses? [12:09] https://github.com/juju/juju/pull/6857 [12:18] Hey I'll be unresponsive for the next couple of hours my wife is at the hospital with a stomach issue mail me If you need me [12:21] perrito666: I hope everything is ok. hope she feels better soon [13:37] axw: babbageclunk: so I noticed both of you guys are making changes to how we're doing clouds between 2.1 and 2.2. I'd like to make sure your changes are resolved relative to each other. [13:37] specifically babbageclunk worked on playing with the names, while it looks like axw got rid of the clouds.BuiltinClouds map [13:37] I'm trying to make sure other 2.1 landed features get forward ported to 2.2 [13:37] can I get some hints as to how this should be resolved? [14:46] Another bless what a week [14:46] lol congrats jujuteam [14:56] balloons: ping [14:59] hey jam [14:59] hi balloons. I just sent you an email. Is it possible for us to carve out some time to go over CI and 2.1-dynamic-briges? [14:59] jam, sure [14:59] I need to go spend time with my family before they disown me, but I can come back in a few hours. [15:00] jam, see to that and we'll talk later [15:01] balloons: I sent a tentative invite [15:01] have a good one [15:37] jam: AFAICT, trusty seems ok for the testing I have done. [16:24] morning [16:39] jam: https://github.com/juju/juju/pull/6870 <<- bond-reconfigure-delay [17:18] cmars: Is there a way to remove a term from a charm? One of the IBM charms still has lorem-ipsum [17:18] mbruzek, push a new version of the charm to the charmstore without that term in the metadata === natefinch is now known as natefinch-afk [18:33] frobware: I reviewed it, I feel like it would be better to be having the config of 'bond-reconfigure-delay' but have the API down to the script itself just think in terms of "reconfigure-delay" [18:33] so the API server notices this is a bond, and sends a different value [18:33] rather than having the "is this a bond" in the script [18:33] is that too invasive? [18:34] jam: yep, we could do that. i think... [18:35] jam: can we discuss this in the morning? [18:35] frobware: certainly [18:35] jam: it would be ideal to shore up these changes _this_ _week_ [18:36] * frobware sighs. [18:36] yep [18:36] frobware: I think its ready to land with that change, as I'm happy with the rest [18:37] jam: there was one additional test I thought of in config.go; we test for a custom value, but I don't think for the default value. [18:37] jam: when you say "just think in terms of "reconfigure-delay"" - is that just naming or a deeper semantic change? [18:40] frobware: the script should not have the "is this a bond", but the api server should be making that decision and returning a value for the bridges it is creating [18:40] jam: ok, so if you pass reconfigure-delay= it will do the sleep regardless of type. yes? [18:41] jam: we're just talking about the origin of truth, correct? [18:41] frobware: if the script gets that value yes [18:41] jam: makes sense. [18:41] the thing deciding how long to sleep is the API server [18:41] jam: and it should know the device type/kind/category. [18:41] right [18:42] jam: caveat emptor: if you run the script manually (as I do a lot) don't forget to pass a value. Just sayin... [18:43] frobware: have a default value of 1-3 ? [18:43] or a default value of 10-20 ? [18:43] jam: 3 was a winner for so long. I vote for 4.2. [18:43] frobware: then if you forget it still fails saif [18:43] :) [18:44] jam: so we're saying cli arguments win, but if not supplied we'll default to 4.2 (or 3). correct? [18:44] frobware: yeah, you had a default of 30 in the script already if I read it correctly [18:45] jam: ah, crap. Hmm. [18:45] frobware: add_argument(..., default=30) I thought I read [18:45] jam: this from my hacking.... probably.... [18:46] jam: I had meant to leave it to whatever it was previously knowing full well that it would be driven from model-config. but perhaps 30 is nice and safe if you run it manually. [18:47] frobware: seems a little too safe [18:47] frobware: especially if it is the one that SSH is talking on and you wonder if everything is dead [18:47] jam: a interface is better up than down. :) [18:48] jam: so the only time you'll get 30 is if you specify 0 from juju for bond-reconfigure-delay. [18:48] frobware: we should just always pass the aggregate value [18:48] even if it is 0 so it overrides the default [18:48] * frobware needs to go and look at this to make sure. But tomorrow now... [18:49] jam: I think this comes back to: who drives the value and why do we need a default. if juju passes 0, you get 0. if it passes 1234, you get ... and so on. [18:49] jam: should the script carry a default? [18:50] frobware: the reason for a default is if you run the script by hand (IMO) [18:51] jam: right. but I would counter, it has no documentation, is wrapped up by juju so in the true spirit of *nix you have rope to hang yourself with. [18:52] sounds like you're just trying to be spiteful now :) [18:52] jam: you might be interested in: https://github.com/frobware/juju/tree/go-debinterfaces [18:53] jam: I started a rewrite of the script in Go. The parsing side is done, there's 100% test coverage. I didn't do the bridging side as... [18:54] jam: code is in juju/network/debinterfaces/... === redir is now known as redir_exercise === redir_exercise is now known as redir === tvansteenburgh1 is now known as tvansteenburgh === menn0_ is now known as menn0 === frankban is now known as frankban|afk [23:50] thumper, ping