| === salem_ is now known as _salem | ||
| kalikiana | sliff | 08:47 |
|---|---|---|
| zsombi | indeed :D | 09:17 |
| zsombi | kalikiana: renatu: I am not sure you can affect the focus order of the Sections. Doesn't that use ListView to show the delegates? | 09:18 |
| zsombi | if yes, you're screwed, you cannot really affect the TAB order | 09:18 |
| kalikiana | zsombi: Yes, it does. That could be an additional problem. | 09:21 |
| zsombi | and, with the focus index, we'd add additional complexity :( | 09:22 |
| zsombi | as the delegates must then handke the TAB/BACKTAB themselves | 09:22 |
| zsombi | *handle | 09:22 |
| renatu | zsombi, timp, about the sections I like the way that works today. But if you see my email we are trying to change the header focus order and setting "KeyNavigation.tab: pageheader.sections" is not enough | 11:30 |
| timp | perhaps it needs to be changed in the header code itself | 11:35 |
| timp | so if the order must always be 1. header buttons, 2. header extension (sections), 3. page contents then maybe we can enforce that in the Page/Header components | 11:36 |
| === _salem is now known as salem_ | ||
| zsombi | timp: that can be driven by the order they are instantiated | 11:55 |
| kalikiana | timp: It seems to be 1. header contents 2.page contents 3. header actions in this case but yeah, possibly it could be defined like that - the question is, is that fine for all apps, or do we need to allow changing that order as well | 11:56 |
| timp | I'd say it is the least confusing for users if it is always the same. | 11:57 |
| timp | but we need a bug report and then someone from design to decide :) | 11:57 |
| kalikiana | zsombi: from the component itself it's easy enough to override even after the fact. the question is if it needs customizing - in my proof of concept I used KeyNavigation.tab | 11:57 |
| kalikiana | timp: I do agree, consistency is king | 11:58 |
| renatu | timp, I did not add you in the e-mail sorry, let me forward it to you | 12:21 |
| zsombi | kalikiana: right, that overrides the default tab handling | 12:39 |
| zsombi | but may not work in the ListView... but seems it doesn't need to | 12:39 |
| Mirv | FYI stable overlay now has Qt 5.6.2 for xenial, up from 5.6.1. It should not affect you, but maybe nice to know and it might have a fix for your Qt bug of you had one bugging you. | 14:29 |
| Mirv | After all upstream did hundreds of bugfixes over five months or so. | 14:29 |
| timp | renatu: thanks. The image is missing from the e-mail. | 14:31 |
| timp | renatu: if you report the bug we'll discuss it with design | 14:31 |
| renatu | timp, I will, thanks | 14:31 |
| === boiko_ is now known as boiko | ||
| kalikiana | Mirv: You realize that can also be read as "hundreds of potential new bugs"? :-P | 14:44 |
| renatu | timp, kalikiana https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1659869 | 15:00 |
| ubot5 | Ubuntu bug 1659869 in ubuntu-ui-toolkit (Ubuntu) "Page header and focus behaviour " [Undecided,New] | 15:00 |
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| timp | mpt_: hello. Can you have a look at the bug above, or if you're not working on UITK ask someone who is? | 15:14 |
| Mirv | kalikiana: nooooo :) | 15:15 |
| mpt_ | looking | 15:15 |
| === JanC_ is now known as JanC | ||
| timp | kalikiana: I approved https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-app-platform/+git/ubuntu-app-platform/+merge/315696 and https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-app-platform/+git/ubuntu-app-platform/+merge/315701 but there's no autolanding. | 15:16 |
| timp | do you want to merge them? | 15:16 |
| Mirv | I trust their LTS QA are sensible, they have also rejected changes based on not being suitable for LTS. Overall, it should be beneficial. 5.6.3 will follow by June or so. | 15:17 |
| matv2 | hi I am supposed to start converting my clicks to snaps. I have not yet worked withg snap untill now. As I have the clicks hosted on LP, what would be advisable? creating the click from within LP or doing it locally? Is there benefits to either one? | 15:30 |
| timp | I would first create snaps locally, so you can test it immediately without waiting for launchpad to generate it. | 15:30 |
| timp | matv2: there is a tutorial here https://tutorials.ubuntu.com/tutorial/create-first-snap#0 | 15:31 |
| timp | but once your snapcraft file is good and part of your code repository, I think you can set up launchpad to automatically create the snap when the code is updated. | 15:32 |
| timp | mpt_: thanks | 15:33 |
| matv2 | timp right, thanks you. I believe that tut isn't on snapcraft.io is it? Maybe I missed it but otherwise you might want to link to it. | 15:37 |
| timp | matv2: right, it is not there (at least I don't see it either). | 15:41 |
| timp | tutorials.ubuntu.com is quite new still, but I'll propose to add the link to snapcraft.io. | 15:42 |
| timp | thanks :) | 15:42 |
| mpt_ | timp, commented | 15:43 |
| renatu | popey, could you top approval this? https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051/+merge/315772 | 15:43 |
| renatu | popey, I do not have the permissions for that :D | 15:43 |
| timp | mpt_: thank you | 15:44 |
| kalikiana | timp: Oh, I remember talking about the CI setup. I guess I could have another look at that. I think something else more urgent prevented me from finishing the auto merging jobs. | 15:53 |
| * kalikiana doesn't like manual merges at all | 15:53 | |
| timp | kalikiana: yes, it would be great to have it :) | 15:57 |
| popey | renatu: lemme see | 16:55 |
| pmcgowan | renatu, not sure where popey went but I can approve it | 18:09 |
| popey | pmcgowan: had to setup my build env again to make the click | 18:28 |
| pmcgowan | popey, isnt it friday after 5pm :) must be a nearby pub calling your name | 18:30 |
| popey | i wish | 18:30 |
| popey | i have a meeting at 22:00 | 18:30 |
| popey | can't really do that from the pub | 18:30 |
| popey | testing the click on an m10, took a while to get the build env working.. won't take long to test | 18:31 |
| popey | \o/ that fixed it | 18:33 |
| popey | renatu: approved, thanks | 18:34 |
| pmcgowan | popey, use the old "my camera is not working" | 18:50 |
| renatu | popey, pmcgowan nice that is working. popey are you able to release a click on store for it? | 19:04 |
| popey | renatu: yes, I will publish an update | 19:06 |
| renatu | popey, thanks | 19:06 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!