/srv/irclogs.ubuntu.com/2017/02/07/#juju-dev.txt

stokachuwallyworld, should i be doing a PR against staging branch on GH?00:52
stokachuit's a small change to the bash completion so nothing major00:52
anastasiamacstokachu: what release is it for?00:52
wallyworldstokachu: propose against develop. that will get into staging automatically after each blessed CI tun00:52
anastasiamacstokachu: develop is essentially 2.200:52
stokachuok cool00:53
anastasiamacstokachu: if u need it in 2.1, propose against 2.100:53
wallyworldgood point if it's for 2.1 then PR gainst 2.100:53
anastasiamacstokachu: which will b merged in develop and then eventually staging00:53
stokachuok so propose against 2.1 branch and it will go into develop/staging?00:53
anastasiamacstokachu: yes00:54
stokachuanastasiamac, great, thanks00:54
anastasiamacstokachu: here to help \o/00:54
stokachuok lets see how this looks https://github.com/juju/juju/pull/692701:09
* anastasiamac looking01:09
stokachuanastasiamac, when you say flag do you just have to mention them and thats it?01:17
stokachuor do i need to do anything01:17
anastasiamacstokachu: I have "flagged" them by virtue of @ on github :) hipefully they'll notice and will know what to do with it ;)01:18
stokachuanastasiamac, ok cool thanks01:18
anastasiamacstokachu: ideally, we'd ove to have QA tests for this to ensure that code behaves but also that priorites are respected01:19
anastasiamaclove*01:19
stokachuanastasiamac, yea maybe some expect tests would be nice01:20
wallyworldperrito666: did you test your mongo tuning work when the server rebooted? it seems the values as set in mongo.go are not sticky01:44
perrito666I did I even upgraded01:46
perrito666You mean the cache size one?01:46
stokachuwallyworld, do you guys want a force push to squish additional commits into one?01:48
stokachuanastasiamac, ^01:48
wallyworldstokachu: many folks do that, some don't01:48
wallyworldus bzr refugees hate throwing away history01:48
stokachuis there a preference?01:48
wallyworlddepends who you ask :-)01:49
stokachuhaha01:49
anastasiamacstokachu: no preference here, but history is nice \o/01:49
stokachuok cool ill stick to that01:49
anastasiamacworld would b better place if history was remembered :D01:49
wallyworldexcept git discourages that :-(01:49
perrito666stokachu: in my opinion history is good while each commit compiles01:58
perrito666wallyworld: btw, did you see my answer to the mongo tuning?01:59
wallyworldwhich answer?01:59
wallyworldoh, that one01:59
wallyworldperrito666: i mean a server reboot01:59
perrito666wallyworld: but by tuning you mean the mongo cache size?02:00
wallyworldthe hugepage values are not applied again02:00
perrito666ahh I see, that is odd02:00
wallyworldwell ensure mongo is not run every agent start yo02:00
wallyworldup02:00
perrito666wallyworld: it should02:00
wallyworldunless i tested wrong02:01
wallyworldwhich i could have done02:01
perrito666wallyworld: mm, you might be right02:02
wallyworlddid you test it?02:02
wallyworldenesure mongo only runs at bootstrap i am almost certain02:02
perrito666wallyworld: I did, but I might have got confused by the syslog output02:02
wallyworldand hence the hugpage values are no reapplied02:02
wallyworldi can't see a way of adding those to sysctl.conf so will find another way02:03
perrito666wallyworld: I believe ensuremongoserver IS called upon restart but cant be sure because its inside a convoluted network of manifold nonsense02:04
perrito666this code looks like javascript spaghetti02:04
wallyworldEnsureMongo is called from jujud/bootstrap.go02:04
wallyworldthat is only run once at bootstrap time02:04
perrito666becaise its called by MachineAgent.initState which is passed as OpenState in machine.ManifoldsConfig02:04
perrito666wallyworld: EnsureMongoServer02:05
perrito666wallyworld: for reasons completely unknown to me: cmd/jujud/util/util.go:EnsureMongoServer = mongo.EnsureServer02:05
wallyworldright, called from func (c *BootstrapCommand) startMongo02:05
perrito666wallyworld: then cmd/jujud/agent/machine.go:if err := cmdutil.EnsureMongoServer(ensureServerParams); err != nil {02:05
perrito666wallyworld: that is eventually called by MachineAgent.ensureMongoServer02:06
wallyworldis that in 2.1?02:06
perrito666wallyworld: ghaa, that fix is not applied to 2.1 of course,02:07
perrito666it is though02:07
perrito666if you look at cmd/jujud/agent/machine.go line 135202:07
wallyworldok, i'll dig into it a bit02:08
perrito666the only difference is that a fix removing the if !mongoInstalled has not been applied02:08
wallyworldright, i do not want to remove that02:09
wallyworldthat check is there for a reason02:09
perrito666wallyworld: no, it isnt02:09
wallyworldremoving it would be wrong02:09
perrito666wallyworld: its wrong02:09
wallyworldif we have already installed mongo, there's no need to go through the work of doing it again02:10
perrito666wallyworld: that check means "if there is a service file for mongo dont make sure its there"02:10
perrito666wallyworld: its just por wording02:10
perrito666wallyworld: what it actually checks is that systemd/upstart file is there02:10
perrito666if not it re-generates it02:10
perrito666you want to re-generate it in case mongo parameters have changed02:10
wallyworldbut it all installs mongod all over again etc02:11
wallyworldEnsureMongo does a lot more than just mess with conf files02:11
perrito666wallyworld: it should be idempotent, if its not, something is effed up02:13
wallyworldis is of course. but it's unnecessary work02:13
wallyworldoverhead to starting up the agent02:13
wallyworldmessing with packaging etc02:14
wallyworldmaybe we don't care02:14
perrito666wallyworld: you are not restarting 1k times per second02:14
wallyworldstill potentially hits repos etc02:15
perrito666its an unnecessary optimization and, incidentally, also a bug :p02:15
wallyworldslow network would cause agent startup to hang for a bit02:15
wallyworldi disagree it's unnecessary02:15
perrito666wallyworld: allow me to quote william on that one: show me numbers02:16
wallyworldthere's a difference between applying new config and installing mongo02:16
perrito666apt will not hit repos for installed packages02:16
perrito666apt will just say "all this is installed" since the dependency resolution is done offline02:16
wallyworldi'll backport from develop then since it's already landed there02:17
perrito666wallyworld: :) see, all it takes is some civiliced conversation and quoting william02:18
wallyworldi still think we should have separated cfg management from othe rthings02:18
wallyworldit's just too hard to do anything else right now02:18
perrito666wallyworld: sure, also we should not have used mongo but we are too late to fix things done 2 years ago02:18
wallyworldwell changing this behaviour wasn't done 2 years ago02:19
thumperugh02:19
perrito666wallyworld: EnsureMongo is at least 2 years old02:19
wallyworldwe don't for example attempt to install over and over all of our other packages02:19
thumperfixing the conflicts in this branch is *awesome*02:19
wallyworldperrito666: sure ENsureMongo is 2 years old, but calling it every time unnecessarily isn't02:19
perrito666wallyworld: we dont install other packages, juju is not installed using apt02:20
wallyworldjuju install dependencies02:20
wallyworldusing apt as part of bootstrap02:20
perrito666wallyworld: perhaps we should02:20
wallyworlddisagree02:20
perrito666wallyworld: apt-get install on an already intalled package takes:02:21
perrito666real0m0.807s02:21
perrito666user0m0.768s02:21
perrito666sys0m0.028s02:21
wallyworldit's not just that - it's the inconsistent behaviour02:21
perrito666we install mongo separately from the other packages, its not entirely inconsistent02:22
wallyworldsome packages are reinstalled each agent start up, others aren't02:22
wallyworldanyways, looks like there's only one way forward02:22
perrito666wallyworld: there are not reisntalled, its a no-op they are never going to be reinstalled02:22
wallyworldi didn't mean that literally02:22
perrito666wallyworld: you are free to add an EnsureServerParams field that avoids the apt call if it makes you happy02:22
perrito666it should be trivial and harmless02:23
wallyworldnot for 2.1, i'll just stick to what was done for develop02:23
wallyworldwe haven't got time to change all that at the moment02:23
perrito666wallyworld: suit yourself, for me the apt call is free and harmless and consistent with a gazillion other idempotent behaviors and keeps mongo startup encapsulated02:24
perrito666leverage the tools at hand, no need to re-implement checks that the package manager does for free02:24
wallyworldnothing is ever "free" :-) but will stick to that02:25
perrito666wallyworld: we should have a discussion about marginal costs some day :p02:25
perrito666also my eye drops just stopped making effect so I am going to sleep02:25
wallyworldttyl02:25
wallyworldaxw: remind me, do we support controllers on redhat? or just ubuntu02:29
axwwallyworld: just ubuntu02:29
wallyworldok, ta. the kernal tweaks to disable hug pages are potentially different on redhat02:29
thumperhug pages?02:34
* thumper needs a hug02:34
anastasiamacthumper: potentially different hug, like redhat?02:35
thumper:)02:35
anastasiamaclooks like we are disabling hugs per above :D02:35
wallyworldsigh02:51
axwthumper: can you please take a look at https://github.com/juju/cmd/pull/46?03:06
* thumper looks03:07
thumperaxw: we don't need to do it this way... I don't think03:07
thumperaxw: we have other places that do special output for a single value03:07
thumperyou just don't call the format method03:07
thumperbut write the output03:07
axwthumper: we have a broken version in "model-config", which isn't honouring --output03:08
axwthumper: fixed in my upcoming PR03:08
thumperok03:08
axwthumper: the alternative would be to expose the io.WriteCloser to the command, but then it needs to close the file. seems a bit safer/neater this way to me03:09
* thumper nods03:09
thumperaxw: lgtm03:11
axwthumper: thanks03:11
* thumper out... 03:26
axwanastasiamac and/or wallyworld: when you can, please take a look at https://github.com/juju/juju/pull/692803:34
wallyworldok03:34
wallyworldaxw: what was the dep change?03:38
axwwallyworld: https://github.com/juju/cmd/pull/4603:40
wallyworldlgtm, thNK03:43
axwanastasiamac: what is "eda" ?04:25
anastasiamacaxw: Escaped Defect Analysis04:26
axwanastasiamac: okey dokey. thanks04:26
anastasiamacaxw: means it got out into the wild, should have been caught in QA by functional test (possibly)04:26
* axw nods04:26
anastasiamacaxw: QA specifically monitor bugs with this tag :) so it's a means of us flagging the bug to their attention...04:27
anastasiamacfor us*04:27
axwanastasiamac: ah ok04:27
pranav_Hi. I have a question regarding Cinder charm.06:07
pranav_If i locally modify the cinder.conf through the shell and then modify config through the juju-gui06:08
pranav_the local changes get overridden. Any workaround this?06:08
wallyworldpranav_: you may be better asking in #juju where likely to be folks with more direct experience on that issue07:14
blahdeblahAnything I can do to get new regions available in GCE on 2.0.2?07:20
anastasiamacaxw: m looking at ur 6929 pr :)07:24
pranav_wallyworld: doing it in parallel on both :)07:26
wallyworldif you don't what you need, an email to the juju list normally gets answers as well07:27
wallyworldblahdeblah: is the region in public clouds yaml? if so, update-clouds should do it07:28
blahdeblahwallyworld: I did an upgrade-clouds, and the regions closest to us (US West & Asia East) weren't there.07:29
wallyworldblahdeblah: hmmm, it may be the publoc clouds yaml needs updating07:30
wallyworldblahdeblah: yeah, the public clouds yaml file oooks out of date to me http://streams.canonical.com/juju/public-clouds.syaml07:32
wallyworldblahdeblah: you can for now edit your own clouds.yaml file with the new regions07:33
* blahdeblah looks for clouds.yaml07:33
wallyworldit won't be there unless you create it07:34
wallyworldyou can use juju add-cloud07:34
blahdeblahI've got a ~/.local/share/juju/clouds.yaml with canonistack & maas in it.07:34
wallyworldthat CLI command takes a cloud name and an optional yaml file07:34
wallyworldok, so you can copy the gce cloud info from public clouds and edit it07:35
blahdeblahOK - thanks; will give that a try07:35
wallyworldput it in your local file07:35
wallyworldkeep the cloud name the same - it will override the upstream07:35
wallyworldwe'll haveto organise to get publoc clouds yaml updated07:36
blahdeblahthanks wallyworld07:39
wallyworldi'm off to soccer soon, but let me know if you still have issues with the workaround07:39
blahdeblahthat seemed to work fine; much appreciated, wallyworld07:43
wallyworldyay, great07:47
wallyworldblahdeblah: i raised bug 1662449. no need to target to 2.1 since fixing the yaml will alllow 2.1 and 2.0.2 to get the latest regions with upload-clouds07:50
mupBug #1662449: public clouds missing google regions <juju:Triaged> <https://launchpad.net/bugs/1662449>07:50
blahdeblahI had it wrong; it was US West & Asia Northeast which were missing07:51
blahdeblahI'll update bug07:51
=== aluria` is now known as aluria
axwprotip: reboot -h does not mean reboot --help08:40
axwanastasiamac: if you're still around, here's another one: https://github.com/juju/juju/pull/693008:57
anastasiamacaxw: have soccer but m happy to look when/if m back08:59
axwanastasiamac: I hope you don't stay at soccer forever... thanks :p it can wait till tomorrow08:59
anastasiamacaxw: \o/ soccer forever... nice :D09:00
jamaxw: yeah, same for shutdown -h10:32
axwjam: yeah I knew that one, didn't realise reboot did the same10:33
axwreboot --halt seems weird10:33
axwpoweroff rather10:34
jamaxw: I have a feeling it is the sort of 'everything is linked to the same object'10:34
anastasiamacaxw: good one \o/ i hope it did not cause u too much pain ;(10:34
axwjam: yup. -> systemctl10:34
axwanastasiamac: nah, just annoying10:34
jamaxw: or ultimately "busybox" :)10:34
anastasiamacaxw: i imagine :)10:35
axwjam: can you bind an endpoint to a space after deployment?10:35
jamaxw: no, we don't have moving things10:36
jamaxw: we'd probably like to get there, but there are the risks around "not all units are in the same space"10:36
jamaxw: would you mind if we set up a regular "standup" like call together? I'm finding that without a team around it can be hard for me to organize my next steps sometimes.10:37
axwjam: sure, no worries10:37
axwjam: what time would be best for you? you're +4 right?10:38
jamyeah. start-of-my-day would be good, which is around UTC 5, but I'm open for whatever time10:41
axwjam: that'll work10:41
* axw bbl10:42
=== rogpeppe1 is now known as rogpeppe
anastasiamac_axw: (I hope u r afk but) LGTM :)11:19
axwanastasiamac_: thanks11:42
anastasiamac_axw: my pleasure \o/ awlways amazingly nice to see ur code ;)11:42
perrito666morning all11:44
anastasiamac_perrito666: o/11:45
perrito666jam: would you stamp the backport? https://github.com/juju/juju/pull/693111:57
jamperrito666: submitted11:58
perrito666jam: tx11:59
anastasiamac_perrito666: backports only need stamps if there is significant difference... if it's exactly the same as the originally reviewed code, feel free to self-stamp :) why re-invent the wheeel and re-stamp?11:59
jamperrito666 is probably worried that he'll accidentally get a tramp-stamp12:01
perrito666I am sure there is ajoke there12:01
jambut perrito666, I agree with anastasiamac_ that backports/forward ports can be self-stamped if there isn't any significant changes. With the caveat that 2.1 is in prep-for-RC mode so we should be careful what we want to put in it12:01
perrito666but it requires for me to google12:01
jamperrito666: any chance you could look at https://github.com/juju/juju/pull/693315:22
perrito666jam: certainly, any chance you can jump into the outage channel on the other irc? :) need a second opinion15:24
jamoutage?15:25
cory_fuWas credentials support added for lxd in the latest beta?  It has started prompting me for a credential when working with a shared lxd controller where it did not previously, and I have no credential to supply it with.15:49
perrito666jam: ship it15:54
jamcory_fu: axw was the one making some of those changes. I'm not sure how it interacts with existing LXD deployments. I think there is an upgrade step to fix that sort of thing, but that would be a 2.0=>2.1x upgrade16:04
jamvs a 2.1b4 => 2.1b516:04
cory_fujam: I don't understand.  This is a freshly bootstrapped 2.1b5 localhost controller.  I used add-user + grant, then registered the controller with another juju and tried to add model from there and it said "no controller specified."  This worked in the last beta.  I could add a credential for the controller like I have to do for aws, etc, but I don't have a credential to add16:09
cory_fujam, axw: So, I tried upgrading a juju 2.0.2 to the latest beta and then registering the controller, and I got a new error about an invalid credential: http://pastebin.ubuntu.com/23948469/16:29
jamcory_fu: sounds like a bug we need to address in 2.1b5, can you submit one and we'll poke axw to look into it16:34
cory_fuSure16:34
jamcory_fu: I know we were doing bad things with credentials and LXD before, it looks like fixing credentials may have broken multi-user16:34
cory_fujam: I'm currently testing whether how I bootstrapped it has an effect.  I don't recall if I bootstrapped it as lxd or localhost.  Testing with localhost to be sure16:35
cory_fujam, axw: Filed https://bugs.launchpad.net/juju/+bug/1662587  Thanks16:54
mupBug #1662587: 2.1beta5 breaks lxd shared controller <juju:New> <https://launchpad.net/bugs/1662587>16:54
redirmorning juju-dev (almost forgot!)17:22
alexisbmorning redir17:23
perrito666redir: morning17:24
redir:)17:24
mupBug #1662599 opened: Change maas api and password controller in model already created <juju-core:New> <https://launchpad.net/bugs/1662599>17:26
=== frankban is now known as frankban|afk
perrito666hey Ill step out for a moment and return later, cheers18:06
=== frankban|afk is now known as frankban
=== frankban is now known as frankban|afk
redirintermittent internet today19:26
redirlots of rains19:26
redirand winds19:26
redireasy PR: https://github.com/juju/juju/pull/693519:46
perrito666redir: ship it20:09
redirtx20:19
redirperrito666:20:19
redirwallyworld: yt?20:19
redirme steps away shortly to run a couple errands.20:48
kwmonroecory_fu!  i'm so l33t.  i shared a lxd controller and added a localhost stanza to the credentials.yaml on the remote user (jenkins in your case). it needs the contents of server.crt, client.crt, and client.key from the remote lxd host.  then a set-default-credential for jenkins, and bingo bango, add-model for days.21:50
kwmonroei'll expand on the workaround in https://bugs.launchpad.net/juju/+bug/1662587, but wanted to let you know in case you were stuck.21:50
mupBug #1662587: 2.1beta5 breaks lxd shared controller <juju:New> <https://launchpad.net/bugs/1662587>21:50
cory_fukwmonroe: Awesome!21:51
cory_fukwmonroe: Is that with beta5 on both the sharer and sharee?21:55
kwmonroeyou made up some of those words cory_fu21:55
kwmonroeyes, b5 all around21:55
cory_fu:)  Ok21:55
balloonsperrito666, you on-call reviewer?21:56
balloonscory_fu, ouch that bug21:57
perrito666balloons: no, but I am keen to review things if you need22:00
balloonsperrito666, ohh, well then; https://github.com/juju/juju/pull/693622:00
babbageclunkugh, who decided that using dashes as the separator between items that have dashes in them was a good idea?22:01
balloonsnot sure how much you've played around with snaps, so this is your chance to vet22:01
perrito666balloons: build-packages: [gcc] ?22:02
perrito666balloons: I have snapped things, go things to be accurate :)22:03
balloonsperrito666, that was requested by snapcraft upstream for there builder. It's no-change from the previou22:03
perrito666k then, lgtm, let me stamp it22:04
balloonsperrito666, mind trying out a build; I'm keen to make sure it's easy for developers to snap up there local repo22:04
kwmonroecory_fu: bug 1662587 updated if you need the steps..22:04
mupBug #1662587: 2.1beta5 breaks lxd shared controller <juju:New> <https://launchpad.net/bugs/1662587>22:04
balloonsnot sure how much you've tried to to that. snap, and then push to the store22:05
perrito666balloons: let me see if this computer has the snapcraft things22:05
balloonsperrito666, ahh, no worries if not22:05
perrito666balloons: building22:06
cory_fukwmonroe: Thanks.  Does set-default-credential actually work with beta5 on an imported controller?22:07
kwmonroe$ juju set-default-credential localhost hamburgalar22:07
kwmonroeDefault credential for localhost set to "hamburgalar".22:07
kwmonroeyeah, looks to work for me.. subsequent "juju add-model blah" don't need a --credential flag22:08
kwmonroe$ juju add-model see-cory-fu22:09
kwmonroeUploading credential 'localhost/cwr-ci/hamburgalar' to controller22:09
kwmonroeAdded 'see-cory-fu' model on localhost/localhost with credential 'hamburgalar' for user 'cwr-ci'22:09
kwmonroeand now i need to google how to spell hamburgalar.. i think it probably hamburgler22:10
kwmonroei'm sure that's not a special case in the juju code though, so you should be fine.22:10
cory_fukwmonroe: Ok, so they fixed that, so that's nice.  Not sure how we'll handle the transition, though22:11
cory_fukwmonroe: Interesting.  Doing `juju add-credential localhost` in 2.0.2 creates a cred with "auth-type: empty" and no other props, like we tried to create before22:12
kwmonroeit's hamburglar22:23
perrito666balloons: interesting, I have time to take a shower while snap builds juju22:27
perrito666actually I could take two since it has not finished yet and I am already back22:27
balloonsperrito666, :p22:34
cory_fukwmonroe: Good to know22:37
kwmonroe:)22:37
balloonswallyworld, perrito666, anastasiamac_, abentley, sinzui, https://github.com/juju/juju/pull/6936 is the PR. I have pushed 2.1-beta5 to the beta channel, and 2.0.2 to the stable channel. Check them out. snap install juju --classic and snap install juju --classic --beta23:13
balloonsthey should all "just work" as you expect23:13
sinzuithank you balloons23:14
wallyworldawesome23:14
balloonswallyworld, you'll note btw it uses your local tree by default, but there's a few options to specify tags, commits or branches as well as location. Should make dev builds easy23:15
wallyworldok, i'll check it out23:15

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!