| === rangerpb is now known as rangerpbzzzz | ||
| larsks | harlowja: still around? | 02:49 |
|---|---|---|
| smoser | larsks, i just responded to your MP | 03:08 |
| smoser | i'm sorry. | 03:08 |
| larsks | smoser: yeah, I expected the unit test request, since obviously having one would probably have avoided the problem in the first place :). | 03:10 |
| larsks | I will try to add that tomorrow. | 03:10 |
| smoser | i really hate it when people do that to me | 03:10 |
| smoser | so i pass the love on to you | 03:10 |
| smoser | :) | 03:10 |
| larsks | I was partly considering a more substantial rewrite, but then the networkmanager folks got all responsive and went and fixed the second problem when I pointed it out today. | 03:11 |
| === shardy_afk is now known as shardy | ||
| === shardy is now known as shardy_lunch | ||
| === shardy_lunch is now known as shardy | ||
| === rangerpbzzzz is now known as rangerpb | ||
| rharper | smoser: have you uploaded master to zesty ? specifically for those ds-identify label fixes ? | 15:51 |
| smoser | rharper, the label fixes are in zesty, yes. | 15:52 |
| rharper | hrm, I'm not seeing the comma fix | 15:52 |
| smoser | zesty has 0.7.9-26-g1cd8cfa-0ubuntu1 | 15:53 |
| rharper | ok | 15:54 |
| * rharper looks at his image build | 15:54 | |
| smoser | (if we hadn't gotten it in, then curtin woudl still be failing) | 15:54 |
| rharper | yeah; that's right | 15:55 |
| larsks | smoser: I added tests to https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/317553 | 16:27 |
| smoser | larsks, yeah, i saw. i'lll get that today. | 16:30 |
| larsks | Spiffy. | 16:30 |
| smoser | larsks, ok. i reviewed. i'll pull. | 16:54 |
| larsks | \o/ | 16:54 |
| smoser | in general, please try to set commit message to git style commit message to be squashed | 16:55 |
| smoser | subject | 16:55 |
| smoser | <blank line> | 16:55 |
| smoser | description | 16:55 |
| larsks | It is? | 16:55 |
| larsks | Already? | 16:55 |
| smoser | ah. yes. your top commit *is* , and thats good. | 16:55 |
| larsks | The second one, too. | 16:55 |
| smoser | but in the merge proposal | 16:56 |
| smoser | a combined one... to squash to | 16:56 |
| smoser | as i'll just squash them. | 16:56 |
| larsks | Sure. I specifically *didn't* squash them so that the test could be tested before the fix. | 16:56 |
| larsks | Otherwise there's no demonstration that the test is testing anything. | 16:56 |
| smoser | yeah, thats fine. and good. | 16:56 |
| smoser | but my general flow is that i'd | 16:57 |
| smoser | git checkout larsks/branch | 16:57 |
| smoser | git rebase -i master | 16:57 |
| smoser | <squash everything> | 16:57 |
| smoser | grab the 'Commit message' from the merge proposal web ui | 16:57 |
| smoser | git commit | 16:57 |
| smoser | git checkout master | 16:57 |
| smoser | git merge <that head> | 16:57 |
| smoser | so there is only one commit addd to master | 16:58 |
| larsks | Ah, I see. Well, you could just take the commit message from the top commit, and discard the second. | 16:58 |
| larsks | But I get it, and will note that in the future. | 16:58 |
| smoser | thats what i did | 16:59 |
| smoser | and just pushed | 16:59 |
| smoser | the pain in that process above is that it is painful | 17:00 |
| smoser | and also that i then have to manually tag the MP as 'merged' | 17:00 |
| larsks | Fair enough. | 17:00 |
| larsks | Like I said, noted for the future. | 17:00 |
| smoser | as my rebase now has no lineage with the head, so laucnhpad doesn't just recognize it got pulled. | 17:00 |
| smoser | i need tools for this :) | 17:00 |
| larsks | I can squash and re-push the merge request if you'd ilke. | 17:01 |
| smoser | ist fine. but i shoudl have run tox fully before pusing :-( . | 17:02 |
| larsks | smoser: I think your fingers just had too much to drink. | 17:02 |
| rharper | mmm, coffee | 17:02 |
| smoser | i dont usually bother correcting typos. i just leave that to the readers brain. faster that way. | 17:02 |
| nacc | or smoser is half-german | 17:03 |
| nacc | ist at least means something then :) | 17:04 |
| harlowja | larsks am around | 18:23 |
| larsks | harlowja: I fixed some bugs in cloudinit/net/sysconfig.py, which I think is your work. It's been merged as f81d6c7. | 18:25 |
| harlowja | sweet | 18:25 |
| larsks | I hope it looks sane to you :) | 18:25 |
| harlowja | will try to check it out | 18:29 |
| smoser | the failure iiuc was with multiple ip addresses (networks) on a single link | 18:54 |
| smoser | jgrimm, or rharper if you have some time, read this | 20:45 |
| smoser | http://paste.ubuntu.com/24015364/ | 20:45 |
| jgrimm | ack | 20:46 |
| jgrimm | smoser, line 24? not sure i grok the connection between reading 1-5 and not being able to change via user-data/vendor-data? | 20:52 |
| jgrimm | possibly worded funk that i'm not understanding what you are saying | 20:53 |
| jgrimm | funky | 20:53 |
| jgrimm | ah, i get it (after reading cloud-init:) nvm | 20:54 |
| smoser | bah. should be 1-3 there. | 20:54 |
| jgrimm | ok, i wondered that | 20:54 |
| smoser | 1-4 | 20:54 |
| smoser | man. typos abound | 20:55 |
| jgrimm | ack. happens | 20:55 |
| jgrimm | smoser, initial setting for xenial will be false? and configured via? | 20:57 |
| jgrimm | not mentioned lines 34-36 area. | 20:58 |
| jgrimm | but otherwise looks good | 20:59 |
| smoser | when we initially put it back into xenial, we'll be in 'report' mode | 21:07 |
| smoser | which means nothing will be affected at all. | 21:07 |
| smoser | cloud-init's builtin default will be 'false', so it woudl then warn without a timeout | 21:09 |
| smoser | which i think is kind of what we'd want. | 21:09 |
| jgrimm | ack, just verifying as it wasn't mentioned | 21:12 |
| smoser | jgrimm, i'm running out the door, probably poke inlater | 22:12 |
| smoser | http://paste.ubuntu.com/24016244/ | 22:12 |
| smoser | i uploaded to zesty with some of that. | 22:13 |
| jgrimm | smoser, ack thanks | 22:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!