| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| kalikiana | Mirv: bzoltan Can one of youse add daker to https://launchpad.net/~ubuntu-sdk-team ? | 08:00 |
|---|---|---|
| Mirv | let me at least start a CI for that MP manually | 08:04 |
| kalikiana | daker: Replied on bug 1661890 | 09:01 |
| ubot5 | bug 1661890 in ubuntu-ui-toolkit (Ubuntu) "TextField in a Dialog returns nothing if prediction is enabled" [Undecided,Incomplete] https://launchpad.net/bugs/1661890 | 09:01 |
| === chihchun is now known as chihchun_afk | ||
| daker | kalikiana: hi, thanks for the replies, is this test correct https://paste.ubuntu.com/24034225/ ? | 15:09 |
| kalikiana | daker: Maybe I'd do compare(selector.count, model.count) if the model you're using for the test allows that. But yeah, looks fine | 15:51 |
| daker | kalikiana: yes that's i did : compare(selector.count, customModel.count); | 15:52 |
| kalikiana | daker: Okay, great | 15:52 |
| daker | kalikiana: i have also proposed some RTL fixes in multiple MRs | 15:57 |
| daker | on issue i did found is how can i mirror the icon of an Action ( aka this bug 1665938 ) | 15:58 |
| ubot5 | bug 1665938 in ubuntu-ui-toolkit (Ubuntu) "Pagestack backAction should point to the right in RTL" [Undecided,New] https://launchpad.net/bugs/1665938 | 15:58 |
| daker | ? | 15:58 |
| daker | s/on/one | 15:58 |
| kalikiana | daker: Two options. If all you need is to literally mirror it, you could do mirror: LayoutMirroring.enabled on the Image (http://doc.qt.io/qt-5/qml-qtquick-image.html#mirror-prop). Or you create an 'rtl icon | 16:12 |
| kalikiana | in the theme | 16:12 |
| kalikiana | The latter is what we usually do and I'd say is better becasue any theme can customize it more easily | 16:12 |
| kalikiana | Trying to think of an example of the latter | 16:13 |
| daker | for the listview i used mirror since the progress is juste an image | 16:13 |
| kalikiana | If an exact mirror is all you need, then mirror should be okay | 16:14 |
| daker | i think the back button is the only element that needs a change of orientation on the pageheader(in RTL mode) | 16:15 |
| daker | this means changing the internal of the Action ? for just one element ? | 16:16 |
| daker | or add a new prop to the api ? mirror ? | 16:16 |
| daker | well i think just copy the icon an mirror it then passe it the Action instead | 16:19 |
| kalikiana | daker: That's why using the API is not perfect :-D It depends on the icon used whether it needs to be mirrored, so mirror: only makes sense if you know what the icon is. And adding that to the Action API would imho be awkward because app devs shouldn't need to care about something that's always true/false for the same icon | 16:25 |
| daker | ok then i'll just copy the chevron image and flip it | 16:27 |
| daker | hmm ok not sure this will work | 16:29 |
| daker | https://www.irccloud.com/pastebin/XTe6WMMT/ | 16:31 |
| daker | not sure how to mirror it :D i don't think the theme does have a forward button | 16:32 |
| kalikiana | daker: 'back' is the icon name. That stays the same. Just in this case you want two files on disk, eg. back.svg and back-rtl.svg. | 16:33 |
| kalikiana | I'm not sure if we've ever tested this properly, though, it's possible that it also needs a fix in our icon loader - if that's the case I can probably help you with that. | 16:34 |
| daker | kalikiana: you mean that's the icon loader will detect the rtl mode and will load "back-rtl" instead ? | 16:35 |
| kalikiana | daker: Yes | 16:36 |
| daker | kalikiana: ok i see | 16:36 |
| kalikiana | daker: So wherever that icon is used, it'll be mirrored correctly | 16:37 |
| daker | kalikiana: yes but since the icons are from the theme, back-rtl need to be add to the theme right ? | 16:38 |
| kalikiana | We have those for media-playback/preview in suru atm | 16:38 |
| kalikiana | daker: Yes | 16:38 |
| daker | kalikiana: i'll test that | 16:39 |
| kalikiana | daker: So to be clear, I couldn't find the code for -rtl handling, either it's done in Qt, or we might need a small fix in src/UbuntuToolkit/ucscalingimageprovider.cpp if -rtl isn't detected | 16:40 |
| daker | i'll try to look at the code to see if i can find something | 16:41 |
| === JanC is now known as Guest41946 | ||
| === JanC_ is now known as JanC | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!