| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| kalikiana_ | _salem: any update on testing the organization fix? https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/organizedCrime/+merge/316825 would be good to know if we can pass it on to the next landing | 10:39 |
|---|---|---|
| kalikiana_ | daker: I added some docs to SortFilterModel https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/insensitivePattern/+merge/317537 | 10:58 |
| daker | kalikiana_: thanks! much better | 10:58 |
| kalikiana_ | t1mp: review, please ^^ | 10:59 |
| === _salem is now known as salem_ | ||
| salem_ | renatu, ^ did you test the organization fix? | 11:18 |
| renatu | salem_, not yet, let me test it | 11:19 |
| renatu | kalikiana_, what is the silo that contains that? | 11:21 |
| kalikiana_ | renatu: https://bileto.ubuntu.com/#/ticket/2478 | 11:33 |
| kalikiana_ | daker: The components.api is still wrong https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1341559/+merge/317568 | 12:21 |
| daker | kalikiana_: yes i saw it, he knew that i did lie to him :D | 12:22 |
| kalikiana_ | lol | 12:22 |
| daker | kalikiana_: how can can i update it without compiling :D | 12:24 |
| kalikiana_ | daker: Well, you can edit it by hand | 12:24 |
| === chihchun is now known as chihchun_afk | ||
| t1mp | kalikiana_: happroved https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/insensitivePattern/+merge/317537 | 13:31 |
| akhil_surabhi | hello, i'm trying to compile ubuntu touch from sources, i'm getting the following error, please help me | 13:31 |
| akhil_surabhi | Prebuilt apk found in PRODUCT_COPY_FILES use BUILD_PREBUILT instead!. Stop. | 13:32 |
| kalikiana_ | t1mp: Thanks! | 13:35 |
| daker | kalikiana_: fixed, if you want to trigger CI | 15:09 |
| kalikiana_ | Done | 15:10 |
| kalikiana_ | Let's see if he can get this passing | 15:10 |
| daker | kalikiana_: i still have other MRs if you want to look at them when you have time | 16:28 |
| kalikiana_ | daker: Hand them to me | 16:29 |
| kalikiana_ | I'm all eyes | 16:29 |
| daker | https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1630872/+merge/317806 | 16:29 |
| daker | https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1665938/+merge/317804 | 16:29 |
| daker | https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1665944/+merge/317712 | 16:29 |
| daker | https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1665942/+merge/317711 | 16:29 |
| daker | https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1486940/+merge/317401 | 16:29 |
| daker | that's all :) | 16:30 |
| kalikiana_ | daker: We need to talk about this one again me thinks https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1665938/+merge/317804 | 17:22 |
| daker | kalikiana_: i was reporting a bug against ubuntu-themes | 17:23 |
| kalikiana_ | Where? | 17:23 |
| daker | https://bugs.launchpad.net/ubuntu-themes/ | 17:23 |
| daker | basically the RTL back icon is just the "next" icon named "back-rtl" | 17:25 |
| daker | because the arrow needs to point to the right | 17:25 |
| kalikiana_ | daker: That's half true. Those icons look like reverses of each other. But they are very much independent icons that coincidentally look like that right now in that theme. You don't know that it will be true in the future or with another theme. | 17:30 |
| kalikiana_ | And trust me, I've seen this mistake happen before and icons did change. | 17:30 |
| kalikiana_ | daker: So, the only future-proof fix is to add a back-rtl.svg to the theme. Even if it's a copy of next.svg. | 17:31 |
| daker | kalikiana_: i see, you mean we need a mirrored "back" icon, not a "next" icon, so whenever the back change back-rtl should be a mirror of it, right ? | 17:32 |
| kalikiana_ | (And some themes even symlink internally. Which is fine, as long as it's in the implementation of the theme) | 17:32 |
| kalikiana_ | daker: Yes. It could be that eg. back becomes thicker, rounder, whatever, and won't anymore look the same as next. | 17:33 |
| daker | kalikiana_: you are right | 17:33 |
| kalikiana_ | daker: Are you going to report a bug for it? | 17:36 |
| daker | kalikiana_: yes | 17:36 |
| daker | kalikiana_: bug 1666607 | 17:40 |
| ubot5 | bug 1666607 in Ubuntu theme "Add an RTL back button icon" [Undecided,New] https://launchpad.net/bugs/1666607 | 17:40 |
| === mardy_ is now known as mardy | ||
| kalikiana_ | daker: Are you planning on looking into the icon loading side of it? | 18:06 |
| daker | kalikiana_: i'll try, is there quick way to test change ? or how do you guys test your changes ? | 18:07 |
| kalikiana_ | daker: I think we might want the test in tests/unit/iconprovider/tst_iconprovider.cpp | 18:14 |
| kalikiana_ | We can have test icons there, regardless of the real theme | 18:15 |
| daker | kalikiana_: i mean how do you "test" your change, do you have to recompile everything each time ? | 18:15 |
| kalikiana_ | daker: Not sure I get what you're asking | 18:18 |
| daker | kalikiana_: to fix somethings which steps do you follow ? grab the code, fix the bug, compile everything ? how do you visualize the change ? how do tell the gallery app to use your newly built sdk, not the system one ? | 18:21 |
| daker | see my point ? | 18:21 |
| kalikiana_ | Ah | 18:25 |
| kalikiana_ | So: generally, yes, I do recompile the branch. | 18:26 |
| kalikiana_ | There's a few options to use the plugin you built | 18:26 |
| kalikiana_ | Unit tests and AP tests will automagically pick up the code from the folder | 18:27 |
| kalikiana_ | You can use ./export_qml_dir.sh (if you use Bash) to modify your local shell | 18:28 |
| kalikiana_ | Or ./gallery.sh | 18:29 |
| kalikiana_ | ^^ daker | 18:29 |
| daker | ok i see | 18:29 |
| daker | thanks kalikiana_ | 18:30 |
| daker | for horizontalAlignment, why do you think it's incorrect ? | 18:31 |
| kalikiana_ | daker: I think using the value from Qt.application may not be the best option, since there are local properties as well. But I haven't personally run into problems where that matters, so it "may" be incorrect | 18:35 |
| kalikiana_ | I'm basically trying to keep it in mind, not saying it's necessarily bad | 18:35 |
| daker | kalikiana_: ok, i see | 18:36 |
| kalikiana_ | daker: Thanks for taking the time to understand my reviews btw. You're doing an outstanding amount of fixes these days. Very happy to work with you! | 18:41 |
| daker | kalikiana_: thanks, i am not an expert in the field but i just try to understand the comments maybe i am not doing/understanding things as they should | 18:43 |
| daker | kalikiana_: so i'll need to rely on QGuiApplication::isRightToLeft() to test if we are on RTL or not right ? | 18:46 |
| kalikiana_ | daker: Yup | 18:48 |
| daker | kalikiana_: ok, do you have an example the full string image://scaling/scale/path ? | 18:49 |
| daker | path ends with an extension i would say | 18:50 |
| daker | nvm i see an example on the file :D image://scaling/0.5/arrow.png | 18:54 |
| daker | so here if we are in RTL i would split the path/extension add -rtl to path[0], if it exists load it normally otherwise load the original path | 18:56 |
| daker | kalikiana_: ^ | 18:57 |
| kalikiana_ | daker: Yes | 18:57 |
| kalikiana_ | Sounds right | 18:57 |
| daker | kalikiana_: excellent | 18:57 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!