=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== JanC_ is now known as JanC
=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
[08:46] <kalikiana_> renatu: Did you have a chance to test https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/organizedCrime/+merge/316825 at this point?
=== chihchun is now known as chihchun_afk
[10:52] <daker> kalikiana_: hi i started working on the iconprovider, i faced a wired issue QGuiApplication::layoutDirection() is always Qt::LeftToRight
[10:52] <daker> s/wired/weird
[11:02] <kalikiana_> daker: Are you setting it in your application?
[11:03] <daker> kalikiana_: how ? i am just using the gallery rtl/ltr action to change the layout
[11:04] <kalikiana_> Oh. And the value stays the same?
[11:04] <daker> well always Qt::LeftToRight
[11:05] <daker> so i am not sure the rtl changes are only applied to the elements not the app
[11:05] <daker> if*
[11:06] <kalikiana_> daker: Hmmmm I'm checking examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml it looks like it's never actually changing it
[11:07] <kalikiana_> That should probably be changed
[11:07] <daker> that's what i thought
[11:09] <daker> kalikiana_: should i file a bug ?
[11:10] <kalikiana_> daker: Yeah
[11:43] <daker> kalikiana_: can you look at this solution https://paste.ubuntu.com/24046050/
[11:44] <daker> the change needs to be made in src/UbuntuToolkit/unitythemeiconprovider.cpp not src/UbuntuToolkit/ucscalingimageprovider.cpp
[11:53] <kalikiana_> daker: Note on style, braces should cuddle ie. "if (QGuiApplication::layoutDirection() == Qt::RightToLeft) {" with the opening brace on the same line
[11:54] <daker> kalikiana_: sure
[11:54] <kalikiana_> I think that change makes sense, yeah. The check for -rtl is only needed once, right?
[11:54] <kalikiana_> As long as all code goes through that
[11:55] <kalikiana_> Seems like it will
[11:55] <daker> yes if we are in RTL change if we have -rtl icon, if the theme found one we are good it will be returned, else the code will continue normally like it did before
[11:56] <kalikiana_> Okay
[11:56] <kalikiana_> And it won't try to be too smart, which I think is good
[11:57] <daker> yes
[11:59] <daker> kalikiana_: not that the only thing i have added is https://paste.ubuntu.com/24046132/
[11:59] <daker> note*
[12:01] <kalikiana_> daker: Understood, I checked the code in unitythemingprovider.cpp to see where function was used (my main question was if it was always used to find the name)
[12:02] <kalikiana_> daker: Bug 1666869 is about the gallery, right? Or are you saying the value in any application is wrong at startup?
[12:02] <ubot5> bug 1666869 in ubuntu-ui-toolkit (Ubuntu) "QGuiApplication::layoutDirection() is always Qt::LeftToRight" [Undecided,New] https://launchpad.net/bugs/1666869
[12:04] <kalikiana_> The description is a bit unclear
[12:04] <daker> kalikiana_: no not the gallery, but the sdk, how can you force QGuiApplication::layoutDirection() to change from QML ?
[12:04] <kalikiana_> daker: So layoutDirection is wrong regardless of locale?
[12:05] <kalikiana_> Default value and changing are two different things
[12:05] <daker> kalikiana_: wait, QGuiApplication::layoutDirection() is related to the locale ? so the "change layout" is not related to it right ?
[12:06] <daker> "change layout" button on the gallery*
[12:06] <kalikiana_> daker: The button in the gallery to change it exists for testing only. So that one doesn't need to change the locale and can see differences easily.
[12:07] <kalikiana_> At startup it should be whatever the locale says
[12:08] <daker> i see, so how can run the gallery(for ex) with a different locale ?
[12:11] <daker> i think i need to add LANG=$LANG to tests/Gallery/gallery to see if it works
[12:12] <kalikiana_> daker: LANGUAGE=en
[12:12] <kalikiana_> But note that this only works if it's installed
[12:12] <kalikiana_> gettext kinda sucks that way, there's no easy option for using locales from the build folder
[12:12] <daker> yes i have 3 locales installed fr/en/ar
[12:13] <kalikiana_> So using ar or en you should see a different layout by default
[12:14] <kalikiana_> daker: FYI I updated the title of bug 1666869
[12:14] <ubot5> bug 1666869 in ubuntu-ui-toolkit (Ubuntu) "Toolkit gallery doesn't change QGuiApplication::layoutDirection" [Undecided,Confirmed] https://launchpad.net/bugs/1666869
[12:15] <renatu> kalikiana_, I could not test it yet. Messaging app build is broken
[12:15] <daker> kalikiana_: i'll test it, if QGuiApplication::layoutDirection change i'll just mark that bug as invalid
[12:16] <kalikiana_> daker: The bug is not invalid IF we're talking about the bug in the gallery :-)
[12:16] <kalikiana_> Again, two different things
[12:16] <kalikiana_> Easy to confuse
[12:16] <kalikiana_> renatu: You did not test, but it is broken? I don't get it
[12:17] <renatu> kalikiana_, I need the new messaging-app to test it, but the build of it is broken
[12:17] <kalikiana_> renatu: Oh, unrelated issue. Okay.
[12:17] <renatu> kalikiana_, because of that I could not test it
[12:17] <kalikiana_> renatu: Understood.
[12:21] <daker> kalikiana_: that "change layout" button on the gallery does change the layout but not QGuiApplication::layoutDirection
[12:22] <kalikiana_> daker: Yes
[12:22] <daker> kalikiana_: it should ?
[12:22] <daker> because that's the bug i have filed
[12:39] <kalikiana_> daker: I think the button should change the layout :-)
[12:39] <daker> but not QGuiApplication::layoutDirection, right ? if yes then the bug is invalid...
=== _salem is now known as salem_
[12:43] <daker> ah i think i understand what you mean there, you mean even if you pass LANGUAGE=ar QGuiApplication::layoutDirection stays Qt::LeftToRight
[13:03] <kalikiana_> that would be a different bug
[13:54] <daker> kalikiana_: would you mind explaining it ?
[15:01] <kalikiana_> daker: First bug: you run the gallery. The gallery has a button, for testing purposes, to switch between RTL and LTR, regardless of what locale you're using. Turns out, the switch is incomplete. the layout direction of QGuiApplication is not changing, only the QML layout changes
[15:03] <daker> kalikiana_: this is what i meant when i reported the bug
[15:04] <kalikiana_> daker: Second - maybe - bug, you run any app in different locales, which are written from LTR or RTL by default, layout direction of QGuiApplication should take the default from the locale, eg. English is LTR, Arabic is RTL, Japanese is LTR for the purposes of a computer screen
[15:06] <daker> kalikiana_: ok, this one i still need to test it
[15:20] <daker> kalikiana_: should i open another bug for the icon provider or use the same bug 1665938 ?
[15:20] <ubot5> bug 1665938 in ubuntu-ui-toolkit (Ubuntu) "Pagestack backAction should point to the right in RTL" [Undecided,Confirmed] https://launchpad.net/bugs/1665938
[15:24] <kalikiana_> daker: I'd say renaming the bug is fine
[17:46] <renatu> kalikiana_, you need to rebuild the silo, there is a new version of UITK on overlay-ppa
=== salem_ is now known as _salem
[22:44] <daker> kalikiana_: ha ha, the second i am suspecting it's also a bug :D