[14:07] <kalikiana_> t1mp: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/realLayoutDirectionChange/+merge/318359
[14:09] <kalikiana_> t1mp: I wonder if you could also check https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/hiddenWindowPopup/+merge/317530 - it's not passing, and I can't figure out why the test doesn't work.
[15:34] <daker> kalikiana_: hi, i think you MR fixes also bug 1667165 & bug 1667157
[15:34] <daker> your*
[15:38] <kalikiana_> daker: I don't think so. It doesn't change the layout at all or where the default comes from
[15:40] <daker> ah i see
[15:40] <daker> kalikiana_ i have submitted another MR to fix the checkbox label in case you want to review it https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1333228/+merge/318311
[15:40] <daker> i don't have access to the specs to see if what i did is correct
[15:40] <kalikiana_> ^^ bzoltan this is where the real discussions are happening ;-)
[15:41] <kalikiana_> daker: Looking
[15:45] <kalikiana_> daker: I recall this having been changed this way intentionally (which personally I find horribly confusing UX). I don't know if the latest spec is to have this or not...
[15:47] <daker> kalikiana_: ok who knows ? mpt ?
[15:48] <kalikiana_> daker: Probably a good start. I don't know who's currently working on that
[15:49] <daker> kalikiana_: ok thanks
[15:49]  * mpt looks
[15:49] <daker> it's bug 1333228
[15:56] <mpt> kalikiana_, daker: I changed the spec and had it approved. It’s the same as checkboxes behave in pretty much every other toolkit. What would you like to know?
[15:59] <daker> mpt: just wanted to know if to that specific part of the spec, i have a MR but i don't know if what i have done is correct(spacing, font-size, etc..)
[16:01] <daker> if i can i have access*
[16:05] <mpt> daker, sorry that was a bit curt, I was dealing with two other things at once…
[16:05] <mpt> daker, I don’t have permission to make the full spec public, but I quoted the entire relevant part in the bug report.
[16:06] <mpt> daker, I’m not an engineer, but one thing that looks a bit doubtful is the “implicitHeight: units.gu(2)” … What happens if the label wraps to multiple lines?
[16:07] <bzoltan> kalikiana_: I know, I know :)
[16:09] <daker> mpt: the label will be truncate if i am not wrong, but true i'll have to recheck that
[16:10] <daker> mpt: my concern is more about the label font size, color of the label, spacing btwen the checkbox and the label
[16:11] <mpt> daker, ok, a checkbox label should wrap to multiple lines unless it’s inside a list item (same as any label should)
[16:15] <mpt> daker, font size and color should be the same as any other label, e.g. for a text field or switch
[17:56] <kalikiana_> mpt: daker: Checkboxes don't wrap right now, see bug 1442851
[17:57] <daker> kalikiana_: i got access to the checkbox spec, i see that it need to to support three states
[17:58] <kalikiana_> daker: How's that related to the toggle?
[18:02] <daker> that's what i saw, checked, mixed, unchecked(like qt quick checkbox)
[18:03] <daker> kalikiana_: ^