| === JamesTait is now known as Guest95749 | ||
| === Guest95749 is now known as JamesTait | ||
| === JanC is now known as Guest86538 | ||
| === JanC_ is now known as JanC | ||
| daker | kalikiana_: morning, i did update the MR if you want to have a look https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1333228/+merge/318311 | 10:57 |
|---|---|---|
| daker | i still don't know why the label doesn't wrap | 10:58 |
| ltinkl | daker, tried setting "maximumLineCount" to something > 1? | 11:18 |
| daker | ltinkl: no, but i am suspecting that setting implicitWidth of the parent item doesn't make it ellipsis or wrap | 11:19 |
| daker | it's like i am telling the item to stay at that fixed width | 11:20 |
| tsdgeos | Mirv: what would you think of backporting this leak-fix (not very common) to our packages? https://codereview.qt-project.org/#/c/187028/2/src/qml/types/qqmldelegatemodel.cpp | 11:42 |
| kalikiana_ | daker: Checking it here | 11:58 |
| Mirv | tsdgeos: I wonder if they'd like it for their 5.6 series? I guess 5.7 and even 5.8 are somewhat closed now | 13:33 |
| Mirv | but sure, if it seems it'd be good for us, we could have it | 13:33 |
| tsdgeos | Mirv: i had a conversation with tronical about it, he wanted "some extra work explaining why a memory leak needed to be backported" | 13:33 |
| tsdgeos | and i decided that given how they don't work much towards the community with not doing bugfix releases | 13:34 |
| tsdgeos | i'd let them backport it for themselves if they wanted | 13:34 |
| Mirv | tsdgeos: ok then | 13:51 |
| Mirv | I know they're saying "critical fixes only" from now on in 5.6, which is a bit less LTS maybe than one could hope, but it's really their choice | 13:51 |
| Mirv | and it seems they might have LTSish releases starting from 5.9 if they get their CI in good shape. at least many point releases. | 13:52 |
| tsdgeos | yep, there's always hope | 13:52 |
| Mirv | tsdgeos: file a bug please so that I've something to point to in changelog | 13:52 |
| tsdgeos | i did | 13:53 |
| tsdgeos | i cc'ed you on it | 13:53 |
| tsdgeos | let me find it | 13:53 |
| Mirv | oh, thanks :D e-mail, so old-fashioned | 13:53 |
| tsdgeos | Mirv: https://bugs.launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/+bug/1668982 | 13:53 |
| ubot5 | Ubuntu bug 1668982 in qtdeclarative-opensource-src (Ubuntu) "Backport memory leak fix" [Undecided,New] | 13:53 |
| Mirv | yeah, found it, thanks | 13:53 |
| tsdgeos | we'll not really CC'ed but "added you to notified of all changes" | 13:53 |
| tsdgeos | not sure what that really does | 13:53 |
| Mirv | well it adds me to bug CC and depending on how my filtering feels it shows up in correct folder (it did) | 13:54 |
| kalikiana_ | daker: http://paste.ubuntu.com/24090227/ | 14:25 |
| daker | kalikiana_: ok, i'll add to the MR | 14:26 |
| daker | that* | 14:26 |
| daker | kalikiana_: done | 14:38 |
| kalikiana_ | daker: Please get rid of the clip: true that I used for testing, otherwise the focus ring doesn't work | 14:49 |
| daker | kalikiana_: yeah sorry, i don't have a way to test it on this 14.04 machine, it's fixed now | 14:51 |
| kalikiana_ | daker: You don't have a keyboard? :-o | 14:57 |
| daker | kalikiana_: lol, no i mean i am on 14.04 on this machine :D | 14:58 |
| kalikiana_ | Ah :-D | 15:00 |
| kalikiana_ | Happroved | 15:00 |
| kalikiana_ | Thanks for you work on this! | 15:01 |
| daker | kalikiana_: \o/ | 15:01 |
| daker | two bugs (y) | 15:01 |
| GreatDanton | something | 18:15 |
| === Elleo_ is now known as Elleo | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!