| === dandrader_ is now known as dandrader | ||
| === dandrader is now known as dandrader|afk | ||
| alan_g | greyback: I'm needing a discussion about API design. Would you be willing? Doesn't need to be now. (Context is https://code.launchpad.net/~alan-griffiths/miral/fix-1668651/+merge/318616) | 09:36 |
|---|---|---|
| * alan_g wonders if greyback saw the the above | 09:55 | |
| === dandrader|afk is now known as dandrader | ||
| alan_g | greyback: I'm needing a discussion about API design. Would you be willing? Doesn't need to be now. (Context is https://code.launchpad.net/~alan-griffiths/miral/fix-1668651/+merge/318616) | 09:58 |
| greyback | alan_g: ack, thanks for the repeat (got you the first time) | 09:59 |
| alan_g | ;) | 09:59 |
| alan_g | dednick: if you can add the missing test (for a scenario U8 won't use) I can land https://code.launchpad.net/~mir-team/miral/move_workspace_content/+merge/318589 | 10:05 |
| dednick | alan_g: ack. will try get to it today. | 10:05 |
| alan_g | dednick: any other feedback or niggles with the workspaces APIs? | 10:06 |
| greyback | alan_g: ok I understand the problem. What api question have you? | 10:08 |
| alan_g | /1/ should I rely on user code to do the thread co-ordination? Or engineer some safe defaults? | 10:10 |
| alan_g | /2/ Should I provide a declarative for internal clients to be notified of intending shutdown, instead of the ugly "hook" in the MP? | 10:11 |
| dednick | alan_g: so far it all seems fine and easy to work with. my only issues so far are boundaries between qtmir/unity8, but that's our issue... | 10:11 |
| greyback | alan_g: for 2: a nicer solution could tie in with solving bug 1624407 nicely | 10:18 |
| ubot5 | bug 1624407 in mir (Ubuntu) "Add a 'quit' message that is app-wide, as opposed to mir_event_type_close_surface" [Medium,Triaged] https://launchpad.net/bugs/1624407 | 10:18 |
| alan_g | greyback: Ah, that's a more natural way to notify clients than I'd thought of. (But won't work for Mir < 0.27) | 10:19 |
| greyback | alan_g: ok. But would be nice long-term goal | 10:20 |
| alan_g | I'm not rejecting it, just thinking it isn't something I could do for 1.3 | 10:21 |
| greyback | alan_g: for 1, since InternalClient takes the responsibility to create the thread at the right time, I do think it has responsibility in destroying it at the right time. | 10:21 |
| greyback | so a safe default would be nice. Again, I'm not opposed to telling API users: hey, on shutdown, be prepared to do... | 10:22 |
| alan_g | Right, now for the next question... | 10:23 |
| alan_g | /3/ Do we need to support the "general case"? (I.e. shall I put all the magic "under the API" and not expose the join thread logic for clients at all?) | 10:24 |
| alan_g | I don't see that we need it (yet) | 10:24 |
| greyback | I don't think so either | 10:25 |
| dednick | alan_g: added test. | 10:26 |
| alan_g | dednick: cool! | 10:26 |
| * alan_g wonders if dandrader could use the InternalClient::join_client_thread() for his internal test clients | 10:30 | |
| greyback | that's been a use-case I've had in mind. I don't think we've hit any shutdown crashes though | 10:31 |
| greyback | but that mainly because the internal clients are managed by the tests themselves | 10:32 |
| alan_g | is he about this week? | 10:34 |
| greyback | he is, back today | 10:43 |
| duflu | alan_g: I am stuck in multiple-prerequisite-limbo again. Would you mind looking at my little cleanup branches? | 10:46 |
| duflu | I need to EOD | 10:46 |
| alan_g | duflu: sure. (later) any recommendations? | 10:47 |
| duflu | alan_g: Just the little ones from the past two days | 10:47 |
| duflu | And then I see another mistake | 10:48 |
| duflu | Errors stopping errors from stopping errors getting fixed | 10:58 |
| duflu | from getting fixed | 10:58 |
| greyback | alan_g: any tips on how to reproduce the miral-shell crash on shutdown? ctrl+alt+backspace (if so, I need to stop X listening for that) | 11:07 |
| alan_g | That's what I used, but Ctrl-C would also work | 11:07 |
| alan_g | But because of the other bugs all you really see is an EXIT_FAILURE | 11:08 |
| duflu | Fun fact: the only apparent Mir crash that's bringing down unity8 a lot right now is the setting of invalid keymaps | 11:09 |
| === dandrader is now known as dandrader|afk | ||
| alan_g | greyback: I know you were looking at it before I'd made it WIP, but you TA'd it after I'd made it WIP. Was that really intended? | 13:37 |
| greyback | alan_g: I didn't know you made it WIP, sorry | 13:37 |
| alan_g | I was adding the changes we discussed. Not removed the new APIs yet. | 13:38 |
| alan_g | greyback: done with it now, take another look? | 13:51 |
| greyback | will do | 14:09 |
| redduckx | nope | 14:52 |
| redduckx | ./quit | 14:52 |
| === dandrader|afk is now known as dandrader | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === JanC_ is now known as JanC | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!