| kalikiana_ | zsombi: review? https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/realLayoutDirectionChange/+merge/318359 | 08:54 |
|---|---|---|
| zsombi | kalikiana_: sure | 08:54 |
| kalikiana_ | zsombi: Also https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/ellipticSubTitles/+merge/318390 has been sitting a while | 08:55 |
| zsombi | kalikiana_: I had once a fix for the Mainview not dispatching the layout direction change properly, prehaps we should reload that work again... | 08:55 |
| kalikiana_ | zsombi: The problem here first of all is that the gallery is cheating by not actually changing it. I suspect there's buglets that will surface only now. daker is the one who actually triaged several RTL/ direction-related issues more recently | 08:59 |
| zsombi | k | 08:59 |
| kalikiana_ | zsombi: Do you have any pointers to the dispatching issue? Old code, bug or a piece of code? | 09:00 |
| zsombi | kalikiana_: should be on the staging, in between some working branch, having some words about MainView rtl crap :D | 09:00 |
| zsombi | it was long ago | 09:00 |
| kalikiana_ | zsombi: So it was committed? | 09:01 |
| zsombi | not completed afair | 09:01 |
| kalikiana_ | Hmmm | 09:02 |
| zsombi | kalikiana_: https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/mainview-rtl/+merge/251420 | 09:03 |
| zsombi | I even made an MR, but we got redirected to some other things | 09:03 |
| kalikiana_ | zsombi: Ah, thanks, I remember we were talking about that. So that may still be needed to get the right out of the box behavior | 09:07 |
| zsombi | yep | 09:08 |
| kalikiana_ | I'll provide an updated MR for it (that branch even predates our version split, so weird to look at it now :-D) | 09:10 |
| zsombi | kalikiana_: I know :) | 09:11 |
| zsombi | it was abandoned, and never had time to return to it | 09:11 |
| kalikiana_ | zsombi: It seems we have LayoutMirroring settings in several components in staging, but not in the MainView... I'm wondering if there was a reason not to do it in MainView for everything | 09:49 |
| === JanC is now known as Guest42627 | ||
| === JanC_ is now known as JanC | ||
| kalikiana_ | zsombi: daker: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/rtlBackButtonIconName/+merge/319668 | 10:03 |
| kalikiana_ | Also: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringEnabledInMainView/+merge/319669 | 10:06 |
| === chihchun is now known as chihchun_afk | ||
| daker | zsombi: does your last MR fixes bug 1667165 too ? | 10:56 |
| ubot5 | bug 1667165 in ubuntu-ui-toolkit (Ubuntu) "APL gets incorrectly layouted in RTL" [Undecided,New] https://launchpad.net/bugs/1667165 | 10:56 |
| daker | sorry it's for you kalikiana_ | 10:56 |
| kalikiana_ | daker: It's related but not the same. So, right now apps have to enable RTL, like the gallery does, to get full layout mirroring out of the box - the MR changes that. Although, as said above, I am wondering if there was any reason to do it on a per-component basis... | 11:50 |
| daker | kalikiana_: i see, i am not sure about the second part :D | 11:55 |
| bluss | is there a thumbnailer I can call from Python to get or generate thumbs for example for PDFs | 17:31 |
| daker | kalikiana_, zsombi i want try to write some components using QCC2 but there are some packages not available in 16.04, not sure how to deal with that | 17:43 |
| kalikiana_ | daker: That's work in progress. The new qtbase is now building in the silo, and qtdeclarative/quickcontrols2 are coming soon | 17:45 |
| kalikiana_ | There were some issues with the build configuration | 17:45 |
| daker | kalikiana_: ok | 17:46 |
| kalikiana_ | daker: For now you can have a go in a Zesty lxd container if you want. Otherwise you'll have to wait a couple weeks or so | 17:46 |
| kalikiana_ | (Maybe longer, it depends if there's more build issues or if what was done in qtbase is enough) | 17:46 |
| daker | kalikiana_: i can use the lxd container, but i am not sure how to launch it... | 17:47 |
| daker | not sure how to tell lxd to use my X server as a display | 17:49 |
| zsombi | [11:49:04] <kalikiana_> zsombi: It seems we have LayoutMirroring settings in several components in staging, but not in the MainView... I'm wondering if there was a reason not to do it in MainView for everything | 19:43 |
| zsombi | there was no reason | 19:43 |
| zsombi | my IRC client died... and I did not notice it... | 19:43 |
| zsombi | daker: what components do you want to write? | 19:44 |
| kalikiana_ | zsombi: Hmm okay. Well, my MR is there, moving the code to the MainView was simple enough. One thing occurs to me after I prepared it, if those components are used outside a MainView, including a MainWindow, this wouldn't suffice... so maybe we actually want to retain the default in all of those respective components | 19:56 |
| kalikiana_ | Or rephrased more simply: MainView and MainWindow should probably have the LayoutDirection in addition to individual components, not instead of | 19:57 |
| zsombi | kalikiana_: the fun is that it's an attached property after all... | 19:58 |
| kalikiana_ | Not sure how that's related | 19:59 |
| zsombi | kalikiana_: well, every component's layotu can be driven through the attached props, it's only that we need to react and take them into account properly | 20:02 |
| kalikiana_ | zsombi: I don't see what that has to do with anything. I'm concerned where we need to enable the defaults. It would be the same if it was a regular property | 20:03 |
| daker | zsombi: i don't know maybe start with a simple one :) | 20:04 |
| zsombi | kalikiana_: right... I was just thinking loud :) | 20:04 |
| zsombi | the feature I added to MainViewBase was defaulted to local's layout direction | 20:04 |
| kalikiana_ | Right | 20:05 |
| zsombi | kalikiana_: so something like that needs to be set, and perhaps we shoudl add that to be automatically set for all components... | 20:05 |
| kalikiana_ | zsombi: I feel we'd want want that to apply to any component... it seems odd to me that it's not the default for Item to be honest | 20:07 |
| zsombi | kalikiana_: I do get that why | 20:07 |
| zsombi | for instance you want to give the possibility to the component implementation to drive when they take the layout direction into use, so you don;t default anything on those | 20:08 |
| zsombi | the layout direction handling is after all implemented in the Item, the LayoutDirection attached object si just an interface to drive that | 20:09 |
| kalikiana_ | zsombi: Maybe then it should only be added to AdaptivePageLayout and nowhere else | 20:22 |
| kalikiana_ | Since MainView (or MainWindow) has no use for it | 20:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!