=== shardy_afk is now known as shardy
=== shardy is now known as shardy_lunch
=== shardy_lunch is now known as shardy
[16:05] <powersj> smoser: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/320560
[16:17] <powersj> smoser: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/317692
[16:23] <powersj> https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218
[16:23] <powersj> https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/314496
[16:27] <smoser> powersj, https://code.launchpad.net/~raharper/curtin/trunk.snappy-dd/+merge/317672
=== powersj_ is now known as powersj
[17:31] <smoser> powersj, you said you filed a pylint issue
[17:31] <smoser> for
[17:31] <smoser>  +    _REQ_VER = LooseVersion(_REQ.version)  # pylint: disable=no-member
[17:43] <powersj> smoser: yes
[17:44] <smoser> link K?
[17:44] <powersj> https://github.com/PyCQA/pylint/issues/1390
[17:55] <smoser> powersj, http://paste.ubuntu.com/24242020/
[17:55] <smoser> that look sane ?
[17:55] <smoser> on top of yours
[17:56] <smoser> err. http://paste.ubuntu.com/24242021/
[17:57] <powersj> I like that change, did you run pylint to make sure it is still good?
[18:01] <smoser> yeah, it is.
[18:01] <smoser> you're welcome to add a pylint-tip
[18:02] <powersj> ok let me add your changes and -tip
[18:02] <powersj> thanks for looking
[18:02] <smoser> powersj, i can just do it here too.
[18:02] <smoser> and pull it.
[18:02] <powersj> ok whatever is easier
[18:03] <smoser> or you can . etierh way. i wont add the -tip right now if i do it.
[18:03] <powersj> let me do it then
[18:04]  * powersj is seriously missing his large monitor right now
[18:18] <powersj> smoser: merge updated
[18:22] <smoser> oh..
[18:22] <smoser> theo hter question...
[18:22] <smoser> would be nice to get Renderer out of .pylintrc
[18:25] <powersj> https://paste.ubuntu.com/24242207/
[18:27] <powersj> I did start to mess with that code, but thought better
[18:39] <smoser> http://paste.ubuntu.com/24242277/
[18:41] <smoser> powersj, ^ i think that is right.
[18:42] <powersj> smoser: is there a way to test that?
[18:42] <powersj> other than building the deb and injecting it in some image :)
[18:45] <smoser> powersj, well, pylint runs
[18:45] <powersj> :D
[18:45] <smoser> and it is looking at all the things that subclass from Renderer
[18:45] <smoser> well, i thought it was
[18:45] <smoser> wait. it might
[18:45] <powersj> mine just passed with that
[18:50] <powersj> smoser: want me to commit?
[18:53] <smoser> powersj, how do i make it show an error ?
[18:53] <smoser> i want to see the error number
[18:56] <powersj> hmm I have to remember, I don't think it is as simple as turning on the report
[19:00] <smoser> pylint --disable=C,R --enable=W0223 cloudinit/net/eni.py '--msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}'
[19:00] <smoser> so... its annoying though
[19:01] <smoser> you cant enable just that warning
[19:01] <smoser> if you disable W (like you did in the .pylintrc) then you can't enable a specific warning
[19:03] <smoser> powersj, so... i added that @abc.abstract
[19:04] <powersj> added to?
[19:04] <smoser> and then i removed an the eni.Renderer
[19:04] <smoser> http://paste.ubuntu.com/24242414/
[19:04] <smoser> and saw that pylint *does* complain about that.
[19:04] <smoser> so i thought "ok, i'd like to see other occurences of W0224"
[19:04] <smoser> but, thats not so easy
[19:05] <powersj> :)
[19:06] <smoser> i would have hoped that explicitly listing a W0224 in the enable would do that.
[19:06] <smoser> but it seems if they're turned off in the disable with 'W' (all warnings) then you cant turn back on
[19:06] <smoser> i thik
[19:13] <powersj> I agree, I tried disable: all and then enable a few things, but that didn't seem to work
[19:14] <smoser> i think you can disable the things one by one
[19:14] <smoser> WXXX,WXXX,WXXX
[19:14] <smoser> so we could get there.
[19:14] <smoser> i just merged.
[19:15] <smoser> you can diff trunk versus your branch to see the delta
[19:16] <powersj> thanks! looks like you fixed up renderer
[19:17] <smoser> yeah. and removed a duouble declaration of thread._local ?
[19:18] <smoser> powersj, now i'd love to get to a point where we did not have to disable all warnings.
[19:18] <powersj> oh wow.. didn't even see that
[19:18] <powersj> yeah that would be nice; as you said those are helpful
[19:19] <powersj> a lot of the warnings are about exceptions being too broad
[19:38] <smoser> powersj, why didnt ci run on https://code.launchpad.net/~multani/cloud-init/+git/cloud-init/+merge/320815
[19:39] <powersj> ah this is the whole groups permissions thing
[19:40] <powersj> jenkins-launchpad-plugin only lets you run jobs if people are in certain groups, so I would need to add his name to the list of valid users
[19:40] <powersj> I've done this for a few other people as well
[19:43] <smoser> ah. k
[19:44] <powersj> next run should pick his up
[19:52] <powersj> smoser: https://paste.ubuntu.com/24242635/ 465 warnings: 129x too general exception 112x using deprecated warn 47x unused argument 33x unused variable 25x TODO
[19:54] <smoser> so it'd be nice to see the unused variable
[19:54] <smoser> as honestly we should fix those
[19:55] <smoser> and the deprecpated warn we could fix too
[22:59] <powersj> smoser: when you are really bored this weekend you can snap cloud-init ;) https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/320994