| stokachu | so anyone have any insight as to the recent jump in github stars on juju? | 00:43 |
|---|---|---|
| stokachu | looks like 200+ in the last couple of days | 00:44 |
| stokachu | also been on the Go trending list | 00:44 |
| stokachu | wallyworld: ^ you notice that yet? | 00:46 |
| wallyworld | stokachu: no I haven't but that is good news | 00:47 |
| stokachu | yea it is, im interested to see what drove the traffic | 00:47 |
| wallyworld | stokachu: maybe 2.2 beta1 memory fixes enticing people to grab it | 00:47 |
| stokachu | maybe the graphs on there | 00:47 |
| thumper | well, nate finch did write a blog post | 00:55 |
| thumper | about juju | 00:55 |
| thumper | and mentioned it on twitter, and lots of gophers follow him | 00:55 |
| thumper | and it is the biggest open source Go project | 00:56 |
| axw | thumper: I'd say almost certainly nate's blog post, it was on HN front page for a while | 01:12 |
| stokachu | ah | 01:28 |
| stokachu | makes sense | 01:28 |
| wallyworld | babbageclunk: standup? | 01:31 |
| babbageclunk | bugger sorry | 01:32 |
| thumper | poo | 02:37 |
| thumper | my state tests have gotten very unreliable | 02:37 |
| thumper | probably something I did | 02:37 |
| thumper | but not sure what | 02:37 |
| * thumper looks deeper | 02:37 | |
| thumper | so much for "quick fix" | 02:38 |
| thumper | :( | 02:49 |
| * thumper sighs | 02:49 | |
| thumper | see related panic is a big fat lie | 02:51 |
| thumper | when the panic is in tear down | 02:51 |
| thumper | yep, definitely something I have done | 03:05 |
| thumper | but I'm struggling to figure out which change broke it | 03:05 |
| thumper | :( | 03:05 |
| thumper | well, the good part is I have a repeatable failing test that I haven't touched | 03:07 |
| thumper | not directly anyway | 03:07 |
| thumper | ... | 03:07 |
| * thumper thinks he has an idea... | 03:07 | |
| axw | awesome. we have bootstrap command tests that are "passing", but are completely broken because they're using the wrong gc.C | 03:11 |
| * axw head desks | 03:11 | |
| thumper | axw: awesome | 03:13 |
| thumper | winning | 03:13 |
| thumper | well, I have isolated my test failure down to something that shouldn't cause a failure | 03:13 |
| thumper | so that's kinda goodish | 03:13 |
| thumper | ok... moved a few lines... | 03:23 |
| thumper | oh fuck... | 03:25 |
| thumper | think I have found a bug in our state runners code | 03:25 |
| thumper | particulary the situation when we try to stop workers before they have fully started | 03:26 |
| thumper | this makes no sense | 03:29 |
| axw | wallyworld: can you please review this trivial one: https://github.com/juju/juju/pull/7153 | 06:29 |
| wallyworld | sure | 06:30 |
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| === dpb1_ is now known as dpb1 | ||
| === akhavr1 is now known as akhavr | ||
| === lazyPower is now known as lp|Kubecon | ||
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| cmars | hi, can i get a review of https://github.com/juju/juju/pull/7157 ? | 21:31 |
| menn0 | cmars: i'll take a look | 22:36 |
| cmars | menn0, thanks | 22:36 |
| babbageclunk | wallyworld: What's the best way to determine whether a relation is cross-model from inside a RelationUnit? | 22:54 |
| wallyworld | babbageclunk: i'd have to look at the code, but in general, you need to see if the other end is a remote application. there's watcher code which does something similar to that as there's a remote relations watcher from memory | 22:56 |
| babbageclunk | wallyworld: The only way I can see is to go through the endpoints calling RemoteUnit on the unitnames and if it works then it's remote. | 22:57 |
| wallyworld | remote unit doesn't mean what you think it does | 22:57 |
| babbageclunk | wallyworld: ah | 22:58 |
| wallyworld | remote unit in this context is the other end of the relation regardless of model | 22:58 |
| wallyworld | from a relation unit you get the relation | 22:58 |
| wallyworld | from a relation you get the endoints | 22:59 |
| wallyworld | you then look to see if the endpoint at the other end has a remote app | 22:59 |
| wallyworld | endpoints have applicationname as an attribute | 22:59 |
| babbageclunk | wallyworld: ok, I'll use that. | 22:59 |
| wallyworld | there should be code already to do that sort of thing | 22:59 |
| babbageclunk | wallyworld: thanks! | 22:59 |
| wallyworld | i'll have a look and see if i can dig something up | 23:00 |
| wallyworld | babbageclunk: there's no specific code as such that can be reused, but the above is the general approach | 23:04 |
| babbageclunk | wallyworld: cool - I'll put a IsCrossModel (better name?) method on Relation. | 23:05 |
| wallyworld | i think that's ok | 23:05 |
| cmars | menn0, thumper thanks for the review, updated https://github.com/juju/juju/pull/7157 | 23:53 |
| menn0 | cmars: will look soon | 23:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!