/srv/irclogs.ubuntu.com/2017/03/31/#juju-dev.txt

wallyworldhml: did you have time for a quick hand over for next week? in standup ho?00:14
hmlwallyworld: sure00:14
* menn0 is pretty sure he just fixed the mgo/txn issue which leaves txn-queue entries behind for assert-only txn.Ops01:58
anastasiamac\o/ niice01:58
menn0before the model docs would have tons of txn-queue entries, more after each deploy01:59
menn0now they just have one01:59
menn0it was only a few new lines in mgo/txn/flusher.go01:59
menn0needs more testing but it's promising01:59
anastasiamacmenn0: since each deploy used to increase entries, we could probably have a CI test around it to ensure no future regressions?..02:01
menn0anastasiamac: that's very doabel02:01
menn0doable02:01
anastasiamacmenn0: m thinking of how to test it without having long-running test02:01
anastasiamac:D02:01
menn0anastasiamac: just deploy a few things and check the length of the txn-queue fields on some select docs02:02
anastasiamacveebers: do u know of CI tests that examine db state after/as part of the run? ^^ is it an easy test to add?02:03
* anastasiamac thinks veebers is probably recovering from anastasiamac's humor02:04
veebersanastasiamac: heh :-) There are no tests that I know of that introspect the db as part of the assertions02:06
anastasiamacveebers: so not a simple test to add to CI?..02:07
veebersanastasiamac: I'm unsure how much work would be involved. If it's possible to have a command we can run with ssh that's really handy and shouldn't be too hard02:07
veebersanastasiamac: it depends on what's involved with checking he db state02:07
menn0axw: review please: https://github.com/juju/juju/pull/718302:56
axwlooking02:57
axwmenn0: LGTM, ta02:58
menn0axw: cheers02:58
axwwallyworld: if you've got nothing better to do, here's the bulk of the persistent storage changes that I've been working on: https://github.com/juju/juju/pull/718603:41
axwand thanks for the other review03:41
wallyworldaxw: ok. i didn't realise xtian had proposed his public address PR. it will conflict a bit with mine. best to land his first once approved and then i'll need to adjust03:42
axwwallyworld: okey dokey03:42
wallyworldhe deletes subnets stuff which i'll have to add back :-)03:42
axwheh03:42
wallyworldas we will need it at some point03:42
wallyworldaxw: PR 7177 looks ok at first look - there's a todo or 2 i think needs to be there , but if it lands i can rebase my PR i proposed just before and address any issues. can you take a look and i'll land if you're happy?03:49
axwwallyworld: will do03:53
wallyworldty03:53
mupBug #1662857 opened: cannot go get the source code  <juju-core:Confirmed> <https://launchpad.net/bugs/1662857>03:57
axwwallyworld: LGTM04:07
wallyworldty04:07
wallyworldaxw: i just got to pruneExistingMachineStorageAttachments and am unclear why that has been added. perhaps a comment to clarify?04:09
axwwallyworld: sure, will do04:09
axwnooo, using 1.8 code in my  ec2 PR. maybe I can just wait for the builders to be updated...05:13
jamany chance for a review on https://github.com/juju/juju/pull/7180 over the weekend?05:36
axwjam: will do05:43
axwwpk: hey, I believe jam and sinzui are both out. if you are blocked or need anything, I'm around for a couple of hours still07:25
axwwallyworld: that pruneExistingMachineStorageAttachments call was from a previous iteration of the code, it's not necessary anymore. if the volume attachment exists when we go to attach storage, we'll error out07:31
axw(so I'm removing it)07:31
wallyworldok, i couldn't figure out what is was for07:31
axwwallyworld: yep, thanks for calling that out07:32
wallyworldnp07:32
wallyworldaxw: xtian's branch has landed but it has borked mine and i'm working to get stuff going and hand tested on aws etc. hopefully i'll be done soon, but you never know07:33
axwwallyworld: ok. well, I'm still around for a while07:33
wallyworldyeah, see how i go07:34
wallyworldaxw: i'm live testing atm, but here's the PR now rebased on xtian's work (ie develop tip) https://github.com/juju/juju/pull/718407:58
axwwallyworld: ok looking08:02
wallyworldaxw: testing on aws shows the sec group ingress rule is correctly set to <ip of mediawiki>/32 and it works as expected08:08
axwwallyworld: cool bananas. still reviewing, there's a fair bit to get through08:09
wpkaxw: thanks08:09
wallyworldaxw: yeah, sorrry. i lot is deleting. the main addition is the new watdher08:09
wpkaxw: my idea is to get rid of bridgePrefix (from everywhere) and bridge name generation in random places and force passing of the full bridge name down from FindMissingBridges08:11
axwwpk: heh, sorry that is beyond my knowledge of the juju networking code. I can help with more general thing ;)08:14
axwwpk: happy to talk that through though if you want to explain - not sure I'll be helpful tho08:15
wpkaxw: Well, currently I'm like Mr. Bean in the movie - I sit in the corner... and look at the code.08:24
axwwpk: hehe. I'll finish up what I'm doing soon and see if I can understand the current bridge prefixing code, then might be able to provide useful input08:26
wpkaxw: I'm currently working on cleaning up https://github.com/juju/juju/pull/6963 this to hit two birds with one stone and also add support for https://bugs.launchpad.net/juju/+bug/1672327 this08:27
mupBug #1672327: Too long names for bridges <cdo-qa-blocker> <maas-provider> <openstack> <uosci> <juju:In Progress by wpk> <MAAS:Triaged> <https://launchpad.net/bugs/1672327>08:27
axwwpk: ok, cool. are you aware that I made some changes to the python version to handle multiple stanzas for the same interface? that was after the Go version was written08:28
wpkaxw: I was not, thanks08:29
axwwpk: some history: https://bugs.launchpad.net/juju/+bug/165030408:29
mupBug #1650304: Juju2: 'Creating container: failed to ensure LXD image: image not imported!' <oil> <oil-2.0> <regression> <juju:Incomplete> <juju 2.1:Incomplete> <https://launchpad.net/bugs/1650304>08:29
wpkaxw: kk08:34
wallyworldaxw: i found 2 issues which i adds cards for. removing a relation doesn't close the ingress rule. adding the relation again a second time doesn't open the port, because it seems the watcher needs to do a better job of oading initial data08:40
wallyworldthe removal issue may be pre-existing08:41
axwwallyworld: mk08:41
wallyworldshould be easy to fix, i'll let xtian know08:42
axwwallyworld: left a bunch of comments08:58
wallyworldty09:05
wallyworldaxw: i fixed the issue with address counts and added a test09:30
axwwallyworld: sorry had to go make dinner, looking10:32
wallyworldno worries at all10:32
wallyworldgotta eat10:33
=== akhavr1 is now known as akhavr
axwwallyworld: LGTM, thanks10:37
wallyworldaxw: tyvm for review10:44
wpkSurvey: what do you think is the most unlikely character to happen in an interface name?11:55
zeestratwpk: Trying to come up with a unique prefix?12:06
wpkzeestrat: no, with a separator for command line12:30
wpk<interface>~<bridge>12:30
wpkI came up with ~12:31
anastasiamacwpk: according to https://www.wired.com/2013/08/the-rarity-of-the-ampersand/ ~ is the least used char :)12:35
=== akhavr1 is now known as akhavr
=== admcleod is now known as not_adam
=== not_adam is now known as admcleod
redirhttps://www.meetup.com/SF-CockroachDB-User-Group/events/238072086/16:19
=== frankban is now known as frankban|afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!