[00:14] <wallyworld> hml: did you have time for a quick hand over for next week? in standup ho?
[00:14] <hml> wallyworld: sure
[01:58]  * menn0 is pretty sure he just fixed the mgo/txn issue which leaves txn-queue entries behind for assert-only txn.Ops
[01:58] <anastasiamac> \o/ niice
[01:59] <menn0> before the model docs would have tons of txn-queue entries, more after each deploy
[01:59] <menn0> now they just have one
[01:59] <menn0> it was only a few new lines in mgo/txn/flusher.go
[01:59] <menn0> needs more testing but it's promising
[02:01] <anastasiamac> menn0: since each deploy used to increase entries, we could probably have a CI test around it to ensure no future regressions?..
[02:01] <menn0> anastasiamac: that's very doabel
[02:01] <menn0> doable
[02:01] <anastasiamac> menn0: m thinking of how to test it without having long-running test
[02:01] <anastasiamac> :D
[02:02] <menn0> anastasiamac: just deploy a few things and check the length of the txn-queue fields on some select docs
[02:03] <anastasiamac> veebers: do u know of CI tests that examine db state after/as part of the run? ^^ is it an easy test to add?
[02:04]  * anastasiamac thinks veebers is probably recovering from anastasiamac's humor
[02:06] <veebers> anastasiamac: heh :-) There are no tests that I know of that introspect the db as part of the assertions
[02:07] <anastasiamac> veebers: so not a simple test to add to CI?..
[02:07] <veebers> anastasiamac: I'm unsure how much work would be involved. If it's possible to have a command we can run with ssh that's really handy and shouldn't be too hard
[02:07] <veebers> anastasiamac: it depends on what's involved with checking he db state
[02:56] <menn0> axw: review please: https://github.com/juju/juju/pull/7183
[02:57] <axw> looking
[02:58] <axw> menn0: LGTM, ta
[02:58] <menn0> axw: cheers
[03:41] <axw> wallyworld: if you've got nothing better to do, here's the bulk of the persistent storage changes that I've been working on: https://github.com/juju/juju/pull/7186
[03:41] <axw> and thanks for the other review
[03:42] <wallyworld> axw: ok. i didn't realise xtian had proposed his public address PR. it will conflict a bit with mine. best to land his first once approved and then i'll need to adjust
[03:42] <axw> wallyworld: okey dokey
[03:42] <wallyworld> he deletes subnets stuff which i'll have to add back :-)
[03:42] <axw> heh
[03:42] <wallyworld> as we will need it at some point
[03:49] <wallyworld> axw: PR 7177 looks ok at first look - there's a todo or 2 i think needs to be there , but if it lands i can rebase my PR i proposed just before and address any issues. can you take a look and i'll land if you're happy?
[03:53] <axw> wallyworld: will do
[03:53] <wallyworld> ty
[03:57] <mup> Bug #1662857 opened: cannot go get the source code  <juju-core:Confirmed> <https://launchpad.net/bugs/1662857>
[04:07] <axw> wallyworld: LGTM
[04:07] <wallyworld> ty
[04:09] <wallyworld> axw: i just got to pruneExistingMachineStorageAttachments and am unclear why that has been added. perhaps a comment to clarify?
[04:09] <axw> wallyworld: sure, will do
[05:13] <axw> nooo, using 1.8 code in my  ec2 PR. maybe I can just wait for the builders to be updated...
[05:36] <jam> any chance for a review on https://github.com/juju/juju/pull/7180 over the weekend?
[05:43] <axw> jam: will do
[07:25] <axw> wpk: hey, I believe jam and sinzui are both out. if you are blocked or need anything, I'm around for a couple of hours still
[07:31] <axw> wallyworld: that pruneExistingMachineStorageAttachments call was from a previous iteration of the code, it's not necessary anymore. if the volume attachment exists when we go to attach storage, we'll error out
[07:31] <axw> (so I'm removing it)
[07:31] <wallyworld> ok, i couldn't figure out what is was for
[07:32] <axw> wallyworld: yep, thanks for calling that out
[07:32] <wallyworld> np
[07:33] <wallyworld> axw: xtian's branch has landed but it has borked mine and i'm working to get stuff going and hand tested on aws etc. hopefully i'll be done soon, but you never know
[07:33] <axw> wallyworld: ok. well, I'm still around for a while
[07:34] <wallyworld> yeah, see how i go
[07:58] <wallyworld> axw: i'm live testing atm, but here's the PR now rebased on xtian's work (ie develop tip) https://github.com/juju/juju/pull/7184
[08:02] <axw> wallyworld: ok looking
[08:08] <wallyworld> axw: testing on aws shows the sec group ingress rule is correctly set to <ip of mediawiki>/32 and it works as expected
[08:09] <axw> wallyworld: cool bananas. still reviewing, there's a fair bit to get through
[08:09] <wpk> axw: thanks
[08:09] <wallyworld> axw: yeah, sorrry. i lot is deleting. the main addition is the new watdher
[08:11] <wpk> axw: my idea is to get rid of bridgePrefix (from everywhere) and bridge name generation in random places and force passing of the full bridge name down from FindMissingBridges
[08:14] <axw> wpk: heh, sorry that is beyond my knowledge of the juju networking code. I can help with more general thing ;)
[08:15] <axw> wpk: happy to talk that through though if you want to explain - not sure I'll be helpful tho
[08:24] <wpk> axw: Well, currently I'm like Mr. Bean in the movie - I sit in the corner... and look at the code.
[08:26] <axw> wpk: hehe. I'll finish up what I'm doing soon and see if I can understand the current bridge prefixing code, then might be able to provide useful input
[08:27] <wpk> axw: I'm currently working on cleaning up https://github.com/juju/juju/pull/6963 this to hit two birds with one stone and also add support for https://bugs.launchpad.net/juju/+bug/1672327 this
[08:27] <mup> Bug #1672327: Too long names for bridges <cdo-qa-blocker> <maas-provider> <openstack> <uosci> <juju:In Progress by wpk> <MAAS:Triaged> <https://launchpad.net/bugs/1672327>
[08:28] <axw> wpk: ok, cool. are you aware that I made some changes to the python version to handle multiple stanzas for the same interface? that was after the Go version was written
[08:29] <wpk> axw: I was not, thanks
[08:29] <axw> wpk: some history: https://bugs.launchpad.net/juju/+bug/1650304
[08:29] <mup> Bug #1650304: Juju2: 'Creating container: failed to ensure LXD image: image not imported!' <oil> <oil-2.0> <regression> <juju:Incomplete> <juju 2.1:Incomplete> <https://launchpad.net/bugs/1650304>
[08:34] <wpk> axw: kk
[08:40] <wallyworld> axw: i found 2 issues which i adds cards for. removing a relation doesn't close the ingress rule. adding the relation again a second time doesn't open the port, because it seems the watcher needs to do a better job of oading initial data
[08:41] <wallyworld> the removal issue may be pre-existing
[08:41] <axw> wallyworld: mk
[08:42] <wallyworld> should be easy to fix, i'll let xtian know
[08:58] <axw> wallyworld: left a bunch of comments
[09:05] <wallyworld> ty
[09:30] <wallyworld> axw: i fixed the issue with address counts and added a test
[10:32] <axw> wallyworld: sorry had to go make dinner, looking
[10:32] <wallyworld> no worries at all
[10:33] <wallyworld> gotta eat
[10:37] <axw> wallyworld: LGTM, thanks
[10:44] <wallyworld> axw: tyvm for review
[11:55] <wpk> Survey: what do you think is the most unlikely character to happen in an interface name?
[12:06] <zeestrat> wpk: Trying to come up with a unique prefix?
[12:30] <wpk> zeestrat: no, with a separator for command line

[12:31] <wpk> I came up with ~
[12:35] <anastasiamac> wpk: according to https://www.wired.com/2013/08/the-rarity-of-the-ampersand/ ~ is the least used char :)
[16:19] <redir> https://www.meetup.com/SF-CockroachDB-User-Group/events/238072086/