| flocculant | bluesabre: will the iso see the progress bar fix before next Thursday? | 06:42 |
|---|---|---|
| akxwi-dave | wooohoooo thanks :-) | 08:57 |
| bluesabre | flocculant: I'll try to get that uploaded dshortly | 09:40 |
| bluesabre | always feel so awkward doing git snapshots | 09:40 |
| Unit193 | That's because they're awkward, bud. | 09:43 |
| bluesabre | Perhaps ochosi could make a new release today... | 09:45 |
| Unit193 | April 6th | 09:47 |
| Unit193 | 09:47 | |
| Unit193 | Warning /!\ FinalFreeze, Warning /!\ ReleaseCandidate, Warning /!\ LanguagePackTranslationDeadline | 09:47 |
| bluesabre | :( | 09:48 |
| bluesabre | And all those usually hit before I get home | 09:48 |
| Unit193 | Putty! | 09:49 |
| Unit193 | (I have neeeever done an upload from work, nooo. >_>) | 09:49 |
| bluesabre | xubuntu-docs (16.10) | 09:51 |
| Unit193 | bluesabre: They also don't believe in updating d/changelog, here's one constructed from git: http://paste.openstack.org/show/DZr1rTntMXWvSailkCFI | 10:03 |
| bluesabre | :D | 10:03 |
| bluesabre | knome: would you consider the docs ready to upload? (It's now or z+1) | 10:04 |
| Unit193 | (Full file: http://paste.openstack.org/show/cx51mR1Kjcb6O3mgTmJR) | 10:05 |
| bluesabre | (good to fix before) | 10:28 |
| bluesabre | startpage/index.html:21:<h1>Welcome to Xubuntu 16.10 Documentation!</h1> | 10:28 |
| bluesabre | But it does build... so if any docs folks want to update that string and approve... :) | 10:31 |
| bluesabre | Going to get some breakfast, back in a bit | 10:34 |
| Unit193 | And approve the changelog. | 10:38 |
| knome | bluesabre, i'll update that now | 10:51 |
| Unit193 | \o/ | 10:52 |
| Unit193 | knome: Pushing changelog too or not? | 10:55 |
| knome | am | 10:57 |
| knome | and pushed | 10:57 |
| Unit193 | (Just needed to know as bzr doesn't handle conflicts well at all.) | 11:02 |
| Unit193 | Erm, alright... | 11:09 |
| knome | wut? | 11:09 |
| Unit193 | Minimal changelog. | 11:10 |
| knome | should it be not? | 11:10 |
| knome | :) | 11:10 |
| knome | i mean, were there pending stuff? | 11:11 |
| Unit193 | Well, just updated with what the docs team did, constructed from git: http://paste.openstack.org/show/cx51mR1Kjcb6O3mgTmJR | 11:12 |
| knome | haha. | 11:12 |
| ochosi | knome: no women's shirt news from my side | 11:18 |
| ochosi | bluesabre: i could make a release tonight, isn't that too late though? | 11:18 |
| knome | ochosi, mhm | 11:19 |
| -SwissBot:#xubuntu-devel- ::xubuntu-docs:: [zesty] r633 Update the startpage to be release-agnostic so we don't need... (by Pasi Lallinaho) | 11:20 | |
| flocculant | lol | 11:23 |
| flocculant | alternatively docs could write a process doc so they don't forget :p | 11:23 |
| flocculant | akxwi-dave: talking of which - you got any time to look at release note? | 11:24 |
| bluesabre | flocculant: where's the release note? | 11:25 |
| bluesabre | knome: so, is that the changelog we're going with? | 11:25 |
| flocculant | bluesabre: http://wiki.xubuntu.org/releases/17.04/release-notes | 11:25 |
| bluesabre | Unit193 will probably need to push the upload | 11:25 |
| bluesabre | flocculant: sgt-launcher/sgt-puzzles | 11:26 |
| knome | Unit193 should poke eeet | 11:26 |
| knome | :P | 11:26 |
| flocculant | bluesabre: yup | 11:27 |
| flocculant | knome: this time next week would be a good time for the website announcement to have been done :) | 11:28 |
| * flocculant wanders off a few hours again | 11:29 | |
| knome | ack | 11:29 |
| knome | bbl as well | 11:30 |
| akxwi-dave | flocculant: will do.. | 12:05 |
| === akxwi-dave_ is now known as akxwi-dave | ||
| krytarik | If we are to add to the docs d/changelog based on the commit log, we should merge at least.. | 14:37 |
| krytarik | [ flocculant ] | 14:37 |
| krytarik | * Changes to contributor docs | 14:37 |
| krytarik | Erm, we might pull any translations since the last release too then.. | 14:55 |
| flocculant | afternoon | 16:01 |
| krytarik | Hi flocculant. | 16:03 |
| flocculant | hi krytarik | 16:03 |
| akxwi-dave | evening.. flocculant the release notes are looking good | 18:18 |
| flocculant | akxwi-dave: sorry - I totally presented the wrong end of that stick to you :p | 18:20 |
| flocculant | I meant will you have time to do anything with the release note to get it up to date before next week :) | 18:20 |
| akxwi-dave | lol... no worries thats what i thought you meant.. thought I'd have a little laugh.. | 18:23 |
| flocculant | ha ha ha | 18:23 |
| flocculant | ali1234 ochosi - does this make sense re thunar hang and gdb - http://paste.ubuntu.com/24329908/ | 20:46 |
| ali1234 | can you try to strace it? | 20:52 |
| ali1234 | it might be more revealing | 20:52 |
| flocculant | ali1234: if you help :) | 20:52 |
| ali1234 | "strace -p <pid>" | 20:52 |
| flocculant | it's still there - just in case someone pitched up :) | 20:52 |
| ali1234 | it will most likely spam only one thing over and over | 20:52 |
| ali1234 | btw someone reported this bug on lp | 20:53 |
| flocculant | had to sudo it | 20:53 |
| flocculant | same as gdb | 20:53 |
| ali1234 | said it was something to do with qt creator making autosave files in a folder that is open in thunar | 20:53 |
| flocculant | but - all it's done is echoed this and stopped > futex(0x562c4f5889e8, FUTEX_WAIT_PRIVATE, 2, NULL | 20:54 |
| flocculant | yea - I think I remember seeing that | 20:54 |
| ali1234 | okay thats helpful | 20:54 |
| flocculant | k - cool | 20:54 |
| flocculant | anything else? if not I'll kill it now | 20:55 |
| ali1234 | do you have thunar-media-tags-plugin? | 20:55 |
| flocculant | yep | 20:55 |
| ali1234 | https://bugs.archlinux.org/task/16977 | 20:55 |
| ali1234 | hang on let me look at that backtrace again... hmm | 20:56 |
| ali1234 | what was that patch recently that added a mutex? | 20:57 |
| flocculant | not a clue tbh | 20:57 |
| ali1234 | https://github.com/xfce-mirror/thunar/commit/b838a4d250e3283590cabac2ee5947cdf91c8864 | 20:58 |
| ali1234 | this one | 20:58 |
| ali1234 | its probably related to that | 20:58 |
| ali1234 | g_cond_wait is waiting on a mutex | 20:59 |
| ali1234 | the other thread is on G_FILE_MONITOR_EVENT_MOVED | 21:00 |
| ali1234 | so yeah | 21:00 |
| ali1234 | this patch fixes the crash, now it deadlocks instead :( | 21:00 |
| ali1234 | thunar...... | 21:00 |
| flocculant | ;) | 21:01 |
| ali1234 | so basically | 21:02 |
| ali1234 | there's two places where the mutex gets locked | 21:03 |
| ali1234 | one of them must be calling the other from inside the mutex | 21:03 |
| ali1234 | sorry, there's three places | 21:03 |
| flocculant | is it worth me removing that plugin and seeing if it occurs again? | 21:05 |
| flocculant | though it might be a while till it does | 21:05 |
| ali1234 | nah | 21:06 |
| ali1234 | that bug is ancient | 21:06 |
| ali1234 | this is 100% caused by the recent patch | 21:06 |
| flocculant | okey doke | 21:07 |
| ali1234 | 0x0000562c4f308246 in thunar_file_monitor (monitor=<optimised out>, event_path=0x562c507922a0, other_path=0x562c50b92fa0, event_type=G_FILE_MONITOR_EVENT_MOVED, user_data=<optimised out>) at thunar-file.c:822 | 21:07 |
| flocculant | nothing more to be found from the hung thunar ? | 21:07 |
| ali1234 | can you "apt-get source thunar" and tell me what is line 822? | 21:07 |
| ali1234 | for me it is a blank line | 21:08 |
| flocculant | yup | 21:08 |
| flocculant | ali1234: well - in what file do you want me to look? | 21:09 |
| ali1234 | thunar-file.c | 21:09 |
| flocculant | try and remember this is mostly voodoo to me :) | 21:09 |
| flocculant | G_LOCK (file_rename_mutex); | 21:10 |
| ali1234 | huh, really? | 21:10 |
| flocculant | yup | 21:10 |
| ali1234 | in which function? | 21:10 |
| ali1234 | its here, right: https://github.com/xfce-mirror/thunar/blob/b838a4d250e3283590cabac2ee5947cdf91c8864/thunar/thunar-file.c#L804 | 21:11 |
| flocculant | yea | 21:11 |
| ali1234 | wait a minute | 21:12 |
| ali1234 | that calls thunar_file_move_thumbnail_cache_file (event_path, other_path); | 21:12 |
| ali1234 | so it moves a file from within the mutex that detects moved files | 21:12 |
| ali1234 | hmm | 21:12 |
| ali1234 | i need to get the right source code version | 21:12 |
| ali1234 | okay this matches up: https://github.com/xfce-mirror/thunar/blob/35e65ab0ed5675b2dc7b4224b0ad152df3c3e9b0/thunar/thunar-file.c | 21:13 |
| ali1234 | what directory was shown in thunar when it froze? | 21:15 |
| ali1234 | was it your homedir? | 21:15 |
| ali1234 | and do you have "show hidden files"? | 21:16 |
| flocculant | home/wolf/Desktop/Git/mpd/ | 21:16 |
| flocculant | and yes - have show hidden | 21:16 |
| ali1234 | that is a git checkout of mpd source code? | 21:16 |
| flocculant | yea | 21:16 |
| ali1234 | hmm, that blows that theory | 21:16 |
| flocculant | and I know exactly what I was doing just prior to thunar hanging - failing to build mpd in a terminal opened from the right click menu in thunar | 21:17 |
| flocculant | just in case that helps :) | 21:17 |
| ali1234 | yes | 21:17 |
| ali1234 | that means that a lot of file monitor events were coming in | 21:17 |
| ali1234 | so check this: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800723;msg=91 | 21:18 |
| ubottu | Debian bug 800723 in thunar "intermittent segfault on file drag and drop" [Important,Fixed] | 21:18 |
| ali1234 | this is the old bug that used to crash | 21:18 |
| ali1234 | "thunar_file_move_thumbnail_cache_file" makes an appearence | 21:18 |
| flocculant | actually thinking about it - last time it hung - it would likely to have been a fair few monitor events going on | 21:18 |
| ali1234 | i think that function triggers a monitor event | 21:19 |
| ali1234 | so previously the two events would stomp on each other and cause a segfault | 21:19 |
| ali1234 | the mutex stops that but causes a deadlock | 21:19 |
| flocculant | ali1234: ok - what if I turn of thumbnails - and watch for a few days? | 21:19 |
| ali1234 | i'm not really sure how thumbnails work | 21:19 |
| ali1234 | do they get saved into the filesystem? | 21:19 |
| flocculant | I think so | 21:19 |
| ali1234 | i mean they do | 21:20 |
| ali1234 | but i thought they got saved in like ~/.thumbnails | 21:20 |
| ali1234 | which would not cause any monitor events in some other totally different directory | 21:20 |
| flocculant | well .cache/thumbnails | 21:20 |
| ali1234 | yeah | 21:20 |
| ali1234 | did you have other windows open? | 21:20 |
| ali1234 | or maybe thunar monitors that directory constantly | 21:20 |
| flocculant | ali1234: 2 tabs in 1 thunar | 21:21 |
| Unit193 | knome: Poke. | 21:21 |
| ali1234 | i think this is definitely the cause | 21:21 |
| flocculant | thumbnails? | 21:21 |
| flocculant | if so - I can turn that off and watch what goes on over the next dayish | 21:22 |
| ali1234 | oh i get it | 21:22 |
| ali1234 | say you are looking at a directory with a jpeg in it | 21:22 |
| ali1234 | something outside thunar renames the jpeg | 21:22 |
| ali1234 | then thunar has to also rename the thumbnail in ~/.cache to match | 21:22 |
| ali1234 | this triggers a file rename event | 21:22 |
| ali1234 | the event runs into the mutex of the previous event | 21:23 |
| ali1234 | then it deadlocks | 21:23 |
| flocculant | so running with that off will help prove something? | 21:24 |
| ali1234 | maybe yes | 21:24 |
| ali1234 | definitely worth a try | 21:24 |
| flocculant | ok - I can comment on that bug too | 21:25 |
| ali1234 | ochosi: do you know the xfce bug number for the patch that is https://github.com/xfce-mirror/thunar/commit/b838a4d250e3283590cabac2ee5947cdf91c8864 | 21:26 |
| ali1234 | its not 12260 :) | 21:27 |
| flocculant | 12264 I think | 21:28 |
| ali1234 | 12264 yes | 21:28 |
| flocculant | well show thumbnail is now off here | 21:29 |
| flocculant | seems like I can replicate this issue at will then ... | 21:31 |
| flocculant | just did exactly the same thing - failed to build mpd and it has hung | 21:31 |
| ali1234 | show thumbnail might not make any difference if it is still updating them, and it probably is | 21:32 |
| flocculant | mmm | 21:32 |
| flocculant | well I'll have a go tomorrow morning - as it is - time for me to skedaddle | 21:33 |
| flocculant | night all | 21:33 |
| bluesabre | Evening all | 21:40 |
| ali1234 | okay i commented on the bug | 21:43 |
| ali1234 | not sure what else to do | 21:43 |
| ali1234 | flocculant: can you attach that backtrace from ubuntu pastebin onto the xfce bug please? | 21:45 |
| bluesabre | Final Freeze is now in effect, but let's get xubuntu-docs uploaded anyway... are we waiting on any other changes? | 21:47 |
| bluesabre | knome, slickymaster, krytarik, Unit193 ^ | 21:47 |
| bluesabre | Will also try to settle the 32bit parole issues in the next few days | 21:48 |
| knome | no other changes for docs for me | 21:48 |
| knome | though we could pull the translations or so | 21:49 |
| knome | i just hit my forehead on a closet door | 21:49 |
| knome | (ow) | 21:49 |
| bluesabre | :( | 21:50 |
| bluesabre | knome: if you think we should, we can, else I can just move it along | 21:50 |
| knome | i mean it doesn't hurt us anyway | 21:52 |
| bluesabre | Feel free to pull them in :) | 21:52 |
| knome | i'll do that a bit later | 21:53 |
| knome | food time | 21:53 |
| bluesabre | k | 21:54 |
| knome | or you can do it if you are impatient ;) | 21:54 |
| bluesabre | nah | 21:56 |
| bluesabre | I'm the upload guy today | 21:56 |
| knome | hihi | 21:57 |
| Unit193 | \o/ | 22:00 |
| * bluesabre begins dinner prep | 22:00 | |
| knome | hmh, bzr diff doesn't say anything | 22:07 |
| bluesabre | after merging? | 22:08 |
| bluesabre | or | 22:08 |
| knome | after explicitly telling to get translations | 22:08 |
| knome | so either i'm missing something or... | 22:08 |
| * bluesabre nudges Unit193, knower of things | 22:09 | |
| Unit193 | What'd you run? | 22:10 |
| krytarik | knome: You'd have to initiate an export from LP Rosetta to the branch first. | 22:10 |
| knome | krytarik, i just turned the exports on | 22:10 |
| krytarik | So it'll be done sometime in the morning UTC, as usual. | 22:10 |
| knome | now the question is... can i run it manually once? | 22:10 |
| knome | egh. | 22:10 |
| krytarik | Doesn't seem so, had a look myself a bit ago. | 22:11 |
| knome | i literally just did it | 22:11 |
| knome | let's see if i can download the .po files from launchpad | 22:11 |
| krytarik | I mean manual export. | 22:11 |
| knome | and push to the branch manually | 22:11 |
| knome | yeah | 22:11 |
| knome | ok, i requsted an export | 22:12 |
| * knome goes turn auto export off | 22:12 | |
| krytarik | Yeah. | 22:12 |
| knome | and get some more food | 22:12 |
| knome | ughhh | 22:14 |
| knome | and pushing | 22:20 |
| krytarik | How about my suggestion to merge flocculant's two log entries..? | 22:24 |
| knome | what log entries? | 22:26 |
| krytarik | Commit log, and subsequently d/changelog. | 22:28 |
| Unit193 | 'Update the startpage to be release-agnostic' can go under your 'general', but that's nitpicking. :P | 22:28 |
| knome | krytarik, didn't i push that? :P | 22:29 |
| knome | Unit193, yeah, not going to fix it any more :P | 22:29 |
| Unit193 | :) | 22:29 |
| knome | anything else you're going to make me do? | 22:30 |
| krytarik | knome: I mean the way I put it here earlier today, rather than having two entries for the same thing, plus a reference to a review. | 22:30 |
| Unit193 | knome: Headstand. | 22:31 |
| knome | Unit193, i feel like i'm doing that already | 22:31 |
| knome | the closet door was open 90degrees and i bumped to it with quite some power | 22:31 |
| Unit193 | Twack! | 22:31 |
| knome | yep. | 22:32 |
| knome | and "oouwwww" silently | 22:32 |
| knome | as one can't wake up the sleeping baby | 22:32 |
| knome | (or wife) | 22:32 |
| Unit193 | First will cry, second will kill. | 22:32 |
| knome | hah. | 22:33 |
| genii | Killer babies! | 22:44 |
| * genii ducks | 22:44 | |
| knome | make up your mind | 22:44 |
| knome | are they killer babies or ducks? | 22:44 |
| Unit193 | Killer baby ducks? | 22:45 |
| genii | Heh | 22:46 |
| Unit193 | Sooo, is there an upload? | 23:20 |
| -SwissBot:#xubuntu-devel- ::xubuntu-docs:: [zesty] r634 Synchronize translations from Launchpad... (by Pasi Lallinaho) | 23:21 | |
| knome | time to go to bed. nighty! | 23:36 |
| krytarik | Night, knome. | 23:36 |
| Unit193 | bluesabre: We uploadin'? | 23:53 |
| bluesabre | yay | 23:59 |
| krytarik | Yay or yea? :P | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!