| cmars | hi there, can i get a review of https://github.com/juju/juju/pull/7228 ? | 00:03 |
|---|---|---|
| wallyworld | cmars: looking | 00:30 |
| wallyworld | cmars: reviewed with a wish to count unknown OS type also | 00:38 |
| === menn0-doctor is now known as menn0 | ||
| cmars | wallyworld, excellent suggestions, updated 7228, ptal | 02:40 |
| wallyworld | cmars: looking | 02:40 |
| cmars | bah | 02:41 |
| cmars | i could collapse that increment | 02:41 |
| cmars | one sec | 02:41 |
| wallyworld | cmars: yeh, lgtm, feel free to land | 02:41 |
| cmars | wallyworld, all right, thanks! | 02:42 |
| anastasiamac | wallyworld: axw: jam: thumper: menn0: here is another re-occurence of wrong upgrade to devel version when a released is out: https://bugs.launchpad.net/juju/+bug/1681853 | 04:45 |
| mup | Bug #1681853: Juju Tools Upgrade from 2.0.2 to 2.1.2 fails: ERROR no matching tools available <juju:Incomplete> <https://launchpad.net/bugs/1681853> | 04:45 |
| wallyworld | anastasiamac: that's a x-stream issue | 04:46 |
| anastasiamac | wallyworld: my wording is poor - from 2.0.2 to 2.1.2.1 when 2.1.2 is expected | 04:49 |
| babbageclunk | wallyworld: wanna talk about networking stuff? | 05:05 |
| wallyworld | babbageclunk: sure, just in meeting, will finish real soon | 05:06 |
| babbageclunk | wallyworld: okies | 05:06 |
| axw | wallyworld: FYI on vsphere, apt update/dist-upgrade are being run | 05:16 |
| wallyworld | axw: on xenial? | 05:16 |
| axw | wallyworld: yes | 05:16 |
| wallyworld | ok, tahnks. i'll test on aws also | 05:16 |
| wallyworld | might just be joyent | 05:17 |
| wallyworld | babbageclunk: now? | 05:20 |
| wallyworld | standup HO? | 05:20 |
| babbageclunk | yup | 05:20 |
| thumper | this bug is turning into a world of hurt | 05:24 |
| * thumper is done for today | 05:24 | |
| menn0 | jam: this PR puts the beings docs on a diet: https://github.com/juju/juju/pull/7230 | 05:39 |
| jam | menn0: looking | 05:41 |
| jam | menn0: reviewed | 05:44 |
| menn0 | jam: thanks | 05:45 |
| menn0 | jam: I agree that iter is better. will change | 05:45 |
| menn0 | jam: and yes the proposed upgrade step and/or pruning logic will take care of old data | 05:46 |
| menn0 | jam: regarding the upgrade step, I'm not sure if we can safely do it as API connections are already up when the upgrade-steps worker runs. | 05:47 |
| jam | menn0: we have db migration steps that sync between the controllers, don't we? | 05:48 |
| jam | menn0: ISTR there was a place that triggered really early because of stuff like that | 05:48 |
| menn0 | jam: we do but the worker doesn't come up until there's an API connection | 05:53 |
| menn0 | jam: the state upgrade steps are now defined and run separately from the rest but still within the one worker | 05:54 |
| menn0 | jam: really we need 2 upgrade-steps workers | 05:54 |
| jam | menn0: sounds like we do | 05:54 |
| jam | pre-api, and post-api | 05:54 |
| menn0 | yep | 05:54 |
| menn0 | sigh | 05:54 |
| menn0 | I can't really spend much more time on this | 05:54 |
| menn0 | jam: maybe we just get the presence pruning done, negating the need for the nuke-from-orbit upgrade step | 05:55 |
| menn0 | although a "compact" call after that first big prune wouldn't go astray | 05:55 |
| menn0 | jam: ^^ | 05:55 |
| jam | menn0: presence pruning is generally useful, and I guess it would push out all the old data pretty quickly since everything would be new after an upgrade | 06:00 |
| axw | anastasiamac: would you please review? https://github.com/juju/juju/pull/7231 | 06:53 |
| === meetingology` is now known as meetingology | ||
| axw | or jam, wallyworld ^^ | 06:57 |
| jam | axw: lgtm | 06:58 |
| axw | jam: ta | 06:58 |
| === frankban|afk is now known as frankban | ||
| wallyworld | axw: sorry, was out talking to anastasia | 07:45 |
| axw | wallyworld: all good | 07:45 |
| wpk | quick one: https://github.com/juju/utils/pull/271 | 11:51 |
| === urulama is now known as urulama-afk | ||
| === frankban is now known as frankban|afk | ||
| wallyworld | babbageclunk: any chance i can arm twist you for a review on that PR? | 21:20 |
| babbageclunk | wallyworld: looking at it right now, sorry! | 21:20 |
| wallyworld | np | 21:21 |
| wallyworld | hml: your test skip pr is good to land | 21:21 |
| hml | wallyworld: cool, tx | 21:22 |
| babbageclunk | wallyworld: LGTM. What's JEM? | 21:26 |
| babbageclunk | (I had thought you were saying JUMM in Strine.) | 21:26 |
| wallyworld | babbageclunk: Juju Environment Manager (from memory) | 21:26 |
| wallyworld | it's the controller proxy | 21:26 |
| babbageclunk | Thanks - what does JIMM stand for again? | 21:27 |
| wallyworld | can't recall exactly right now! | 21:28 |
| wallyworld | thumper: got 30 seconds to jump back into release HO? | 21:54 |
| thumper | first part: https://github.com/juju/cmd/pull/51 | 23:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!