/srv/irclogs.ubuntu.com/2017/05/10/#juju-dev.txt

wallyworldbabbageclunk: for when you have a moment later, i've updated the controller facade PR. Besides a lot of cut and paste, it's a new reduction in LOC. https://github.com/juju/juju/pull/728600:38
babbageclunkwallyworld: yay! looking soon00:38
axwwallyworld: another little one: https://github.com/juju/description/pull/14 (needed to land the MAAS storage branch)01:15
wallyworldok01:15
wallyworldaxw: don't you need to increment a version number somewhere?01:17
axwwallyworld: nah, it's an optional field01:17
axwwallyworld: old code doesn't care about it, new code doesn't care if it's missing01:17
wallyworldok01:18
axwwallyworld: please see my comment on https://github.com/juju/juju/pull/732002:17
menn0babbageclunk: how long would you expect the "transferring ownership" step of a migration to take?02:22
babbageclunkmenn0: which cloud? Mostly quick - I think I was surprised how long Azure took to do it.02:23
wallyworldok02:23
babbageclunkmenn0: more often it would appear to take a long time because it was in a crash/retry loop02:24
menn0babbageclunk: not sure. heard about it from rogpeppe. he waited for 30mins and it didn't finish.02:24
menn0babbageclunk: i'll ask for more info.02:24
babbageclunkmenn0: That's definitely a crash.02:25
babbageclunk*almost definitely02:25
menn0ok02:25
wallyworldaxw: i was wondering whether the tests, which do exercise all of the Watch* methods, include enough data in the collections which would be excluded from the results, testing the newly added filtering.02:25
babbageclunkmenn0: hmm, I guess they could be doing it on Azure and have lots of things to retag.02:26
babbageclunkmenn0: maybe we should be doing that in parallel.02:26
menn0babbageclunk: the model had nothing deployed in it. could there be a bug with that case?02:30
babbageclunkmenn0: maybe? I don't think it would be that specifically.02:33
axwwallyworld: like I said, it's 100% coverage: that includes the cases where the filter returns "false"02:33
wallyworldok02:34
axwwallyworld: the tests might be a little non-obvious, because the "mixed" storage apps have two stores each, and there are default pools configured by the test helper02:34
axwwallyworld: by default one will be machine-scoped, one model-scoped02:34
menn0babbageclunk: i've copied you in on the email where i've asked for more details02:35
wallyworldrightio02:35
babbageclunkmenn0: cool cool02:35
axwbabbageclunk: weency review please? https://github.com/juju/juju/pull/732103:02
babbageclunkaxw: yup yup03:29
babbageclunkaxw: approved03:31
babbageclunkwallyworld: you did an amend again. :( What's different between the version of the code I reviewed and this one? Do I need to scroll through it all again?03:33
wallyworldbabbageclunk: ah sorry, our somewhat dumb policy because git sucks is to squash everything into one commit, but in this case I should have broken that rule03:34
wallyworldmain thing is that grant/revoke cli now uses controller facade methods03:35
babbageclunkwallyworld: or do it after it's reviewed?03:35
wallyworldyeah, sorry03:35
wallyworldi owe you a beer or 603:35
babbageclunkwallyworld: I haven't been squashing things - I guess I should be?03:36
wallyworldwell, i don't agree that we should but that's meant to be the policy03:36
wallyworldbzr is much better than git at only showing what you want to se03:37
wallyworldotherwise it is discarding history03:37
wallyworldwhich i disagree with03:37
wallyworldso take an extra look at grant/revoke03:37
babbageclunksure - it's unfortunate to lose the fine-grained commits.03:38
wallyworldand access_test.go in apiserver03:38
wallyworldit is03:38
babbageclunkok, will do - thanks03:38
babbageclunkwallyworld: LGTM'd03:54
wallyworldyou rock ty03:54
jammenn0: standup ?04:10
jamthumper?04:11
menn0jam: sorry! coming04:13
rogpeppefirst stage in getting juju controllers to know their own public hostnames, review appreciated: https://github.com/juju/juju/pull/732309:29
rogpeppeaxw, menn0, babbageclunk: you might wanna take a look ^09:29
axwlooking09:30
axwrogpeppe: stupid question: what's the point if you have to have the CA cert in the first place?09:36
rogpeppeaxw: you don't need a CA cert09:36
axwrogpeppe: to login the first time, to get back the public IP09:37
rogpeppeaxw: you can connect without the CA cert09:37
axwrogpeppe: how do you know what you're talkign to then?09:38
axwrogpeppe: is this for register?09:39
rogpeppeaxw: so... currently things are quite fragile09:39
rogpeppeaxw: the client is the only thing that knows the public DNS name09:39
rogpeppeaxw: the controller doesn't know the name, so (for example) it can't pass it to agents09:40
rogpeppeaxw: we had a problem after migrating to a public controller because the public dns name is lost09:40
rogpeppeaxw: if the DNS name changes, there's no way of notifying clients (not that it *can* change right now)09:41
axwrogpeppe: the controller doesn't know the name? it's part of teh controller config (autocert-dns-name)?09:43
rogpeppeaxw: after "juju register", you won't know the public host name without this.09:43
axw(fair enough re updating the client)09:43
rogpeppeaxw: yeah, the controller knows that name, but doesn't let the clients know (and actually, as mhilton points out, the public name might not actually be held in autocert-dns-name, something we need to consider)09:44
axwokey dokey09:45
axwrogpeppe: LGTM09:58
rogpeppeaxw: tyvm09:58
rogpeppeanyone know what the failure is here? http://juju-ci.vapour.ws:8080/job/github-merge-juju/10859/artifact/artifacts/grant.log10:22
rogpeppeaxw: ^10:22
rogpeppemake clients know about public hostnames explicitly: https://github.com/juju/juju/pull/732411:36
rogpeppejam: looking for a review of the above if you have some time...11:47
rogpeppesome juju code garbage collection: https://github.com/juju/juju/pull/732614:08
rogpeppeprovide CACert in the juju client API: https://github.com/juju/juju/pull/7327, if anyone's arround16:02
=== akhavr1 is now known as akhavr
rogpeppehere's another juju PR that just deletes unused stuff: https://github.com/juju/juju/pull/732816:40
=== ejat_ is now known as ejat
=== frankban is now known as frankban|afk
=== akhavr1 is now known as akhavr
thumpermorning20:54
stokachuwallyworld: we've had to work to make the latest jaas stuff work https://github.com/conjure-up/conjure-up/pull/87921:02
stokachuwallyworld: i think we're still good for tomorrow, just need to make a push for libjuju and conjure-up then run some tests21:03
balloonswallyworld, thumper, axw, hml, the joyent infastructure issues are fixed. Sorry for the noise. We'll get the jobs run again and off the failures22:18
thumperballoons: awesome, what was the underlying issues BTW?22:26
balloonsthumper, keys keys keys. It worked for a short time, then another update killed it. Many of our clouds use more than one key (don't ask me why). Joyent fell into the trap of requiring a fingerprint for one key, but the actual public key of the other (again, don't ask me why)22:36
thumperheh22:37
thumperok22:37
menn0wallyworld: easy review pls? https://github.com/juju/juju/pull/732923:27
menn0following on from one of yesterday's topics23:28
wallyworldmenn0: so just removing the -S23:28
menn0yep23:28
wallyworldlgtm23:29
menn0wallyworld: cheers23:30
* wallyworld disappearing for swap day, off to take kid to hospital23:31

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!