| wallyworld | hml: if you're still here, a review of that oracle-compute -> oracle pr would be awesome https://github.com/juju/juju/pull/7334 | 01:38 |
|---|---|---|
| axw | wallyworld: can you please take a look at https://github.com/juju/juju/pull/7322 when you have a chance? there's more backed up behind it (aside from the watcher fix) | 04:17 |
| wallyworld | sure, give me 5 | 04:18 |
| babbageclunk | wallyworld: quick review? The environ interface changes we talked about. https://github.com/juju/juju/pull/7335 | 04:41 |
| babbageclunk | wallyworld: I'll get jam to have a look at them as well, but he's having a weekend atm. | 04:41 |
| wallyworld | babbageclunk: ok, just finishing another one | 04:42 |
| babbageclunk | ta | 04:42 |
| wallyworld | axw: i had a question about Storage and AttachedStorage param values | 05:07 |
| wallyworld | what happens if these overlap/conflict | 05:08 |
| wallyworld | babbageclunk: just a minor quibble on wording | 05:10 |
| babbageclunk | wallyworld: ok, thanks | 05:10 |
| babbageclunk | wallyworld: yeah, model's better - I wasn't happy with database either. | 05:12 |
| wallyworld | \o/ | 05:12 |
| burton-aus | wallyworld https://github.com/juju/juju/commit/64fe0a58aacc7eff08cc3684eceb0bd05a4a41b5 | 05:25 |
| burton-aus | wallyworld just found out all oracle ci jobs failed there. | 05:25 |
| wallyworld | burton-aus: right, we have been asked to rename oracle-compute t oracle. nicolas knows but i accidentially left you off the notification, sorry :-( | 05:26 |
| burton-aus | wallyworld no worries, I will update the cloud-city for credentials. | 05:28 |
| wallyworld | burton-aus: thank you, appreciated | 05:28 |
| wallyworld | babbageclunk: her's the first of several PRs. it's on a new feature branch. maybe you can look first up on monday? | 05:36 |
| wallyworld | https://github.com/juju/juju/pull/7336 | 05:36 |
| babbageclunk | wallyworld: sure. | 05:37 |
| babbageclunk | wallyworld: Hey, you killed off crossmodelcommon? | 05:37 |
| wallyworld | yeah | 05:37 |
| wallyworld | no longer needed | 05:37 |
| wallyworld | as there are no longer 2 controller facades | 05:37 |
| babbageclunk | wallyworld: Doh, I was just putting more things into it. | 05:37 |
| wallyworld | :-( | 05:37 |
| wallyworld | everything is now in just the applicationoffers facade | 05:38 |
| babbageclunk | I'll just put the functions into the application facade until I need them from elsewhere. | 05:38 |
| axw | wallyworld: you want to check my responses before I merge? | 06:06 |
| wallyworld | axw: looking | 06:13 |
| wallyworld | axw: all good | 06:14 |
| axw | wallyworld: ta | 06:14 |
| rogpeppe | axw, babbageclunk: would you be able to take a look at this? it's kinda tangential, but useful. https://github.com/juju/juju/pull/7331 | 07:53 |
| axw | rogpeppe: looking | 07:54 |
| rogpeppe | axw: ta | 07:54 |
| axw | rogpeppe: LGTM | 08:01 |
| rogpeppe | axw: tyvm | 08:01 |
| === frankban|afk is now known as frankban | ||
| === frankban is now known as frankban|afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!